From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4657EC3ABAC for ; Fri, 2 May 2025 15:05:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74D706B008A; Fri, 2 May 2025 11:05:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D5786B008C; Fri, 2 May 2025 11:05:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 550CF6B0092; Fri, 2 May 2025 11:05:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3595E6B008A for ; Fri, 2 May 2025 11:05:04 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 740918205C for ; Fri, 2 May 2025 15:05:05 +0000 (UTC) X-FDA: 83398290570.01.F0138E7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id B37ED100015 for ; Fri, 2 May 2025 15:05:02 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sribkiaz; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746198303; a=rsa-sha256; cv=none; b=tvd8LF1H1HV7pmOBsJUie+JR5Z3FFpM9zY86bpKDUBb4/KU2qh+0DKqDrtieJrZOPSyk3Y OFxXDv6MQ7yoW6mz9D2i2HxUIOjcqUUwMy67BxFu3WOuzBeDg8JtQbogCNRjbW1XxiIhKH ByBBIR4p8aD5veTm9NwHIyQM1Jwtarg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sribkiaz; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746198303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uGszKsYJV+/3KxrWyzdce5oTg3e1aS8x57TNNDe6TdU=; b=tAxO5oH6xpfdC2fmd1ysITvtE31fBCVfuOFXuYzPVoEiT3Jr69i8kAkgRdiJuNCylymwvZ yOIHQ/0/8zHgbSU59dVSvM/TR5XrOSkzLcvQppVUBepOwTXpXr5Yp1IPNACb/mylYx/6Es qWoNntvSynIa7u7cLBRXx6LKYqtEJRA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746198302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uGszKsYJV+/3KxrWyzdce5oTg3e1aS8x57TNNDe6TdU=; b=SribkiazzTjFKeFXlNHZVJELMFrC+hkiQ7vENXoGYk0Eb/hMzQhUh339HTS1G3/9cDUEK4 SGtbqpnT+jXE7DDkUAs8jK4x6xTfmJuhGZ5U+yS3JehEc8se/Ozgg1qBqOy5en7iV0aCvc volyzcKzNJWazfpLoJEiD1wbGUy3TSs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-338-isuaNVvJM9GZs_rm4smBPA-1; Fri, 02 May 2025 11:05:01 -0400 X-MC-Unique: isuaNVvJM9GZs_rm4smBPA-1 X-Mimecast-MFC-AGG-ID: isuaNVvJM9GZs_rm4smBPA_1746198300 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cf44b66f7so10471365e9.1 for ; Fri, 02 May 2025 08:05:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746198300; x=1746803100; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uGszKsYJV+/3KxrWyzdce5oTg3e1aS8x57TNNDe6TdU=; b=TAPdXZd51d2OgbCoYOQKC9EKdj5+zZ6MykxWleIS4J+576JHlAKBeD5tbJTbzpO+OZ queRWeNhYSu/zZFhs9EIZo8q5ejcnNdUhYwpPIaOsyNHqLa/mr9Gm/mvIIg1q1OU11Wl BIdXKbPHxiwLyvpEmf2dNET297KAfMhDHuxDVEaeB9GRt4eXJeyyVVtS27KBFBKNu+iJ WAkIB9nfZ2DyKJUu0lSZmfLUyaSQb50rG9TOj+YhJ1/2kMk97fj6rM/+UY6xyR0pIjct Igfqs1Hi7u0WneFOJM3uSg/FIDKX6xXA4QiUKRswjiiX97wh6zjuxi+023rXyXBujW1I IwiA== X-Forwarded-Encrypted: i=1; AJvYcCUeP8dycdYHTd6m2BHG0XdJLBAZxE43ogjQpl/4s+1IW83lFEVc9+rz2cEKMB+UyFb+ngJorW8utw==@kvack.org X-Gm-Message-State: AOJu0YzsP1uBRpyoWe4Dpe5SC2JkZ3Y3sp7QW827UKAK37dwdU75DhYF +RkI6xmsL8L6HiZuM3EkHL4wkhpuf2FqU1t+NIICGwhPgu9lqzOGoCR3inIq2Fd0+vMMyP/FRYu zfi+Ee6i+bctI1cfc996sbt7wFK8LrBPA3siRgm+/EhDpxMZ1 X-Gm-Gg: ASbGncsg2kmZSw8ZT+5QuEOVTKP1IROOaZuBPVVGxTHa8M9Jb9NB/WETie4KyF9C2mV 0tLSNz7rO/e4AQybmOjWL3ku1jATMt/GH5c0CcSpS0InH2Bihf3W4UDwwxGii6FM8xN4mVcH8AM RALmwlW2oFJZAHy7yXIdyP46G1dkckz1xKox71QU86aX2+IvJibbBr2I1De50mKZRI5FOc8NxwA T8YN2xYGZrD9hWoqGl0Eab18RJH3cmoWjtKJMBigk3y/OHY2BhX3wdHKccwe2YiiAMe+HoctScP kLDyK/svZjHTjnztXeetsFLvTxs4061Er+pvSLfA9TDfTUJ8U8Bgip/Kxb0JtwwUajltNnJ5/bg cTeqUg8PeoG20he4tN7aPb1pYfwqa9/G+oz6kcMw= X-Received: by 2002:a05:600c:470f:b0:440:67f8:7589 with SMTP id 5b1f17b1804b1-441bbec4897mr28964385e9.16.1746198299704; Fri, 02 May 2025 08:04:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBmFWdd61i7kQfGj0DSlbMhLGC/f16Iqwd9J9AcP1MHmrDAlG5FHiYpT5N2sKEXY6IvxTSTQ== X-Received: by 2002:a05:600c:470f:b0:440:67f8:7589 with SMTP id 5b1f17b1804b1-441bbec4897mr28963495e9.16.1746198299210; Fri, 02 May 2025 08:04:59 -0700 (PDT) Received: from ?IPV6:2003:cb:c713:d600:afc5:4312:176f:3fb0? (p200300cbc713d600afc54312176f3fb0.dip0.t-ipconnect.de. [2003:cb:c713:d600:afc5:4312:176f:3fb0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2af2922sm92031265e9.17.2025.05.02.08.04.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 May 2025 08:04:58 -0700 (PDT) Message-ID: <386c1169-8292-43d1-846b-c50cbdc1bc65@redhat.com> Date: Fri, 2 May 2025 17:04:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 06/13] KVM: x86: Generalize private fault lookups to guest_memfd fault lookups To: Ackerley Tng , Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AiSfamXPbVD3108EmX7mf2n_EyG_ToUSCLN41uz8PRc_1746198300 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: B37ED100015 X-Rspamd-Server: rspam04 X-Stat-Signature: cc61d7nautmwk6yip8zs5zpcxj4e6yff X-HE-Tag: 1746198302-667501 X-HE-Meta: U2FsdGVkX1/i5rkw3ySAtzqXXA5Gcqo9kTVtS/GT2PHQ2MgkhM+Z4mNEvIp3eCdt9cVh50+GV6A/yjvYOLYSP5fbThmw+qC2x7KMfIFxxwrsVBIDajrU8yd8BIONkCip5UJ2dJK7MV+lFAIDIN1tkth9uhAcG737ouDwSqgV1AfQCDDMgNCB7fm9VoZrBBXeJME+7Kw/YBMVJqUkLk9Ocsz5BATYgn0N+PcerOxO/QQZCQbFBcIGbmxisJ48Tzs+KQ8qbhCClQV6+Fvx49gHhSzpsbaio+4E7ryZuqpW0dI6Dfv9ky9u+RaBcPpjfDWn2PvuK8fDwPRu/d0Ofr6QzqKU6eigWHZ3hE24ECej+FAFVPSfxi2wnfO6j1cJicBU8fNrVazoqPT0n11fUlFepFRYBUnK3N/Ar7hsSZzexP0GcjeWlCAbKt7riSdeAdehtRJF6R2sO8fq2pmmHO+vJt35gU7DZf737zaQB167/QDlNB/G3QGsao1UOPfXI9mVJLG3qoKFa3M0rU0/BsOZtjRe5mEET/bc1mlBcMC/nvjPTeOKyEJB8o2OjBEqDHuVBqXsGABgSFwJ2PlbgTo+5DO57bGmwWkQB3IVccbiOv/Ay+rUQLDCAtUlI/dyaTL2k5enDDszT224IjJ1FMtctsfJiBj56gm0YH+oY7TChqoXkpgKF4/UCYUzCxO6o32LMtTSNgXEmL5KG8e6L27udYa5dvHDHpdt+6gbDJ6Lex14VAGXC166qieS0ZDkpcXv5+FzvkWnG2Q8RplCoIRf3J7XFrAl18IYJZe3Rw4GthgHRtatF0yU32GCLgvMdn9k3MVYquqzIs+PSRPVheM7rVep8dOL23NCzSvQ/37DHXlmzbQ1gIzrF5UVcrRJrshcxKfV+OoPq2FmTq4yZfSpaPG/0I/RW9Nva96ADqrUrqYfHbYxOirDzSh7A1Qv9SDyglGxHeWNNI997iRD1dJ jQsuDJYM kPEwE7jmuTRvhnUGcH08UXqh+9b3pO8Ka+Lbwih3xKVOb6diwwmMA01II0Qh8XebabgeMZ0ug5HGAm6jpR5CQ2mHQZ9QSDR3gGR3m5efuZebbIRwwW7qfyXhpn3V3i8KfnBRW5uNsNL01z03iUfmatIPAN8Edmqz7+K0QqeNppFXT7K321BUhJUDoZ1ciwJCPzuyfPhjnXcFwEIHH3oq+X1cifEbcVLa1zLQ7UuiLVMHl9LL0l78xhrdOCJh1HZEhD1Vo2g3f3L4qarf4RotaRBRUaJK2X5bIAJBzn83wzvvQF+cFE499q5rdlijq0dwzLVVkVLKBNOfxpw0muz+CHjSrmmo8FBctosanNqAJ6ZQu/669dzMEdgp+ZBILnH2akixnqY+yf9NKBszoaMZmDWaRbdPsR8BqnrjzlA1VvNXQ/i1ieP0wc3e3p0irFIgIISAUPeWr8ffpGIo24LutEKGGxz+7mj3WFW4Ju5PBeietpn8GF3tfhDYDCIPBm08DgJFTtCnN3uRBfDODibM1UcvUmnbJs1Xm/+MI5HwLQ7NJG+t2ywBAwGBaIbwSkgARhRKR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.04.25 20:58, Ackerley Tng wrote: > Fuad Tabba writes: > >> Until now, faults to private memory backed by guest_memfd are always >> consumed from guest_memfd whereas faults to shared memory are consumed >> from anonymous memory. Subsequent patches will allow sharing guest_memfd >> backed memory in-place, and mapping it by the host. Faults to in-place >> shared memory should be consumed from guest_memfd as well. >> >> In order to facilitate that, generalize the fault lookups. Currently, >> only private memory is consumed from guest_memfd and therefore as it >> stands, this patch does not change the behavior. >> >> Co-developed-by: David Hildenbrand >> Signed-off-by: David Hildenbrand >> Signed-off-by: Fuad Tabba >> --- >> arch/x86/kvm/mmu/mmu.c | 19 +++++++++---------- >> include/linux/kvm_host.h | 6 ++++++ >> 2 files changed, 15 insertions(+), 10 deletions(-) >> >> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c >> index 6d5dd869c890..08eebd24a0e1 100644 >> --- a/arch/x86/kvm/mmu/mmu.c >> +++ b/arch/x86/kvm/mmu/mmu.c >> @@ -3258,7 +3258,7 @@ static int host_pfn_mapping_level(struct kvm *kvm, gfn_t gfn, >> >> static int __kvm_mmu_max_mapping_level(struct kvm *kvm, >> const struct kvm_memory_slot *slot, >> - gfn_t gfn, int max_level, bool is_private) >> + gfn_t gfn, int max_level, bool is_gmem) >> { >> struct kvm_lpage_info *linfo; >> int host_level; >> @@ -3270,7 +3270,7 @@ static int __kvm_mmu_max_mapping_level(struct kvm *kvm, >> break; >> } >> >> - if (is_private) >> + if (is_gmem) >> return max_level; > > I think this renaming isn't quite accurate. After our discussion yesterday, does that still hold true? > > IIUC in __kvm_mmu_max_mapping_level(), we skip considering > host_pfn_mapping_level() if the gfn is private because private memory > will not be mapped to userspace, so there's no need to query userspace > page tables in host_pfn_mapping_level(). I think the reason was that: for private we won't be walking the user space pages tables. Once guest_memfd is also responsible for the shared part, why should this here still be private-only, and why should we consider querying a user space mapping that might not even exist? > > Renaming is_private to is_gmem in this function implies that as long as > gmem is used, especially for shared pages from gmem, lpage_info will > always be updated and there's no need to query userspace page tables. I'm missing the point why shared memory from gmem should be treated differently here. Can you maybe clarify which issue you see? > >> >> if (max_level == PG_LEVEL_4K) >> @@ -3283,10 +3283,9 @@ static int __kvm_mmu_max_mapping_level(struct kvm *kvm, >> int kvm_mmu_max_mapping_level(struct kvm *kvm, >> const struct kvm_memory_slot *slot, gfn_t gfn) >> { >> - bool is_private = kvm_slot_has_gmem(slot) && >> - kvm_mem_is_private(kvm, gfn); >> + bool is_gmem = kvm_slot_has_gmem(slot) && kvm_mem_from_gmem(kvm, gfn); > > This renaming should probably be undone too. > >> >> - return __kvm_mmu_max_mapping_level(kvm, slot, gfn, PG_LEVEL_NUM, is_private); >> + return __kvm_mmu_max_mapping_level(kvm, slot, gfn, PG_LEVEL_NUM, is_gmem); >> } -- Cheers, David / dhildenb