From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 153EEE65D3F for ; Fri, 22 Nov 2024 09:47:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C8446B0096; Fri, 22 Nov 2024 04:47:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 977A06B00B9; Fri, 22 Nov 2024 04:47:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CA1C6B00C0; Fri, 22 Nov 2024 04:47:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5F3F56B0096 for ; Fri, 22 Nov 2024 04:47:55 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EAE95161020 for ; Fri, 22 Nov 2024 09:47:54 +0000 (UTC) X-FDA: 82813252830.23.17D939A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id BFE42C0006 for ; Fri, 22 Nov 2024 09:47:28 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FHYIHCkJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732268685; a=rsa-sha256; cv=none; b=GXlqaiToxPka4h0IpGovHfDHACenzP+2nM4k0PGmgvcCkaCvJUGsTiIz1my+ijRxf5D+B2 RZ4o0Tv3B/S4kxK6vJwZWF55eiU0OJAwyQugpyFawHxgiKEGmKjgtjJgoEzgBSIngWnLB4 3L0GW+yBA70CKjvwySo5uzXclQIVPHc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FHYIHCkJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732268685; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ci6p4OAEag/t/B0pMHs058dh2BK7Mn/De3aq3KIhX5Y=; b=6k/9v9h4OKefXnAowk4QHtDepLWer7eCUnkdBh1mIVOGk4AHWam+axpHUGP06nJOL64vTW hngUN7SXK1yL0NPDytw0/wNCUvClJUMTepQ+73EiAlE/MD1r9+wZb22N5PozbA4QwgKSEe Rqn11AnlgbbeYHmkQJclT6CUXfePZ4g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732268871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ci6p4OAEag/t/B0pMHs058dh2BK7Mn/De3aq3KIhX5Y=; b=FHYIHCkJMr1lEltNk3+sdxKhEI5eFdREzS8qkMRDZGzYRHtabIdQ0qWqvYm+xGTl9QADeG ZPJQWW7/ptPk43QNsdLV9glgeyPs0/rqjIYgsQUE/9l31KZAQaL/VvI/P295aOlgSF7Nor fy7+eyrL2awksZk0Shg2swFFZ59zwqk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-471-7mEo_jSyOy6YwCTYt6ONkg-1; Fri, 22 Nov 2024 04:47:50 -0500 X-MC-Unique: 7mEo_jSyOy6YwCTYt6ONkg-1 X-Mimecast-MFC-AGG-ID: 7mEo_jSyOy6YwCTYt6ONkg Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-431673032e6so11928095e9.0 for ; Fri, 22 Nov 2024 01:47:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732268869; x=1732873669; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ci6p4OAEag/t/B0pMHs058dh2BK7Mn/De3aq3KIhX5Y=; b=LcAVDYnD+UEANTCSM5YSe78Bn5ORrSfCevu4qXgGTTB/OawhITA/TiQuNtquZKeMTG GygbKVeylH/sBp+9kKR0Rot9p60LeVuZKO6tHa7fx2T4uviFKnV+I7APixTnrEd/5niv yr/X2BWpk5k9HDt9mjuesHG/IMrflfFEsMoC8O9VzKj0805etyQ6500ylZli1c13E/PE ciHbH4Wm7IGCJdOtf3V6xwGvNMje8vZd5BbJ0wuR8mXXmbbyVGjv+7EWPvDbZXbUrxx0 b7GGKTY2N6eaYQMz70Nib9vR4ut4NG/qslF+IZx0IzyesjmpYPUtdiqwqABZ2/hZRnM3 UTNQ== X-Forwarded-Encrypted: i=1; AJvYcCVn0dGbZsyfphylqfsVyd13z5LwR6v3sdkJyYy0tXClKGztndKgnm0ItyF5Nd206k8JARwvzULfBQ==@kvack.org X-Gm-Message-State: AOJu0Yyj0fkFixmsyV/rt8gQRCElnQgjvoyBYGcHiFPQ5pS34zZpMnH3 ureJ5uRVVLEXorjvIN7XcFljcTWodddMcbbAPJ9fwbkk4cTTZQJVWgCXyWieAee0eiuC/UCfTzJ hCLWsr4uttAhPvkP3SyWynQT5VhjLGK3/odSei5iqEIulR1aqQ+RO0r4/ X-Gm-Gg: ASbGncu5C8KDNvWkO1Y0llwrR7YqUib8XEd9yD3j85DOHczGxgFQpGu9y2hkeCmpCoz nMYfeMvyT9jkLGXSAA6IKSGrjF5pEwFT9jfmHZPipPXDrvA2QDDFllOJqB5wd4FX8HQEI0GX3VP xOS5/9IHRNuebKWZaMHd5xQQBcgxbignsfTSEyRwT69ceIubqe6qLWj7Hthtj36CkKmizqWbvox e2scdZMz/vvoTV548K12dmxIqJx2E08VOpFsgciG7GiDIxQF1mwIJJkwmw7QQs7cd5Awzvr1UTx DcEu//ZIiAG9OFeyiEm7zgeySUdUYfBe68a3YZIur2EXn87Pek2xJ5MGhXrqc4blLt8R+oBTDfg = X-Received: by 2002:a5d:6d8c:0:b0:381:f08b:71a4 with SMTP id ffacd0b85a97d-38260bce4a4mr2031158f8f.45.1732268869393; Fri, 22 Nov 2024 01:47:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGzdx/gLIZH1VTc8mr3WHY/86y1dvP0OX0vMKHqWCr02PkymP5OabS5ttIAfpHLubkoBaO9IA== X-Received: by 2002:a5d:6d8c:0:b0:381:f08b:71a4 with SMTP id ffacd0b85a97d-38260bce4a4mr2031131f8f.45.1732268869025; Fri, 22 Nov 2024 01:47:49 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:7a00:9ccd:493:d8e2:9ac8? (p200300cbc70b7a009ccd0493d8e29ac8.dip0.t-ipconnect.de. [2003:cb:c70b:7a00:9ccd:493:d8e2:9ac8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825faf9dd2sm1906180f8f.26.2024.11.22.01.47.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Nov 2024 01:47:47 -0800 (PST) Message-ID: <3866cec8-9983-4adf-b96e-42fa728c84a8@redhat.com> Date: Fri, 22 Nov 2024 10:47:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/11] fs/proc/vmcore: introduce PROC_VMCORE_DEVICE_RAM to detect device RAM ranges in 2nd kernel To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Vivek Goyal , Dave Young , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Eric Farman , Andrew Morton References: <20241025151134.1275575-1-david@redhat.com> <20241025151134.1275575-8-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dVGWs_Wn_UsCB7LWbGQMC6WGjm8Q0mXUNuY0JKGGIhQ_1732268869 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: eqsb6xdfrbmdnmgq3iq63rzwqujesey9 X-Rspamd-Queue-Id: BFE42C0006 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1732268848-542413 X-HE-Meta: U2FsdGVkX1+HGb3kJeJkvEBLwU6pOc1+qNNU6NuywkZ4pYbADY2GsRoX5TGH3qWFbUNHT/ffNZ/qwtz5FqZ1vzCC9pwPB/5wrZ3B3kDSR5EIa+RkjG2jpPpDG/xuPSzgtmtTZKOhrd04z6+mpRxR1/u8IvpGELdyG/++NWrUJ9xfe7P+qfRErYutnSx3KxWTrH8MjsyyYa9qGIdquELnYSi9XeMejOA7zfcUnyjMXb+qzusvcdloG7V3wC4CNOw9Jj0k6MoFSj0/XWDOksYDe+G8NKJPI8oophFb4cnjpSIEGyjcnkqAp+QudSYQb5+Acvo0UTbBz+j7mUr+UPZ+Y14w29a0roJnja9dvuw0jls9YfeHjLuUh2KpNN2PiISAxQzjnBQxQB6dBt1s8PpAFmz5/OSNtjRuMPTPdCmFFBdhdRSJ8fUFgb6wbSUDEM+73OjYf7ln/ydL1OW0ld82Qh6HGQN0CjhPmvXg9L3yrIFZwPslaZAZgnE623GoVVF1TLZzcG/hjqUVTLtMHekOlfn9nhcDtaMd+zIKqSpbGyAkOLhHKGOXyaLUdTSLEpRxClQC8dsWLa5n6NJkNMjp24rVKfiGbKPmJQsK58nlyWjQjM5piiIMnaK15ej23Jk/OYpJ/8/p22G5ej1+VQwbjviNUqtHyLhe4sMh2WVfrhdxDJfjEc0KfBZjcngjYMZmAhK3vz3y3szJykvqgLDRMByUFqxWmf4lDIjIfubledy7bHFm+J5Rqe+k2dmCtWCALsCb58rhE1pKwZwEWWSbHGaKBG+d9Sb7o7KDq4fr3c8i4ISRUzPauzloOb9mlYalmIjxBvV7MuGXmr0zdSyzneJGHKRT6LGER/tW+OzxBW0hJY6AwfJnEMDkk/j6Mb5Z1oAgzj67PwW5uqSSR0fvSWkxrV4Zp5fyVbJiJvFsUKXIvKpMHNg92Ak8ebZqlvcfb7X9UIDupGNuhng8cPQ cJmy33aY 4qO4g5Bdd6zJJNsCPel0YKYsiNCbbcrmiWp+aJwAQCWq+OZIg+TV+ivXf1wed9vScEcZrzUVN3GCZRpiREQUlOHR4JJ1evtXAXh1qgUbERcmPmKHjQPJjGGnc/LNkUfdKz+VYeqO8Mje2ymnbRvV9JbQ3ombIIpfqSDE/QUL1f+51f8fM7r6GdMi2lDCLwXdGAN99Frrfwy2ML1bUJE6XE2exv0+hnH0MKk7S4g2zF3Phok13X+SpLGfAdmsx4ebIUttZJZr+YMF2swMDGGpBtYrt4iUmCCXTRplki4O3YgZEk+57inslv+eI9VN30KO8sb8sIIeiAMhC46NqcsfUV89wsUe8qzknaE3OCNmyhWQOy/LHdchePOStDtw+y+WTSDWqLYu0JV/1tTlWbTwr6CFl/MX+qsij5tL+WDevtWXHLNW8Q/dRONG1gv0S0IdBbcxC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.11.24 08:31, Baoquan He wrote: > On 10/25/24 at 05:11pm, David Hildenbrand wrote: > ......snip... >> diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c >> index 3e90416ee54e..c332a9a4920b 100644 >> --- a/fs/proc/vmcore.c >> +++ b/fs/proc/vmcore.c >> @@ -69,6 +69,8 @@ static LIST_HEAD(vmcore_cb_list); >> /* Whether the vmcore has been opened once. */ >> static bool vmcore_opened; >> >> +static void vmcore_process_device_ram(struct vmcore_cb *cb); >> + >> void register_vmcore_cb(struct vmcore_cb *cb) >> { >> INIT_LIST_HEAD(&cb->next); >> @@ -80,6 +82,8 @@ void register_vmcore_cb(struct vmcore_cb *cb) >> */ >> if (vmcore_opened) >> pr_warn_once("Unexpected vmcore callback registration\n"); >> + else if (cb->get_device_ram) >> + vmcore_process_device_ram(cb); > > Global variable 'vmcore_opened' is used to indicate if /proc/vmcore is > opened. With &vmcore_mutex, we don't need to worry about concurrent > opening and modification. However, if people just open /proc/vmcore and > close it after checking, then s390 will miss the vmcore dumping, is it > acceptable? See my reply to your other mail (patch #3). > >> mutex_unlock(&vmcore_mutex); >> } >> EXPORT_SYMBOL_GPL(register_vmcore_cb); >> @@ -1511,6 +1515,158 @@ int vmcore_add_device_dump(struct vmcoredd_data *data) > ...... >> + >> +static void vmcore_process_device_ram(struct vmcore_cb *cb) >> +{ >> + unsigned char *e_ident = (unsigned char *)elfcorebuf; >> + struct vmcore_mem_node *first, *m; >> + LIST_HEAD(list); >> + int count; >> + >> + if (cb->get_device_ram(cb, &list)) { >> + pr_err("Kdump: obtaining device ram ranges failed\n"); >> + return; >> + } >> + count = list_count_nodes(&list); >> + if (!count) >> + return; >> + >> + /* We only support Elf64 dumps for now. */ >> + if (WARN_ON_ONCE(e_ident[EI_CLASS] != ELFCLASS64)) { >> + pr_err("Kdump: device ram ranges only support Elf64\n"); >> + goto out_free; >> + } > > Only supporting Elf64 dumps seems to be a basic checking, do we need > to put it at the beginning of function? Otherwise, we spend efforts to > call cb->get_device_ram(), then fail. The idea was that if there is nothing to add, then the elf class doesn't matter. But yes, I can move this further up. Thanks! -- Cheers, David / dhildenb