From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6057C282DE for ; Mon, 10 Mar 2025 17:52:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B360A280017; Mon, 10 Mar 2025 13:52:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABDE2280004; Mon, 10 Mar 2025 13:52:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 913CE280017; Mon, 10 Mar 2025 13:52:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6CCA1280004 for ; Mon, 10 Mar 2025 13:52:29 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A81E2A9F62 for ; Mon, 10 Mar 2025 17:52:29 +0000 (UTC) X-FDA: 83206386018.17.025E3B9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 29D854000B for ; Mon, 10 Mar 2025 17:52:26 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=b3xKyfCD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XEdzQ6Os; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=b3xKyfCD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XEdzQ6Os; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741629147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7ZNNFzLW+s59eHnXQyTn8Lm4Z2jh00lQpZl3pknjAdA=; b=tnyE0AJTDu3MXiby3UI3ewq7SjyxNqcjDjGtmE+KSdERDI8AI3Ok2Ap+gqiT8+usE9kh6F J09EHpn+zOzzCutaOY6ldVMeZa7hHKbxC7DSAtqn+Rme8pzqtSTJTa0R9+KoB1DxLDwmBP +xhrvmJQenobvKpQbLd9iQDwsnm8M0U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741629147; a=rsa-sha256; cv=none; b=y8YdtztGZOiWkrYyzupIKA4j2M2HRqPicwCBKPomlQI9YoefT/nRoukeIOsKQlkaKaJ58p wiOci3kxxhfcxzS4b2ZHP8TLbBzfhS1WRf5EidvVfSPP3Mj2xFxj8LTiBq8YzFopkDm6i7 xJsDoq73T2Xv/XFuWPcdQryVSyzKD9I= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=b3xKyfCD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XEdzQ6Os; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=b3xKyfCD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XEdzQ6Os; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8C0001F393; Mon, 10 Mar 2025 17:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741629145; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7ZNNFzLW+s59eHnXQyTn8Lm4Z2jh00lQpZl3pknjAdA=; b=b3xKyfCDqjktdTF1cokFAmJG3ezB50JTCo4IiXkfTtoWG7/TVad3GczBjSY4/JoTM2x0DP AhOV4Wh+FmoY0zikIpb4kGp7b3wbGMhlltxRHN6ZzmfK7AopGGE2Bn3Vj4uUD8OgtkamCt W5ksJqDctPfOCb0HLDJvrmVOjtZ1k/s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741629145; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7ZNNFzLW+s59eHnXQyTn8Lm4Z2jh00lQpZl3pknjAdA=; b=XEdzQ6Os1FscXLy/3Xtw2UEgdgF5CUW1DnhSPafNvysEyQWXbR9qN2+3rc3wKSd9rf9Aim b+kMB0GpOE13YHCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741629145; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7ZNNFzLW+s59eHnXQyTn8Lm4Z2jh00lQpZl3pknjAdA=; b=b3xKyfCDqjktdTF1cokFAmJG3ezB50JTCo4IiXkfTtoWG7/TVad3GczBjSY4/JoTM2x0DP AhOV4Wh+FmoY0zikIpb4kGp7b3wbGMhlltxRHN6ZzmfK7AopGGE2Bn3Vj4uUD8OgtkamCt W5ksJqDctPfOCb0HLDJvrmVOjtZ1k/s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741629145; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7ZNNFzLW+s59eHnXQyTn8Lm4Z2jh00lQpZl3pknjAdA=; b=XEdzQ6Os1FscXLy/3Xtw2UEgdgF5CUW1DnhSPafNvysEyQWXbR9qN2+3rc3wKSd9rf9Aim b+kMB0GpOE13YHCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 76C121399F; Mon, 10 Mar 2025 17:52:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BuCMHNkmz2fveAAAD6G6ig (envelope-from ); Mon, 10 Mar 2025 17:52:25 +0000 Message-ID: <38628bf6-1676-409a-9712-15095eec8dc1@suse.cz> Date: Mon, 10 Mar 2025 18:52:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] mm/mremap: thread state through move page table operation Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Harry Yoo , Yosry Ahmed References: <1d85814f3a73eaa241c554b3e0f751f3e267a467.1741256580.git.lorenzo.stoakes@oracle.com> From: Vlastimil Babka In-Reply-To: <1d85814f3a73eaa241c554b3e0f751f3e267a467.1741256580.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 29D854000B X-Stat-Signature: ryfc3bysu9a9cgxbbijrpk5c9rfyw7i5 X-Rspamd-Server: rspam10 X-HE-Tag: 1741629146-163993 X-HE-Meta: U2FsdGVkX19oo/uTLD4iW0A3fSttVIhh5z7QS9k06ho8jh81r4yldtbpkfghv5gzMaRd6tDwAKZYgX+DVZsjAhpeli+MTDqQZtofR8CCN2ove4Wfz2dv/VnZMzpN4Qjbdm3I2FMd+b36bEW4igLd4bLyjpukyE+NOxs7VnDVUPfzpUeO+MZJqOAOYNY3xO/TUVrrzuPC780s+WNvB4bKlhYHlIJcSvFDyKOmmlWmMpdAsrnCQfRiM/0tDDN2SkuYvjYNUYGgjSRoGBfrFbAns3QJGWUXkv2TH1wvJxclKjN5g3ZDYKlptkvzutcTMiKcpIooVyX9MkDx1mK+tn7aA0iHBrl4ASQz6hXu3AEw+uI+6lwW1SWGhNdQX/295jjzxSShWxaKbP0GkSNvUi5lPRAn4pBCpbWUT6HXpfOi0OXSVkMQdMosi8Wf0FyYs+WpYny7mPPPqqL4bIrTfXUs3HJWGjmLYgC0rkmLykgyqJiWPJEjBGPOPEwHswlJl153XJeTzVgkJhqGmp76g1WnfuNYHxQreTwHkB98lWtbefX2x+ruMNhdBzFL7BjIsqMKmGR0ENUL1tdZy9ktoS0oT+UuYrImlZiItThHPcRIKZCLY6zrcl4mRjfcf8obVfPE5lepiGXaMbgir4tpJSIqkm4H2BWFPkuU/QbGmid4u9ZRVVoaEmp8qnnsRqDzeJVIuogDjPYJ8pTa4OgaDO62OFNXBfATh3PylsW5mIV+jt3IzdEQrsdHJIrq8Mdvispo25RnFhr/ilsXQ1knsgKwTqvjhRiE6CVd3RRrJIqKDGx5Muq15KrO4hn5uDYB7gj+kiZn/8YTGtsAoNyfAjKvB0aC7HTy3hbA/gAGObF0jyUaCtIP9AGGnpHLWBNgV30ca4mlnqMeLbcQZZ3XnQYQyfcwOnyOblp0lLj/CjmDqREDEI3zKlypkY1e9T2dKTP48ez+dz5xbo6Cc1DwGJE OGjSfMB3 TRO8SeehZQXaGsgJAYdPduy3LksWW3AOOnIUGbTvdk+KH5A6+V0PZ9cEBSluaKjLTXDEWC4MCugquUZOxi08+yydOSZvLrtn3YNAjetd58E+Wpi8E3uMrB10YI3v19rl2xNS+ebKr6tBNRrdnKvvx/x3K1ybKNQIr/8gNy7MNiHbzpaErZSRBHGGVw96efdACpmr8df8g60a2v+0ZiHc5ywBv4tACKVj45WVu8BlyvlLm0sxFLYcHqU4KrlDHGObG7zh0/itmnNnZpCj7N4lGMTpFkv7hz0tVQkzA+G58FRwvTW6O+o2PbnpsxPp4MWSulUdphROdT/KjVs46ZsYHg0VqtLeN8eULCiKEBZaOf5ZdPgQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/6/25 11:34, Lorenzo Stoakes wrote: > Finish refactoring the page table logic by threading the PMC state > throughout the operation, allowing us to control the operation as we go. > > Additionally, update the old_addr, new_addr fields in move_page_tables() > as we progress through the process making use of the fact we have this > state object now to track this. > > With these changes made, not only is the code far more readable, but we > can finally transmit state throughout the entire operation, which lays the > groundwork for sensibly making changes in future to how the mremap() > operation is performed. > > Additionally take the opportunity to refactor the means of determining the > progress of the operation, abstracting this to pmc_progress() and > simplifying the logic to make it clearer what's going on. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka Small nit: > > +/* > + * Should move_pgt_entry() acquire the rmap locks? This is either expressed in > + * the PMC, or overridden in the case of normal, larger page tables. > + */ > +static bool should_take_rmap_locks(struct pagetable_move_control *pmc, > + enum pgt_entry entry) > +{ > + if (pmc->need_rmap_locks) > + return true; > + > + switch (entry) { > + case NORMAL_PMD: > + case NORMAL_PUD: > + return true; > + default: > + return false; > + } > +} > + IMHO the "overriden" logic would be more obvious if we removed the initial "if" and just had default: return pmc->need_rmap_locks