From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E44C021A4 for ; Mon, 24 Feb 2025 18:52:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A288928000C; Mon, 24 Feb 2025 13:52:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B18828000A; Mon, 24 Feb 2025 13:52:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DCAB28000C; Mon, 24 Feb 2025 13:52:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5A9A328000A for ; Mon, 24 Feb 2025 13:52:13 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0A44981AD4 for ; Mon, 24 Feb 2025 18:52:13 +0000 (UTC) X-FDA: 83155733346.14.142D362 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by imf04.hostedemail.com (Postfix) with ESMTP id 5F2BF40007 for ; Mon, 24 Feb 2025 18:52:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TPFBNA4m; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf04.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740423130; a=rsa-sha256; cv=none; b=0niewnBeJRMrB9IbakMGIBk6PRiQJHAg4VCfBoCf3rE/6lkOyNqYjGm7655TjPnJehfbDY VA8HAdkV1Y3/1SO6/Coz56C2ov8Tm/9mLTr7rTiUFv1LgWpevK7xdsTvXednNKV0KCD8EZ cFP40f84uJbEQ7bj6AeKBDCYzxgGOPY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TPFBNA4m; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf04.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740423130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=evFQtB1xm0507gukIQefGKNvk/d9IQ9l81afZUw0Gxs=; b=XFLK+B6RJxjJxiSUYjFo167Ovec3nFx40ET2H+KjBMrci6PdhnvnVZjj8MEMEU/ZRpBIRp AG282rfdd347PyLsSLBEGGvslLKXL+wBB8aS2aNCl/eyGx2KnDZzwj/nxARQal3/PKKpbv y1ssBEcOJ2LW2hMLMwMsUGU90vLK2sw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740423130; x=1771959130; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=p8WahEKH3FtIxaDZp3CmgnleCkUrzMZgELQO6SZHpQ0=; b=TPFBNA4mJCbPP6Et3L3c0E2/2O5AvyvoxqZTWfj4+TgThcAseEiYASAD xKu0uFIM2vgux2qMqhmqvpA+DqFC3e3LlIdZHh2kdRs8JKfAAgiJ9I8MT Zy5rNBWUTTI9WaPnsq24qNN+e8BOcbfZ1hov1yaBzZko6nXnmoboQJSBb vzPleDdA2cRzkGnxYuV39DDx+/aMMDhWXb/GeCwYWBWCkvXcvm+aC4/0b Leu5u84JDlmafKYParMK+943Y5P4aoj/tltYoAyjxO8Msbsk6T+zzveZa BnhDmwclcodEeFiOfg1uUOIKj103y+EM161dZvPr4HmmLnXPmNa0CTs+8 w==; X-CSE-ConnectionGUID: FZWNnX+rTiGJyB3h8vjS9Q== X-CSE-MsgGUID: Tf/wgNXoSC6GF+7tY0zc+A== X-IronPort-AV: E=McAfee;i="6700,10204,11355"; a="41077364" X-IronPort-AV: E=Sophos;i="6.13,312,1732608000"; d="scan'208";a="41077364" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 10:52:08 -0800 X-CSE-ConnectionGUID: XBIhuaevS5WPDtri+kYBvw== X-CSE-MsgGUID: fxayIjWdSveDXmRs3xcdYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,312,1732608000"; d="scan'208";a="116644263" Received: from cmdeoliv-mobl4.amr.corp.intel.com (HELO [10.125.111.40]) ([10.125.111.40]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 10:52:06 -0800 Message-ID: <385e1498-2444-4a7a-a1b0-0013b0b8fd68@intel.com> Date: Mon, 24 Feb 2025 10:52:13 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/7] mseal, system mappings: kernel config and header change To: Jeff Xu Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com References: <20250224174513.3600914-1-jeffxu@google.com> <20250224174513.3600914-2-jeffxu@google.com> <443992d7-f694-4e46-b120-545350a5d598@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 5F2BF40007 X-Rspamd-Server: rspam12 X-Stat-Signature: xaxphkfa73rouchhscnwjs6zkmtwcdg5 X-HE-Tag: 1740423129-70920 X-HE-Meta: U2FsdGVkX18ZgaSzL36+v+3Am6uJx0j5pKT0E0E4wVQ4Gv/1God8I7+qAJkw9qloLil9gbURaTuDXFj2OP7AL6kQLdmHgxFzVjh5HW8QuZ79qHXqetFwPUG6+w1+DTZxVaCGfIGkThgTZZeNc5OCMV7C1cEWBub/jhacPXnG/jxxbuB1cWi2BclqxfFzsqBiL/zBIueTJzlZfdeihCLfHvfzheUY64YW5OiFzppZ4ZKZu6wt3jIohqkaEfPY8TizTioYxblre5UCwviHFA6L+kRrSvX4fW8oAo1Kg7AgScR5bP2qvtUtP0c2rla2NZMiDBCpzrI2QTOSk5a6jDysTihR7LqJPC5z10akJQXgHKEmJTKQrX/24AHdScm9smCvqNSrcwCfk0XqePV8XSbdtLzCcAmUJ7irDJ3enUY8+3eGAmB/2+RuL6XHOf4LtN88VK7ZalV08G7o4CwxFKDAjOUuRT76Ha2J8uIG5FMVNy8T24BDxXLsV5e0TmPwUH0tQsmmXlgeHSdqOTIMYOZSxsaFLH3Nng9TCJewLaY1RNrDkElIA/xk3aCFi/PzoCBqoyvNm6mjacuvERw23Y6a1tQJNJ8bRadCIPtx+nK240Oky2CbPLCCDJbfagX2WxD6sBT615Kk1DFwXHJfbJNZsO/R5LNGSxFF395wK8u302IpZdNYF958i+JOMMkaXJM+CT0cnAUS7BNgkrXyfhy8FzNpqjGkRNRHloepWFlk/kCiYwLqYAPMj/maNULXoiVBvPjkOFdtIakNNC6ZgI2OxFw00iImCjupvDE7fkPDIH9CUiYBisgzrNMmTtDgp6b1bzwnU60gkXCIFBaCKBpPT0P6gybuDrbWlf8EJG9y3bkmUKZJAtm6IJr0uhGsVvyhgk/6eUHZZx95H6P/mK8fwZ6NR+HeSfl9+5H1wJCmD8GpJ9yqzRIT9/e0Jzkvqp0+0vlzrSLjtlTSzIJ58Xh wTdaGFpX h0otB07RpJC4fxk4YLcwh8tt0lIkJ2M0wbwBIRAhuaIcsH1NQNIyeCXYpPtvQnMIoceXGfd2TobwpD8UgrDxXshL2Vg6eMIG/YtUTIHxrARPa10Nj0gEAQGMX887M5AfctNYziuy9M8XC6LXIWsN5F9ZxgiiHw9KmIdemF+ja2EhyykYkFj1KtREsmwqcLXWBeUNRh9Y+FWCAvn17jM4nL1o08f+E46+qBwCXGb6pcAKwcRb5OZIy6sGvhdu+XVcbuBWEH+Nn+uP45gi2OfIYIMX1Sg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/24/25 10:44, Jeff Xu wrote: > For example: > Consider the case below in src/third_party/kernel/v6.6/fs/proc/task_mmu.c, > > #ifdef CONFIG_64BIT > [ilog2(VM_SEALED)] = "sl", > #endif > > Redefining VM_SEALED to VM_NONE for 32 bit won't detect the problem > in case that "#ifdef CONFIG_64BIT" line is missing. > > Please note, this has been like this since the first version of > mseal() RFC patch, and I prefer to keep it this way. That logic is reasonable. But it's different from the _vast_ majority of other flags. So what justifies VM_SEALED being so different? It's leading to pretty objectively ugly code in this series.