From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB50FCF31B9 for ; Wed, 2 Oct 2024 20:22:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 257C16B014D; Wed, 2 Oct 2024 16:22:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2069B6B0167; Wed, 2 Oct 2024 16:22:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00BEE6B016C; Wed, 2 Oct 2024 16:22:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BE6696B014D for ; Wed, 2 Oct 2024 16:22:29 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ED4B94035F for ; Wed, 2 Oct 2024 20:22:28 +0000 (UTC) X-FDA: 82629784776.04.5F65B87 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf26.hostedemail.com (Postfix) with ESMTP id 75A0C14000A for ; Wed, 2 Oct 2024 20:22:25 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=gLPn9YOw; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="VA/2THNd"; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf26.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1727900451; a=rsa-sha256; cv=pass; b=UpEfjlB9d/v4S7+K5f7Nr/Ewp8xBufMVgp44N2s6M18h1QZctQ5RpT0e3p9MBXizT+NBrj Q/tNn5Ruyq9VjiJcfu/jaOYBxbEveFw2Y4u4htC5LxUbsm53LjqOBxmhsIn/eCppxXyR3R cpyl0rJvKA6BSsHnKIzNotCW6GcvbQE= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=gLPn9YOw; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="VA/2THNd"; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf26.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727900451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UuMRFLta2Ej5irWHuNG8e6qSLHFTk3D9TrKwTqdmaQ0=; b=m6eWKCKhjN7s/GiLt9m8K8Yz98S+bKP+YeMd//R245Fx2n0IDRcC1rna3hfqJMM9jaUIQp VqSTRtMFZerVDcxk6qybbM0IQMDOJxrYUh9uJvFIn/Ylmo0KvFS/vnh1kmh/QNmK4yxEAF Dlyu58fZVmbekymQ8AEeMbRgPGfz/ic= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 492J0Xsk021457; Wed, 2 Oct 2024 20:22:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=UuMRFLta2Ej5irW HuNG8e6qSLHFTk3D9TrKwTqdmaQ0=; b=gLPn9YOwJnvjG4n5D4CDDzfVibAu8L6 W3mnwV2IUSJQhHNuPIxrWzXA3KNx3dJVFVZrMQQJmqUjK+TEKEsd13mUagsNWydW t2m2o9SIcJu1WDI28KMn6Ttn/SyB7kih4obtW8gF/tF+cB5Ej2kdnWLDHNCiNeoR NCtBoQTycsR2YuOiUUMlsDUVUXIs1m/3KzU7liDBaTX2EiY9d5qgaPA+MNqcqUsL UQx5/3N9b6GvGmh72ok07NoQeJvoJb58ybHqyG6KDs/HXWEFtoA1bqV7udYJ2TcI tchZzb8+jpqQPA8egEh8Ry3IAX/FPlKyq0qpKl8d0HsJiYQiB6NJP8g== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41x9p9tdsv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Oct 2024 20:22:23 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 492JedLp040595; Wed, 2 Oct 2024 20:22:23 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2174.outbound.protection.outlook.com [104.47.56.174]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 41x889aqvw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Oct 2024 20:22:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mu8yd+1rR7U2N2Ywb14F/A9hDIV7qEyMcTH9KaPtOwhbZ9+9jdzYF/HDwSiJAlyAl6eaaGuFMZDozfCa0iEfuKbtNpUmUQ8z987hFSsvjTCBrDK43GX6ex2K3h01Oiq8m+dDhoRSI+iY8OaqKb9Lg7EsOQ0SMfLuDakWL9RKG71gQHY5fUKgoVBHYn9jgfz/UH/5W25ObcSdt709Jj2o7Wib78dfw9qBd+jAtXCCEZT4ZhwaNYvQmviRXTccaxiDN6jHfg4zn3ftywsF00r9kP3Qd72RSskJKaX3Ok79DirhKu7ppIMMUJ00fexA3YMN5l3iVbnavk8QnZZA5HiUhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UuMRFLta2Ej5irWHuNG8e6qSLHFTk3D9TrKwTqdmaQ0=; b=IoSYuvuo296blDj+3AKsPD2U9KvE7VC5F7du1A1Cj4Se7lojmiZFHNhXbI07Bzyv3EryrpUGNvBAnhfQbJEb1NNNh6x7ofma9IU/sECiidsmupNeh3Z1Yy4Dlsj2R1RfLywtObB5hrmU6vUAMlcYT1bv/rpj5NvRqy8MTjPDC/zQ+Wql4ac5XLXeoLyQ6XIAsOrZgJWKQnzv05OHLRQva46dbiackIsu9RNye369XYXDyO27zmgACwRZ1lRsu9ZGfSkaEG61uR0jsbCHtvVur4mcnx+oniRIUgSo4iJDGQIVnfkdpiEsoPF2iy7EZ9WJdctPx1N95/nlxr0F11yNNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UuMRFLta2Ej5irWHuNG8e6qSLHFTk3D9TrKwTqdmaQ0=; b=VA/2THNdsCVW+BKFo2uj5bqggs9vjw9MtICaWYDGMvkgc6f0xwJdpt4+qbb4NEfDBVQGRKqxVP+JVQ8QZCO2Fof5XFrnn3OtkT4jtRc03wkBRlMOamvIQFGS0Twf6LIg/lG9uB7526PATFI4ordY0BNxEP50ovkFguNmU/sO7AE= Received: from SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) by MN6PR10MB8143.namprd10.prod.outlook.com (2603:10b6:208:4f5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.16; Wed, 2 Oct 2024 20:22:20 +0000 Received: from SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e]) by SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e%5]) with mapi id 15.20.8026.016; Wed, 2 Oct 2024 20:22:19 +0000 Date: Wed, 2 Oct 2024 21:22:13 +0100 From: Lorenzo Stoakes To: Bert Karwatzki Cc: "Liam R . Howlett" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 14/21] mm/mmap: Avoid zeroing vma tree in mmap_region() Message-ID: <385da45a-16df-4c8b-ae5e-33734e21f827@lucifer.local> References: <20241001023402.3374-1-spasswolf@web.de> <26991b8a-9fc4-4cf9-99de-048c90e7a683@lucifer.local> <32c0bcb3-4f05-4069-ac18-3fc9f76c6f7f@lucifer.local> <9d8761c5f32e2bad14b23772378a0a856b51003b.camel@web.de> <240ede917b6712021481ab356714977e247036b6.camel@web.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <240ede917b6712021481ab356714977e247036b6.camel@web.de> X-ClientProxiedBy: LO4P123CA0356.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::19) To SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5613:EE_|MN6PR10MB8143:EE_ X-MS-Office365-Filtering-Correlation-Id: d3db6363-7345-4a46-0e16-08dce31fea25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XwLfwcCpwaNeNlqx4C2FGcZ0V+IxjnHNSp6km3fbqxx1MYVwftsumGEyZSpp?= =?us-ascii?Q?6WIuw4MrPoectImGQEVRjbFeWs6UXv0kMd8II6e+6SSYVFQygFxRWgOHMalV?= =?us-ascii?Q?2B7TyRpYUZGO6fMa4NAgVBxu3Wg7qqzq2Bgxq4c4W87Qs8JIe1/JoNl97m19?= =?us-ascii?Q?KLiTVUj+lDkHMm+JHe8Rt+Au8z/5p1hXLKNWUsTgXa3Y+yx+UBO5TePZmfGG?= =?us-ascii?Q?MlZageh4zGbFXHoViw4QDbjVybGx9N+Tn6UNJyLAGJm99K5bjObdyF8h9nZx?= =?us-ascii?Q?9bagzVBtbA7uOyLw3APkjkSFcPTHOs89ZUG0aywMIjAIbRhgHRdX2Uq9HYBY?= =?us-ascii?Q?11hvRBOqJUP3qyan3iyW0Gow9lyCEdO2w40utlcyT2jiRlW5Tg5rA/59TS1r?= =?us-ascii?Q?PtFx4dL4tGrkpsmnkwcdoabaMUNid3IR0Np9HZvL3Xs7QNTPe0dw5bz8IBPx?= =?us-ascii?Q?QeouoMXfnF96hbcIxJ3RyvNNAq9ORHlRPwnQ6c4eVTZfsfezoAHsfs1wcZVs?= =?us-ascii?Q?bROZVcbiCcufDknHr80TsAbROXNY39eYMNiEucObFTlNXphe+tydvH4lfXtz?= =?us-ascii?Q?gnJ4F61PiktUc/j4t8/agCBpaN6rIex+ZGgt4W8lGMdACuWJAt/qeOUzsaLa?= =?us-ascii?Q?CyX/1/WyMSSoPdeYOpIagCSUI/GELv/+AdrFsC1vptEg0oIReVzjn5dg1TrH?= =?us-ascii?Q?XD6b1CU7wjGNS+gDn1lyG3G8bv2BhMfrptsIowbHDRbMXdYaqgIFXQOSxIIX?= =?us-ascii?Q?kD3tqpQugNGjM3xpCcMbjNb2OBXlOAPs0RtF7Zj0pSdJFlPAVg7rfmFRLeYt?= =?us-ascii?Q?ogdDA8shw48R8KxIAakLO/QRMMkGaKYzR85SFxTgLEx6e9c5zPFcovavYMzW?= =?us-ascii?Q?04acz0/716c9nf0kwC8EbpP6hI7+dpB5jqM7jIOXhb2k6s/n1WaeymUT+/cY?= =?us-ascii?Q?8374RmtkfN7AgQJnnJytKde4R+N5n9dI3D+eeazjyWVuC6mfFJyzybMTLH/P?= =?us-ascii?Q?VaHT+1b/UCxz3ti5+kqP18LRv1mKWassscKR0PNrHYbHICzJC/6SPgxhvAaC?= =?us-ascii?Q?lAwK5zvKVrRkn1zN85Jw3kjaQcGDvcUMhY4LWbhrmtwl9i4p55FzVQNGBX+y?= =?us-ascii?Q?tcnn8dQbpoyKCEs555ygCYQ0DSIMprzGka6CxzOPk8EChiEBw1OAI9D8aE8k?= =?us-ascii?Q?G795HCfPM4dC7qSwPBe0wNRtpevRM/4jw7Z4R7iPd+hOofqoGTw1L4YV07iD?= =?us-ascii?Q?/wAFEGUm67mxi/oB6FYCWUmSraP5JL4bRwYdnKngRw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB5613.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D8YN6rrhXz/Y8Ha+z8tnEVdAA7kQE34vMWx8jSKO5MdgToJZ0f2J24vTS6X9?= =?us-ascii?Q?CHppLRiXw3q5RptZ/DF7b0nIsOFa5LxiRcUwA2R8AfzxID/BDCIS+HOY1p/r?= =?us-ascii?Q?tPnWckAUJ1JeBILbJUcIOegR3TmJxUxfwu0OYAUAd5+3Zu6+vTLtAhkc7ePq?= =?us-ascii?Q?1ZVW1Nc8iyNjwHat8jrwOa8MXwQcrSyw3GlNTkC9YnqmWIOklzzUvqD5Eqae?= =?us-ascii?Q?QZ2KRfKGdHVZ7Y7cqrvaHLHjzr/a4PfLuL1QgF0HWsaJg6EOpKdREMVw3nQJ?= =?us-ascii?Q?qLkQ0jSdhUDZ/TfcbEcZaYBMiCYpKZrt3QxUVmXQwvNETsHLQyhRuLo6AF3r?= =?us-ascii?Q?bzujTf8j3TZd2isLNec4zawyj6Edd9SC3eqvaIPsiYRBMjaWuWBPMEEgKwGa?= =?us-ascii?Q?LRF6pIw29KYQXRuWNh+F/JLfL+qEFcoFLE/xkl1mpelSUqq/JFup0uBuuYdv?= =?us-ascii?Q?lMzJI3ykaLIlAHlvBh3pj+KyBY+yvAtZGB6TytRaKlGXHougOxSGBk5ELP2R?= =?us-ascii?Q?NhBxh6sqTnouPGo8o616rR0STQV6LhRw+14FQz7ZabGWuOpXQYLFfD19rn7T?= =?us-ascii?Q?Fla1k0ogIArRRPLYJbcFgK5EWuxGAJTAoCU+B3hYK3PtmKDhOWj2rHPnhTx4?= =?us-ascii?Q?MfR2GpjWBw7iwsvHfqWHbROtjernEy1dqRJtL81rEz0zca37bDEOX2VGsCFh?= =?us-ascii?Q?5X6aRCNM4ggvvnHRu1roKT6zZSE+uSEd3yUWTvVFiKw/QBbpNExGxtTOsVHJ?= =?us-ascii?Q?9mVNp0RCstdmWwazwL2f49eymFVwrdS/KyojjYyIx2XSe/V2pnh0Gtnrf7Eb?= =?us-ascii?Q?ot5wPcvZ7Dm6CMn49xhYXR9jQKN1HbUX8LX0lM8WDP0UXtcW+7TlidFX2dNx?= =?us-ascii?Q?AuW6hmgYrcCm9hUtii5oR9cK5e+D0TRSYyG0bOM+0z/b4Ee1RoMTcZHgPACb?= =?us-ascii?Q?Sduoy+4CCLY+rnWwvl+uam33K2NYKZFXLGi7rEAnjT7DdxfpqAgS9itp1LPq?= =?us-ascii?Q?Dmb9lKm9WyxsjYKf8PdK/ImoS/lLTzH/t807aBtmSh91k3uWzrBaPj7jdaGR?= =?us-ascii?Q?sMWmf4F7esIyyaDbxTazQIm6ZhbcYuRPD75vBMPvox3KQmHfiVLg+WvdPLhQ?= =?us-ascii?Q?WO3qzItvwiPUYznJBi3XTOzIFsJgc6HhDFiQX/52+wcO5mkj0CBqxOB82hWD?= =?us-ascii?Q?E4Y3omoY6jWT4BN3saoHVz2xLs/ioI5oChHs402KFTjyaJXyPsx7PIA+V0ts?= =?us-ascii?Q?21tG89W/MJG/ov798yQ3XEDO497gNxdnTB3a1zZLhsrr/gb/sI5a8oi8qhhK?= =?us-ascii?Q?vv0hRVw6Vv8ThyXYEOYyjCBfrP6qOYZhxD/QRcbkCSsp3MSxT0RckL5CrXqH?= =?us-ascii?Q?kwVNKG9oIVnIu9s/R6V8OGNB88E6tgYqyE3dCWkNE3W8MPOkYysbUAd3tzgB?= =?us-ascii?Q?0pMM2YZOzW9R0osqt04Ikk9SEQCxOrSvk3w8X60U5fpuSEkZsmRg0suMVLN2?= =?us-ascii?Q?+r2R8gcXPuLtN33X+2TzJgD49e6qXJ7HOU603k6JfRqeGrF6U7wYyAggrn4P?= =?us-ascii?Q?oYN94by6A/BrLTt7O091incLat+cKKGbkinIAKVudcf8+aWLJgjunuOAPy5n?= =?us-ascii?Q?w9kamZ83rlscctiEbqlUoW8CDvnxYNIWwmCrOoaOgYHlgqouR8ijSbz1eyD2?= =?us-ascii?Q?cm6RrQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Bo8XB7T8gKqDUpDtlzjUih7Q8Bb0UlSpR8c4s4FYMzhRZmrAN5RkeVAclxt+cxKXjuvHY43/b2Aap7RK1EmfqroCSgnDsAO7xiVJcamqacVE/MjItBnjhVaxdZV1REFMCRhTfVSLzXZJ0crKZsTN23nhddKtwZkqaxoOPztYiom4SpGMhltJHnuJ/bBB8/Jh4IHoNyf0HMXcMpXNlaqXx1WIeu2QvOpaXZUxmKfrLmbQUMAsb6X7H3GQp5bKJCEgfnEajDHQO8O39yOc53yYMvzcee/NDm1jxx2ZJOAd8PJ4p6EDHEar20GwDoqq8/rAQ9pjyr3Z/+qALw1H5Hk0FIr/JzA523GbzKfxi9QBSdfdvs/Y62AxxvYcINR+4tx/LUe2VEreKVXw1gT753bbtavj2MLSm2c9soCs36B2YmTv5dFsiM19ANcUz9vqQS3bIE8sP9MjryKY9j1wIokB6nTRoXoEpQ3hPzbwF0lzQDFTAFg8MMt+3FlIkUk8pJuePWjxoA8ZgXJR2ndEFmhg3bhfTI0UeCn2YS9XRsG+G702sfFAATrDjoW8/fdDdzj0lZ+l5YqL6+AndnvvD1efu/jMxm79fV2btD5t18iwkj0= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3db6363-7345-4a46-0e16-08dce31fea25 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5613.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2024 20:22:19.4114 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ILNZZp/dGr9beYblj0YQH7w2h29Yehi4PF6B2xvA7HMfljfy31LitVUHg6BRHsT/iyd4YnMZeDaUVY/fhbK3GE/KrKP215DoYXE6uQ8ClxQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR10MB8143 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-02_20,2024-09-30_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2408220000 definitions=main-2410020146 X-Proofpoint-ORIG-GUID: YRF1znl_Tl4-Zw40-Nd618IJlWSMAsg1 X-Proofpoint-GUID: YRF1znl_Tl4-Zw40-Nd618IJlWSMAsg1 X-Rspamd-Queue-Id: 75A0C14000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: us59g3d9kxnstmfi717ghu9rsge3x7ds X-HE-Tag: 1727900545-50101 X-HE-Meta: U2FsdGVkX19JuXOKcarMID4cvwt106wGyrUneumjBSoWm7IPT7mnddEU+4YjfruOvdJGr81cvzTUwlZLNAxjggzfY4FrjXu5hFsZUGTc8AWxocMjMLaLensJTvTZ3VtonGcS6SA3LwfcfcPyOYDbX//ALNQOSa/D2oFAVn8PINvxwwjLIChFEfcLrWnFlVab+jLlGmVTfrEDx/AvzEBfROgZTBwDJLa9Zj8jtj58CbKMiCRQ+1cK1pmcOYpHxGzG7r7fJhc3tRvxSYAOHyIwBagZJStN2eCThM7lYr8/TF1Y58RbszmD0GE4LoZ5/jw6pOKWquJ59W82w55HiVRT+m26Z0aVQjFcPn2apEHoWq5+xOqX4BzzIhe0CranKDvKf/LWKBHTWfs8sUQyUKI7gmV2GJ6N5ZegURvBCUSAPAZS6KesTVWfKyNoXBBdRRO1n2qWHwze8OhNnUVvqJdXcCM1Kp/kvgMB6d27gg86k4L/IR/GVQUYB4JR3DCdNiSby9LnISFtsEpzMY4zb+xjTuONQcAMEkqv8mzKZBlsWGAaaAwP/+cgUGZ5Dppa55iNA5wGd6cmnlB++URp1btTYFJV+HCHiPXgMNvd0DTbf0/nR5WvTw8cKBJ2JxyvR2JyfJezjbq7rKPF0VhCwiwpQLyK/ruFKtTtmgx58Arym6AaLhSIZz470x43pxlpPcJUM0J+bjxcTinxdZK8h16IhWJbVD9E4xOys/w105/q7/bzWjqjj5uLI9/iBIfbvbpkfNBad6GzvYync3a9Ti9/iPvpav3tPheGDZiq3IiH8hljRdMBvvRXTQuBSIFHJnfJ7X2QT6SWpYPVANppTr+rQHIwMFNNelvi3tsnLnQ+l8KzQmV1g0BRaeuFnyiYtIeHju3wrGRkbld57vV48C7TGOYYqRugsVxfrQWt4xzFb7BtdUezJbWWfD5pVVydkASiIANQC3y4wYUII0i1+Ja kXree2hp H3CXsSGRnh5Pcy29R+sdxoRd8l304PEh6xz01IZrSSW+4RQSmXbXOGmyZHq7GaEjZf0u+6j6UPc+pSea4NqSdby/7ULnJ7IX5mBYdvATYhbS6yW017Yp4loNEDMH4TfUnED0+Brkie3rbnsnDp/wodOt+CKfgl5VEEThE1sNDGQSDP7roE92Pnf/7TU8kUfOO6j6r4kziQ933RYXBf7LEIlmvpg/4LHqfTo42vsGbdAe5gpz/CRF5c+4WALouQoLdoZfO/Huj6sRLVhj2tLeB88taJWWhnOJpPEFbxagq1V8maHm+y3CXHvmxNMK3n22qzgesQw0413hjDi2HQE43ei8ZlDPgQuu5tRIWZf0VlvHUWQmMBFkamDxfAvHLlpM64Y98oISeFSQx5QXwy9RYrLxv8p3Z3TT0UidJOHKcUuBh6xgB/R2YTQ7T/E3Zqv4lAnqZyWAeAHCvKSlF/vgCN09tTH9JdPuBlz/M2YREI/YWd/rty4uFj26VC15fiKj+nIGt6ztrDmiHsoF74sXGUWdIJOjo7gjTQigf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000106, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 02, 2024 at 10:06:34PM GMT, Bert Karwatzki wrote: [snip] > > > > diff --git a/mm/internal.h b/mm/internal.h > > index 93083bbeeefa..cd9414b4651d 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -1443,4 +1443,19 @@ static inline void accept_page(struct page *page) > > } > > #endif /* CONFIG_UNACCEPTED_MEMORY */ > > > > +static inline bool check_interesting(unsigned long start, unsigned long end) > > +{ > > + const unsigned long interesting_start = 0x1740000; > > + /* Include off-by-one on purpose.*/ > > + const unsigned long interesting_end = 0x68000000 + 1; > > In an earlier patch you requested this to be changed to 0x798b1000, is this > correct? > Yes, please leave it as it is for now. > > + > > + /* interesting_start interesting_end > > + * |--------------------------| > > + * ============================> end > > + * <============================= start > > + */ > > + return end > interesting_start && /* after or overlaps... */ > > + start < interesting_end; /* ...overlaps. */ > > +} > > + > > #endif /* __MM_INTERNAL_H */ > > diff --git a/mm/mmap.c b/mm/mmap.c > > index dd4b35a25aeb..8a1d5c0da86f 100644 > > --- a/mm/mmap.c > > +++ b/mm/mmap.c > > @@ -1341,6 +1341,18 @@ struct vm_area_struct *expand_stack(struct mm_struct *mm, unsigned long addr) > > return vma; > > } > > > > +static void ljs_dump(struct mm_struct *mm, > > + unsigned long addr, unsigned long len, > > + vm_flags_t vm_flags, bool is_unmap) > > +{ > > + if (!check_interesting(addr, addr + len)) > > + return; > > + > > + pr_err("LJS: %s mm=%p [0x%lx, 0x%lx) [vm_flags=%lu]\n", > > + is_unmap ? "munmap" : "mmap", mm, addr, addr + len, > > + vm_flags); > > +} > > + > > /* do_munmap() - Wrapper function for non-maple tree aware do_munmap() calls. > > * @mm: The mm_struct > > * @start: The start address to munmap > > @@ -1354,6 +1366,8 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, > > { > > VMA_ITERATOR(vmi, mm, start); > > > > + ljs_dump(mm, start, len, 0, true); > > + > > return do_vmi_munmap(&vmi, mm, start, len, uf, false); > > } > > > > @@ -1375,6 +1389,8 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > VMA_ITERATOR(vmi, mm, addr); > > VMG_STATE(vmg, mm, &vmi, addr, end, vm_flags, pgoff); > > > > + ljs_dump(mm, addr, len, vm_flags, false); > > + > > vmg.file = file; > > /* Find the first overlapping VMA */ > > vma = vma_find(&vmi, end); > > @@ -1390,6 +1406,12 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > > > vmg.next = vms.next; > > vmg.prev = vms.prev; > > + > > + if (check_interesting(addr, addr + len)) > > + pr_err("LJS: prev=[%lx, %lx), next=[%lx, %lx)\n", > > + vmg.prev ? vmg.prev->vm_start : 0, vmg.prev ? vmg.prev->vm_end : 0, > > + vmg.next ? vmg.next->vm_start : 0, vmg.next ? vmg.next->vm_end : 0); > > + > > vma = NULL; > > } else { > > vmg.next = vma_iter_next_rewind(&vmi, &vmg.prev); > > @@ -1413,9 +1435,29 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > vmg.flags = vm_flags; > > } > > > > + if (check_interesting(addr, addr + len)) { > > + char *special = vm_flags & VM_SPECIAL ? "special" : ""; > > + char *has_file = file ? "file-backed" : ""; > > + > > + pr_err("LJS: Interesting [%lx, %lx) flags=%lu, special=[%s] file=[%s]\n", > > + addr, addr+len, vm_flags, special, has_file); > > + } > > + > > vma = vma_merge_new_range(&vmg); > > - if (vma) > > + if (vma) { > > + if (check_interesting(addr, addr + len)) { > > + pr_err("LJS: Merged to [%lx, %lx), addr=%lx, end=%lx\n", > > + vma->vm_start, vma->vm_end, vma_iter_addr(&vmi), > > + vma_iter_end(&vmi)); > > + > > + mt_validate(&mm->mm_mt); > > + } > > + > > goto expanded; > > + } else if (check_interesting(addr, addr + len)) { > > + pr_err("LJS: Failed to merge [%lx, %lx), reset...\n", > > + addr, addr + len); > > + } > > /* > > * Determine the object being mapped and call the appropriate > > * specific mapper. the address has already been validated, but > > @@ -1441,6 +1483,11 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > if (error) > > goto unmap_and_free_vma; > > > > + if (check_interesting(addr, addr + len)) { > > + pr_err("LJS: call_mmap() on [%lx, %lx) old_flags=%lu new_flags=%lu new range=[%lx, %lx)\n", > > + addr, addr + end, vm_flags, vma->vm_flags, vma->vm_start, vma->vm_end); > > + } > > + > > if (vma_is_shared_maywrite(vma)) { > > error = mapping_map_writable(file->f_mapping); > > if (error) > > @@ -1467,6 +1514,11 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > /* If this fails, state is reset ready for a reattempt. */ > > merge = vma_merge_new_range(&vmg); > > > > + if (check_interesting(addr, addr + len)) > > + pr_err("LJS: flags changed for [%lx, %lx) from %lu to %lu %s", > > + vma->vm_start, vma->vm_end, vm_flags, vma->vm_flags, > > + merge ? "merged" : ""); > > + > > if (merge) { > > /* > > * ->mmap() can change vma->vm_file and fput > > @@ -1510,10 +1562,18 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > > > /* Lock the VMA since it is modified after insertion into VMA tree */ > > vma_start_write(vma); > > + > > + if (check_interesting(addr, addr + len)) > > + pr_err("LJS: mm=%p: iter store addr=%lx, end=%lx, vma=[%lx, %lx)\n", > > + mm, vma_iter_addr(&vmi), vma_iter_end(&vmi), vma->vm_start, vma->vm_end); > > + > > vma_iter_store(&vmi, vma); > > mm->map_count++; > > vma_link_file(vma); > > > > + if (check_interesting(addr, addr + len)) > > + mt_validate(&mm->mm_mt); > > + > > /* > > * vma_merge_new_range() calls khugepaged_enter_vma() too, the below > > * call covers the non-merge case. > > @@ -1530,6 +1590,10 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > perf_event_mmap(vma); > > > > /* Unmap any existing mapping in the area */ > > + > > + if (check_interesting(addr, addr + len)) > > + mt_validate(&mm->mm_mt); > > + > > vms_complete_munmap_vmas(&vms, &mas_detach); > > > > vm_stat_account(mm, vm_flags, pglen); > > diff --git a/mm/vma.c b/mm/vma.c > > index 4737afcb064c..33f80e82704b 100644 > > --- a/mm/vma.c > > +++ b/mm/vma.c > > @@ -1108,8 +1108,13 @@ void vms_clean_up_area(struct vma_munmap_struct *vms, > > vms_clear_ptes(vms, mas_detach, true); > > mas_set(mas_detach, 0); > > mas_for_each(mas_detach, vma, ULONG_MAX) > > - if (vma->vm_ops && vma->vm_ops->close) > > + if (vma->vm_ops && vma->vm_ops->close) { > > + if (check_interesting(vma->vm_start, vma->vm_end)) > > + pr_err("LJS: mm=%p Closing [%lx, %lx)\n", > > + vma->vm_mm, vma->vm_start, vma->vm_end); > > + > > vma->vm_ops->close(vma); > > + } > > vms->closed_vm_ops = true; > > } > > > > @@ -1179,6 +1184,10 @@ int vms_gather_munmap_vmas(struct vma_munmap_struct *vms, > > struct vm_area_struct *next = NULL; > > int error; > > > > + if (check_interesting(vms->vma->vm_start, vms->vma->vm_end)) > > + pr_err("LJS2 vms->start=%lx, vms->vma->vm_start=%lx\n", > > + vms->start, vms->vma->vm_start); > > + > > /* > > * If we need to split any vma, do it now to save pain later. > > * Does it split the first one? > > @@ -1202,6 +1211,11 @@ int vms_gather_munmap_vmas(struct vma_munmap_struct *vms, > > goto start_split_failed; > > } > > > > + if (check_interesting(vms->vma->vm_start, vms->vma->vm_end)) > > + pr_err("LJS: mm=%p vms=[%lx, %lx) split START of [%lx, %lx)\n", > > + vms->vma->vm_mm, vms->start, vms->end, > > + vms->vma->vm_start, vms->vma->vm_end); > > + > > error = __split_vma(vms->vmi, vms->vma, vms->start, 1); > > if (error) > > goto start_split_failed; > > @@ -1217,12 +1231,23 @@ int vms_gather_munmap_vmas(struct vma_munmap_struct *vms, > > for_each_vma_range(*(vms->vmi), next, vms->end) { > > long nrpages; > > > > + if (check_interesting(vms->vma->vm_start, vms->vma->vm_end)) > > + pr_err("LJS: mm=%p vms=[%lx, %lx) UNMAP [%lx, %lx)\n", > > + vms->vma->vm_mm, vms->start, vms->end, > > + next->vm_start, next->vm_end); > > + > > if (!can_modify_vma(next)) { > > error = -EPERM; > > goto modify_vma_failed; > > } > > /* Does it split the end? */ > > if (next->vm_end > vms->end) { > > + > > + if (check_interesting(next->vm_start, next->vm_end)) > > + pr_err("LJS: mm=%p vms=[%lx, %lx) split END of [%lx, %lx)\n", > > + next->vm_mm, vms->start, vms->end, > > + next->vm_start, next->vm_end); > > + > > error = __split_vma(vms->vmi, next, vms->end, 0); > > if (error) > > goto end_split_failed; > > @@ -1295,9 +1320,14 @@ int vms_gather_munmap_vmas(struct vma_munmap_struct *vms, > > } > > #endif > > > > - while (vma_iter_addr(vms->vmi) > vms->start) > > + while (vma_iter_addr(vms->vmi) > vms->start) { > > vma_iter_prev_range(vms->vmi); > > > > + if (check_interesting(vms->vma->vm_start, vms->vma->vm_end)) > > + pr_err("LJS3: addr=%lx, vms->start=%lx\n", > > + vma_iter_addr(vms->vmi), vms->start); > > + } > > + > > vms->clear_ptes = true; > > return 0; > > > > -- > > 2.46.2 > > I just tested the "hunch" commit (without this patch) and it crashed in the same > way. Here are more detailed instructions of how I create the crash: > > The game used is Rogue Heroes: Ruins of Tasos (which is basically Zelda). The > game itself does not work anymore (even on unaffected kernel versions), it has > been crashing with a > > Unhandled Exception: > Microsoft.Xna.Framework.Graphics.NoSuitableGraphicsDeviceException: Failed to > create graphics device! ---> System.TypeInitializationException: The type > initializer for 'Microsoft.Xna.Framework.Graphics.GraphicsAdapter' threw an > exception. ---> SharpDX.SharpDXException: HRESULT: [0x80004005], Module: > [General], ApiCode: [E_FAIL/Unspecified error], Message: Call failed. > > error for sometime (probably a year). > > 1. Go to Properties->Compatibility and select "Force the use of specific Steam > Play compatibility tool" and the select Proton 7.0-6 > 2. start the game, the game should then crash with the Xna error above > 3. Go to Properties->Compatibility and unselect "Force the use of specific Steam > Play compatibility tool" > 4. start the game again, this will usually give the vma error (on two occasions > so far the whole procedure (1-4) had to be done twice to get the error. > Thanks for this, however the game does work for me, at least on nvidia :)) I continue to suspect an amd-specific issue here. I will try on my intel gpu laptop too. > Bert Karwatzki >