From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC18C25B67 for ; Tue, 24 Oct 2023 01:57:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11CE46B0167; Mon, 23 Oct 2023 21:57:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CD3C6B0169; Mon, 23 Oct 2023 21:57:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFE626B016A; Mon, 23 Oct 2023 21:57:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E3B8C6B0167 for ; Mon, 23 Oct 2023 21:57:36 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BA9534099E for ; Tue, 24 Oct 2023 01:57:36 +0000 (UTC) X-FDA: 81378693312.25.129A864 Received: from out-197.mta0.migadu.com (out-197.mta0.migadu.com [91.218.175.197]) by imf25.hostedemail.com (Postfix) with ESMTP id B8D7CA0008 for ; Tue, 24 Oct 2023 01:57:34 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TtQ3KVye; spf=pass (imf25.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.197 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698112655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SjgMBTuitzWiqP1VcTJIuT4VtPo4lD7nloc78b4VZx4=; b=dcas1gP6ur7cRSIC6wrpvWtFTJnGhyXVG9fobsFAZRzpG9k4iSEfgddN7wwAclCpV7lzo/ RY9r3Yx+6ujxxsG8UhsN46soEfoxr9zLsNxAyoe1ERdvfCx92edqjxmDis4zA2vVsficke 9Jg1AESYJjAZALGp4af+Q/r1FXbKDV0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698112655; a=rsa-sha256; cv=none; b=FpqfB+08MecF/l1c0v/NpX8vBwHxJ86RC3BzmG20fYerEd1euUKmh0ApxGxiCSzm2bR1lC RxqrnQAozir8UmhEJe5SnuJOG5leH4HwTgPz6yTB3Uk151Wx6pDIqZrYiz/jaU28IQt/Se egiWod21XLceQfgiNAeg6NgsYVcqeN0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TtQ3KVye; spf=pass (imf25.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.197 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: <3853229d-f68b-4960-8679-70d6f6aff9aa@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698112652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SjgMBTuitzWiqP1VcTJIuT4VtPo4lD7nloc78b4VZx4=; b=TtQ3KVyew64mhmsodXWVnBiE7CVDnvKHUF0hZZAVTl6JC9JB/PbJPd7kMyhG3w8jkliNji WFaHIPwoXbV6ozjjVW0ivWgodejQYMD/thWQNK3DL/7ALURmqKyWltcDTikNMAcVoi/oG6 SzPEdkGNoKgGLb72/LHldviYu8ZYi+M= Date: Tue, 24 Oct 2023 09:57:25 +0800 MIME-Version: 1.0 Subject: Re: [RFC PATCH v2 1/6] slub: Keep track of whether slub is on the per-node partial list Content-Language: en-US To: Matthew Wilcox Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, pcc@google.com, tytso@mit.edu, maz@kernel.org, ruansy.fnst@fujitsu.com, vishal.moola@gmail.com, lrh2000@pku.edu.cn, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chengming Zhou References: <20231021144317.3400916-1-chengming.zhou@linux.dev> <20231021144317.3400916-2-chengming.zhou@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: joshhgz4ck4q17djxjmgk1p7tmoth4xq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B8D7CA0008 X-Rspam-User: X-HE-Tag: 1698112654-545532 X-HE-Meta: U2FsdGVkX1/WfqN9UJ5itovMSzhDssp/+Tv3MB528yAAw2vuB0GEX1l0kiquuJ/eWYF7gZdUYgygEJ5ICo7lmAd2k2vOg9oIgIAaMXM7DtgUSfic8uXBXPubJyQc+45uram8Vx0EXI+wqX+FXnmuh+tKsBfEajgTwz5e0ewDpFoOP8tuNlwETH4gtaxgBC+CBiHI9UoSgbBYefpO8/oVUZQzUMAw5BM+C5ayTtla4jnN9uS5hVdHdWHZE4HV3EpePu+Foq8b9GauFKVJH39rAdPrm0PbJCGzr5PqEgr0QRUD4n47TxXQ23nkZdndfaWEeGDSM0sHxbKsu2CtgoGSy5bXAZMwXK8YQHQx6WlLQ5hN1YUvHaydmDZSq7TfntwdEmFy81Z2eJvAeQUlYglpiB4OzYya4XF+hIfAvWEdTsw4Iyd/RpqkgkK3W8lnN1jUbc6z99nWUSaF/Q4dV+EzB/UrZV4rEDLnmX4FaTPurIkcPWTcds49AyxXoCOhx13hS0BqjtPvmLtZQHPcmExXSKPaPXS/fLofc3qLKmkOwC1w+mZ+zTmkdvu+G6zt2miAnzYR/FHgJKdHmljVHGE7RLs+Eqx25vhm+RtPkB6+PUd3YmjVvj385SKyQX0eHPBD9+7YRchOaT6AtoDAIKraEEZeVPFZBE6wCOKQ821ILsBYseGrIAQuc/zdfWJP50Vcz5FYrL6KtN8M/fhpaAYvyRM/VjhWqXnKr9xnz+6K6MCOiTh0hHik6L3OQRovYnD1wXLSFbrGcmGna0UPNMha4M5L12xKRdVb0ZZfUZ/xTJWcERUtxVRzEvaaO5a2P50zl3X1rZ+geSLT8MQP51lWOcBs9da4ja0lrLoFEPq99t/AhCa+bZFlWzCpI6M46Rf/Fn+W9dQhwmy1Wyj51FDG1VnNg/YjZPs91A1jxQR9h/BQNLxNQLvOz8E9PPtmggddfw3oioRrXiXCUqniKzp 3GufKn/e CouvY27SPbWgKRRcVnzHaTtLD6zylRBiQpJkj1CQtep0GfAjOvEzf7WUiF8yu+pJ8kOazwD3QWMVpMFXtwhOSHYO3PsVxRsG3w5dsHXFwlWzQy/99dqevTaoXNmICmIPH/Vdc6vXv4wzRxvUaVjrOchcorxNACHtkr+z0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/10/24 00:22, Matthew Wilcox wrote: > On Mon, Oct 23, 2023 at 01:32:27PM +0100, Matthew Wilcox wrote: >> _Assuming_ that it's safe to use the non-atomic flag setting, I'd >> rather see this done as ... >> >> static inline void slab_set_node_partial(struct slab *slab) >> { >> __folio_set_workingset(slab_folio(slab)); > > Ugh, I meant to delete this line. I meant to just write the next line. > >> __set_bit(PG_workingset, folio_flags(slab_folio(slab), 0)); >> } Yes, it's safe to use the non-atomic version here, since it's protected by the slub per-node list_lock and we want better performance here. Ok, will change to directly use __set_bit() and __clear_bit() instead of polluting the "workingset" interfaces there. Thanks.