From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D295C4345F for ; Thu, 25 Apr 2024 14:45:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CC716B008A; Thu, 25 Apr 2024 10:45:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 754DB6B008C; Thu, 25 Apr 2024 10:45:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A7636B0092; Thu, 25 Apr 2024 10:45:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 39C5E6B008A for ; Thu, 25 Apr 2024 10:45:31 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D75F5C0608 for ; Thu, 25 Apr 2024 14:45:30 +0000 (UTC) X-FDA: 82048327620.25.984BC76 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf05.hostedemail.com (Postfix) with ESMTP id D4737100017 for ; Thu, 25 Apr 2024 14:45:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=UPwzZfRz; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf05.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.210.176 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714056329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Upe9hXc85SfykUK8OSJyDQtUplWhtMiTd1jA3tMRXuo=; b=7AatzAjkvHwF0rjMpwo3sJwO9PLVVdjR4/5ozsPqi/05LmyWqFqiMBm97OBk6oQnwtNkd5 xG5sXUjkWnuO6sJIUZIXDTu8PJSH0/hzrN+NTDT63s2dwpzNuvYqkpqj01ihTEIbsFMpWj byT4T/MWfHt2VkC781YWEsIP6rHrqCw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=UPwzZfRz; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf05.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.210.176 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714056329; a=rsa-sha256; cv=none; b=SetK1XMW8DJYUbWWFX2ygK/5sDzQLVkXy0rButhFeZ0+MMDku6Fs2gstWVjJQgeYdSkL3h 5lswnkawwV0ldkmxB7X2y+SMykB3ZNOU7d6Hyk2FPTcBsPKMIOCv/69k94Ui/EDSobcLJn iIiJoTRgGn8MMmHNQcKWS/gwuG7o90Q= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6f055602a7aso65347b3a.2 for ; Thu, 25 Apr 2024 07:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1714056328; x=1714661128; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Upe9hXc85SfykUK8OSJyDQtUplWhtMiTd1jA3tMRXuo=; b=UPwzZfRzQaYWbgLOtfvxNh3QfxZQAY7+hlcH0Wn/2gEtVEH//g6gPW1DHdoT4zOETs pgHaf2jJG2yatFe5ZbibCVcyqps/mKqWM734ygfJO3kE2KON3T3IlBNFrlBkk6nIsV7V gaQNwKNkZ7+ye2OgFTZMamuGiWo92kBnIv1Ys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714056328; x=1714661128; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Upe9hXc85SfykUK8OSJyDQtUplWhtMiTd1jA3tMRXuo=; b=Uk/OjXvmF8Xf05a2AeLUkNHFC8gSDSnZEFNG+WpqVnwFId+lLFNd+SaispdP+7x75F TRFRs9YKRpXEfj2NkiAQrnIyG+ZoyE7xeGGfD/YSBBZ0+galtcOLPLnSuh/Tfe6e22oR qOlkQSS9VwTvOKpe0a5m4AwfidIqcIbubbr8UFB9XIuAoq8QCKFRAoshK7WbxCAmSGyu QWqP2qC2/PyY7nkwkRC9K9/wIQOH6MuA88+VKMD+EpQ4mw3AM6NMXbkK0XuRq27444cG j3hZKr+YCW5r93od3l34ZTgqfdCUKH/HMOMUSraWuBh44zYwB7mitu2SpIuWwHU0ZC0y VQ9w== X-Forwarded-Encrypted: i=1; AJvYcCXUzg7MH3FlvJ76zGLHV/lCd4tDRja3Zd0DmfOKF0U0upEzYZ2YwysCPUL+RyJcpeBo25aGyNylTb74r1JtE3o+aHE= X-Gm-Message-State: AOJu0YziBKkIfL8M3jV5NhPHvSlYudna1PG7AuLlAAEB/CYnUaLq0J+p 5jPSTAvbSQarRil/xqZbyWRJaU7v7+JSi7lTOs9h+YuUDU4tu6ce13hRepbugbU= X-Google-Smtp-Source: AGHT+IH2ZWIxVnWGlxZ14mWcvRqLtKyE6u0gRzo1WyBlfFhqv5treC26C0VPwnpQrTOD05hYIY1E7A== X-Received: by 2002:a05:6a00:731:b0:6ea:ba47:a63b with SMTP id 17-20020a056a00073100b006eaba47a63bmr6568081pfm.0.1714056327589; Thu, 25 Apr 2024 07:45:27 -0700 (PDT) Received: from [192.168.43.82] ([223.185.79.208]) by smtp.gmail.com with ESMTPSA id k124-20020a633d82000000b005f7d61ec8afsm11351461pga.91.2024.04.25.07.45.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Apr 2024 07:45:27 -0700 (PDT) Message-ID: <3848a9ad-07aa-48da-a2b7-264c4a990b5b@linuxfoundation.org> Date: Thu, 25 Apr 2024 08:45:07 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 25/35] KVM: selftests: Convert lib's mem regions to KVM_SET_USER_MEMORY_REGION2 To: Dan Carpenter , Sean Christopherson , Shuah Khan , Greg Kroah-Hartman Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" , Naresh Kamboju , Anders Roxell , Benjamin Copeland , Shuah Khan References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-26-seanjc@google.com> <69ae0694-8ca3-402c-b864-99b500b24f5d@moroto.mountain> Content-Language: en-US From: Shuah Khan In-Reply-To: <69ae0694-8ca3-402c-b864-99b500b24f5d@moroto.mountain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D4737100017 X-Stat-Signature: 7gok9teb8gfmrzicycpxzjmttsfuifhc X-HE-Tag: 1714056328-702395 X-HE-Meta: U2FsdGVkX1+GPaPDS01GV9TgB11UjbXJeQNFZOm2rjAVLdY7H4J/LU136/LWSomVl4GITl78pTH9wsAwIO+ST1+xRZfgTWgXpZYO+uPqzaxzd6dxYSxwkPKWPf6x7zWVLJwabceWHMAd6x5gpdhfFzhvL8QhfHW5zYuugAd9MBPAQf6a5UmwGtFdiIDnFM+60hEyY650zKT4E5/egCmLs6ytkAa7E+BPyNyxj1zEmzZmCUcq2nE3DaRdPlVfiOuA0bG5gsdduHI0zF63qjIY1aUeGxmNEOee6TOrpJjSIPJBQGSQOWnQ2F1Igj/z3tY7WrP2wUXk9dqnSaKerGJWpXmJ25csWZQ5t9PDPxW+hfne8BtQAWlKQHQAdtRVSC4gbCdW1aAVHKs8iqmu0JjCjQqcrdj/Dy/zmj/2mwma61KqXLl3liti/gGLXF+THaJ7wk7MR3TJ8HxOhDmps82O7y5hYMpcrRMzfX/1Gve6eGBPBP4dMaiQV31JfHAih0cEhDPd6XdCjloktZqc/dBe/oBcDBJn/KLV0ofgfPs4EGyr1fiDiconKASh3JOVDKTRo8FX3x3YWSKGxDeovxsJ52DllvTF0MIL4lRXGBvDiuYaSKhmwe5WTZ+a99ZOHoe8tF11ADmKE4BpXcfUzVKozs+0zNsGh7kE2n0tkdeQjA86EXbLb6/qJ4F9NwOlti1JoiG4pmwjtynDBSkg6DqyA9x58Qb0ZwMzcfs32jgs/yrSP5bXC95yh2bREfsM3PHkTTSrGOBakbzqY0A7cdedmoiLXJuxa9WGSK8oU9uHqU4WVduXPnWNbR7B2OUrD5HP6RF5rhKPBmhn+MMkOGGU3ZZS4Q/sDTHmnDr4vwjPG5M9gergsVJwlJ1zlrdg2CeAokd6o29GwMF+8YoBliyuiGc0mfQ0qigSFumBOCkHVlDdI990Tu/15O8dryVxiq2jXGW8Xt6WfO78V+2CrQf 0hbue6E2 kry2/7I+Kz8TW0bQEQoEju62I1q9UitjtjJu15hX8hvc79WQKGuMuIgt4a/d4U/q16IHTs1IXsInoI/6wMUOzWKcliyCOYKmNsOjPUOxvBW5rJTI1cB3iNKkbcZUp2i1Tes2iyHy13+YTfj95Z4vyZj1Ry1Zru8uQd1Ac/Hzm2zVn/4X/R55bTZzrNyj4WbIXGBc056++jhHeYaDVG/TNnhVA5mEe979t9E5KNZKsx4LxtyEMd4H/+gYlfKePvfBU4MVtRLSMB3xLXs3vHOZPZ2Q5+S0Lez7GnIkg74fMt9YTW4fVBNnEFMO6AgTmtfI8rmpGWDpZDfyPWEsUU3BCDi8A+sShODCCnmKjf18NBQD0JLctP4LlAa7sj6eR270HXBoFVZ8Mb7jHjWqWU6jhbMVaIwFYUcKPHCNy1jIA7sgPBj5Aw3Wlz8kPN3janVgshyGdJCjGR0A8Fgn4bJffTKeb8CYfq1N95y81tmLHsbsEdaOBQeqUkCBF3icVtF9IfB3xw/Vxso5/lgarCl6Ttk13heTULn97r66S7QQ/zLn6AWLQGKHJCDU24A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/25/24 08:12, Dan Carpenter wrote: > On Fri, Oct 27, 2023 at 11:22:07AM -0700, Sean Christopherson wrote: >> Use KVM_SET_USER_MEMORY_REGION2 throughout KVM's selftests library so that >> support for guest private memory can be added without needing an entirely >> separate set of helpers. >> >> Note, this obviously makes selftests backwards-incompatible with older KVM > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> versions from this point forward. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Is there a way we could disable the tests on older kernels instead of > making them fail? Check uname or something? There is probably a > standard way to do this... It's these tests which fail. They shouldn't fail - the tests should be skipped on older kernels. If it is absolutely necessary to dd uname to check kernel version, refer to zram/zram_lib.sh for an example. thanks, -- Shuah