From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C046AC05027 for ; Mon, 23 Jan 2023 10:33:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E29F36B0071; Mon, 23 Jan 2023 05:33:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD92A6B0072; Mon, 23 Jan 2023 05:33:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA9B76B0073; Mon, 23 Jan 2023 05:33:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B95C96B0071 for ; Mon, 23 Jan 2023 05:33:34 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8E293C05D9 for ; Mon, 23 Jan 2023 10:33:34 +0000 (UTC) X-FDA: 80385702348.23.69C1220 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 6C6C0C0004 for ; Mon, 23 Jan 2023 10:33:32 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hynLKjFa; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674470012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ElqFEoc0EbRc9UUN0JseQJHQuAPyVJiJ/2beNKrTrWs=; b=K5JJia9iJk4f4sS0wwd/z4uJONgHDjyW9P3JzmSh/507xrngz3p7ZzoKbaH6ts7feH44MS 4m2UaZlwa2eFTJCauw1xsNLNqAf0DkP+eetndaEEncVFQnfiiBhjEEAa3gLTkIMPW5FybV n11TfHT2f/Df3qQsaDy5dhbABuaLkN4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hynLKjFa; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674470012; a=rsa-sha256; cv=none; b=vzuneoVOAJSbQiWJENCg16lGKKBSHxIk1R8daofh0tYn7IPnhk8wmKEfHLrMVSSZhGxVCD JEOvsHnpFYt/GpJEBDc5rZP7CT1fft+iZxKBxhG0ywUzgpQQYunDgLojeJtadIDB9FNQEa f6i8ut2xHixitpjpxAjDRJc1HPPJH64= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674470011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ElqFEoc0EbRc9UUN0JseQJHQuAPyVJiJ/2beNKrTrWs=; b=hynLKjFaSjN8B+t/7Zh7KrHhF2zjFaPu136hh3YZZuAZscQLcQpWUcIgjz1YHXm6kVnf+p MbD/YyTq7m97pIrvvFcYtK5BUQyqH+aFDzhX9MGwjhHev5RHdGxOFA1+Xt0TBe47oCSznO LJavXq9TSrZKf/kvg5KbrZYJsHImCi4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-460-qnntXXWTMamifG4vQ1HkBg-1; Mon, 23 Jan 2023 05:33:30 -0500 X-MC-Unique: qnntXXWTMamifG4vQ1HkBg-1 Received: by mail-wm1-f72.google.com with SMTP id c7-20020a1c3507000000b003d355c13ba8so7272426wma.6 for ; Mon, 23 Jan 2023 02:33:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ElqFEoc0EbRc9UUN0JseQJHQuAPyVJiJ/2beNKrTrWs=; b=WqM5DCwR3h1w9nfbEpSMfFJNm1pv06+hhw8290gZ/+SlpinyyO8pfjPykKf/soLYmE 6BBlBfhE0XMwytiCQJvQQa+ZCwng3PXnTQ2dq5HUUzak3t00u1gBnAkvVrKuMYJiRcjy pcmOzG/wL5lYyRqJiQ5xjnHZFl0bSIlFLEwINtkgWI1kbhvLf0IBEgRsPROyKpoDyNxr zFeewNXOOKqXz9XrQIUu3BHizRY/Q8t37+RMrs9aSXq5vw3qD4pZJCaObXWxCVUrzIpb g68ujCgEdd+mLfouTOGXUN5GdRUoWZGPEkocSW+EXdfkBUcsirNOyOprrn2sScfNokK1 RXJw== X-Gm-Message-State: AFqh2kp1PS4mRLiYoequb+vltbndTrzU3bzD7b2exQoEID2zq7OZ0ME7 h5tUjP/XjSQiIhXxmJ4KzHZad47pQzmNtJqOzK12WXBtWpMYyNQh4kRHXBYVUgThV4jgcvMfCMA 8WBSyCSqdiPw= X-Received: by 2002:adf:d0c3:0:b0:2bd:e5cb:e7df with SMTP id z3-20020adfd0c3000000b002bde5cbe7dfmr16250518wrh.32.1674470009603; Mon, 23 Jan 2023 02:33:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXsk5G9ktr9anm6O4EXqjV/YLTZzKnz+baHLmpWrz/G0eS9BZQhooZDNEW6O1TbYbRlganruIw== X-Received: by 2002:adf:d0c3:0:b0:2bd:e5cb:e7df with SMTP id z3-20020adfd0c3000000b002bde5cbe7dfmr16250502wrh.32.1674470009318; Mon, 23 Jan 2023 02:33:29 -0800 (PST) Received: from ?IPV6:2003:cb:c704:1100:65a0:c03a:142a:f914? (p200300cbc704110065a0c03a142af914.dip0.t-ipconnect.de. [2003:cb:c704:1100:65a0:c03a:142a:f914]) by smtp.gmail.com with ESMTPSA id q4-20020adfdfc4000000b002bc6c180738sm41477377wrn.90.2023.01.23.02.33.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 02:33:28 -0800 (PST) Message-ID: <3842ed6a-6c9d-7909-2ab8-106cb4897973@redhat.com> Date: Mon, 23 Jan 2023 11:33:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2] drivers/base/memory: Use array to show memory block state To: Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, shan.gavin@gmail.com References: <20230120233814.368803-1-gshan@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230120233814.368803-1-gshan@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6C6C0C0004 X-Stat-Signature: cc1y7c9wa9i9apzd1gkeyzp3w39m9aog X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674470012-9262 X-HE-Meta: U2FsdGVkX1/wnIuWPHIINwY6yQNP2oCxE1kMTSSz213RgjnHeSyJ7q+LKlan/ov6yprGBNsPC+OoG2SY05ubBXUFEk5iF1qwGjFjdWiY2yl7p7zmugt9gqlKq/LaFL5hWVRFW9k4SxXKVtkyHJApRVx10xQ39f5Z0YVqGoFfpq99Bi5g8HOQYh3xVPei/xSuJ84O5sO0gpVffY+cVJD1HW/1imzi+FksGHtmhys+EJLIZg8NIJCawzktan3F8OcbQhRtUORQY3FOeBa6nlkxEelCr++OwIr0O4CyVkCeoyjMeYc/88TTKVQN5mokEtaI4mAaMRJdLmCshQB0KgpHhTdG/IPC2Haws+haHRm3LrFnEuhUGAzJ1SAzeZkbN1fxCP2VbRAGr2HMdv41Ogx8LQekqrZrfTqdq/V7Llnk1wvLliuzI0yE1wrcZRgMAwPR/Db96ZN31SGWVhHgux0GhAiZoUcxh0y0/CxASF2XQeICm0L16vwEnaDkz1CgAeZ1JzY3rmM+EeKb5MN1IV7kG6TPlYmS4yntt3QDBrvKgDmOjsOCWHr7WD/wT8pj9ZBloPFx6+0FIE90Kn4+CahBHTH7Md6MGL38ss6803boNqPlU8uBWD5Y23eus6TwqN4wnF2uG5FvxGKhMgiC2/QRbD8ZY/F5nF1VT9Ka4Bh0jD1VpaM3ddibTmQjUkz1zlUDAOWWusl7fHQD0O6vudGoThIw7AAfghPtZjcSFC8qfFjJfkNzUNhW8Z6ZtUD5dUhc2nZSgFg0iIKL335/6bC6YuO47lMCfhS//qTaWobduJlZddcEU0t9rAstip2mOoWArdMIf5NUT/Aih46O6icAQLiXmH6t2rVribpWkkHITQ+QYYzc19zCEr4SmiSEvOjkuxfAgz9stwsXcZTwmtgevxHAOyTEUrNiZzgJydKdd1IicqFKrCJTufzAXb8x9R/L2sBOuxUOs8jfb5sQ/Em PJYbdyJl DWTeN1ulrSK02S5u+sWL7CdCkqL4FJ/fxKtjw38/6KwUTlerbqN7TAqjfLGsusG+YnlkI87LPPh9xyjsAguhn24irGE3iNj9GRcP9r9eCPZXUCiekutr9yaBJWGAmOosOZOynaBIsGVUFuGDeir62M/gQd9jB0dOmcHlz43LsTf9hn6NtAy7mhcFvV3EhpzzmuXTGEqbgqYU8qohbKoYH2bMrh7bTRO7PviY4KTt5cX2ARhYe6tLxsyloLrub0ieQwvWJsGRLqwR1epf41efnvZNnbbcYI30xZySzN6GdF4MaBJeUfF5LlP2PUc+BFBQI+eX+XQVm59Ar9KVy9F2fSV2cZAJ5fh0Q0MJCnpIK9splxFaSQWIQ/NpA/fJ6WG2fSVk63IFML+jWQPEV0BAyMOThqtyc4rkku2lg1Dg/NWWDlaX8SUqDcpI47Z2l+FF7xyIWXGhvZf+8U5RNcbPzLJmtbdaRALjVdeTpT7C3OU3bLt17wRNjNcKVVA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.01.23 00:38, Gavin Shan wrote: > Use an array to show memory block state from '/sys/devices/system/ > memory/memoryX/state', to simplify the code. Besides, WARN_ON() > is removed since the warning can be caught by the return value, > which is "ERROR-UNKNOWN-%ld\n". A system reboot caused by WARN_ON() > is definitely unexpected as Greg mentioned. > > No functional change intended. > > Signed-off-by: Gavin Shan > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb