From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44527C433F5 for ; Tue, 3 May 2022 18:17:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6A9D6B00BC; Tue, 3 May 2022 14:17:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F1EF6B00BD; Tue, 3 May 2022 14:17:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 845136B00BE; Tue, 3 May 2022 14:17:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 6E2046B00BC for ; Tue, 3 May 2022 14:17:51 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 40408808A7 for ; Tue, 3 May 2022 18:17:51 +0000 (UTC) X-FDA: 79425240342.14.7435025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 7BFD51C0094 for ; Tue, 3 May 2022 18:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651601870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P63ZGOtEGiivSqfcLZo0Ewf/QknQvuPiQQu+5Py7rXA=; b=FjytNXEJoqJB7oe+E5UsEDm5/Tf85fcYBLWYT5a0jIPc7bRlfWsbs9Qd/lJ7bv9ENQuAkx KsMFzXDQvAmzy6vZlu5ACWNNNWqDpXgF+d7LFURsC2t1391bJR22wu+Zn2PCKpHLJR7TkF m5CJzbUxM+vygxrHoyHQVk/5k5aKvCc= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-449-O0Z1OUcvP2KZMSRYcAdU2g-1; Tue, 03 May 2022 14:17:38 -0400 X-MC-Unique: O0Z1OUcvP2KZMSRYcAdU2g-1 Received: by mail-pl1-f197.google.com with SMTP id l4-20020a170903244400b0015ebe12a192so629587pls.16 for ; Tue, 03 May 2022 11:17:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=P63ZGOtEGiivSqfcLZo0Ewf/QknQvuPiQQu+5Py7rXA=; b=1SPBD0fP1km4mPdVytjSI2hIUvjai02d6FyuxQPRZxEuECfJdRs8ssbdJq0WlS0t55 Xza7xmP7AzhfuNagbbx5zKjgYDBbS/vvShbWgVDKs9fUHA+ntfA7lLHDC80mXVJWa4mI zQDeA3+YOqrI5lI93WH81Uglxz1a9a5ZJyNgIXYoXssHdpoOYIxQ2BbzTLxJ8zQL6iW1 BBDO3DLTkv5AZwrK7gdNVwWOssdrpkmx9BldnCTsMouwdJj6TfywOVJRzoJDYFVZdzDj jhdU8seiNCP1hb4YwaL70UhZwQ6FI2VX7Zl/MlTkgZsewoWkQ1Nq2DL+Uh2LUvW+ze2t RqXg== X-Gm-Message-State: AOAM530LgjXP4UDV39261dOtFwV35Hz+F7LdGsz7n2gRoGJ6PbBZ7Lat GhYTCq2Y+e4jdtmzwfX8NnloCZRpBbtG3g2x3nVtKsQFKifDJMvhB+VGdSCQdKHPAx88jKtd2qj EnTRFVNALTeA= X-Received: by 2002:a17:902:bf09:b0:153:99a6:55b8 with SMTP id bi9-20020a170902bf0900b0015399a655b8mr17547401plb.142.1651601857855; Tue, 03 May 2022 11:17:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuI7TcozKFCyPppg6x8KBz2OVqVxwFQ8U4CwwNi/frBVHhp6t110Iv+HC7VWKGZ5BO8WqnhQ== X-Received: by 2002:a17:902:bf09:b0:153:99a6:55b8 with SMTP id bi9-20020a170902bf0900b0015399a655b8mr17547366plb.142.1651601857503; Tue, 03 May 2022 11:17:37 -0700 (PDT) Received: from [10.10.69.234] ([8.34.116.185]) by smtp.gmail.com with ESMTPSA id c21-20020aa78c15000000b0050dc7628179sm6610559pfd.83.2022.05.03.11.17.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 11:17:36 -0700 (PDT) Message-ID: <383d5191-ec3f-49d6-106a-ffb33e0c3a5d@redhat.com> Date: Tue, 3 May 2022 20:17:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/6] drivers/base/node: cleanup register_node() To: Davidlohr Bueso , linux-mm@kvack.org Cc: mhocko@kernel.org, akpm@linux-foundation.org, rientjes@google.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, dave.hansen@linux.intel.com, tim.c.chen@linux.intel.com, roman.gushchin@linux.dev, gthelen@google.com, a.manzanares@samsung.com, heekwon.p@samsung.com, gim.jongmin@samsung.com, linux-kernel@vger.kernel.org References: <20220416053902.68517-1-dave@stgolabs.net> <20220416053902.68517-2-dave@stgolabs.net> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220416053902.68517-2-dave@stgolabs.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: rnbntj4w8uia9c1c16qygomckqeeter5 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FjytNXEJ; spf=none (imf20.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7BFD51C0094 X-HE-Tag: 1651601864-321015 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.04.22 07:38, Davidlohr Bueso wrote: > Trivially get rid of some unnecessary indentation. > > Signed-off-by: Davidlohr Bueso > --- > drivers/base/node.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index ec8bb24a5a22..6cdf25fd26c3 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -661,16 +661,16 @@ static int register_node(struct node *node, int num) > node->dev.bus = &node_subsys; > node->dev.release = node_device_release; > node->dev.groups = node_dev_groups; > - error = device_register(&node->dev); > > - if (error) > + error = device_register(&node->dev); > + if (error) { > put_device(&node->dev); > - else { > - hugetlb_register_node(node); > - > - compaction_register_node(node); > + return error; > } > - return error; > + > + hugetlb_register_node(node); > + compaction_register_node(node); > + return 0; > } > > /** Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb