From: David Hildenbrand <david@redhat.com>
To: Davidlohr Bueso <dave@stgolabs.net>, linux-mm@kvack.org
Cc: mhocko@kernel.org, akpm@linux-foundation.org,
rientjes@google.com, yosryahmed@google.com, hannes@cmpxchg.org,
shakeelb@google.com, dave.hansen@linux.intel.com,
tim.c.chen@linux.intel.com, roman.gushchin@linux.dev,
gthelen@google.com, a.manzanares@samsung.com,
heekwon.p@samsung.com, gim.jongmin@samsung.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] drivers/base/node: cleanup register_node()
Date: Tue, 3 May 2022 20:17:34 +0200 [thread overview]
Message-ID: <383d5191-ec3f-49d6-106a-ffb33e0c3a5d@redhat.com> (raw)
In-Reply-To: <20220416053902.68517-2-dave@stgolabs.net>
On 16.04.22 07:38, Davidlohr Bueso wrote:
> Trivially get rid of some unnecessary indentation.
>
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
> drivers/base/node.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index ec8bb24a5a22..6cdf25fd26c3 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -661,16 +661,16 @@ static int register_node(struct node *node, int num)
> node->dev.bus = &node_subsys;
> node->dev.release = node_device_release;
> node->dev.groups = node_dev_groups;
> - error = device_register(&node->dev);
>
> - if (error)
> + error = device_register(&node->dev);
> + if (error) {
> put_device(&node->dev);
> - else {
> - hugetlb_register_node(node);
> -
> - compaction_register_node(node);
> + return error;
> }
> - return error;
> +
> + hugetlb_register_node(node);
> + compaction_register_node(node);
> + return 0;
> }
>
> /**
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-05-03 18:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 5:38 [PATCH RFC lsfmm 0/6] mm: proactive reclaim and memory tiering topics Davidlohr Bueso
2022-04-16 5:38 ` [PATCH 1/6] drivers/base/node: cleanup register_node() Davidlohr Bueso
2022-04-25 22:30 ` Adam Manzanares
2022-05-03 18:17 ` David Hildenbrand [this message]
2022-05-04 4:33 ` David Rientjes
2022-04-16 5:38 ` [PATCH 2/6] mm/vmscan: use node_is_toptier helper in node_reclaim Davidlohr Bueso
2022-04-25 22:32 ` Adam Manzanares
2022-05-04 4:33 ` David Rientjes
2022-05-04 7:26 ` Jagdish Gediya
2022-05-31 11:50 ` Aneesh Kumar K.V
2022-06-01 6:12 ` Ying Huang
2022-04-16 5:38 ` [PATCH 3/6] mm: make __node_reclaim() more flexible Davidlohr Bueso
2022-04-16 5:39 ` [PATCH 4/6] mm: introduce per-node proactive reclaim interface Davidlohr Bueso
2022-04-19 0:00 ` Tim Chen
2022-04-16 5:39 ` [PATCH 5/6] mm/migration: export demotion_path of a node via sysfs Davidlohr Bueso
2022-04-22 17:31 ` Yang Shi
2022-04-22 17:33 ` Yang Shi
2022-04-22 17:50 ` Davidlohr Bueso
2022-04-17 3:49 ` [PATCH 6/6] mm/migrate: export whether or not node is toptier in sysf Davidlohr Bueso
2022-04-18 15:34 ` Dave Hansen
2022-04-18 16:45 ` Davidlohr Bueso
2022-04-18 16:50 ` Dave Hansen
2022-04-22 17:37 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=383d5191-ec3f-49d6-106a-ffb33e0c3a5d@redhat.com \
--to=david@redhat.com \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=gim.jongmin@samsung.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=heekwon.p@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=tim.c.chen@linux.intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox