From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDFBEC54E65 for ; Thu, 22 May 2025 17:21:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 893CF6B0085; Thu, 22 May 2025 13:21:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86A596B0088; Thu, 22 May 2025 13:21:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 734F96B0089; Thu, 22 May 2025 13:21:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 55E856B0085 for ; Thu, 22 May 2025 13:21:46 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 12B0A141B98 for ; Thu, 22 May 2025 17:21:46 +0000 (UTC) X-FDA: 83471211012.08.32887BE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 780A9120004 for ; Thu, 22 May 2025 17:21:43 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VvUMvCEO; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747934503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pYxc2D0JwJLViMTAcH2xt8CaCIo0A7lmtsU/AQhy9Wk=; b=3sypIDeiysqrIEP2uJiLy8jazebNFepumyivxvswZ4z9nhA1653XwaxG4hdP/YiZzBPBuN L19aNaSZwEkbc6jsmQ/6AdM79Bh7YvfTGepGZag+ux2wbaPNsUmWJkUrLTfy1CbBXfDL3W Q4YpvUnp+mWMPoDLWwTT/AjW2nmqGZQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747934503; a=rsa-sha256; cv=none; b=UYRZl/FSeqNVwOekpv2McLZhXV6jp6oGBrYKL7G1V4Jo690RNy1X8oUyVpxbOoef103WPh vLiWTHaDFSmPlpVORthdX3QEsVb/grDo/rsmtK1Kq3jfiQJa6GGLoc94ZoXr9cYKTcCK58 J5m6TnuLyetJxR89SS2G6PljW1IUAA4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VvUMvCEO; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747934502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pYxc2D0JwJLViMTAcH2xt8CaCIo0A7lmtsU/AQhy9Wk=; b=VvUMvCEOW0tD2WH2uUwSBiqoaAg/G6twsX2WofeLJPlhKHcc1XvA9OL0PQNhGmc7BHdsk3 wwK/h+RyOPvB9c5n+AwEyBUYXUXvaWUZCEaksHKWiFNlVE9k8g26aQ+ShfYkFbGc2kCb30 ONQBkgQgYl7695w42cLg4cJExl+IXjQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-qnUdaylLNlWmtuvA9RwA6g-1; Thu, 22 May 2025 13:21:41 -0400 X-MC-Unique: qnUdaylLNlWmtuvA9RwA6g-1 X-Mimecast-MFC-AGG-ID: qnUdaylLNlWmtuvA9RwA6g_1747934500 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a3703c1fe7so2424963f8f.1 for ; Thu, 22 May 2025 10:21:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747934500; x=1748539300; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pYxc2D0JwJLViMTAcH2xt8CaCIo0A7lmtsU/AQhy9Wk=; b=rTgmtRjR7QTqOF13k0H36aqG8lT2zgmeP2FkFAbhweFfJ6Nr6qfblk3a/QhsSURV9o hgKRHaXe4GTvMYJCbcbqUOqWz22PKxtMOaUUKbvn8k4nxB5HrMTtIndrgLHpshQFswai iqNViq6pvn+xUUu+e0gcQM9qbSo4/9GgmMREfh/NRackHqNukDykA4BWV2kI9wcYiSLh 9FZ+J58EkR38pwdEyv7h2RlprXWFHiQ0OU8YPTkYNt3KCNIb1S0MaR0UufBGj8taXc0M VfkM8oi1azL3wyXsTuEH9RWdh0ZSQMedXF3pg4WqIBCznoiV0bOLcb6aTFK7/8+aSQ2V SFVg== X-Forwarded-Encrypted: i=1; AJvYcCUZIgvmzzv/rEKGApzC8Dgs04ti3I0HUE6wqYT/biqVcxvmBKZy5mdQtpJcoKwx/BE7rrmGIbvEEA==@kvack.org X-Gm-Message-State: AOJu0Yzsf9udhoV4XlQGc1y6JoPe3FFGcP4YjrG9EtnRn8JZ9UgHVfQC bteZNxm8ImL21SWWukWBc3DDsFOwiOtGccqagUppz0fv910FfsN7JXaaVZUDa7gBYq9QPyrMMv0 mDXiivHdvl/ahqgPGGUktcBJnX9TBxU9YUdvs73rrAGf2rRzMVXBs X-Gm-Gg: ASbGncsGJ8QXTbRAE4+PUDz32f0NCHEmLzDGCbmdLFHv4LoXVlvIiE5qm2ikriozqG0 TWk8/SUOfdso/AyhYfwJtAQaRrL34e1Rp7ZXaEEn3pAtb5ADe9H1gciOghZ6BOA8aon60Dutzl3 DzAvSrHKby/tNNqLUdDXvzHHduIrUYvvoVGhzKoybj1+Vfryrc0iwl8NcEV8xzq2EAUoJpu72a4 9kq68YIUuh8N/v26UM8hD6oHTkFMIJV5Jl4bj4u0m8iRzSi4LeJl7KytdPjZ90m/Op2Va82IFUm 6oDeA5RaOumALlJ1kp9WmaFp5qHoiz2Ah8YfpwIv0beP73XdnKZbETTD3KCskGOr1Ui79JHjTmH B8NiX8a9S2/KtnSfzFooDKD2Ptvc6ZQP1Va9fIRc= X-Received: by 2002:a05:6000:2282:b0:3a3:7bbc:d94e with SMTP id ffacd0b85a97d-3a37bbcdc22mr12205840f8f.6.1747934500500; Thu, 22 May 2025 10:21:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHp/byQcJieqNQ3hbbBNzcI5U9f85MgUT9hdxi5zZ2koQY7FLLXdzMyNlpCQ3pvw4LXVWqGMA== X-Received: by 2002:a05:6000:2282:b0:3a3:7bbc:d94e with SMTP id ffacd0b85a97d-3a37bbcdc22mr12205805f8f.6.1747934500082; Thu, 22 May 2025 10:21:40 -0700 (PDT) Received: from ?IPV6:2003:d8:2f22:2e00:6e71:238a:de9f:e396? (p200300d82f222e006e71238ade9fe396.dip0.t-ipconnect.de. [2003:d8:2f22:2e00:6e71:238a:de9f:e396]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca5abaesm23879693f8f.39.2025.05.22.10.21.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 10:21:39 -0700 (PDT) Message-ID: <382839fc-ea63-421a-8397-72cb35dd8052@redhat.com> Date: Thu, 22 May 2025 19:21:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v0 2/2] mm: sched: Batch-migrate misplaced pages To: Zi Yan Cc: Bharata B Rao , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jonathan.Cameron@huawei.com, dave.hansen@intel.com, gourry@gourry.net, hannes@cmpxchg.org, mgorman@techsingularity.net, mingo@redhat.com, peterz@infradead.org, raghavendra.kt@amd.com, riel@surriel.com, rientjes@google.com, sj@kernel.org, weixugc@google.com, willy@infradead.org, ying.huang@linux.alibaba.com, dave@stgolabs.net, nifan.cxl@gmail.com, joshua.hahnjy@gmail.com, xuezhengchu@huawei.com, yiannis@zptcorp.com, akpm@linux-foundation.org References: <20250521080238.209678-1-bharata@amd.com> <20250521080238.209678-3-bharata@amd.com> <62cef618-123c-4ffa-b45a-c38b65d2a5a3@redhat.com> <5d6b92d8-251f-463b-adde-724ea25b2d89@redhat.com> <996B013E-4143-4182-959F-356241BE609A@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <996B013E-4143-4182-959F-356241BE609A@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DxABVqchWLzTzyXrTtneyTs0pld6HHfCAdY406WoLVc_1747934500 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 780A9120004 X-Stat-Signature: ff39b5adhbsnnxakpf1c8cgd83yxwtop X-Rspam-User: X-HE-Tag: 1747934503-367206 X-HE-Meta: U2FsdGVkX1+8x2CfmvfefLZ6yjEKuVBR6eg0sitk7JGIBmrZm50v1fMgiuoBmahmk+1QrnMXGxqxWg2PLieJoUf8eFwbQDNcGtNV5lcwddLZblvdxxnQw2FdM8vXfksjlh08RqE+SPKnqVl4TeDfD7+Sn5rK1NYHYJHx77J/IlqJl9v89O/oyoRPSU5Ojpn0IJLNJSfvKq5rNSEu6S/c7XIFEsJ1c02Fb4l6U+IrmSBFrh3abWkx2+nIuZLXmmAwTd1gYm+VqexweP6KsYrEJRHqNiNtYJoJjiv6YqNzXTA0/Louzj4k0TZ3ckE829wTkjF0n3ZjFT/SvsXgb2vFv9DhqKUcanIzBHahduLkyeecM7EAhFfip04NabnjiGiFfQzidAzuXGsMfGujXiHCJMb4QayAT8517FQYfdtZ7DKN2EiZWVq9ApGCt4WlhQG3iDrxe3dCvJH6OgeWeeyCMxXVmyyx5gNZB6L105U6ZuF17wFaSrURypTD1ANxXTO8EKdv1cjePsBGSDmZGbXa//Wg0EwUMqMzJvnmvvtx36kRgz93IwXwZ7rHf1gMcRJ5QkQ9PJZqLPE4aZu74HmuAt1p6tX2J5LpLhO3qVSyVCwf7YmYQ41u25p3qDTxEvibAWtSxAQIZy2od1a3Bn+khi4SfMCFcB6FNUgl8XTPnP/taH9fruhV+t16phD6NGoB4xuvr7shywIxNp5lutYRWq8aKIwiwAu84xv79r9DrmA6kwL8SPmPpEE0oPpWeJh/NIjniBckPHHBlkKKifKqKixeahsKj5js6LZ/jkX+HXiq5DiR69o3EDgu77VJzYSHpb5O0op+ixkWu4kfsG7OtGXRZ+Nq6pYF3wWD0Lmq+EPs8lPMETXMM2sALx+XIHKME+7TiVr6dPsrDToJCt4MerhdvBII1hT2y6oeT5csbk4vV4PIf1IhUFuENs9WaML7vsktukd3vpU2vNHDxzy J6Dh6P9/ Oph4qiEojuovXl/3wd8gDyw++REwvSL/PtEu+MkBz4EWeTNKVfnNL04TIwF2WghLguZZn0OGcZ3X6zzpGa/4smvA553SX3Z9Taa/shvfq/aJReozZwrzgg7aYvE1Lhn4Jj9NmevFpjEsC4aiaDDg4a+mDBo2SrOnm0hyivTtlxb/tNAiJj6DBlKyFi9r91QO0A1gJELIS0kMXlkAspzNK8LH11dAcbi8+oAUFkAW2tbRi7+9MHAFFzGjlTZgXJw+ES74fXeuqRor+dxCxd6LP3ochmhKec3nsp6RztVJv5sZod4uV+jVy89rezis429y8i8weAbB/35ggTj/kJ6D8x7ggZNgDEWnAb6t2spE57BFcQB76RZ7ORM2BsZp5R9pq/sPmrwpQYnweh/OYIxAjZOuJCxFDtTArZ6+on+R9jMQrIRymYOdfvyGFZ66JpUYmyIGjlgPbcRZjUe3lJ9PUUK3fArw+EeQ3Dn6r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.05.25 18:38, Zi Yan wrote: > On 22 May 2025, at 12:26, David Hildenbrand wrote: > >> On 22.05.25 18:24, Zi Yan wrote: >>> On 22 May 2025, at 12:11, David Hildenbrand wrote: >>> >>>> On 21.05.25 10:02, Bharata B Rao wrote: >>>>> Currently the folios identified as misplaced by the NUMA >>>>> balancing sub-system are migrated one by one from the NUMA >>>>> hint fault handler as and when they are identified as >>>>> misplaced. >>>>> >>>>> Instead of such singe folio migrations, batch them and >>>>> migrate them at once. >>>>> >>>>> Identified misplaced folios are isolated and stored in >>>>> a per-task list. A new task_work is queued from task tick >>>>> handler to migrate them in batches. Migration is done >>>>> periodically or if pending number of isolated foios exceeds >>>>> a threshold. >>>> >>>> That means that these pages are effectively unmovable for other purposes (CMA, compaction, long-term pinning, whatever) until that list was drained. >>>> >>>> Bad. >>> >>> Probably we can mark these pages and when others want to migrate the page, >>> get_new_page() just looks at the page's target node and get a new page from >>> the target node. >> >> How do you envision that working when CMA needs to migrate this exact page to a different location? >> >> It cannot isolate it for migration because ... it's already isolated ... so it will give up. >> >> Marking might not be easy I assume ... > > I guess you mean we do not have any extra bit to indicate this page is isolated, > but it can be migrated. My point is that if this page is going to be migrated > due to other reasons, like CMA, compaction, why not migrate it to the target > node instead of moving it around within the same node. I think we'd have to identify that a) This page is isolate for migration (could be isolated for other reasons) b) The one responsible for the isolation is numa code (could be someone else) c) We're allowed to grab that page from that list (IOW sync against others, and especially also against), to essentially "steal" the isolated page. -- Cheers, David / dhildenb