Re: [PATCH] gpu/drm/nouveau: fix return type in nouveau_dmem_migrate_to_ram()

["David Hildenbrand (Red Hat)" <david@kernel.org>]

On 14.11.25 02:22, Balbir Singh wrote:
> ret of type vm_fault_t is reused to capture the return value of
> nouveau_dmem_copy_folio(), which returns an int. Use a new variable
> err to fix the issue. The issue is not new, prior to this the function
> called was called nouveau_dmem_copy_one() and ret was used to capture
> it's value.
> 
> The bug does not cause a real issue at runtime, the value is used
> as a boolean to check if nouveau_dmem_copy_folio() succeeded or failed.
> The different types should not impact the execution of the code at
> runtime.

Again, spell out that it is a sparse warning one way or the other and 
ideally paste the relevant part here,

Also, take a look at the definition of "bug", like at wikipedia

"In engineering, a bug is a design defect in an engineered system—such 
as software, computer hardware, electronics, circuitry or machinery—that 
causes an undesired result."

Talking about a bug when nothing is broken can be really misleading to 
people that watch out for CVEs etc.

-- 
Cheers

David