From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5810FC6FD1F for ; Tue, 14 Mar 2023 21:52:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A20648E0001; Tue, 14 Mar 2023 17:52:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CFC56B0075; Tue, 14 Mar 2023 17:52:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 870BB8E0001; Tue, 14 Mar 2023 17:52:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 76AB36B0071 for ; Tue, 14 Mar 2023 17:52:19 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4E5061403C5 for ; Tue, 14 Mar 2023 21:52:19 +0000 (UTC) X-FDA: 80568852798.17.C413EB7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 495971C000D for ; Tue, 14 Mar 2023 21:52:17 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QQu1NO8S; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678830737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KL7RUrUlJgDEAxq9GYJFCawiEJWge2p1Oaahbua9byM=; b=BXcYDOBqPme7tfVTzcyIA5tL0xIGAuv+oS8Dlt8R+G8aa5Ax0FdYHWm/8UxjCTMtJYj6gq LhBgmBKPGRxIiWgsO33HiseNDiHiOkkb6qorw/7BgRQfLiJW9b6WD3sguEJTh/X1TDE1pf wgr91LtjDtwl43dh5/nLNE6t6cqDJTU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QQu1NO8S; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678830737; a=rsa-sha256; cv=none; b=oVcAl8IxtBA59f1YJ5L6qD89/AZtg6edxVNyr1r5jwPnFe33husmWiMN4KZ8VvhdExCw6H sNVthPwIGiTYNbuxCoLWv0OH3rrZWWnfPI3TVoELtzcHLQuaduwgoIMufGQsagVM5G+1Ti 4O2nhfgJlhvQ2yaYqZPdrVuoIm7TML0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678830736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KL7RUrUlJgDEAxq9GYJFCawiEJWge2p1Oaahbua9byM=; b=QQu1NO8Sbj6vR5itRaRL8AKiblmFHb0kkLAqP1auMC4MBHTVv+0I5zGlv4OEdQyhA5KT1g d23gESM5xS9VMKIGaNHNP1cIQXE0uxHoEU3k9PUmw/0AJ2tU6BLNWO0fQ144eQhzQkApvF JtJbwq5CjgUCkNJku46e339EC3bRb1A= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-uS-EDXNSN3qnzq1H8duDKw-1; Tue, 14 Mar 2023 17:52:11 -0400 X-MC-Unique: uS-EDXNSN3qnzq1H8duDKw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 76942385F36D; Tue, 14 Mar 2023 21:52:10 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21BD9C164E7; Tue, 14 Mar 2023 21:52:08 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230308165251.2078898-1-dhowells@redhat.com> <20230308165251.2078898-8-dhowells@redhat.com> To: Christoph Hellwig Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Steve French , Christoph Hellwig , John Hubbard , linux-cifs@vger.kernel.org Subject: Re: [PATCH v17 07/14] splice: Do splice read from a file without using ITER_PIPE MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3826684.1678830727.1@warthog.procyon.org.uk> Date: Tue, 14 Mar 2023 21:52:07 +0000 Message-ID: <3826685.1678830727@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 495971C000D X-Stat-Signature: 5i38awabt6yi565j9r5q1chfa6bz7ox8 X-HE-Tag: 1678830737-139266 X-HE-Meta: U2FsdGVkX1+M+xLQU3YNmSonjL7+XNT2v7G1vyZxGab0CcvX7FpB5LmmiWXKp3OiDhTBZejvlfpbm5XBgW1HVqXVphE8a7/W/uHhP8NvDPWuvIJZ/X07sJtgqaHmnWDIrbNrbFddDN9gEHS7LyysJkOjwe/4DNdwmChJrL3s5/xIQyWRBW9itWbb2hpb3ryF6PXxthcrvdgYAXlJTo4ttSTh18VvkHMZvCOIQ5JNm6CRJSaSTqoWUL4C7LRBjCBfRpdJ3hQpiBGBzX4Hc9tSe00ycYRKbbDk7vzs4rV8FpWIrmMid5he8l2fR+THSFKoFsrbHu4I9J+s8Wd4dgrp+GYursbSSuIUnc1pmiSQxgsAQE7T5ePTLI32G/ueu+g54+0QiWoH9JD/oMC/StwSCHoKQp89iOChDBk6aa/9CJk5m1R4NoGFGIOTfzOS7dWkb0jdcYnvIkXBIEjLvlJGU53TuBAoaQMSx70KiptME3U6qBTN5FF2CMX9ZZPraJCieL5Hf2wzv3J3rqX3qI3eWGPoeovzopwgT4gdNSvFpn+Eq0B24wwGWz/Y+Khfggbv1cHfxewQ7LYuj1lyO8H5L/HujO3LrsoW/9dxhqNVFfDrQHp3TUljttEqYtnsFmiJJOItuKnlN9ukE+ppEuvmS4EfyN9ONesnRhtwbmPGfwtg2lC6gfwIbvvzC1rdc/ApiXKFXxJ0KARpO0gr5bGDr/mKkJhNcILnVj9N98O8r6F5UH2A07Pe06lAdYvOetLm/KPvuNUUlzDQcXaTc0kbo5GT4LDj7kTsL9dcZDvFeCc1shQGXfTGGG6zph/O/GxhUHy02dOwdNzeaZc+x/9YlKXwtCbX67v6nyH5O7hHwAA7gxxkLyop59L2YuRdgcXfCjeIsPrzta6G20eQR8KgmOzD+VztMVgUvWORn+zFkX9BjbIW+3UDZIMH6BJ60b8K+a9hCGdjCYWHxH0nPxQ 8wOVGc3Q jobIkqN5TYggbncOL44lnLuZVycX2bVCnDRjjIwGvsH8deY9BAxxOjGzzcUYwZUoMV188wVsfi1c7zY6XbjvCFg2rmA/f8rz24AhpvwL6ntjBuR7rGkVOmiaMwdLS5hjqjnrxk67D0ys6Mtrip313VQI9J2fSMVfk4F50l6emGMr2dP4xAR0Jz/QP/uAeLWWt7QQe2h3RsiNyjokzq/ZC1FIXXjwEkuYcTJu2jVT5D1aEv+LDVxF3DMcaGCKi7QrFe3BELUPvWr0KUtLcGUIG5LOfeUYpxA7bR7n25vFd0ugmPVmZLMu6kdVqUVVXOuRbMtJ85Yd/cc6T2SMfFkG+wkbq6MF8JU4wOKcN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > > Make cifs use generic_file_splice_read() rather than doing it for itself. > > Please split the cifs patch out into a separate one. Okay - I've done that. It needs to go after this one and the unexport of filemap_splice_read() needs to go with it (or in a separate follow-up patch). David