From: Manfred Spraul <manfreds@colorfullife.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.rutgers.edu, linux-mm@kvack.org
Subject: Re: vma_list_sem
Date: Tue, 12 Oct 1999 21:46:33 +0200 [thread overview]
Message-ID: <38039019.1D8A1531@colorfullife.com> (raw)
In-Reply-To: <Pine.GSO.4.10.9910121353330.22333-100000@weyl.math.psu.edu>
Alexander Viro wrote:
> b) correct code should not be punished. Ever. ASSERT is wrong.
>
I'll remove the code from load_elf_binary() once I'm sure that the
down(mmap_sem) are really superflous. IIRC you agreed that
load_elf_library() needs the locking.
Possible problems for load_elf_binary():
* swap_out() could find that process. [seems safe]
* swap_out() could execute "kill_proc(pid, SIGBUS, 1)" [not yet
checked]
* what about sys_ptrace()? [looks dangerous]
I really don't like the idea that a structure which can be found via
linked lists has no proper locking. Obviously, locking would be
superflous if noone has access to the "struct mm" pointer, but the
pointer can be eg. found by find_task_by_pid()->mm.
> Some of missing pieces (modulo binfmt-related stuff):
I'll add them, thanks,
Manfred
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/
prev parent reply other threads:[~1999-10-12 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-10-12 17:50 vma_list_sem manfreds
1999-10-12 17:53 ` vma_list_sem Manfred Spraul
1999-10-12 18:48 ` vma_list_sem Alexander Viro
1999-10-12 19:46 ` Manfred Spraul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38039019.1D8A1531@colorfullife.com \
--to=manfreds@colorfullife.com \
--cc=linux-kernel@vger.rutgers.edu \
--cc=linux-mm@kvack.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox