From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C87FCC4345F for ; Sun, 28 Apr 2024 01:09:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0B1A6B007B; Sat, 27 Apr 2024 21:09:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E92886B0083; Sat, 27 Apr 2024 21:09:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D32C86B0085; Sat, 27 Apr 2024 21:09:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B3D746B007B for ; Sat, 27 Apr 2024 21:09:04 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2DFDB1C0CEC for ; Sun, 28 Apr 2024 01:09:04 +0000 (UTC) X-FDA: 82057156608.25.976557E Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf10.hostedemail.com (Postfix) with ESMTP id 2584EC000C for ; Sun, 28 Apr 2024 01:09:00 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714266542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fKfCCtz0FH46AklqUkwMzcTR8MwYcSxFEp4MEf7crKk=; b=quFqpp9/6komNQWF0bcJNEsFIaAX5AdPLB+r274ZDQGUfZYBPT66OKW69z7oStFDSGbwge EB7EWHljAY0AMgyBquebMyizp0wynmjtM3y54xRyQi6RoU8xQcsJkt7jZhTqsRTc7Qnd3A 7qCGPRAFubXG5PYD9Q5fbQNPnwCqxOM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714266542; a=rsa-sha256; cv=none; b=xA85xfhKhvc9iPisCqjPoid8H0Gwg7unEMN7OIlGt3eO0PL7buOw+4krT9u3o7jibnx//i Ydc1uc2ROEPe39o15P5Yso7ibfYJKyTQnfu7Nq4m5TpJhOtt8ZqZHFhWXrfKqM/vxerql3 bwzvmFXjtBey7RcRDi3TFd3yqCLEOsI= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VRpDZ447SzvPr0; Sun, 28 Apr 2024 09:05:50 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id F29FC1403D2; Sun, 28 Apr 2024 09:08:56 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 28 Apr 2024 09:08:56 +0800 Message-ID: <38017f5c-a74a-4d66-9092-efa79ffebfb9@huawei.com> Date: Sun, 28 Apr 2024 09:08:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: use memalloc_nofs_save() in page_cache_ra_order() Content-Language: en-US To: Matthew Wilcox , Andrew Morton CC: , , zhangyi References: <20240426112938.124740-1-wangkefeng.wang@huawei.com> <20240426114905.216e3d41b97f9a59be26999e@linux-foundation.org> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: 2584EC000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: mxrdfi9hy7jptkiwbgrtke4s98iac8te X-HE-Tag: 1714266540-911894 X-HE-Meta: U2FsdGVkX181xfqsWrGFwGZ6yBVgo9vru+WoMVO/YNoFB5Fr3Y2nedUh6B/v5/gVoN8UOfHW3xLGqtjSLyjHPJ21+eT84uTa8IPom+okbdJ1chulrTKy5uaLRZtFOo8SzDKCUExb7aaCHFqs5CUC6jsckeHq5cusa5zNAmvxbYxOPhtZnYrr8Zng1b0/1JtWxujyjZtlLsHhi+SCI5CMlp5PlhnWwsrbbwd7ZDIEN3Mo4Oa8LuUzQlXL1hXOnM+aMCYNVHDtNSBf0BobtPLBLpGNzZE5Fc9spFYcs3k2akQVqokl5mkq81OvHHq6dNxzew8ixqWEfowrbEkPMlI8FH/H8tDKmojBAKrN4gE0iavmMkQA/ubvbSC2oIOLh2C3m04nV4A/JXy1qkXqiUcoAHa43Rgbk4Hr9a1NlG4+6ylXrzjGKDWxhpuxV9GDnZOKPwAj+xcq2EeX1N2wbQ1UPJ5vIentU7+VbOiup/sRhXDzIPP6gIWTzIsEuiaeqSdDQQ1DoeQ11E2i7bGw9+ce56KEcl3sGWWnn5LXMB3M4mWmGq8HrdtIS6Hz+x4MKd4NjBWYeKtVdStuL1QtlZhTjKJv4hIFUg8vuQWlrUMSmEfQOtGmtBPf/iHdhVNZtcTKYVbt6sMZsyyq9mNHN8EchnjagYXacN6xm211dj7sgH2097U8rbWdwpIg+BNcqDie9xd8r6NEVNKnUT2XpjJUw2Tb7SNZ6lMmtd2YopLj83s4AX5hZob5IM5RT5WZ7Uademo78dzOPyHHQi1pSZXM1GQ0BZrjL/n1dtJzNNmhH+xsBqUyQ1YGyWSwZbbOZy8gJSDYyazVvfg+VIZtDm9qSylxeqCmJEWAekdwi+KfkcXaKQKxPT6hd1YRh2ysI+w7iT8xn5THa4w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/27 11:45, Matthew Wilcox wrote: > On Fri, Apr 26, 2024 at 11:49:05AM -0700, Andrew Morton wrote: >> On Fri, 26 Apr 2024 19:29:38 +0800 Kefeng Wang wrote: >>> io_schedule+0x24/0xa0 >>> __folio_lock+0x130/0x300 >>> migrate_pages_batch+0x378/0x918 >>> migrate_pages+0x350/0x700 >>> compact_zone+0x63c/0xb38 >>> compact_zone_order+0xc0/0x118 >>> try_to_compact_pages+0xb0/0x280 >>> __alloc_pages_direct_compact+0x98/0x248 >>> __alloc_pages+0x510/0x1110 >>> alloc_pages+0x9c/0x130 >>> folio_alloc+0x20/0x78 >>> filemap_alloc_folio+0x8c/0x1b0 >>> page_cache_ra_order+0x174/0x308 >>> ondemand_readahead+0x1c8/0x2b8 >> >> I'm thinking >> >> Fixes: 793917d997df ("mm/readahead: Add large folio readahead") >> Cc: stable > > I think it goes back earlier than that. > https://lore.kernel.org/linux-mm/20200128060304.GA6615@bombadil.infradead.org/ > details how it can happen with the old readpages code. It's just easier > to hit now. > The page_cache_ra_order() is introduced from 793917d997df, but previous bugfix f2c817bed58d ("mm: use memalloc_nofs_save in readahead path") don't Cc stable, so the previous patch should be posted to stable?