Re: [PATCH v6 3/6] mm/page_alloc: add support for initializing pageblock as isolated.

[Zi Yan <ziy@nvidia.com>]

On 30 May 2025, at 15:44, David Hildenbrand wrote:

> On 30.05.25 18:22, Zi Yan wrote:
>> MIGRATE_ISOLATE is a standalone bit, so a pageblock cannot be initialized
>> to just MIGRATE_ISOLATE. Add init_pageblock_migratetype() to enable
>> initialize a pageblock with a migratetype and isolated.
>>
>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
>> ---
>
> [...]
>
>>   	set_zone_contiguous(zone);
>>   }
>> @@ -1127,7 +1129,8 @@ int mhp_init_memmap_on_memory(unsigned long pfn, unsigned long nr_pages,
>>   	if (mhp_off_inaccessible)
>>   		page_init_poison(pfn_to_page(pfn), sizeof(struct page) * nr_pages);
>>  -	move_pfn_range_to_zone(zone, pfn, nr_pages, NULL, MIGRATE_UNMOVABLE);
>> +	move_pfn_range_to_zone(zone, pfn, nr_pages, NULL, MIGRATE_UNMOVABLE,
>> +			false);
>
> Nit: Likely indentation suboptimal?

Yep.
>
> Acked-by: David Hildenbrand <david@redhat.com>
Thanks.

Here is the fixup:

From 83e9b8e749481b9397b170075cb5280d0640b16d Mon Sep 17 00:00:00 2001
From: Zi Yan <ziy@nvidia.com>
Date: Fri, 30 May 2025 15:47:06 -0400
Subject: [PATCH] indentation fixup.

Signed-off-by: Zi Yan <ziy@nvidia.com>
---
 mm/memory_hotplug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 43ac34ee8d2e..16e3ad874144 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1130,7 +1130,7 @@ int mhp_init_memmap_on_memory(unsigned long pfn, unsigned long nr_pages,
 		page_init_poison(pfn_to_page(pfn), sizeof(struct page) * nr_pages);

 	move_pfn_range_to_zone(zone, pfn, nr_pages, NULL, MIGRATE_UNMOVABLE,
-			false);
+			       false);

 	for (i = 0; i < nr_pages; i++) {
 		struct page *page = pfn_to_page(pfn + i);
-- 
2.47.2