From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8FC5C3DA4A for ; Thu, 8 Aug 2024 22:30:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CE306B0089; Thu, 8 Aug 2024 18:30:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77D9F6B0092; Thu, 8 Aug 2024 18:30:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61E266B0095; Thu, 8 Aug 2024 18:30:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 457E16B0089 for ; Thu, 8 Aug 2024 18:30:10 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8EF0DC031F for ; Thu, 8 Aug 2024 22:30:09 +0000 (UTC) X-FDA: 82430522538.01.B064EF7 Received: from cmx-mtlrgo002.bell.net (mta-mtl-001.bell.net [209.71.208.11]) by imf12.hostedemail.com (Postfix) with ESMTP id 7516B40024 for ; Thu, 8 Aug 2024 22:30:07 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bell.net header.s=selector1 header.b=aH6Tq4i2; dmarc=pass (policy=none) header.from=bell.net; spf=pass (imf12.hostedemail.com: domain of dave.anglin@bell.net designates 209.71.208.11 as permitted sender) smtp.mailfrom=dave.anglin@bell.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723156198; a=rsa-sha256; cv=none; b=J7YmtDVG94LrbvsSYulR7ckPnmxBrUqqUGEl+8Um9yCljTy+91SGH6dS7jA8ftFHg6gP7V beimPMj8NmQ80WrWyJQGDNJhXX6x9AGaJg3ZxBk65v3030S0jJFDlDucQoAN9fYxaj6kLw M8AQILxgtIbektt4hHJok0KdOVYNXdE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=bell.net header.s=selector1 header.b=aH6Tq4i2; dmarc=pass (policy=none) header.from=bell.net; spf=pass (imf12.hostedemail.com: domain of dave.anglin@bell.net designates 209.71.208.11 as permitted sender) smtp.mailfrom=dave.anglin@bell.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723156198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LgxfzUZVpycHSaGHDE/lQUlboZeRrF+ub5S85Pnl0GA=; b=UErZ+pR/bl5Pj/F3VT4BY84wYdTt65S7hMgDzZ2WDVG+CUT0On60YJAUR3JGpBx5VwIsKq PGq3EU9D/uxTLxBiBaTR223IeU6uLKxjpCWx8K4rk3HI+qsBIbSC+DuiycILsgiK5jqXLn gHE4Hk8OcPyENWmT81nOQs7kRIs25JI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bell.net; s=selector1; t=1723156207; bh=LgxfzUZVpycHSaGHDE/lQUlboZeRrF+ub5S85Pnl0GA=; h=Message-ID:Date:MIME-Version:Subject:From:To:References:In-Reply-To:Content-Type; b=aH6Tq4i2Yn+k0280He2swKvFmn7AjMD8Xv1MtaGNko3k/8xeCSS0bV3N0x9Hz6qWOrEjaLydlMbGYoCiat8wuC1NwP0G/r/o7ZzL3vJ7AyVi3Y3v3A7Z+j/B5JqeyYgksFeDb88wgy8lP87zrN8H9YwpPstyirvedIsUJodMKXXWYLkYZFB3ScpJ3yILrCJFNLuKEMx/QRLt1Ta85Mv8tCQpnOcbTI8RASgRYvXWoteyaVAihntmpTYKsYu9TGKqDJUAVg3ef2rK851bXPR/P8QLx94GFuFYYaXUFU2z3vsSAhP2wX0JkIQri4J3P+kSsRLC+eaOPLASCeo9lWScYg== X-RG-SOPHOS: Clean X-RG-VADE-SC: 0 X-RG-VADE: Clean X-Originating-IP: [76.71.115.75] X-RG-Env-Sender: dave.anglin@bell.net X-RG-Rigid: 6698E80E02170004 X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeeftddrleefgddtlecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceugffnnfdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffhvfevfhgjtgfgsehtkeertddtvdejnecuhfhrohhmpeflohhhnhcuffgrvhhiugcutehnghhlihhnuceouggrvhgvrdgrnhhglhhinhessggvlhhlrdhnvghtqeenucggtffrrghtthgvrhhnpedtkeeihfeivdevgeefuefgfeffiedvgeetieffuefgfefhfffgieehfeeugfehhfenucffohhmrghinhepvghnthhrhidrshgsnecukfhppeejiedrjedurdduudehrdejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedrvddrgeelngdpihhnvghtpeejiedrjedurdduudehrdejhedpmhgrihhlfhhrohhmpegurghvvgdrrghnghhlihhnsegsvghllhdrnhgvthdpnhgspghrtghpthhtohepuddtpdhrtghpthhtohepuggrvhgvrdgrnhhglhhinhessggvlhhlrdhnvghtpdhrtghpthhtohepuggvlhhlvghrsehgmhigrdguvgdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhmmheskhhvrggtkhdrohhrghdprhgtphhtthhopehlihhnuhigqdhprghrihhstgesvhhgvghrrdhkvghrnhgvlhdr ohhrghdp rhgtphhtthhopehlihhnuhigsehrohgvtghkqdhushdrnhgvthdprhgtphhtthhopehrihgthhgrrhgurdhhvghnuggvrhhsohhnsehlihhnrghrohdrohhrghdprhgtphhtthhopehtghhlgieslhhinhhuthhrohhnihigrdguvg X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.2.49] (76.71.115.75) by cmx-mtlrgo002.bell.net (authenticated as dave.anglin@bell.net) id 6698E80E02170004; Thu, 8 Aug 2024 18:29:47 -0400 Message-ID: <37f94771-4ebc-46d2-ad10-f145d139dd9d@bell.net> Date: Thu, 8 Aug 2024 18:29:47 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6.10 000/809] 6.10.3-rc3 review From: John David Anglin To: Guenter Roeck , Linus Torvalds , Thomas Gleixner Cc: Vlastimil Babka , linux-kernel@vger.kernel.org, Linux-MM , Helge Deller , linux-parisc@vger.kernel.org, Richard Henderson References: <20240731095022.970699670@linuxfoundation.org> <718b8afe-222f-4b3a-96d3-93af0e4ceff1@roeck-us.net> <53b2e1f2-4291-48e5-a668-7cf57d900ecd@suse.cz> <87le194kuq.ffs@tglx> <90e02d99-37a2-437e-ad42-44b80c4e94f6@suse.cz> <87frrh44mf.ffs@tglx> <76c643ee-17d6-463b-8ee1-4e30b0133671@roeck-us.net> <87plqjz6aa.ffs@tglx> <87a5hnyox6.ffs@tglx> <8734nezz0g.ffs@tglx> Content-Language: en-US Autocrypt: addr=dave.anglin@bell.net; keydata= xsFNBFJfN1MBEACxBrfJ+5RdCO+UQOUARQLSsnVewkvmNlJRgykqJkkI5BjO2hhScE+MHoTK MoAeKwoLfBwltwoohH5RKxDSAIWajTY5BtkJBT23y0hm37fN2JXHGS4PwwgHTSz63cu5N1MK n8DZ3xbXFmqKtyaWRwdA40dy11UfI4xzX/qWR3llW5lp6ERdsDDGHm5u/xwXdjrAilPDk/av d9WmA4s7TvM/DY3/GCJyNp0aJPcLShU2+1JgBxC6NO6oImVwW07Ico89ETcyaQtlXuGeXYTK UoKdEHQsRf669vwcV5XbmQ6qhur7QYTlOOIdDT+8zmBSlqBLLe09soATDciJnyyXDO1Nf/hZ gcI3lFX86i8Fm7lQvp2oM5tLsODZUTWVT1qAFkHCOJknVwqRZ8MfOvaTE7L9hzQ9QKgIKrSE FRgf+gs1t1vQMRHkIxVWb730C0TGiMGNn2oRUV5O5QEdb/tnH0Te1l+hX540adKZ8/CWzzW9 vcx+qD9IWLRyZMsM9JnmAIvYv06+YIcdpbRYOngWPd2BqvktzIs9mC4n9oU6WmUhBIaGOGnt t/49bTRtJznqm/lgqxtE2NliJN79dbZJuJWe5HkjVa7mP4xtsG59Rh2hat9ByUfROOfoZ0dS sVHF/N6NLWcf44trK9HZdT/wUeftEWtMV9WqxIwsA4cgSHFR2QARAQABzTdKb2huIERhdmlk IEFuZ2xpbiAoRGViaWFuIFBvcnRzKSA8ZGF2ZS5hbmdsaW5AYmVsbC5uZXQ+wsF3BBMBCAAh BQJSXzdTAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJEF2/za5fGU3xs/4P/15sNizR ukZLNYoeGAd6keRtNcEcVGEpRgzc/WYlXCRTEjRknMvmCu9z13z8qB9Y9N4JrPdp+NQj5HEs ODPI+1w1Mjj9R2VZ1v7suFwhjxMTUQUjCsgna1H+zW/UFsrL5ERX2G3aUKlVdYmSWapeGeFL xSMPzawPEDsbWzBzYLSHUOZexMAxoJYWnpN9JceEcGvK1SU2AaGkhomFoPfEf7Ql1u3Pgzie ClWEr2QHl+Ku1xW0qx5OLKHxntaQiu30wKHBcsF0Zx2uVGYoINJl/syazfZyKTdbmJnEYyNa Bdbn7B8jIkVCShLOWJ8AQGX/XiOoL/oE9pSZ60+MBO9qd18TGYByj0X2PvH+OyQGul5zYM7Q 7lT97PEzh8xnib49zJVVrKDdJds/rxFwkcHdeppRkxJH0+4T0GnU2IZsEkvpRQNJAEDmEE8n uRfssr7RudZQQwaBugUGaoouVyFxzCxdpSYL6zWHA51VojvJYEBQDuFNlUCqet9LtNlLKx2z CAKmUPTaDwPcS3uOywOW7WZrAGva1kz9lzxZ+GAwgh38HAFqQT8DQvW8jnBBG4m4q7lbaum3 znERv7kcfKWoWS7fzxLNTIitrbpYA3E7Zl9D2pDV3v55ZQcO/M35K9teRo6glrtFDU/HXM+r ABbh8u9UnADbPmJr9nb7J0tZUSS/zsFNBFJfN1MBEADBzhVn4XyGkPAaFbLPcMUfwcIgvvPF UsLi9Q53H/F00cf7BkMY40gLEXvsvdUjAFyfas6z89gzVoTUx3HXkJTIDTiPuUc1TOdUpGYP hlftgU+UqW5O8MMvKM8gx5qn64DU0UFcS+7/CQrKOJmzktr/72g98nVznf5VGysa44cgYeoA v1HuEoqGO9taA3Io1KcGrzr9cAZtlpwj/tcUJlc6H5mqPHn2EdWYmJeGvNnFtxd0qJDmxp5e YVe4HFNjUwsb3oJekIUopDksAP41RRV0FM/2XaPatkNlTZR2krIVq2YNr0dMU8MbMPxGHnI9 b0GUI+T/EZYeFsbx3eRqjv1rnNg2A6kPRQpn8dN3BKhTR5CA7E/cs+4kTmV76aHpW8m/NmTc t7KNrkMKfi+luhU2P/sKh7Xqfbcs7txOWB2V4/sbco00PPxWr20JCA5hYidaKGyQxuXdPUlQ Qja4WJFnAtBhh3Oajgwhbvd6S79tz1acjNXZ89b8IN7yDm9sQ+4LhWoUQhB5EEUUUVQTrzYS yTGN1YTTO5IUU5UJHb5WGMnSPLLArASctOE01/FYnnOGeU+GFIeQp91p+Jhd07hUr6KWYeJY OgEmu+K8SyjfggCWdo8aGy0H3Yr0YzaHeK2HrfC3eZcUuo+yDW3tnrNwM1rd1i3F3+zJK18q GnBxEQARAQABwsFfBBgBCAAJBQJSXzdTAhsMAAoJEF2/za5fGU3xNDQP/ikzh1NK/UBrWtpN yXLbype4k5/zyQd9FIBxAOYEOogfKdkp+Yc66qNf36gO6vsokxsDXU9me1n8tFoB/DCdzKbQ /RjKQRMNNR4fT2Q9XV6GZYSL/P2A1wzDW06tEI+u+1dV40ciQULQ3ZH4idBW3LdN+nloQf/C qoYkOf4WoLyhSzW7xdNPZqiJCAdcz9djN79FOz8US+waBCJrL6q5dFSvvsYj6PoPJkCgXhiJ hI91/ERMuK9oA1oaBxCvuObBPiFlBDNXZCwmUk6qzLDjfZ3wdiZCxc5g7d2e2taBZw/MsKFc k+m6bN5+Hi1lkmZEP0L4MD6zcPuOjHmYYzX4XfQ61lQ8c4ztXp5cKkrvaMuN/bD57HJ6Y73Q Y+wVxs9x7srl4iRnbulCeiSOAqHmwBAoWaolthqe7EYL4d2+CjPCcfIuK7ezsEm8c3o3EqC4 /UpL1nTi0rknRTGc0VmPef+IqQUj33GGj5JRzVJZPnYyCx8sCb35Lhs6X8ggpsafUkuKrH76 XV2KRzaE359RgbM3pNEViXp3NclPYmeu+XI8Ls/y6tSq5e/o/egktdyJj+xvAj9ZS18b10Jp e67qK8wZC/+N7LGON05VcLrdZ+FXuEEojJWbabF6rJGN5X/UlH5OowVFEMhD9s31tciAvBwy T70V9SSrl2hiw38vRzsl In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 7516B40024 X-Rspamd-Server: rspam01 X-Stat-Signature: 9w71c8d5uxeowq19tch1n338n7966wyr X-HE-Tag: 1723156207-735680 X-HE-Meta: U2FsdGVkX1/emtcdj3zOBrhakOnJXk2yBZUaBDhtU7JD/Gzp2XPMkNhA9hxbiDFmnRhrxNhD9coLv1Sv/YK7lnvVrSL1WEoqdUaPUPTeNfD50bCwPdgycbVLHNx53TYKUI19kMHeFADA1fsZE6Zat4IXacIIOY686AM0sfogNJTEy6CX76RTqRLqdR6AH2wDXFv6lhyqgfYAX4w7kKP5aj6dbz/NSL4y7UhapsFYKpeyTUchvg5jR9Ez2G2RUurSMdo7eHWfNki7diw/ZntDa4WnBzw9LDVZ8Po9Y1MezkZ5KgOUhnEpJNX/NNrGokA7TKERMggSjvKuPxRUjkWCTSMYA/ZNnKuoLKiF5GbA48ofteYmmSZJdkUYlBMaHQOlxtbCcIgGKCPacJBo3uN0FiIcYimA+/MCGNdOk3C+itusdesiqqrPZWEzQk23fYyoo7TTs90W/sbVK2ijTgZoxnj93494G++AlXmzo4+bSS/5fuienjf9VARIgsl4QyRHRrYolhnCTqqXTSmTHv4o+Tu2bBKo6i4iKT4nFYWdtXuks2wIY4lsfWrT0CVlDf1KwoDco7+oseLLkXPiywRLri529xx1FNv1KTbBfV+ieUUQhd4z00TmJuaOM9tnTLbxBWp4artcPKAXG7S/hLNO0CPAhClVxHYCvdnozeGcLhZJU5i8YIvjFx8H6brfHwxCFDeAYKzbnWLxoc9tJfRxwal7RRNc4lsvxupS9H3NLpteuXz+pF360z9E5c7a/0AQhblwuzkrYiwuedCDzEhazsmaLb/sv95Qs9GdoneSTSynwrFg48ZzwyHHeX1z4i+AlH5vWspM9IQTzoiF/T9FB4wzdgXg/+i0S+1z3fuwe/8PGUBJ8AGBvYdZ9zNqTyRP5T5rMM9qoiHWsZCTsznr0jyIWBmShA0R9GSNPgv+xncsrefGeooe9QMblkf2tt2T2xfyeISOpxXrvXmyQbK ml+jf0gI UzaChK4j1kKWnCCf1kaAWyxK8XeGGQz6a4hjxm+tLmzvuUdkbUt4FRwrQ0LGuPEeJXy0sxWxlrw3hrT3wKPKNvryRL8aHa1k0lSDQ8AP4567YOU9r5gM0hwdUBRkscB1cbtBWOjFbm6i/RcY1Q77lrPQMP7IDbtkK5YlPIjIH0JpdYwUTGNn6+VoDo4XbDt17LLO1PO5ZR6xkiIc6x3fY/Q3vSZH2EBjjSw5lMl0xE7H8SouudWKs3yr9TLjl3tctd+IoglgTdouUICZ6JT67cL2RbUtAfkiMIeZWJMVnbqihvqkMNz+kpfCj/PQAdEWyw+lRXzfkdUUUEgoYp6xZoIOk0AeVvMpiOgJu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-08-08 5:50 p.m., John David Anglin wrote: > The mode likely problem is the shladd instruction in the following macro in entry.S: > >         .macro          L2_ptep pmd,pte,index,va,fault > #if CONFIG_PGTABLE_LEVELS == 3 >         extru_safe      \va,31-ASM_PMD_SHIFT,ASM_BITS_PER_PMD,\index > #else >         extru_safe \va,31-ASM_PGDIR_SHIFT,ASM_BITS_PER_PGD,\index > #endif >         dep             %r0,31,PAGE_SHIFT,\pmd  /* clear offset */ > #if CONFIG_PGTABLE_LEVELS < 3 >         copy            %r0,\pte > #endif >         ldw,s           \index(\pmd),\pmd >         bb,>=,n         \pmd,_PxD_PRESENT_BIT,\fault >         dep             %r0,31,PxD_FLAG_SHIFT,\pmd /* clear flags */ >         SHLREG          \pmd,PxD_VALUE_SHIFT,\pmd >         extru_safe      \va,31-PAGE_SHIFT,ASM_BITS_PER_PTE,\index >         dep             %r0,31,PAGE_SHIFT,\pmd  /* clear offset */ >         shladd          \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */ >         .endm > > I believe the shladd instruction should be changed to shladd,l (shift left and add logical). diff --git a/arch/parisc/kernel/entry.S b/arch/parisc/kernel/entry.S index ab23e61a6f01..1ec60406f841 100644 --- a/arch/parisc/kernel/entry.S +++ b/arch/parisc/kernel/entry.S @@ -399,7 +399,7 @@      SHLREG        \pmd,PxD_VALUE_SHIFT,\pmd      extru_safe    \va,31-PAGE_SHIFT,ASM_BITS_PER_PTE,\index      dep        %r0,31,PAGE_SHIFT,\pmd  /* clear offset */ -    shladd        \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */ +    shladd,l    \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */      .endm      /* Look up PTE in a 3-Level scheme. */ Boots okay.  Fixing the addi instruction is harder and it would take some time to test. Dave -- John David Anglin dave.anglin@bell.net