From: David Hildenbrand <david@redhat.com>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, willy@infradead.org,
sfr@canb.auug.org.au
Subject: Re: [PATCH v4 00/15] Fast kernel headers: split linux/mm.h
Date: Tue, 12 Mar 2024 17:32:37 +0100 [thread overview]
Message-ID: <37ed1ddd-f1d0-4582-b6c5-2f4091dc8335@redhat.com> (raw)
In-Reply-To: <CAKPOu+8AQ8g_bEOBRoLiiO6eYBGj09YiUx=U0QPnB0Csifa6xw@mail.gmail.com>
On 12.03.24 17:27, Max Kellermann wrote:
> On Tue, Mar 12, 2024 at 5:10 PM David Hildenbrand <david@redhat.com> wrote:
>>> include/linux/mm.h | 583 +-----------------
>>> include/linux/mm/devmap_managed.h | 37 ++
>>> include/linux/mm/folio_next.h | 27 +
>>
>> Isn't that a bit excessive? Do we really need that many folio headers?
>
> It would technically be possible to have fewer headers by merging
> several of those headers back into one, but then the dependencies will
> be heavier, and eventually we'd be back at the large "mm.h" mess that
> I would like to get rid of.
Just curious: why? Usually build time, do you have some numbers?
> My patch set constitutes the balance of "not too many headers" vs
> "small set of unnecessary dependencies for each including source file"
> according to my taste.
I'm not against splitting out stuff. But one function per header is a
bit excessive IMHO. Ideally, we'd have some MM guideline that we'll be
able to follow in the future. So we don't need "personal taste".
For example, if I were to write a folio_prev(), should I put it in
include/linux/mm/folio_prev.h ? Likely we'd put it into folio_next.h,
but then the name doesn't make any sense.
The point I am trying to make: if there was a single folio_ops.h, it
would be clearer where it would go.
Just my 2 cents, seeing one-function-per-file headers.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-03-12 16:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 9:41 Max Kellermann
2024-03-12 9:41 ` [PATCH v4 01/15] drivers: add missing includes on linux/mm.h (and others) Max Kellermann
2024-03-12 9:41 ` [PATCH v4 02/15] include/drm/drm_gem.h: add poll_table_struct forward declaration Max Kellermann
2024-03-12 9:41 ` [PATCH v4 03/15] include/scsi/scsicam.h: forward-declare struct block_device Max Kellermann
2024-03-12 9:41 ` [PATCH v4 04/15] linux/mm.h: move page_kasan_tag() to mm/page_kasan_tag.h Max Kellermann
2024-03-12 9:41 ` [PATCH v4 05/15] linux/mm.h: move section functions to mm/page_section.h Max Kellermann
2024-03-12 9:41 ` [PATCH v4 06/15] linux/mm.h: move page_address() and others to mm/page_address.h Max Kellermann
2024-03-12 9:41 ` [PATCH v4 07/15] linux/mm.h: move folio_size(), ... to mm/folio_size.h Max Kellermann
2024-03-12 9:41 ` [PATCH v4 08/15] linux/mm.h: move folio_next() to mm/folio_next.h Max Kellermann
2024-03-12 9:41 ` [PATCH v4 09/15] linux/mm.h: move devmap-related declarations to mm/devmap_managed.h Max Kellermann
2024-03-12 9:41 ` [PATCH v4 10/15] linux/mm.h: move usage count functions to mm/folio_usage.h Max Kellermann
2024-03-12 9:41 ` [PATCH v4 11/15] linux/mm.h: move page_zone_id() and more to mm/folio_zone.h Max Kellermann
2024-03-12 9:41 ` [PATCH v4 12/15] linux/mm.h: move pfmemalloc-related functions to pfmemalloc.h Max Kellermann
2024-03-12 9:41 ` [PATCH v4 13/15] linux/mm.h: move is_vmalloc_addr() to mm/vmalloc_addr.h Max Kellermann
2024-03-12 9:41 ` [PATCH v4 14/15] linux/mm.h: move high_memory to mm/high_memory.h Max Kellermann
2024-03-12 9:41 ` [PATCH v4 15/15] include: reduce dependencies on linux/mm.h Max Kellermann
2024-03-12 16:10 ` [PATCH v4 00/15] Fast kernel headers: split linux/mm.h David Hildenbrand
2024-03-12 16:27 ` Max Kellermann
2024-03-12 16:32 ` David Hildenbrand [this message]
2024-03-12 18:11 ` Max Kellermann
2024-03-12 19:26 ` David Hildenbrand
2024-03-12 19:50 ` Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ed1ddd-f1d0-4582-b6c5-2f4091dc8335@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=max.kellermann@ionos.com \
--cc=sfr@canb.auug.org.au \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox