From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92BACC433DF for ; Sun, 19 Jul 2020 23:22:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 50916208DB for ; Sun, 19 Jul 2020 23:22:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50916208DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i-love.sakura.ne.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9BFC66B0003; Sun, 19 Jul 2020 19:22:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94A976B0005; Sun, 19 Jul 2020 19:22:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 812A86B0006; Sun, 19 Jul 2020 19:22:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 6BB366B0003 for ; Sun, 19 Jul 2020 19:22:42 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A66E5DC2E9 for ; Sun, 19 Jul 2020 23:22:41 +0000 (UTC) X-FDA: 77056402122.29.army97_0e14d4c26f20 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 9A155183B04DB for ; Sun, 19 Jul 2020 23:20:59 +0000 (UTC) X-HE-Tag: army97_0e14d4c26f20 X-Filterd-Recvd-Size: 2420 Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Jul 2020 23:20:58 +0000 (UTC) Received: from fsav106.sakura.ne.jp (fsav106.sakura.ne.jp [27.133.134.233]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 06JNKkag085014; Mon, 20 Jul 2020 08:20:46 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav106.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav106.sakura.ne.jp); Mon, 20 Jul 2020 08:20:46 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav106.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 06JNKjCo085003 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 20 Jul 2020 08:20:46 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: [PATCH] mm, oom: show process exiting information in __oom_kill_process() To: Yafang Shao Cc: rientjes@google.com, mhocko@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org References: <1595166795-27587-1-git-send-email-laoar.shao@gmail.com> From: Tetsuo Handa Message-ID: <37e3cb3d-67fc-d680-6b70-6c71b2a0f144@i-love.sakura.ne.jp> Date: Mon, 20 Jul 2020 08:20:40 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1595166795-27587-1-git-send-email-laoar.shao@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9A155183B04DB X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000824, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020/07/19 22:53, Yafang Shao wrote: > p = find_lock_task_mm(victim); > if (!p) { > + pr_info("Process %d (%s) is already exiting\n", > + task_pid_nr(victim), victim->comm); Maybe + pr_info("%s: Process %d (%s) is already exiting\n", + message, task_pid_nr(victim), victim->comm); line is easier to compare with pr_err("%s: Killed process %d (%s) total-vm:%lukB, anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB, UID:%u pgtables:%lukB oom_score_adj:%hd\n", message, task_pid_nr(victim), victim->comm, K(mm->total_vm), line? > put_task_struct(victim); > return;