From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BA88C433DF for ; Thu, 27 Aug 2020 12:09:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1AB16207F7 for ; Thu, 27 Aug 2020 12:09:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AB16207F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B25F58E0018; Thu, 27 Aug 2020 08:09:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD4308E0006; Thu, 27 Aug 2020 08:09:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99BF78E0018; Thu, 27 Aug 2020 08:09:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id 7D2C28E0006 for ; Thu, 27 Aug 2020 08:09:34 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 29EE5180AD81A for ; Thu, 27 Aug 2020 12:09:34 +0000 (UTC) X-FDA: 77196229068.24.match88_2e14d7b2706d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 260561A4B9 for ; Thu, 27 Aug 2020 12:09:29 +0000 (UTC) X-HE-Tag: match88_2e14d7b2706d X-Filterd-Recvd-Size: 3403 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 12:09:28 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B53F131B; Thu, 27 Aug 2020 05:09:27 -0700 (PDT) Received: from [192.168.1.190] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A751E3F68F; Thu, 27 Aug 2020 05:09:24 -0700 (PDT) Subject: Re: [PATCH 32/35] kasan, arm64: print report from tag fault handler To: Catalin Marinas , Andrey Konovalov Cc: Dmitry Vyukov , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <4691d6019ef00c11007787f5190841b47ba576c4.1597425745.git.andreyknvl@google.com> <20200827104816.GI29264@gaia> From: Vincenzo Frascino Message-ID: <37de7524-b042-831f-6e43-30adf85c83a8@arm.com> Date: Thu, 27 Aug 2020 13:11:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200827104816.GI29264@gaia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 260561A4B9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/27/20 11:48 AM, Catalin Marinas wrote: > On Fri, Aug 14, 2020 at 07:27:14PM +0200, Andrey Konovalov wrote: >> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c >> index c62c8ba85c0e..cf00b3942564 100644 >> --- a/arch/arm64/mm/fault.c >> +++ b/arch/arm64/mm/fault.c >> @@ -14,6 +14,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -314,11 +315,19 @@ static void report_tag_fault(unsigned long addr, unsigned int esr, >> { >> bool is_write = ((esr & ESR_ELx_WNR) >> ESR_ELx_WNR_SHIFT) != 0; >> >> +#ifdef CONFIG_KASAN_HW_TAGS >> + /* >> + * SAS bits aren't set for all faults reported in EL1, so we can't >> + * find out access size. >> + */ >> + kasan_report(addr, 0, is_write, regs->pc); >> +#else >> pr_alert("Memory Tagging Extension Fault in %pS\n", (void *)regs->pc); >> pr_alert(" %s at address %lx\n", is_write ? "Write" : "Read", addr); >> pr_alert(" Pointer tag: [%02x], memory tag: [%02x]\n", >> mte_get_ptr_tag(addr), >> mte_get_mem_tag((void *)addr)); >> +#endif >> } > > More dead code. So what's the point of keeping the pr_alert() introduced > earlier? CONFIG_KASAN_HW_TAGS is always on for in-kernel MTE. If MTE is > disabled, this function isn't called anyway. > I agree we should remove them (togheter with '#ifdef CONFIG_KASAN_HW_TAGS') or integrate them with the kasan code if still meaningful. -- Regards, Vincenzo