From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E85AC74A5B for ; Thu, 30 Mar 2023 04:55:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B85AA6B0072; Thu, 30 Mar 2023 00:55:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B35B76B0074; Thu, 30 Mar 2023 00:55:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D4486B0075; Thu, 30 Mar 2023 00:55:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 891E66B0072 for ; Thu, 30 Mar 2023 00:55:38 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 52114A07A9 for ; Thu, 30 Mar 2023 04:55:38 +0000 (UTC) X-FDA: 80624351556.01.759B7E0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 1F80D1A0004 for ; Thu, 30 Mar 2023 04:55:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JIBtfm8n; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680152136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SfE1DWU3+82lgaUycDeR1l3BXeg5cIyOiSyAYjqLz10=; b=hrOdDzEO2uYDsm6NZzuDC0KvaKwtggF+aV8uyeRccATHHAIq6kAjPwtnehoCpxRv3CTWbq BqIM3tYfLNI5jZlZ2N+xvknz0ypbOtoWPWif/7+slFGyt4dzheAdB3ax4Wf52t1f2TmYcT FQa4MDFYeUKl/BO0F8kvGaPD4qfQ1as= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JIBtfm8n; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680152136; a=rsa-sha256; cv=none; b=VoOHXGqb6wBtX/UXVM5/w2mL6D8RuPvhywmod9hDeUC97hTccCY+aL8eec0fSVjmAKxyDK Bah6kGwpl9WoqeIsX1glBadA+oQnSnvyJj02jo3XanvyHBkNYxJiC8m5g38gSVrfuy3KQU 8Ov6bP9O4hQQAIs+R5P4dz+BHUpT2Bs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680152135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SfE1DWU3+82lgaUycDeR1l3BXeg5cIyOiSyAYjqLz10=; b=JIBtfm8nfjhEAtyVdJBsUdOUVE1f3lkKQ8Ru2jz0y+j7p0LaVcZodkBs2oE7oATBtAh3lw +rl0JPdGIcOZF319ahl7RZEJ91gwNVFxaczBFQB7GFHDKK59vzsvqsSUB806IX4QzIBEJh ueqRNsX8tTi/oYN7tAwY246yMdzLUSk= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-YJbd78G1Nui6SnXM3kPaDg-1; Thu, 30 Mar 2023 00:55:33 -0400 X-MC-Unique: YJbd78G1Nui6SnXM3kPaDg-1 Received: by mail-pl1-f198.google.com with SMTP id n13-20020a170902d2cd00b001a22d27406bso8861093plc.13 for ; Wed, 29 Mar 2023 21:55:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680152133; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SfE1DWU3+82lgaUycDeR1l3BXeg5cIyOiSyAYjqLz10=; b=nnBcxSQpU+NthODrZmQuN77NXopztYsYK2oMdNDSAxhhy5LxkslXMcJFaGiYivysDz We/mXtl/R2fw4vAYV7Ru+xMbKnvCa+xOCQzpYojh4LpYXo5g1+Mig0kXJA1iAEfGP69R E51+L420Md+80Tqxp3vTh5RrjySQhhwH9C1FjOWRZX2pCBULPRbUoHVeszkFNQkUzw37 xRufCn1Z5mIpzzsQSoVIxndrRpehdfRrufpTxe/Xd5Jxw5Av4CmPecnxuD7FngmWDOn2 dLFfNZIP0bP87ELyg0bMYkcs3Ntt/WZIrj9FOO+WetfesniFmeu6z1xXHx6IhL2+HjS9 a1mQ== X-Gm-Message-State: AAQBX9e1tB8oZCovCTcERbUFT8zBjYud5y3CsjY4tGrUcraiBcZnOgy3 NRXhlKusm73/gAmPpj3XJ6WTd2by01oVxU8KOYouoYH7ve66UAIUdwhXdxxMi5OhEmM5JkFNwXh /RZiyNFkmXI8= X-Received: by 2002:a17:90a:3:b0:23d:3931:7b49 with SMTP id 3-20020a17090a000300b0023d39317b49mr22164449pja.35.1680152132757; Wed, 29 Mar 2023 21:55:32 -0700 (PDT) X-Google-Smtp-Source: AKy350ahVfgTHtRLxkoOOQlT2RCr2YXsazoiymyRXgQ9yO6J9Xq64hWqpppKwwPGxAW3vPkD+5AjgA== X-Received: by 2002:a17:90a:3:b0:23d:3931:7b49 with SMTP id 3-20020a17090a000300b0023d39317b49mr22164429pja.35.1680152132358; Wed, 29 Mar 2023 21:55:32 -0700 (PDT) Received: from [192.168.35.160] ([64.114.255.114]) by smtp.gmail.com with ESMTPSA id d4-20020a17090ac24400b00240ab3c5f66sm2325330pjx.29.2023.03.29.21.55.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Mar 2023 21:55:31 -0700 (PDT) Message-ID: <37dcd52a-2e32-c01d-b805-45d862721fbc@redhat.com> Date: Thu, 30 Mar 2023 06:55:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Andrew Morton , Stefan Roesch Cc: kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, hannes@cmpxchg.org, Hugh Dickins References: <20230310182851.2579138-1-shr@devkernel.io> <20230328160914.5b6b66e4a5ad39e41fd63710@linux-foundation.org> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v4 0/3] mm: process/cgroup ksm support In-Reply-To: <20230328160914.5b6b66e4a5ad39e41fd63710@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1F80D1A0004 X-Stat-Signature: 6puxxr9kr3xbibyftnq3zoqy6bj7w1ui X-HE-Tag: 1680152135-534212 X-HE-Meta: U2FsdGVkX19uiNmT2kkw7loO8v8cItnHsRa+JqnBcUEN2KVkfUMWt1K+Z+PqFGjWebMJ03OvlVZP9ThjyCH2iFqbXMAspmTWYB6gw5HsPtr9Usd6z3KMYZ+j5VJB8k+qSTzugxl2NuZzDNy5dS5me+xOWmPAQtFlZadD6KAPrgr4gr1LwdMni7tRymbnWN4IS7ohLBYKoJLiuKi+BIlo+opdNdmnWctHVGUcpx9B4DgWi0JGccczMq+/yJhpveXABLHPCnNBP4lDgM+dz5kjZ2X3Go3zOoYmATxbPeKsDiE//3ZWF9a+St42k8XoLlhednQnrlI3qdwEILwoTsVOC5BGkclPdrRA71YezTNavWGxavSpM3qULriDYXpSJdu6GihzogaSF3O+UId0EHV2/h5K/0bW8uyq1P67s/FVM0ODEGDhlpo4MEiJTj8gFK6Qs/Z4C7YWwmSrUjnXn2Ounm+oGbKrn6kkXj84R4GYMz5qwxuzktJzZUfguJp/U/vSb6msKjee65na//u3iylVMTNWkGhkkMTvzVH1krUZlJ2AGhKyNoGckN1exD6KAaKeNzzKKatJC3MOJi9oQxKtDpqIADGvSonS6DjBZhJGkjw2YwEPOk2P4BezLKQwjdYEO7KvbH5NOwspXbngGvBSJeWhIIitWtEOtUvVXJVjBZ1egbTdcp3exOATLc5+ISFoI6ISe000wtfFOMCzZkWulUH5sb2PtmfQm9fvVeX2xD0mn8YRBuJDBcyP41om4lD0hjAZn7t3g0rNHm3Mw3iJfKtDIm3HoeyQieEqPEI74ul09F3FmQv3U0MS6fpQKMgrO7bL6WKs9GOjkEg5GcYYaUGaKnfQAb3MRvGwIuUZJ1u55VD01TbEf3AWiAC8ynxAJFT015RLktTJ0+5ELkBG8j/Gk3Sf9q0nCdNSfRlMWX5Nv2hL2AIgFd+XbFpLOty9CCiTHLeh7uCtY+WDL8E qNj+6soQ 45qMedlMCFeK+5RiuJSRtI/HYP6qRBd3++GPPp338u6F+8EGAzyTYu2+Ig804O67+Z0N7sUXHLBpslAab1mbWOhnVyf40vkiPsXO7c+BHWg2cvxqBHzs9T1er+AC2PBQHZBsS3wIrLPmwUKWiMBO1OmphOorPHUUhURW5DFKYWWI+ezVrDbALxEB2dCJFFEFOmmLG4R0og6qXTNaSVZ+7Tv8HFi3wmpI9FxGw6xwcHN+JAa8aujp+DWh+TgHXBRj63rbgIv39tYCAjII+A3gmq1YU9xrv0tX+jSpBMtbWz4OevzIvrXJVkyZ+lKxNTczS2TSV0vqqmU3ZxFORGRFoFFZtQRjI/GJehv2p176Lnl1/YYck2BVLrxS8Y3GY2M4DuktOnAC0/BjmPANcH+br7nhOTQuUXF+hpjwLqu+lLnZjFtyElKI7znZH25qZme4XleoicpRArSR5Mseqk50pC0iVSmXBprJbMFGoVfu8HLR6/Jv7BlZ6XR7aAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.03.23 01:09, Andrew Morton wrote: > On Fri, 10 Mar 2023 10:28:48 -0800 Stefan Roesch wrote: > >> So far KSM can only be enabled by calling madvise for memory regions. To >> be able to use KSM for more workloads, KSM needs to have the ability to be >> enabled / disabled at the process / cgroup level. > > Review on this series has been a bit thin. Are we OK with moving this > into mm-stable for the next merge window? I still want to review (traveling this week), but I also don't want to block this forever. I think I didn't get a reply from Stefan to my question [1] yet (only some comments from Johannes). I would still be interested in the variance of pages we end up de-duplicating for processes. The 20% statement in the cover letter is rather useless and possibly misleading if no details about the actual workload are shared. Maybe Hugh has some comments as well (most probably he's also busy). [1] https://lore.kernel.org/all/273a2f82-928f-5ad1-0988-1a886d169e83@redhat.com/ -- Thanks, David / dhildenb