From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 972DFEB64D8 for ; Tue, 20 Jun 2023 18:48:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 126E38D0002; Tue, 20 Jun 2023 14:48:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D8348D0001; Tue, 20 Jun 2023 14:48:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F08338D0002; Tue, 20 Jun 2023 14:48:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DFED98D0001 for ; Tue, 20 Jun 2023 14:48:50 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9AEF2C050A for ; Tue, 20 Jun 2023 18:48:50 +0000 (UTC) X-FDA: 80924012820.13.85D40AB Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf12.hostedemail.com (Postfix) with ESMTP id C0CED40005 for ; Tue, 20 Jun 2023 18:48:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="nJC/EPZm"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687286928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n73HwmExb0xI3jswJYBnp87S5CxPkhc/DI183iU/NVE=; b=uHEawkAB4OsavLXp99aAyMx3fmCVaPpv6+iI91OWzZkBN/XWdLCJVpxwNNVNQ7NjjMmOXQ 2XN4JTuyMalw0HgEbWEcHaoRnrOOmOVADPuyDaHabTZ8fDeCNYHSYQu5D7pwCXNERKFjIQ fOQznpidsMMmhj41S2TU1VcYMc3Rf3I= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="nJC/EPZm"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687286928; a=rsa-sha256; cv=none; b=CGy8+EZ06j/dds1CjH3p0Z8Zst1Ko1v6LTtMQ390oOCHtSnM2Skwnem3YPpBpmTwBWkX8o VEO3ihkGRu5zAR/3K9ToyPeefauDnvFibwxCcLIfRpdJXaFCXF5zeuRZsws+e2VODhPooe 7wUSJyMGWM/uq+7IcZR7qj8/0mJG4BA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687286927; x=1718822927; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=cIjOp3qxDgmIfUXuVTvaRq9H0mpWEZcDYyV4VtVHbgs=; b=nJC/EPZmr/XeCyMp3Gy6S/BpdxhnXOrzHWRq1AgeuWPD8iIDYfFVYgPt PWbYbwDCx90tV94dERnTT6BJxfH3DA40ZPCjm9WnBQbEmYl+tSLzgbFT4 WoI2lDvQsOoZ85k/4TbLq/95BsfCqUz8Yns7sdHktBcSrRk4xno37FThh Jg/BrNWAfJKAWesmE0GqE0Bz0IbsrwN2U3ckbfKb7sV7LI9r14l+voE4O KGjEDASmcwuf7up7WhGsrSuGvorNnyVz0izyXCCQXRKnSO08dhjJov/Kd XIhhDyTlfwX+2JqHE+HYbW/k/DDKtjMCXrufL14g0zOsNF3g5efaHcSf7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="358826309" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="358826309" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 11:48:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="743878869" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="743878869" Received: from rashmigh-mobl.amr.corp.intel.com (HELO [10.255.228.28]) ([10.255.228.28]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 11:48:34 -0700 Message-ID: <37d2378e-72de-e474-5e25-656b691384ba@intel.com> Date: Tue, 20 Jun 2023 11:48:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Content-Language: en-US To: Andy Lutomirski , Kent Overstreet Cc: Mark Rutland , Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, "linux-bcachefs@vger.kernel.org" , Kent Overstreet , Andrew Morton , Uladzislau Rezki , "hch@infradead.org" , linux-mm@kvack.org, Kees Cook , the arch/x86 maintainers References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-8-kent.overstreet@linux.dev> <20230619104717.3jvy77y3quou46u3@moria.home.lan> <20230619191740.2qmlza3inwycljih@moria.home.lan> <5ef2246b-9fe5-4206-acf0-0ce1f4469e6c@app.fastmail.com> <20230620180839.oodfav5cz234pph7@moria.home.lan> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C0CED40005 X-Stat-Signature: hb5cbeww7d39edzj5itrf3pt977k888x X-Rspam-User: X-HE-Tag: 1687286927-626021 X-HE-Meta: U2FsdGVkX1+hz5Lb9mYVdQVaLmOtX9RvSLhrawulmOhG91YcV0cUoe86+gQqHglBu+1V28O0xlvtxuzDNAzbPJZzk7Dm1QLo3abUSTHZ3RtPhZD70/GQj5mENLtr9yK+QKhFl57WDcA04KBSA3JHBgw34dSPLjt8pwoWAY8cST22mugiDVKpknEO3Agr74MKY9DlMm7DaKToyh0rN7ubzd7jtdY8ph6oDLNk+Bhb5LVACOkC8WS0FbZbESGP3xl9ZBjTBhDEJRHdYmZQnadRP5XEdJvzQLDStr4FIH3+oWNabnucOGbAZqFpCIBOgZbxG9Y/dpMnDdJnAmJJoM+jZUqS1LsDdhhDKlllN/IXJlo3t4R11r+hX8ZuSOBdT1qWyPL+gEZEQWoowK40Df8yqKIaDSvbLb1KiNN0r+iIfOfg3ilKQyB+42GKCUx3mury+IStsUNElLDqMk0HeYxqgRCj8RUz3AMqT2lijWcKt7fEhBEvOG9x27o1KSJrUJhkM6nSTFw+CbnL1cw3Dy1bs8XXVaBXXcc/ehIFgjBQ8MBHuZDMw/eNorVlPgQwzcc7/mXslbi56P0hXjZshRSy5FLTqNDqxrE3LZsMU0LPReEe4+VIxfNQNxK7Ha0s7+Tu2XPyWJnuxC9+mQ3Yl3qODQR30tbnMBFWSbnIuGA3jF3hnFTypsFhuYGmNLDSGV6ZwrvRvmxiAx4RpdbX5qcPP5k61Eh17XjY2x6QZIdmPiB2zcmy4dbbQWOt1/EGnUabvLsm88kjQgJ+ki5n9VM7bdHWZUoHzn1EBhOlvT784AEXAsN4s3fPEvI1/u+bHJjmBMlee8B5CP3dzUunX5asBoGgb1viZ3xZoMObB9GUlv4uclMTISi6r8bLRInmIa9kyZ1zUy5PJ7QbuZ9cW7+4nTOWYJmrItf+nM0cqWB82jqr3i9f82oW0je3O7EZDKsVB4BEjRTRymBzaW03Zkr 1SjyzA0U /Bt8d5lun+EhkAoIbNdwkgTLvrAzMzNfSvxERrlqXjs8flpGmS1ki5KlTANLv1vbRNNtW9zG5nw23CGVkg4xiuJf+jdUkzkF7J2LlzglxipEz2Ow5qUK/tB8Q6ZM1uPHZotLuEK6YFVAxzYwX7mpaJ2GMO4yvcgyqI/7vv42djQFNS45vUZRSOXVK0MPPsTIv7SKTnGd/nsn/ShRtVDT6LlRUW8yy4bU8X0s7aCwLzi/aXqHpIcG9IpnvwRkNxcOgHjfAeRQcdxhwhzDFoAJ6iZImWeGHjICWX19pOu1j1kWLoAzMUpPSjllkXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> No, I'm saying your concerns are baseless and too vague to >> address. > If you don't address them, the NAK will stand forever, or at least > until a different group of people take over x86 maintainership. > That's fine with me. I've got a specific concern: I don't see vmalloc_exec() used in this series anywhere. I also don't see any of the actual assembly that's being generated, or the glue code that's calling into the generated assembly. I grepped around a bit in your git trees, but I also couldn't find it in there. Any chance you could help a guy out and point us to some of the specifics of this new, tiny JIT? >> Andy, I replied explaining the difference between text_poke() and >> text_poke_sync(). It's clear you have no idea what you're talking about, >> so I'm not going to be wasting my time on further communications with >> you. One more specific concern: This comment made me very uncomfortable and it read to me very much like a personal attack, something which is contrary to our code of conduct.