From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78631D2F7EF for ; Thu, 17 Oct 2024 07:01:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D19D16B007B; Thu, 17 Oct 2024 03:01:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC9D46B0082; Thu, 17 Oct 2024 03:01:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB7FC6B0083; Thu, 17 Oct 2024 03:01:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9E6506B007B for ; Thu, 17 Oct 2024 03:01:39 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4F93E1C6DAA for ; Thu, 17 Oct 2024 07:01:27 +0000 (UTC) X-FDA: 82682198424.24.8706CB0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 8223F4000C for ; Thu, 17 Oct 2024 07:01:32 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729148352; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nE81IXRFgvr1mcaY8oaSytx234AhFMm5KFfDokpnMm4=; b=fyiIvzhELZ9eDVfrMtYAgUfQL2+YIQQBmyvM0PpYT7dXUouPLVIiOeBc38tlKGs31Fs7ks 84GgUemgxkGI8rDm0M63570/VfX9e8elZjIoLqTSFBcTkZFr8gTHiseqWlYOWpAC7LCfit dmzBcbjt/7l05cdIG3rzWHiYROG1YfI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729148352; a=rsa-sha256; cv=none; b=qAoboH1pDHxR44tADuGfMWeccc9Xg4UFQrbZu+D7gZbONdfHl0eBEcEHISFsLR1ueWobwx 5yLxHvDnM0FkKAy1h72jWALvySQ+szEucrI8Wp+VqFUl2Kml6+D36KLS4rxGDh89hsrTC6 3dcdrh42d2GFAQK2fTETbZN98mkoQwk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AFCADFEC; Thu, 17 Oct 2024 00:02:05 -0700 (PDT) Received: from [10.163.39.37] (unknown [10.163.39.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D69E3F528; Thu, 17 Oct 2024 00:01:33 -0700 (PDT) Message-ID: <37ce9dfa-3193-4e11-bfd1-d2c8b60b0090@arm.com> Date: Thu, 17 Oct 2024 12:31:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: mm: fix the incorrect usage() info of khugepaged To: Nanyong Sun , akpm@linux-foundation.org, shuah@kernel.org, zokeefe@google.com Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com References: <20241015020257.139235-1-sunnanyong@huawei.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20241015020257.139235-1-sunnanyong@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8223F4000C X-Stat-Signature: 7osn47jns1ryz33w6j9xsw14q48bz1zx X-HE-Tag: 1729148492-769480 X-HE-Meta: U2FsdGVkX1/D5rN1zcdzmP83WmEPfn1uwfunHSA5gGVCt0r2OxgNhFOe4xgpMYCNeAYJK7ulG3kq6Jp4jYs4TRqMQHbHExIHRZrq3NFt2tlCl1LSGHiefENPgDtHIAo5jRiA+hHY6qszssIAgdiUoehUV/N3Av2k38PN6pZFeSY4xhUCBOtKrdWEugiLP1rRqEYiq7iT0/O+FfFtuxXrE9LWSGnrAEY6bdQhBHoo4Pwgt924G1JP9i2Ei37ArGmq35b+L3yG7gUx24OiUeTUfaF0gU1YyJEV9Rp9zfPajinZ6dYITaCOPKW4yvD0eTTVh0TAbhpbSl/K8Y8rpejDtfAge+SvMFcEIkFtpB31uYX7/aJl4AfYmzT3PL2Dk7R6plLfV2xbWs/2yhL9ifPPwvOHOX+GKHgCvmOTKtJTcceZX94YGjOumquRAqtF3ZXTYC6k4V9AwaGOiV3umhHKMKSyp+dVB5LGhPIWM7/P8G/Meh6eqPbIYT7+rchl1bpQHup8//7qfhvAtXOeZDcqV5D7stE8/b/5MWwBoH9VOoIjsFtWtZE3wcYoxk+jlQwS7i+3NirlF4Kp7QPGVB4Yn1FXimkgln2S7rBzNpZfXhuZQ64TFsaqdnQfh+FZyN1JJ+xBf7saLLcFrQ5XDMA++HSoRvh6E29Kbdzvfe0lszPUXkfuOCtescTIyOsSZOrBVM3Im5nzCYb3+e+YRhHSLFjRfVM45934x6hknOFBBtnlbdhPm+ercGEOqq7HQ0SQbaUCRqEOetdnvXaKaHWej/NESSPEeJEafAy7J4oVa4US0ttd8FQQE4uL/EwgPSPTj8NRJGmsoHdonDMd8UghpOLdoKP2JBlP8d7oVOPOZwLrWJlo1FU3RMCWLVkTPIKkt/ZxiEtBNJJKlqmULDXBZk7YzXZERjJozBk/XfUD42YR4nu7yAfPsjURYXeTAbwvwHPJqGwN1XzNjlGuwdp 4ndKwtaJ jEjAo4h06ctLghUNt6owSy5tQx0Cp0dStGBye8lpjPzIadRk4929yabMDWoAySaQUOkdeEqTk0iMSOQJYQIuzv6esISJuI8fi3h3X9g2WtkQNTDCYil0JK+Syx4Qey6456om+OC7XlSWZ6R7I4J93Gsv0jogxq2BR52e2ogduRKbL5G3Eh42QG00525upMefHA6ls9jW1wxbbDRJ5vLKhgkS1W+56tjHryXd5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/15/24 07:32, Nanyong Sun wrote: > The mount option of tmpfs should be huge=advise, not madvise > which is not supported and may mislead the users. Agreed. > > Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing") But nothing is really broken here. This just fixes usage information. Please drop the "Fixes:". > Signed-off-by: Nanyong Sun > --- > tools/testing/selftests/mm/khugepaged.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c > index 56d4480e8d3c..8a4d34cce36b 100644 > --- a/tools/testing/selftests/mm/khugepaged.c > +++ b/tools/testing/selftests/mm/khugepaged.c > @@ -1091,7 +1091,7 @@ static void usage(void) > fprintf(stderr, "\n\t\"file,all\" mem_type requires kernel built with\n"); > fprintf(stderr, "\tCONFIG_READ_ONLY_THP_FOR_FS=y\n"); > fprintf(stderr, "\n\tif [dir] is a (sub)directory of a tmpfs mount, tmpfs must be\n"); > - fprintf(stderr, "\tmounted with huge=madvise option for khugepaged tests to work\n"); > + fprintf(stderr, "\tmounted with huge=advise option for khugepaged tests to work\n"); > fprintf(stderr, "\n\tSupported Options:\n"); > fprintf(stderr, "\t\t-h: This help message.\n"); > fprintf(stderr, "\t\t-s: mTHP size, expressed as page order.\n"); Without the above "Fixes:" tag, Reviewed-by: Anshuman Khandual