From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEFD8D10BE4 for ; Sat, 26 Oct 2024 04:01:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 496786B008C; Sat, 26 Oct 2024 00:01:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 443EB6B0092; Sat, 26 Oct 2024 00:01:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 332D66B0095; Sat, 26 Oct 2024 00:01:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 15D3F6B008C for ; Sat, 26 Oct 2024 00:01:14 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B2C611614A9 for ; Sat, 26 Oct 2024 04:00:50 +0000 (UTC) X-FDA: 82714402848.11.EDE8FE6 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by imf18.hostedemail.com (Postfix) with ESMTP id AE1991C000F for ; Sat, 26 Oct 2024 04:01:01 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=aOqpRn7d; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729915193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=94xNPQ7reY27xXutMfor02Xwq25M9OnrXWxLpCbP0ak=; b=Dx7OnOdyC21KXO9CneYwZN6CW2A9X5mnIzF/HRRpp/0EXIIgojQAr2N8t1vnpBsuK1BgzS sBjdv7G1mTlch4rkDUEKPunRDvvxF+OOV+lk24brjyrCsfG7tUahn2hJciDsd/EdGanYXV 63qQ2QsS4yuY/cC6zXliZ+Pk8+NGG0k= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=aOqpRn7d; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729915193; a=rsa-sha256; cv=none; b=hFlObOI8AhGFN3PrZimOvXpA24sxQPN+zjwhQFUoVX+G3pkQae3r6t7tbvacdbyBeQTmhB l8dt8JdUaNsDKTP9JD/m9STyHv9uga4cbOOSdEH1iFKGHJDu5i5C26tqVcNT2163XAAClL bm0u4AD9hROIEKFGaFMDU6gbMaza2LQ= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1729915267; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=94xNPQ7reY27xXutMfor02Xwq25M9OnrXWxLpCbP0ak=; b=aOqpRn7dVzd1ne8YYWgiNcAzr3jBnp88bnZRt+3UBY1AGdUkWjru8n7H3ev+E+WcR7F7exmbhN/mKDDdJPJN4sEIvOCntB61sTCITlYCjDXF91P7HYGEP01dtJN4kkIVFaF+5CItjQJLBefs4d+zGUUaHGI6uFCv9GMGPx403hA= Received: from 192.168.0.100(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WHu3gJ3_1729915265 cluster:ay36) by smtp.aliyun-inc.com; Sat, 26 Oct 2024 12:01:06 +0800 Message-ID: <37c82981-42bd-4208-88bc-5de234e6db13@linux.alibaba.com> Date: Sat, 26 Oct 2024 12:01:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: shmem: fallback to page size splice if large folio has poisoned subpages To: Andrew Morton Cc: Matthew Wilcox , hughd@google.com, david@redhat.com, wangkefeng.wang@huawei.com, shy828301@gmail.com, dhowells@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <01423085-1622-41ed-a882-64291f3e97ab@linux.alibaba.com> <20241025154527.31873b55fb75d778c431f5ef@linux-foundation.org> From: Baolin Wang In-Reply-To: <20241025154527.31873b55fb75d778c431f5ef@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: AE1991C000F X-Stat-Signature: kczub3csmy359q6b5gb36o9wh7k4pc58 X-HE-Tag: 1729915261-992989 X-HE-Meta: U2FsdGVkX1+WteZRkMcB0OK1b1rWeOe3ywqXjqiYMDUy2HP2rEeSb8I/PwVr8FEDkkRBFQpDnYGDzZpP5Pb92hbQPGXdC+gBaJ6f08255pjHXrKrzfNbkrQ+sYAh+6kdsFjjDvi6jbR0v5MR1ODIHMog7wKVfTFJZoUG4rT3W2iM8HtzN3GjoNTXFHAsFLeGfzbAXqlseO2godfZKgpRr9CXx3wO1gov79UabE6uCSECHrV63etTmq50KPPAxse2w4xNLv2t1lNQrYPSpnZKwJCqIeoS58QoiB4hLzW1JUBiicLkgLYrYq2aKJeGJfrSRAxuNqnCkv6rxMsBkAqHrKmnUIUMOXMMM/9pIt57MrP3MjOHEr6BLk+OKmgwXizEOn8yCfyOEQmLWimcSIuIxQmcFZC1PvxLuddwgu2K/U5sROcDKO2q1OOh1F3rjxlDkLCMsgPgH7+GBeFm0RxFhRrS6Lm0UBom9j75NNK8WlhJwUzKlgFlhR6v1LzUuvJBaCcZugeeMYxZzPEzWUUCxXd7BHCrJlUC+otoxKTxYsk61UJgOkyaTWbCXEXfhaYm03pCfLqJWVbKRodGlXSol+DuI3GMv0RZPIc/s5iQclAvzG59mvPrRj48LMYbSrzhXKozRINmrjpy85r/TOXvTjMjLC4j5PizPNcLiEK+dTRKln38QKaBFT9VafsoeihYSSCc2Bsxld/+fjS1cltN7LWWlaiHLpodEmhXUuk+vGuCCHJ7nIwol1VUp5QiwSOI3KCypWq+nUx59VRRVZxd4j7opE0EKymOkbvtWZGD7FkRoCne7nE0cjTSTWUQiZJSpnEq0JKbTFKDpbJ4PoUo3UYXaZ6+SY/MPDmOOlaQHFB5jJf3YpBPnIRKUsiF8okF+PooFVAxAeUYSuTHAiDaGrlzJXgdQWWsM+PpWxCzNoadSuy9RO2eeM3T69pmxsOOIMyxQ9EyD0qOUjYhlIJ uVaFVUCu 5/sz3GmFCPfGTqxhd+xlp0YXFzxwfzy4ljV1OHKW60UqEf7X6fDlo1wJnj9GYSI3775KiXWN+YDhe2Uvpbx1RiLCXnRuHKMBSh7/MT+zeR84XVF4i6J7r1lA8vpz1ezfT4RSmK8JGfxj1e1S+AE/A3/75tThj7i87eTH7bEjYypXUgLP8xad0iPHk/bNW3tpbeE6oNSe1ZRuOBxszH/9GLP1malDwJblYMLGcS3USIvAY8oy2+uxa/kI0HkCpSoTvY2hYBZWOHFX/wVmCqAM0yeZ+Jw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/26 06:45, Andrew Morton wrote: > On Fri, 25 Oct 2024 11:41:28 +0800 Baolin Wang wrote: > >> >> >> On 2024/10/25 11:31, Matthew Wilcox wrote: >>> On Fri, Oct 25, 2024 at 11:26:39AM +0800, Baolin Wang wrote: >>>> The tmpfs has already supported the PMD-sized large folios, and splice() >>>> can not read any subpages if the large folio has a poisoned subpage, >>>> which is not good as we discussed in previous mail[1]. >>> >>> folios do not have subpages. folios have pages. do not use the term >>> "subpage" anywhere. ever. >> >> OK. This is my previous habit of naming it. Will change 'subpages' to >> 'pages' for folios. > > While at it, please try to avoid depending upon references to previous > email discussions. The links may be bad 10 years from now, and it's > laborious for readers to trawl through the online discussion archives > to extract the information they need. > > Including the link is fine, and potentially useful. But please also > include the relevant information right here in the changelog. Sure. Will do in v2.