From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99BC1C433DB for ; Tue, 9 Feb 2021 16:06:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26E7064EAA for ; Tue, 9 Feb 2021 16:06:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26E7064EAA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 98D026B0005; Tue, 9 Feb 2021 11:06:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 961326B006C; Tue, 9 Feb 2021 11:06:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 879906B006E; Tue, 9 Feb 2021 11:06:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 73B4A6B0005 for ; Tue, 9 Feb 2021 11:06:45 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3D1172485 for ; Tue, 9 Feb 2021 16:06:45 +0000 (UTC) X-FDA: 77799207570.06.roll74_630c31a27608 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 137A91004692F for ; Tue, 9 Feb 2021 16:06:45 +0000 (UTC) X-HE-Tag: roll74_630c31a27608 X-Filterd-Recvd-Size: 3604 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 16:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612886804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1xwffJWUIzQSXf4SOdpUxpvUWn/I4bujEit2lpJS4OA=; b=cIZbBJ9tGADvfVUn0oQfDTPmUfp0/XDfMxYpmWMi/2J7olcYetIr3rYR7f9QkAx+I7UqRD Yh9uz4wFbxRBQ4+SqmPtHxxj3ZviNkYfiWLWkHUkZgSYPkc8/7BVbIsOOoajp96DqhOjhM /PYa9c6BjYYlbBDskv2Wn8dSIHwIdL8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-241-AGQhXGytM82fBZdCh1c2Tw-1; Tue, 09 Feb 2021 11:06:42 -0500 X-MC-Unique: AGQhXGytM82fBZdCh1c2Tw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3A710192D785; Tue, 9 Feb 2021 16:06:40 +0000 (UTC) Received: from [10.36.113.141] (ovpn-113-141.ams2.redhat.com [10.36.113.141]) by smtp.corp.redhat.com (Postfix) with ESMTP id E1D90100239A; Tue, 9 Feb 2021 16:06:38 +0000 (UTC) Subject: Re: [PATCH v2] mm: cma: Print region name on failure To: Georgi Djakov , akpm@linux-foundation.org, linux-mm@kvack.org Cc: rdunlap@infradead.org, pdaly@codeaurora.org, linux-kernel@vger.kernel.org References: <20210209142414.12768-1-georgi.djakov@linaro.org> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <37be751f-8c11-fd5a-a57f-a5e0599e2420@redhat.com> Date: Tue, 9 Feb 2021 17:06:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210209142414.12768-1-georgi.djakov@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.02.21 15:24, Georgi Djakov wrote: > From: Patrick Daly > > Print the name of the CMA region for convenience. This is useful > information to have when cma_alloc() fails. > > Signed-off-by: Patrick Daly > Signed-off-by: Georgi Djakov > --- > v2: > * Print the "count" variable, as it was originally in the code. (Randy) > * Fix spelling s/convienience/convenience/ in the commit text (Randy) > > v1: https://lore.kernel.org/r/20210208115200.20286-1-georgi.djakov@linaro.org/ > > mm/cma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 23d4a97c834a..54eee2119822 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -500,8 +500,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align, > } > > if (ret && !no_warn) { > - pr_err("%s: alloc failed, req-size: %zu pages, ret: %d\n", > - __func__, count, ret); > + pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n", > + __func__, cma->name, count, ret); > cma_debug_show_areas(cma); > } > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb