From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF685C6FD1F for ; Sat, 30 Mar 2024 20:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4C776B007B; Sat, 30 Mar 2024 16:55:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFD176B0083; Sat, 30 Mar 2024 16:55:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9ED06B0085; Sat, 30 Mar 2024 16:55:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8C83D6B007B for ; Sat, 30 Mar 2024 16:55:47 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 416CA801D1 for ; Sat, 30 Mar 2024 20:55:47 +0000 (UTC) X-FDA: 81954911934.12.008AC8E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 33E7220003 for ; Sat, 30 Mar 2024 20:55:44 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hl6eELnV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711832145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jyi6SED43RWjiHARW2FnY3B2JhkS1d2lHNCRYyCsMcg=; b=Q+4UQoa3kgXiBCBdUlFJuxliB7HdGiEXrmKIDut0+x1K4he06bGWNPP9nuLxThdNs1lPfO hnTRRBKOMKbv0RIXucOssC3+srlWaoL0UjY1uorMk80EjfATu7BfWRTblnb4mOfaG4TKnR JZAN7dKV/lw4g2MXHW/J0Heb18y1zzc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hl6eELnV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711832145; a=rsa-sha256; cv=none; b=HUrRTf3WLKgc81hSPGRc7yJk5rtWPeSZ84EKLIaN3cp6ovJRIGHfvp0KjC8EE9G7QqMX7g LNUwS6r/9JqtX/EeOBvpcdLdROMLrVXCZbcvhW0OpidfqPEeYZpbUbTQBi8eCVzanIEIIF AHXExuAbmh3eaIyM4oimDHJxkp0nDRI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711832144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jyi6SED43RWjiHARW2FnY3B2JhkS1d2lHNCRYyCsMcg=; b=hl6eELnV0t7CvxcVkDU/ihH+xSbaVr3a1Ryu2cp8yTwlDXYVlvf4JZNv0aSBSyfLIO/W8I 4qijzh02FFkamT+YlxopeY3ykUQh4UvZ8dNV8pmrJZ9i1Xmdcp7qGBAQJLCrawF7NbT4J8 MB0nW2/Jbb5eNzBRk1WL854Hks4hK1k= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-13-0qprG8F8PuK3ZKXeaWQUTw-1; Sat, 30 Mar 2024 16:55:42 -0400 X-MC-Unique: 0qprG8F8PuK3ZKXeaWQUTw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d6b9530792so25486511fa.2 for ; Sat, 30 Mar 2024 13:55:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711832141; x=1712436941; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jyi6SED43RWjiHARW2FnY3B2JhkS1d2lHNCRYyCsMcg=; b=hK2Q9IfoPuuwux573WSZzx86Ja2/6WpYOqoaYFPHl/9JR0iNN2aItZ3eqgbmeVsY7g 25Zs1Ec5C07rniKBvNtLyLbnX9XzAAPHyUaY+OPM5Dnd4wusrh98cMesDjtZ6O9IsBZV hcugYEG1Y4NOqNtLF3gsxZtURKY/aq13h0vq8pWZtulUzynl4iybtaEpBcWIY/l4ypkA mx8hGu3Si+E7DZMZVkjnGg0ypkmnN4CJkXShmk+NZeFu/1XAzOPHcifxN3aI0gcsfKnK NZlN5rWhWh1d0u6I0QbeLD2d5RY3LLveVOUrJVWBouyQ8UipSclNpAviYZr7NrF6x/YO K1nw== X-Forwarded-Encrypted: i=1; AJvYcCW9TLWV2wD6qKe+d4tzzTf5lF1pST6a/UUYb7UhRzvaV7I8v4SJpn0O8cnqdwZPz8LW0iQIzAva7Tj1I7AaSq87eIk= X-Gm-Message-State: AOJu0Yww1fUuCeB575x+o6ZIcUBF5c1tUuzlnbQ+GfK7JerMt9gpzkeB cvwFkCf+h4pzwoMk4AQS4TzPOXUR8H0c+pfOVmLpYjp7F3TJYN1HjvI1PdxIImVj/OG5nZ5fazs xM3lAO+qE8uOGuOK+nRzRz8MrivGLD8c4K5f+ZQ4tCSBsUety X-Received: by 2002:a2e:3307:0:b0:2d8:1096:6913 with SMTP id d7-20020a2e3307000000b002d810966913mr136907ljc.20.1711832141177; Sat, 30 Mar 2024 13:55:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3w4cwAv4h4Eb58plOtyeNT/FqmpU2M4qH41wQ1IThyW9pWf1IBmQXNxSRhgLNhjfSlLWhkg== X-Received: by 2002:a2e:3307:0:b0:2d8:1096:6913 with SMTP id d7-20020a2e3307000000b002d810966913mr136864ljc.20.1711832140682; Sat, 30 Mar 2024 13:55:40 -0700 (PDT) Received: from [192.168.10.4] ([151.95.49.219]) by smtp.googlemail.com with ESMTPSA id 17-20020a170906301100b00a45c9945251sm3414724ejz.192.2024.03.30.13.55.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Mar 2024 13:55:40 -0700 (PDT) Message-ID: <37941671-9ece-4078-b308-b185579e8d7a@redhat.com> Date: Sat, 30 Mar 2024 21:55:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 17/29] KVM: SEV: Add support to handle RMP nested page faults To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, Brijesh Singh References: <20240329225835.400662-1-michael.roth@amd.com> <20240329225835.400662-18-michael.roth@amd.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20240329225835.400662-18-michael.roth@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 33E7220003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: w9ms5ak8aummezw9kuy7wh1d8xddxky9 X-HE-Tag: 1711832144-577984 X-HE-Meta: U2FsdGVkX1/o3kimW9qtuoJP7ulxiPpxVOrXhX1SFsoffGkbzKf/f8+3KSAKYiyXGYSfzBGazOGYB6/7fgFBQJ8uZb7hVowctOTS9VZHBYhPCIGRqS18S2rVKUvg5coaLSX4zjgD3HRFUNsevDJP+b8lEeajw3WY15bguoMWx1zLVGVz8BMGi8TE0bZdHqpF9vAch11BYOoLYP9+DV7CiwrX+ZtOytQrhYjnKilatWBE+vZDr6MWIpoQZH6scRhGlS47HxpdsfWraFdO1gofzJkrW7j1+qhGJbTpvyUpxaLXEMtDWwn/8pvhEFulSDB2z4v0b40kKHZb+hGO/ctW5gty00mTA/7uBETOQhb1qYW2n2ZfUH9x+j61sTRMcboIiI8cNLsfTq6IBXgRhrZixTkHz4IkkZbfkPujKt3pjO+gffL3K2aaf+WecCvQAdv9kIs84MGwO3PYRjs2/kDBRRlHP0/jPmDRsXZ5b2J3tYH86khxBu3SHQ+2oGSgzV6jI+TXzFD95sxPq9ssPZ9TmsFsiCkxzJu+Thh7MdbGd+Se3QAWLjoHOdPoGlOzmaMLoV3mOUe1y3L1oadc4w6T4nx3wp+b64QbedgvkETb7S5XhZq2MFjlnoYZjA8DdKXQIVwO21EaLbUALvaxOdq6GGe+mgbqPixWbFwr6/M7KjDGg2fSBL8P8uTiLu1WdvZSKX+1MF6zOuxw2pnJ2CPhnU8IviQO70Hn8XQLQPoAuj/ZcY0i3+6Sm9z4cH3lth1w3bO0aj+SN/G084wOhxADz6qnGkiolwCYON5+/DLOL6d1U5G2GdoeSRO/VNTb3hQN/kYVCcsJ4Fu29VOf1lFOJSbXUKoP4kqvo3f3vTgI6gAQdDa6ruxwEpSi0ELJpIDGrq301ipeXb1N0a2iGJzaikP/szGsaVX3PxChtSfZQzdXyCXn4kV3Wyx0QF9eUnVVBPRP4ZKSgyUnmgib3/2 S8Z28Wur FmSfarEUVAmQBiBuAwTTtXYolN9axLlk1zM0/Hm603hsoG7O+wSL+hWPTfDc6VcW6xJ/fa/NP+iiAucwtYIvAj6PXt/6/yorBAGyonI3xa/3e0ie0j62pXU14sBlBaXI/sR0M X-Bogosity: Ham, tests=bogofilter, spamicity=0.001305, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/29/24 23:58, Michael Roth wrote: > + if (rmp_level == PG_LEVEL_4K) { > + pr_debug_ratelimited("%s: Spurious RMP fault for GPA 0x%llx, error_code 0x%llx", > + __func__, gpa, error_code); > + goto out; > + } > + > + pr_debug_ratelimited("%s: Splitting 2M RMP entry for GPA 0x%llx, error_code 0x%llx", > + __func__, gpa, error_code); > + ret = snp_rmptable_psmash(pfn); > + if (ret && ret != PSMASH_FAIL_INUSE) { > + /* > + * Look it up again. If it's 4K now then the PSMASH may have raced with > + * another process and the issue has already resolved itself. > + */ > + if (!snp_lookup_rmpentry(pfn, &assigned, &rmp_level) && assigned && > + rmp_level == PG_LEVEL_4K) { > + pr_debug_ratelimited("%s: PSMASH for GPA 0x%llx failed with ret %d due to potential race", > + __func__, gpa, ret); > + goto out; > + } Please change these pr_debug_ratelimited() to just a single trace point after the call to snp_rmptable_psmash(). Paolo