From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64D74C6FD1F for ; Sat, 25 Mar 2023 07:44:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A20636B0071; Sat, 25 Mar 2023 03:44:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D0C26B0074; Sat, 25 Mar 2023 03:44:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 898CA6B0075; Sat, 25 Mar 2023 03:44:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7987D6B0071 for ; Sat, 25 Mar 2023 03:44:27 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 433FBC012C for ; Sat, 25 Mar 2023 07:44:27 +0000 (UTC) X-FDA: 80606632974.10.778199E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id E78484000A for ; Sat, 25 Mar 2023 07:44:24 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lrebst2f; spf=pass (imf12.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679730265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c1fqtu9LBWrWaCQxQTVjr0cxRai+bTqOnRnWXMB8NKA=; b=e6VYUyePxXC5rqT4GJ9hhpzFC/4ZiNtsfyOduks1FlAU/aw/zhnHy77hA6TmdQ2LxGXL8s +AYykX+7+uWY9ctiKbAtirMte0798xMqZqmSDRpPFKdvnKmzHpPSNE4VSVdTP12xvf5Ind 3F8aZoSH+oLPOVSnpNSR7hp396r2CQ8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lrebst2f; spf=pass (imf12.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679730265; a=rsa-sha256; cv=none; b=NuWpvnyOQSEgBDTPoXa33A58GjIpJBi5mh6E8t5VJwkia2UJMhunHZnl/GBToVcufpCH0G TR81C8vCNjM4uef7P5jEl4DqrlYhIqtaW9JRTLib3t7c8I4D+nn5fw87EnB5hpvntCW4f0 xWv5KIOJJwcLLIFQpCrIOBE2cAT4RLc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679730264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c1fqtu9LBWrWaCQxQTVjr0cxRai+bTqOnRnWXMB8NKA=; b=Lrebst2fhCQJFf/n0wvwPtURU9Ptbu+J7u/8kygv5vQ8nkLcsQ84ZioTZULbw/QjE5X5jK 0td/0o41+g5pGmxPULbhxPoi+7Fm27huqtMRGMEq5J7vGIqUUwyiqteXvR0KUTCNMeyTB2 agHVeFcYvvcUGxc+jEMkJDykH/RWjpo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-413-H1kqNBBlOki1ozjiPf4r0w-1; Sat, 25 Mar 2023 03:44:18 -0400 X-MC-Unique: H1kqNBBlOki1ozjiPf4r0w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 698D385C06B; Sat, 25 Mar 2023 07:44:17 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 55749175AD; Sat, 25 Mar 2023 07:44:15 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <3763055.1679676470@warthog.procyon.org.uk> To: Herbert Xu Cc: dhowells@redhat.com, willy@infradead.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, viro@zeniv.linux.org.uk, hch@infradead.org, axboe@kernel.dk, jlayton@kernel.org, brauner@kernel.org, torvalds@linux-foundation.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-crypto@vger.kernel.org Subject: Re: [RFC PATCH 23/28] algif: Remove hash_sendpage*() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3792016.1679730254.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Sat, 25 Mar 2023 07:44:14 +0000 Message-ID: <3792017.1679730254@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: irctrkjy4umi4fitxkw53uitzqbdcueb X-Rspamd-Queue-Id: E78484000A X-HE-Tag: 1679730264-837363 X-HE-Meta: U2FsdGVkX1/2gCTv7+DiEzaVGBjUApwaSjrsi9uyr3sAGKf6nzqj+NIsrfmbpOBYB9QuUHjujdq/2XbVxlWG9QHc2V0q+aVapOtM1poJL2Fg+UwAE2FZr31ahV9J7HFZdoNuhjgcsTISpwNksa+wyhMLbZ1Py/1qPHGyOqYZhiDYUEpEKgqAZ+K9j9/gAs74hMldSjPNtlwrHTEJSEmiGBLrnE+n1tD988EwKG+Nki81AuEvHtiO4HABLaevyZpywUUrwutp3iaKeMRBBGhxKOprttGR2GywKRinD41jpc3P5I8sL1O5aILjFoCNOvQPbllgtjih5HJLUmWSx3/yoN9J3UZJkcrI2U9F0pyRVQYxZMinafRmucVDPn5AejU6IvffeUtPlH9zatbnsR6s3PKs0aoZUekz0Zn3dgMVYgyUJQeu/Tb+J+21XJ6k8RD8KKnh5nVFPCR3euwcWy2GRlctztR+9e8bpZxBIEpWDNssHwTkR2gB5psrM4onZQAcucSldPPOfE+nIMFevmKkfATMIYXp5sADFVIxIkSbJs/iOOuOWF7dDYU32IuOLSyps9jDbzqlhZ+vUjqt+qvouIQhGrONxEo/2Mbzc+YJ+za51ClnJl0jP0AC2+PzGJxjXodX8Zha5XmDJowV9qgecnmIJaaUF6dHQvfZhWIWSO6RZhrQaofoAHGSRfKtyz/wXB7rAJ4i7qzvWlSvWxKJSReMJgpS8ShNxJMOHisWtf+lXL4gHihXcfbTa4imnJh0UeZ+8qMfSFCmvKxNT1b3M7j7pHFRBvl8byEQUqMpegutAovoeWfefG61h4OSnC2ogWkZMriZhW95QUPHoFYTjHJG9/G7IISc3zzvQxBSGlW5GkYLCXm9zCAivr+JH4qGtqxeEgC0TXYMge6wogdaQCawxMD2ngyRzBVRLKcazA2gft8hW3Ejyzc70yo5Sk9X9uihbFAz0JTPuz25tCu k6FByqJm civjUg7yUZ9p3bSczaL/zl2fopZjokZmkqxYcV73VAVsxdj2S5Bc5Hy3++1IxsrCYPDfVw3ChTb0CGWFWwkkQoQX8xIhB8XmT9Z+r5WjLyeMjbGJ8pXDBwYJ/hpsk9bzm9pxK6GwARw3npRGwtGlcbiOH9m+QM1VwZnH0wZ8KJ043Re6FjitdZ5ktdNK7QRXvSSUOKXdie2eIYcg/xTt8NQTpt3oQ4pn9ThKnBcsLfjTAWLyPHm/K4I2BtcVV+NyUQsPxi6OQbpNAxGtXEXpfOJsUsQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Herbert Xu wrote: > > I must be missing something, I think. What's particularly optimal abo= ut the > > code in hash_sendpage() but not hash_sendmsg()? Is it that the former= uses > > finup/digest, but the latter ony does update+final? > = > A lot of hardware hashes can't perform partial updates, so they > will always fall back to software unless you use finup/digest. Okay. Btw, how much of a hard limit is ALG_MAX_PAGES? Multipage folios c= an exceed the current limit (16 pages, 64K) in size. Is it just to prevent t= oo much memory being pinned at once? David