From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B076FC3DA4B for ; Wed, 17 Jul 2024 12:11:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BB3A6B009A; Wed, 17 Jul 2024 08:11:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46B816B009B; Wed, 17 Jul 2024 08:11:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 332806B009C; Wed, 17 Jul 2024 08:11:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 16BA96B009A for ; Wed, 17 Jul 2024 08:11:37 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 92B45160AA2 for ; Wed, 17 Jul 2024 12:11:36 +0000 (UTC) X-FDA: 82349130192.03.07C1EC5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id A42E880023 for ; Wed, 17 Jul 2024 12:11:34 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721218255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vEAEYDeot9hB+hzVwrn12651al9MzVZESze4azdS2Vo=; b=KDgcY8zZW8t8Smk9dQLe+jIPoAXzrvPRO1XzzQ24c/R19GlZndvcEDNRZLkok+QMUMyF7m a5w/uRvC6GrMNgbliBzxZV4iSQQwvXTtlvRlPALkv3+1ShtX8zYHpdih6D0vSrBq3iGtzR mDvqIS9th+nMc6Y9DCOLKEwAZo8JBls= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721218255; a=rsa-sha256; cv=none; b=PDvrTbICCs/JI6ca180Q53V2wFykBopmKd2rHkwApCeNskrcogg6ZRKG3FZ9nZ29lM11fx R8b/FljslCy9J5jqgNIjXB9yhK1PLP/TC8wo80DqRs9T3FK3trhSSWkqcxR2peBZWCd91A xt9sCjSW7UrxNQjjEjpNE9MrMgnqZQM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B9611063; Wed, 17 Jul 2024 05:11:59 -0700 (PDT) Received: from [10.162.43.24] (e116581.arm.com [10.162.43.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EFF313F766; Wed, 17 Jul 2024 05:11:30 -0700 (PDT) Message-ID: <3782befb-c317-4bb0-a279-c90adb2ec47b@arm.com> Date: Wed, 17 Jul 2024 17:41:27 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Skip test for non-LPA2 and non-LVA systems To: Ryan Roberts , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Anshuman.Khandual@arm.com, broonie@kernel.org References: <20240717111011.316037-1-dev.jain@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A42E880023 X-Stat-Signature: igubexim8nypfjf9nwa6j3neocqpimhn X-HE-Tag: 1721218294-222092 X-HE-Meta: U2FsdGVkX1+uff8U0FVgUyj18sau+eTe0AsS5TAdiNhcgWUSqrJLwzJhxrEtdTPxJoA658qtRU50Ap0HLM3PCxtD91qJvlsUWTxPgzbHQV/60B+bhTojGUNIibNtMGheTqkI852D5uV4vWutOfYGdSMhK4r/yZc9sf1z9zGmf6zI5wP6vwlbU4oL5WRA72DtNtrchb4B9DUc4aHAuv3oBa7G6HSTLI0Sez5HqA5/WDGdcVlLnsKVbCcJWGSXKYSCZpnOs3Kl5+6sgN974ZVxKXFU/EN3UQvyALbZ4a7F68XEwq7XoG4a6CvTC4ci72lVkCAWK1v/z9CRd2HGtqPrFGeuXcZOVFStwwMw3NQlKMTCoEoBlmKFkUoIlIYXddtoh/Xsg7QWhOgKv1yQM9Rl25x4SUUnze1v4N/+YOt1OWjyAHOZn9CaaF2tezQIsm2hT3r7xyDwaWnsvLtbVRiYWgx50vxW4BApckcpWXj0FURhS91Ovf03q8QB9Xt8eWWJLsn98HBVM9omJBfhSxkREv1ice6lS/Fvg4oviVJ0VqhfVuYD4ZQXKULno8i3UShoBHzIK/ISlsT+yF/6A6hHHGrfTpn9U4bflBzutDgcP168EEdwQ7hwScjaG6Vu9B0lorKALamDkJJ7Fm+3MhLHwKG29T1iAxBB3RslprbkAKcYZBXugwolLc6TD6FlkOqR67bwi5IxoKkCLAbzW5BNcEXJcrKI0N6SOuu1FbYagMDBNlzoVH5BDUjtnWSkozWykzSrf87SZ4A6FX2TmLcQq2bxCPSBUusmgRfNfVCgOxFKPjgx3CLftH6cnfLfxqBtFZ4QwwK6Oa4nf6vzcUBhNeXxhdIm1nYHyxJSkVF8V1aDLXlha7HnxRf+7AFZBoB9mrDoGK6Qli+ZQrSr1dZ4UHDST9UHooMwGvDxuOZof5CH8Pj5dUpj25RgfCcSDdrZXPmHVT4Mbzvfv2QbBEw aV7eXLSC 2Dn5cn/C5f/u+87IRvu4h58lbQPCUjnEtpHigpuBHjwPh1B3kwt1WkEMFjOXIYcdko+99RR01vF4YQc4kcqloZ6NzKU8HVfBdzrwLylnf4b3Ux/E3s6I1gZuWbiSiFHmONEI/znd/JsJbPAB+Me73anSWNCLU6IQC3/kzXpc8Z5hKOPumeEujwulNdCCcldRzcDabZUY68UU6i7Gjvecvm2FgiB4JiZeqetHJgZnJ22adFr9ULOciC3muUchnIOzEP7oS/ZHuHrMho+w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/17/24 17:27, Ryan Roberts wrote: > On 17/07/2024 12:10, Dev Jain wrote: >> Post my improvement of the test: >> https://lore.kernel.org/all/20240522070435.773918-3-dev.jain@arm.com/ >> The test begins to fail on 4k and 16k pages, on non-LPA2 systems. To >> reduce noise in the CI systems, let us skip the test when higher address >> space is not implemented. >> >> Signed-off-by: Dev Jain >> --- >> The patch applies on linux-next. >> >> tools/testing/selftests/mm/va_high_addr_switch.c | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/mm/va_high_addr_switch.c b/tools/testing/selftests/mm/va_high_addr_switch.c >> index fa7eabfaf841..c6040e1d6e53 100644 >> --- a/tools/testing/selftests/mm/va_high_addr_switch.c >> +++ b/tools/testing/selftests/mm/va_high_addr_switch.c >> @@ -293,6 +293,18 @@ static int run_test(struct testcase *test, int count) >> return ret; >> } >> >> +/* Check if userspace VA > 48 bits */ >> +static int high_address_present(void) >> +{ >> + void *ptr = mmap((void *)(1UL << 50), 1, PROT_READ | PROT_WRITE, >> + MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0); > I think there is (very unlikely) possibility that something is already mapped at > this address so it will be replaced due to MAP_FIXED. That could break the test. > But the only way something could be already mapped is if ARM64_FORCE_52BIT is > set and in that case, the test will fail anyway, right? So I think this is fine. The testcases already assume that high addresses must be empty. Yes, FORCE_52BIT is the only way something could already be mapped at high addresses, but in that case the test fails trivially. > >> + if (ptr == MAP_FAILED) >> + return 0; >> + >> + munmap(ptr, 1); >> + return 1; >> +} > I'm guessing this will cause a function-not-used warning on arches other than > arm64? Perhaps wrap it in `#ifdef __aarch64__`? Ah yes, I just checked and that is true. I shall post v2 in some time, shall wait if any more comments are there. > > Thanks, > Ryan > >> + >> static int supported_arch(void) >> { >> #if defined(__powerpc64__) >> @@ -300,7 +312,7 @@ static int supported_arch(void) >> #elif defined(__x86_64__) >> return 1; >> #elif defined(__aarch64__) >> - return 1; >> + return high_address_present(); >> #else >> return 0; >> #endif