From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56109C54E71 for ; Thu, 22 May 2025 02:32:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0F006B0089; Wed, 21 May 2025 22:32:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C985C6B008A; Wed, 21 May 2025 22:32:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B60E36B008C; Wed, 21 May 2025 22:32:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9458B6B0089 for ; Wed, 21 May 2025 22:32:05 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4014E1D34D9 for ; Thu, 22 May 2025 02:32:05 +0000 (UTC) X-FDA: 83468969010.24.F48190C Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by imf03.hostedemail.com (Postfix) with ESMTP id 33F8E20007 for ; Thu, 22 May 2025 02:32:02 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XorGxnXs; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747881123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v7OyzNFi4koovf7Ot55c4ptctb/+0JCIucwjXRDLPVY=; b=8BKHz6DFg3geZfQ0bmimWWp85foUZqKET9x2PMF7LbBD6S0IV9RyQruYImRFDl+l9tUSt5 Rwz0BrKoE4UXXtpUyt1YyZZsrLEm0Z1CvUhUt4QKiwbpg3YVSmY9Md5opkzryXvKlBoPy0 OJC4FB85Coxt37HRs54fn8Ou2GdiE3I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747881123; a=rsa-sha256; cv=none; b=dhkrXcRAVqPq0i78oYwaEVl/iLGl8+0M1VOsuwvrH1TkDG58M6v1kNEbWtaQ0Du9+jHqQo 3VqcwPmbdzeiv5J+6Y5UXgyeAbHecBi/DiKewf7WQDXl4fXlVYGHAycm/Fk2dvqXspBS3n ZMc5q+eJf6O+1uX8ue0rN/OGDn+PZVo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XorGxnXs; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=muchun.song@linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747881120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v7OyzNFi4koovf7Ot55c4ptctb/+0JCIucwjXRDLPVY=; b=XorGxnXsae3VA5C2XCc0b1ahJ4y3yZPrGL8iFM61ZfF/bFE72dsoWm1KBWgv8HcBWbInlm Tc35CcCFHdTz7gf3QP37s+aiEutg8fLTRFzwXKgRgckoYYwJ0TnjCDKVEzb4G0cmVdp+ZQ zncFIK9i1r3a1eelRhzVGRbTthLmg2Y= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\)) Subject: Re: [PATCH RFC 27/28] mm: memcontrol: eliminate the problem of dying memory cgroup for LRU folios X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Thu, 22 May 2025 10:31:20 +0800 Cc: Muchun Song , hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, akpm@linux-foundation.org, david@fromorbit.com, zhengqi.arch@bytedance.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com Content-Transfer-Encoding: 7bit Message-Id: <3782D28E-B0F0-4CC7-98A6-27E443A92730@linux.dev> References: <20250415024532.26632-1-songmuchun@bytedance.com> <20250415024532.26632-28-songmuchun@bytedance.com> To: Harry Yoo X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 33F8E20007 X-Stat-Signature: 9ptonqdgjkm6tobrnfwp58or1us1ectd X-Rspam-User: X-HE-Tag: 1747881122-727199 X-HE-Meta: U2FsdGVkX1/R/St2ChWfpAd2O26giEqQTIhVC33CFuCHzLGQHkD9Cr+QAXnEZQJjhrcmectuq9zLDSG/IRugGuasRgfLD5idRnrTzeiK3tBMcsCGv/iFLaWelYOLClkEmQEd6Z/dINhaXFyzYUavjEXaz5ilH7hE17mJPxSVQPRBk9XN4hzaX9UAXur4D92jmaXZa9uwF0kZN+GTd5mm1wReirDi2foLiZWsT6mCmN95/IG+PM2+plBvWzuHnn59NBlEqdimK9WkFrRqnZ0kIrR3J2GwnV0Njb8kgirjbHi35p8O/Hd7myO7ob/KuqaQA9wBthfh7l1cmoqUM1XnMwJap5/ur5SlF5KOYqXeuR0KrgRpKydE/8z8stqU4bjF9tqUoWviiiXmGM4N3sZ6t4nSPLPS3QyIxPPZwp+S5cNAU36ai0dQRaefGbaKQ3fBzCKGiHfFjLgioyps0XeYK9AZV/qtf4CD8ZNxV9Lpyle03sW17bNWfrXlqd2rqzJm4Prk40Wg2N2VcNA+QyNoWiYXLrTAxsryejS0D94WzXETJGnPCTFyn+tjDMkiDqAxhLdT8Dg7lOG8F/sVX3Zk6I6DN2mtXkIv2ZDituIb5s5gxE6joH1/rVgBCSFzpJEDgmXuw1zkAjPk/yD/MEOetuYham2gYZx164MocphKk47UGjdneWs6e18KrOGcsjpN3Z574jIhVPjttb2tn8/vGAKbaneMS7E9+OUAOtbd7B/C9KjzO9ZkHRFngQuHFOvysgHjp8GKI6Kbw9pb0urFijr/Dvm+T3Cg1spNKt4hc4UrM5k5NidVjluEvRhIm6PmfA2vmxz5gE5ATe0FHgdTRyyY/4EgkoSzD7soFmKNXQHmo3i6rIUlCvDYqFI2V1z2iP99JCpdt507VB35m7D6kUNuQxnGdMDSfQ5++uFrIuvDP7T3oPQKjVvj52IJKSYo0uXQ3xcbWtIA6NaGqK3 UuvxOwaa pILlT6oisY0q3nwCudHoYtiXzMsJCBqCU7TJ9YYildr72TnL9YZm5GUjxIpQDsdrpHV24hsTVZYhNggr1BGMV9XqjhNs08tPipnUIP2pFnF/RM/nBbnO8BNpdvn43Lrc5+IG+96wnBVzKuDTP2FCthIJTCClC+XZMYfwIyj3spYabmsAxGEZbxNTxlICWm4InxiEBoNAPJbQj5Y8Z6JuGF7Jxz695BMNZ1MAUd07TpF9CxIzUdwkg3G6D2HOtaaR1I80XOxVQlU66/PHHN/JA7xHtTwpp8EfkFyUX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On May 20, 2025, at 19:27, Harry Yoo wrote: > > On Tue, Apr 15, 2025 at 10:45:31AM +0800, Muchun Song wrote: >> Pagecache pages are charged at allocation time and hold a reference >> to the original memory cgroup until reclaimed. Depending on memory >> pressure, page sharing patterns between different cgroups and cgroup >> creation/destruction rates, many dying memory cgroups can be pinned >> by pagecache pages, reducing page reclaim efficiency and wasting >> memory. Converting LRU folios and most other raw memory cgroup pins >> to the object cgroup direction can fix this long-living problem. >> >> Finally, folio->memcg_data of LRU folios and kmem folios will always >> point to an object cgroup pointer. The folio->memcg_data of slab >> folios will point to an vector of object cgroups. >> >> Signed-off-by: Muchun Song >> --- >> include/linux/memcontrol.h | 78 +++++-------- >> mm/huge_memory.c | 33 ++++++ >> mm/memcontrol-v1.c | 15 ++- >> mm/memcontrol.c | 228 +++++++++++++++++++++++++------------ >> 4 files changed, 222 insertions(+), 132 deletions(-) > > [...] > >> +static void lruvec_reparent_lru(struct lruvec *src, struct lruvec *dst, >> + enum lru_list lru) >> +{ >> + int zid; >> + struct mem_cgroup_per_node *mz_src, *mz_dst; >> + >> + mz_src = container_of(src, struct mem_cgroup_per_node, lruvec); >> + mz_dst = container_of(dst, struct mem_cgroup_per_node, lruvec); >> + >> + if (lru != LRU_UNEVICTABLE) >> + list_splice_tail_init(&src->lists[lru], &dst->lists[lru]); >> + >> + for (zid = 0; zid < MAX_NR_ZONES; zid++) { >> + mz_dst->lru_zone_size[zid][lru] += mz_src->lru_zone_size[zid][lru]; >> + mz_src->lru_zone_size[zid][lru] = 0; >> + } >> +} > > I think this function should also update memcg and lruvec stats of > parent memcg? Or is it intentional? Hi Harry, No. Do not need. Because the statistics are accounted hierarchically. Thanks. > > -- > Cheers, > Harry / Hyeonggon