From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92F49C83F1A for ; Fri, 11 Jul 2025 11:47:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 340F06B00AB; Fri, 11 Jul 2025 07:47:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CA736B00AC; Fri, 11 Jul 2025 07:47:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16B116B00AD; Fri, 11 Jul 2025 07:47:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 03A936B00AB for ; Fri, 11 Jul 2025 07:47:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A6DC912DB1C for ; Fri, 11 Jul 2025 11:47:51 +0000 (UTC) X-FDA: 83651809542.07.4BC3DC0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 1F2AFC0010 for ; Fri, 11 Jul 2025 11:47:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f4T6AdP0; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752234469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z08Gbg8lHqpscUl1/iAogzg3iZSbLo4ofQx8HgtMHOs=; b=iwuthiPgWICqLYovHzaKTt7QJ94DQuAdWYerKntsLggzb5tJSIPYCFHqk3SaQV4PzmJDSS R+UC2CduIDNWucPwJk0gKLrtA2ZZVgqDiHWgHHTU7FQuxwki6H4vhpCiNFtH7c99cKq+NA vSvDiX8yud+UhmYEY1IQmU8Cd3M0ENA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f4T6AdP0; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752234469; a=rsa-sha256; cv=none; b=zCG9paVl/NpMgFkRDMNMZIlkS2VOqWfUeGP2CXpyAOkSI10UA++gay4HHMnrydliWwBRu0 sUtCS7xH1GejgXF0g/0PLcpYl819Z5L1ZWXHG+BCs1+KYskw8KxjaWbLYwGXubmR1G02tF BGXPomXWYnTDRSGrh67oo57qWsJREXE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752234468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=z08Gbg8lHqpscUl1/iAogzg3iZSbLo4ofQx8HgtMHOs=; b=f4T6AdP0ovozBgiKYG2fUnu1BYx9UUh52Yf1d1a1s9pAxdfbnrWFR86hhQVueOkTr8r7ll HB44QWS31yhdClwg0YRHTmB3Q/DwDzl/z4mPf7Djf1gcW2jM6gYpfdbrupsj/1nxaefEj6 KTaecixzFoXCLOcAEB5+21k0RicU25A= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-PxTIQBOSPUCUup_eDJYQgg-1; Fri, 11 Jul 2025 07:47:47 -0400 X-MC-Unique: PxTIQBOSPUCUup_eDJYQgg-1 X-Mimecast-MFC-AGG-ID: PxTIQBOSPUCUup_eDJYQgg_1752234466 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450d244bfabso16732725e9.0 for ; Fri, 11 Jul 2025 04:47:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752234466; x=1752839266; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=z08Gbg8lHqpscUl1/iAogzg3iZSbLo4ofQx8HgtMHOs=; b=AEETwd1Pw+R2uHDgXGGbtx7aF3ZAWIJd8EeReCwqlZ4NlyzRtzUWW6qSvRTjXaVTwE hSZN7kXbOEYliyWMCDw1JFmtn7MxCSxaG4K0UAVbaAPguG6L/LShnBqB8f/7u9UK4D7R 1MB16em+fk8Antsa555uxYWbCS/3onw3DlL1nIcIm4cHCd5LYFsBZ6EV4iXtC7LJxhfO lcQXteMQw/8PeXimfVQvvsUhcV9rJFBAPfVBeo+lcOnokPLOWlEM4/eT1qHNqkxnT+iA nU0qMTmfEgvI1+t67Vik8bnwxx9TqhcGiHau09hudJ/yew/RLz6I3ravTEqxEytjfxo4 sRwQ== X-Forwarded-Encrypted: i=1; AJvYcCVF+XCjENou2Muh4pf9Uy3LQgVmtr2MkiPCndAzAVrHFEpglzMPMQSgdHPSRCeiU7ENFAkJTC4idQ==@kvack.org X-Gm-Message-State: AOJu0Ywkc/qU9opABY91pV5oXnBbX3XFkE1GzXeOwTBBV+vIukH5iXAe hJkeCMLN/g5g0/a7OQp9V21l4YqVKgYpxN6Y47p3y6jNnE4nxAvikb2yWm194gq4M88ZkAFTz+G TZTVu4wDAxXi2D+Rzjp+/1mGlWQko3M8T/+qnXBB0Csbn7xlEsPyGf6PPyy9kj6k= X-Gm-Gg: ASbGncvD7HsAcSqxkwp2zTltRppojBod96rnXNwVVqOgP1DqxDSGFUJ1m2WqN1BZxfE /WYYIo+yecjPk3YWMTAOeksI9OUP104pfOGbAa8eN6xvMDnngNCsvxMRDtLiY+APBIpVIp3GJ9m ZRga3uAIsSNRr55fMjORUmYu0N5ghbDHLT7izhP+YQM6Q/i9PR7ESRWsNlYFzuERdCG/ucP1BfR 7yY4KsMRxI2N4l0mZMCfsDOEOJAF3vHjtuGf8wsdX2tnoA0ry0CapnBAD1RnysfjyFpecnk7yyu CONcZqu6lCQba/9EBP47VYMiHn4uA1CMylaud8Y1wuBHkoOr1JikVpGKTi/9bToTBVhwzzeMWFy ik3QfL5k1uKGo+sbisJLwuZjz62wtOk5TqnRqVcYf1CwOVRlUFDR4EswlRj2DE2WYg2c= X-Received: by 2002:a05:600c:474c:b0:43d:878c:7c40 with SMTP id 5b1f17b1804b1-454ec12744cmr30550195e9.10.1752234466058; Fri, 11 Jul 2025 04:47:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEi3R3bNrLa+24gylSjT157lm4D7L1IJX001V+RG3F77sHY/3q4HFovSzv9MSWIahtebYUIBA== X-Received: by 2002:a05:600c:474c:b0:43d:878c:7c40 with SMTP id 5b1f17b1804b1-454ec12744cmr30549735e9.10.1752234465456; Fri, 11 Jul 2025 04:47:45 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8bd1a15sm4192005f8f.6.2025.07.11.04.47.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 04:47:44 -0700 (PDT) Message-ID: <377d74d6-a7f9-4e94-9276-168a26d49210@redhat.com> Date: Fri, 11 Jul 2025 13:47:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 10/14] x86/mm: Simplify clear_page_* To: Ankur Arora , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Cc: akpm@linux-foundation.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, mjguzik@gmail.com, luto@kernel.org, peterz@infradead.org, acme@kernel.org, namhyung@kernel.org, tglx@linutronix.de, willy@infradead.org, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com References: <20250710005926.1159009-1-ankur.a.arora@oracle.com> <20250710005926.1159009-11-ankur.a.arora@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250710005926.1159009-11-ankur.a.arora@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pBFUpTuY1P58qom9QdUBHf6VcBEQtU3vh_a0jy_PxvU_1752234466 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1F2AFC0010 X-Stat-Signature: bbhzi4nfjbr6b88q5ak4j7qqnu4eoiit X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752234468-674250 X-HE-Meta: U2FsdGVkX1/fCP5lITCtQSfdvMjAbdTK4VF9GS3jNoNm8O39/lo45NrvzQHojvKjf6ztNbNKuaIddla7t22wn7KNPn6gP7JlGXfBpE3cqO3TCNzqC6uwb06psc+J+9F9sJC/S5AhJpuBaE8MQpb2gesZT7GyOGXZmCWU2CbjDf02UjEpiSnFDbG5QLCZ0J+czjL0l8ad/WDmPhIGad2Snn3ruLAb09L66uusJm9zQJ1gcYbTZlq1mNhVgADF86C+YQFWSsAe06WOcJRj2WP0UQYOVZCn+f+YsLEib7bgtt4iH4RI/sqvaAA4h7Araaerj7HrZ2yQn2WuI259nSwdzmiXyLrbMWSf3ezkB3biFS+q+A05aSul6ktOscB6WmxzgVEkHWvcXU8pKOP3HupTrHB7L5uiiRR3s8GbRFW/wPVqDDZDHg8blBuLRT3NK74qRHAiTIh5EAzaK5MTqJIJ1vRDaJlYQQNjTdoV+gzarSVd/pJvNA/JkZtQVeMzVPQ+Pj0FS6JTIHVM5U7jyvMlnsGdn1e+ypP0b9PpRqa11zn3oBq/bLqPemrIY0RMhARS594d4sQJfIs/qqlGuksH3tB2T68RhJ7Cdto0k+VeclYJmRifuBICKnD/Ikbr1NVW0p9T2gL6lRu5fx3mVCU6RXCroSpfpeCmGQyvT0jU53bkb/3s5BPxCnNLE9ZJtXbNqCeulChR8aIu+kt1hNV6DLeg9EiN5q55R0QGRnedac15WFEGyG+02/OGfc6ycKXKtBBgJRd/V2v8ORszGnbelIusO5lwhhjrCwcGTLUzgUyxZqdsS9w7vxJgk/oOBkq9x1zvoMZIIhJKNNmnKKilUNUjiNdI7crPTEWZ6P3mP/bV27AQ5tTihFl1JVABr6hWz70zWdEGQOMEYEIb9E75aKlPpWjvxVfYdTAxj2SFS4J38GcwoJrxsW93bFOa7j059i1K/HIZlK6ParC97W7 fHiGjl4U +flz04uZHCGkfXWhg8iz4PTFV49g5FKNYjShhrORQWlBR2I5RQdsD1QGZvv4WHGnyTpNizzHkCm6JI/+dSeQqAxoui39IbgnkhMisHUFEQEmqiodHl7cc0larQZ15FeNQSsSZLYat36FIA1xl6npPZs8H50yRNS3EXJ9EQVDK8pJOzgbdxt84rtHTBwgm5iXy+GrmXAXX7wIcEHyFuD64bXTmbsFNMgOlqtPfc4kQW3T5FNVaW0o+YGictvrLi4iM5tCw6qj7W0hS2hDxiZEVvvpTAk4z7XGjylHHkSUwe6Hi/1toEAb1YzZRtHFYY/5y/osbCbyE3otmCjPFSuhtVJLvm/jWYEiLrsOB1tbkiISoETXfa+c/8/pJsQFK/WpL6GgWxMdrhU3UwRvfbtOswmfhHiz3Um4dL2FgY9uYSxH2ur8LKDgqM3sRjLLbko1WcYcE7+Eg+BdcK5QsLOoUJqT7TODcplFkh/dM2Ar+mTzfrrSZrssUNUcrxPE2GndkTjJrdIS8OH0JtiIH2Yg+20ALNhCohMYXxv82 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.07.25 02:59, Ankur Arora wrote: > clear_page_rep() and clear_page_erms() are wrappers around "REP; STOS" > variations. Inlining gets rid of an unnecessary CALL/RET (which isn't > free when using RETHUNK speculative execution mitigations.) > Fixup and rename clear_page_orig() to adapt to the changed calling > convention. > > And, add a comment from Dave Hansen detailing various clearing mechanisms > used in clear_page(). > > Signed-off-by: Ankur Arora > --- > arch/x86/include/asm/page_32.h | 6 +++++ > arch/x86/include/asm/page_64.h | 42 ++++++++++++++++++++++++++-------- > arch/x86/lib/clear_page_64.S | 39 +++++++------------------------ > 3 files changed, 46 insertions(+), 41 deletions(-) > > diff --git a/arch/x86/include/asm/page_32.h b/arch/x86/include/asm/page_32.h > index 0c623706cb7e..a8ff43bb9652 100644 > --- a/arch/x86/include/asm/page_32.h > +++ b/arch/x86/include/asm/page_32.h > @@ -17,6 +17,12 @@ extern unsigned long __phys_addr(unsigned long); > > #include > > +/* /** if this was supposed to be kernel doc (which it looks like it is) > + * clear_page() - clear kernel page. "clear a kernel page" Although I am not sure what a "kernel page" is. Did you mean "clear a page using a kernel virtual address" ? (we have a handful of "kernel page" usages, where we talk about non-user space allocations) > + * @page: address of kernel page > + * > + * Does absolutely no exception handling. > + */ > static inline void clear_page(void *page) > { > memset(page, 0, PAGE_SIZE); > diff --git a/arch/x86/include/asm/page_64.h b/arch/x86/include/asm/page_64.h > index 015d23f3e01f..28b9adbc5f00 100644 > --- a/arch/x86/include/asm/page_64.h > +++ b/arch/x86/include/asm/page_64.h > @@ -40,23 +40,45 @@ extern unsigned long __phys_addr_symbol(unsigned long); > > #define __phys_reloc_hide(x) (x) > > -void clear_page_orig(void *page); > -void clear_page_rep(void *page); > -void clear_page_erms(void *page); > +void memzero_page_aligned_unrolled(void *addr, u64 len); > > +/* > + * clear_page() - clear kernel page.> + * @page: address of kernel page Same comment as above. -- Cheers, David / dhildenb