From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E30C433EF for ; Fri, 11 Mar 2022 09:56:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60FA68D0002; Fri, 11 Mar 2022 04:56:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5983C8D0001; Fri, 11 Mar 2022 04:56:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 438E58D0002; Fri, 11 Mar 2022 04:56:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 34D0B8D0001 for ; Fri, 11 Mar 2022 04:56:34 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DCCA1181CA772 for ; Fri, 11 Mar 2022 09:56:33 +0000 (UTC) X-FDA: 79231650666.25.5942D77 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id F04C62001B for ; Fri, 11 Mar 2022 09:56:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646992592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5BzQ5znBqP745RuD+dwW1ikgl/12q0xJiq/I2QyjkhY=; b=dVeg8XUH6W3xfl7IOUCcYf0PXNIWqjPKaLLy9KtLUhsRclE1aBJ4KZphMb8cWydus2qwQZ b5hcJSDzGZOO2pHxqPVb6WNWw8hMCBvpRJ0uDyjgVe8p+2fbjvRv3prF4dPHO90vgZHnCc V6ZimFdVgUvGdtt2MtW8rqaTHGmOwXI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-yDaAjK8dNaCj0sDGm3ztwg-1; Fri, 11 Mar 2022 04:56:31 -0500 X-MC-Unique: yDaAjK8dNaCj0sDGm3ztwg-1 Received: by mail-wr1-f69.google.com with SMTP id n4-20020a5d4844000000b001f1ed76e943so2633993wrs.22 for ; Fri, 11 Mar 2022 01:56:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=5BzQ5znBqP745RuD+dwW1ikgl/12q0xJiq/I2QyjkhY=; b=DojYGgMqrTlOGZUOj5+9nopxFb7ezsPJEpF0ghrMvVTiL9GU1ZhtChD8dXXKTHq5Km 8eZsHeoU6EJAztSJJPQdFOAXRSADvKzYvLO/YZeZNhZoW/Du83NxL/9L0ahPYKG2uMR3 J9AlpzVO/mokXi+CnuhLBG1HqDXG4hO9qi5j7my6mkYzO5iyYvvmVFN2ZNAB16/dgWFG vXjmmp5f5yClljTmeq8XJmRg6TpYytC7gXVcuqisi0vSn/dtkyumiCjq3bLHMZ+y/1xM szmQBgsBRRfA8zPA+EQkwJ2mXmBvzz0YeGIpknL7zdVB8Igz+Y8uZCCPRHrHPphbwh7G BluA== X-Gm-Message-State: AOAM532bR2gKy/N9iOUj04eBjoE0SpCnxEmTZCrS5+JRpoSmwPofiMv2 nkhMwI2zoDy6eYjrmbycjZB/IndMDYD084A/L611XUTL9Y+K9Wn1eOvEzfzFd0N5LUsJLYLfb1f B9L9Vl9UGaBw= X-Received: by 2002:a05:600c:4f86:b0:389:d5bf:a7f3 with SMTP id n6-20020a05600c4f8600b00389d5bfa7f3mr7055370wmq.49.1646992590130; Fri, 11 Mar 2022 01:56:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJxB5lHprBaxk2MYtTTjae6wI4Ju7wraprW3RrIO7aIylwfdcaT6j/CZz37ZLt5rzZ5idDRiRQ== X-Received: by 2002:a05:600c:4f86:b0:389:d5bf:a7f3 with SMTP id n6-20020a05600c4f8600b00389d5bfa7f3mr7055355wmq.49.1646992589847; Fri, 11 Mar 2022 01:56:29 -0800 (PST) Received: from ?IPV6:2003:cb:c707:8200:163d:7a08:6e61:87a5? (p200300cbc7078200163d7a086e6187a5.dip0.t-ipconnect.de. [2003:cb:c707:8200:163d:7a08:6e61:87a5]) by smtp.gmail.com with ESMTPSA id g17-20020adff411000000b001f03426827csm6257696wro.71.2022.03.11.01.56.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Mar 2022 01:56:29 -0800 (PST) Message-ID: <377bc77d-a9b7-1622-c77d-df6533959804@redhat.com> Date: Fri, 11 Mar 2022 10:56:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] mm/huge_memory: remove unneeded local variable follflags To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220310131253.30970-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220310131253.30970-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F04C62001B X-Stat-Signature: 35kpfudgm1okkeub58u91fphfyrc5qj8 X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dVeg8XUH; spf=none (imf13.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1646992592-255355 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.03.22 14:12, Miaohe Lin wrote: > We can pass FOLL_GET | FOLL_DUMP to follow_page directly to simplify > the code a bit. > > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 3557aabe86fe..418d077da246 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2838,7 +2838,6 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start, > */ > for (addr = vaddr_start; addr < vaddr_end; addr += PAGE_SIZE) { > struct vm_area_struct *vma = find_vma(mm, addr); > - unsigned int follflags; > struct page *page; > > if (!vma || addr < vma->vm_start) > @@ -2851,8 +2850,7 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start, > } > > /* FOLL_DUMP to ignore special (like zero) pages */ > - follflags = FOLL_GET | FOLL_DUMP; > - page = follow_page(vma, addr, follflags); > + page = follow_page(vma, addr, FOLL_GET | FOLL_DUMP); > > if (IS_ERR(page)) > continue; Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb