From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 191F7E77188 for ; Fri, 20 Dec 2024 16:04:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 878A16B00A5; Fri, 20 Dec 2024 11:04:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 828326B00A6; Fri, 20 Dec 2024 11:04:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A1DA6B00A7; Fri, 20 Dec 2024 11:04:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4AEBB6B00A5 for ; Fri, 20 Dec 2024 11:04:52 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EB217140B96 for ; Fri, 20 Dec 2024 16:04:51 +0000 (UTC) X-FDA: 82915809816.12.F39D86B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 42419160021 for ; Fri, 20 Dec 2024 16:04:26 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Gag1/0IL"; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734710657; a=rsa-sha256; cv=none; b=v8z7qwKand4/rLAUqcJrzsFjkKvs8HHfv/gzWMiIBKXrwQbhHEriOGxqlZy4o5gHzuB9Lm eTlDeD7c5CP01KsLiV2M8//IcEm5cL9ktYArFR/MhjJh+rvVrfWu5d1ceANx5xZOpOjI1O SKVyvs7EMZG4vafzsj1S1oXnfVsM/ik= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Gag1/0IL"; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734710657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uye7DAVoGcFBMUflUX2b6O3iwK3FObB0wIlT13ADd1M=; b=pjOWnWfrDw1bvzW6Kq9AVoM2hdTSEWWZwSYE+M8brSRONHugM5TkIoC+g0PrzXmErVp1OA StiX8hy6gGxSfPEcs7GO7WGpZxdyOMAMkCRxqhiiFN9h2HHnwTd55qxL2ABgcvzWGGPgSr rYg/N6BG+paIlmKLKoPAbxlFjeNk6/k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734710688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Uye7DAVoGcFBMUflUX2b6O3iwK3FObB0wIlT13ADd1M=; b=Gag1/0ILwf3HIfM/kthmwmT9wau7BuDLkfDVsi3JI0pMEihpxHTYhb+U0EZbtTo0tUDkU8 VUexZ8eR/ykOF1w9iF24YIpK1x+UFW3L/IxpSl1XeQACIXauSWABqQtBsi4dJyUb2fxm2p PJ3rLvPheAn713WeJ0frA/2AUuWcfY0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-336-Qu0C0emSPT2_haoFCdE0xg-1; Fri, 20 Dec 2024 11:04:46 -0500 X-MC-Unique: Qu0C0emSPT2_haoFCdE0xg-1 X-Mimecast-MFC-AGG-ID: Qu0C0emSPT2_haoFCdE0xg Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-436379713baso11400955e9.2 for ; Fri, 20 Dec 2024 08:04:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734710685; x=1735315485; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Uye7DAVoGcFBMUflUX2b6O3iwK3FObB0wIlT13ADd1M=; b=O/q9xnTsGkatURe8MKdx/el2LqIAu8gJWMtHrVK28uKtfxgxO/cCShJE/+rCw/ELDR EIKNKqg9E6c6wfUrlwgX5pwOh43gRBh8+mh6LKH9MFhUJsILsP+A/C8yCjZX/kUnxIEj C5cfdAubsCLYG1t7rJAeJPRIKFoEMxxNHLrRMjySn0qij6vILQQSGaWWG6QdL7uAvE7I z8yVe7VLSd+mp3hK26X+aHH9j5kvXjVpKbns4QYhz9YkrRPOwIw4fxrcseCco3ZJCr+a DDq51e1FyL7WszGJL6biYhBYbjjbNSCQyRXh9AYR5bB8Za0TbJ+G2pO8dYKQRCo3fdIq W/kg== X-Forwarded-Encrypted: i=1; AJvYcCX3wr+RflxxQNpN45U+xWe4VVcDzZrRdbCpcwUY7hI/TyJyA5FilUrH/6L9vcqvgnAHhAVXYOjCXg==@kvack.org X-Gm-Message-State: AOJu0YwZm+ABrD/VXzJoGJnQSide4cFVXq0qGUBMbCAeFYinyLD1nka5 dowqK/rWzD4Oghf1PFDbglKIxkl7Jkg+DZNexKuCA05pTwzhpglERQDP4JlVYtklgMGBqNgbIrs cVmdP3bhG2M0N0N2aKTtV3VYdEgA4kGuIDmnQXPa9SmOGULA4 X-Gm-Gg: ASbGncuUmfF1p953OSrc33Z2hXHt+ZWCKyNe+g96JSdA5ulaxKoxo2V4837chEtGdrQ 9IbFeZsu9oAxP02JO0aIQ2lrtnNqdVwKnlMzgr6KVEHU2IcQSaK00b66fArcHMKfZ5nhHGMqHrZ eqTYfvUOj3XwhHGCOapcMyCf2cm4x936E+2UWLtr02/OPOYXBuSr3IPzVXkDig2ktaN7Vl4cESJ fWlE6R+dHJlVii6yrXICF80wLHnRrKI+yrxyx5aOQYLiYPtdkXZrk4qrS+Hb+wCl/PaH+dk3EZo VgqI9ZeSrGAZsOXjec6YT/FXwKhbI9V1plidEi/nK3VByhktIpTm4iPdH1ktrG17j8doBF2cCyB sW2BYkrLT X-Received: by 2002:a05:600c:310d:b0:434:e2ea:fc94 with SMTP id 5b1f17b1804b1-436686431ebmr28581295e9.11.1734710685473; Fri, 20 Dec 2024 08:04:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEaD7Ieltgr6XajQdNmlR1ijh4e9DHaJxPAWMu/QU1Z67SPl8Xv4crlgMZDxPsS6QwBbotDAg== X-Received: by 2002:a05:600c:310d:b0:434:e2ea:fc94 with SMTP id 5b1f17b1804b1-436686431ebmr28580855e9.11.1734710684975; Fri, 20 Dec 2024 08:04:44 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436611ea47asm49066465e9.4.2024.12.20.08.04.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 08:04:44 -0800 (PST) Message-ID: <3775fe9c-460e-4b31-9d5c-068a1f685513@redhat.com> Date: Fri, 20 Dec 2024 17:04:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: add build-time option to set hotplug default type To: Gregory Price , linux-mm@kvack.org Cc: linux-kernel@kvack.org, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org References: <20241220144518.206208-1-gourry@gourry.net> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241220144518.206208-1-gourry@gourry.net> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: n3_Rv1-9YHn581dIQVD752tE2Ut1z3fQNF3zIzUMu0k_1734710686 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 42419160021 X-Stat-Signature: 3em59gbrimcmduaog9sqn56kou65gptw X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1734710666-550317 X-HE-Meta: U2FsdGVkX19wwPfKzP0H2OnRxB3F4s8Zxp043vvLhxSYBobui2OjG6arKFaGPW2ufF03GedmKZVLLfJy8dydppgaIgLSwqOuHoGn2LxyrmP0uz5w/vXSN6pPIYdTSBkH4oFK87JyHLK+c6Unu5i2mWWatOi1JpB/klUANF60+YHg/Bk3pj3coyDw0HFK5QHXcSVccMkjPWzj7rTJjDk+eTY40TnkGQ2HqkQluHOsljIqaRVUNibHC+35TNjr4F6P8OKDoibTfJzQzpt7j/BkOAuluYk11hldTHbs1yjud1Qp4aHdHvsObuF4y9Wy9dyvUgS7qV50pmZl7mZgy3sdXVvNnU/Gh8TLKltyJAEY3mHVMylm+MYlFLfhR3QnjsH4ZB5yPJ34AsutSR+9h4+E2+0fqflZy9Aav2nu0dJkGC8HZyYSuZWgQC4RSul82D/z64/hlRAWM/uXgBIwwZWtBY9MD2xjVKYWVs+KJ2cDgsvmxhsDnKTcWcuEBuOjOgFZAsCQ9/8lJiZ+4S8ZtqJ+cozM/2WHWGm60nVvRm3jiJErJh1dlQHqhSKD8UjCwcAASnpZRzLAZ0A8A/WaGuKcb7GXTa71ZBq/Ror41fqW2XJG2qTQ2mbn5oN5cUFi3KcEmton0NLVf3hNuHgvndrdOl5aLa8K4oukGmd27KfwaPaya07bLc8WCMl0hxwCfPIE7rVQrsHs+nlzlE/1pSfb2C/fcDkqSGKTgEmw/9se41MKYYT3LtHD8IoAJHfTbg+Xf95AhI6KRVhKcYWZT9m19tPerrwBmcOcan2sPA1KRPyjCcb84zL5HPk9FRlqpvr/MVgiVTcEjWPuGHucHiWAe1wlRi/W8iEp2UU2z2ZiJlS+mnw44DHb9XfqN4JKo/WPVOkeRxV2vHVVBViLY4nKIFuv1/K1S0mFO4aej0I9UrIF4Kg81bLT+ue6t33qjnNnXWxKBjb6YU5or780Ncs z5d9Lubc QV7qZDRU//sasey9p9yvIyTUMjeCWa62fFBdcJ6TH/iBk7AOcLx4b64hh74pLhBtHAljGcxALWzWhwRgTRuZf4SdmVITv1eXkoq9KDaKSS7IByidAerHsGQ9dBbQQBtciZzbx0l+IZK0gSElC2Bl/MagHkbXPIVuQV6uafcMM7HVtFm2Okm9ZDE5pOybjunPtsnw5drcgdD2JEQFRAWTC1JVoL33JHVRpDaJuJrfl914yy76LA4VpkwbuXXoucJ6Syl6Ihe9yQOtOnHU525jC4iT7RhwnanOND7O8entsfRZU3/QL2wmSfWNfPCcar4vKX+QhPR850bdQdUKQOxvtp3EIdCisdVWa/RRAy0lC5k1MFw9tlZXzJiPLzLoOWEv+WbyWj/J2alY836jUAW/gOXWXee2fZ+e58G2Flmz8VhlS7JS4g04qI4CYeregZv9kCYQp+21MY0etgxQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.12.24 15:45, Gregory Price wrote: > When memory hotplug auto-online is enabled, hotplug memory blocks are > onlined into ZONE_NORMAL by default. The `memhp_default_state` boot > param allows runtime configuration, but no build-time config exists. > > Add a build-time configuration option to change default hotplug zone. > > build config: > MEMHP_DEFAULT_TYPE > > Selections: > MEMHP_DEFAULT_TYPE_NORMAL => mhp_default_online_type = "online" > MEMHP_DEFAULT_TYPE_MOVABLE => mhp_default_online_type = "online_movable" > > When MEMORY_HOTPLUG_DEFAULT_ONLINE is disabled, MEMHP_DEFAULT_TYPE is > set to "offline" to match the current system behavior. > > ZONE_NORMAL still remains the default, because for systems with a large > amount of hotplug memory, defaulting it to ZONE_MOVABLE may result in > portions failing to online if sufficient ZONE_NORMAL memory does not > exist to describe it. > > Signed-off-by: Gregory Price > --- > drivers/base/memory.c | 4 ++-- > include/linux/memory_hotplug.h | 5 +++-- > mm/Kconfig | 33 +++++++++++++++++++++++++++++++++ > mm/memory_hotplug.c | 29 ++++++++++++++++++++++------- > 4 files changed, 60 insertions(+), 11 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 67858eeb92ed..6f69b01abe51 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -512,7 +512,7 @@ static ssize_t auto_online_blocks_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > return sysfs_emit(buf, "%s\n", > - online_type_to_str[mhp_default_online_type]); > + online_type_to_str[memhp_default_type()]); > } > > static ssize_t auto_online_blocks_store(struct device *dev, > @@ -524,7 +524,7 @@ static ssize_t auto_online_blocks_store(struct device *dev, > if (online_type < 0) > return -EINVAL; > > - mhp_default_online_type = online_type; > + memhp_set_default_type(online_type); > return count; > } > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index b27ddce5d324..a43470f0d93c 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -144,8 +144,6 @@ extern u64 max_mem_size; > > extern int mhp_online_type_from_str(const char *str); > > -/* Default online_type (MMOP_*) when new memory blocks are added. */ > -extern int mhp_default_online_type; > /* If movable_node boot option specified */ > extern bool movable_node_enabled; > static inline bool movable_node_is_enabled(void) > @@ -303,6 +301,9 @@ static inline void __remove_memory(u64 start, u64 size) {} > #endif /* CONFIG_MEMORY_HOTREMOVE */ > > #ifdef CONFIG_MEMORY_HOTPLUG > +/* Default online_type (MMOP_*) when new memory blocks are added. */ > +extern int memhp_default_type(void); > +extern void memhp_set_default_type(int online_type); Please call these "default_online_type". Further keep the "mhp" terminology, it's more commonly used. We cannot rename the "memhp_default_state" parameter name unfortunately. > extern void __ref free_area_init_core_hotplug(struct pglist_data *pgdat); > extern int __add_memory(int nid, u64 start, u64 size, mhp_t mhp_flags); > extern int add_memory(int nid, u64 start, u64 size, mhp_t mhp_flags); > diff --git a/mm/Kconfig b/mm/Kconfig > index 7949ab121070..b6e63e5306b1 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -565,6 +565,39 @@ config MEMORY_HOTPLUG_DEFAULT_ONLINE > Say N here if you want the default policy to keep all hot-plugged > memory blocks in 'offline' state. > > +choice > + prompt "Memory Hotplug Default Type" > + depends on MEMORY_HOTPLUG_DEFAULT_ONLINE > + default MEMHP_DEFAULT_TYPE_NORMAL > + help > + Default memory zone for driver managed hotplug memory. > + Select normal to generally allow kernel usage of this memory. > + Select movable to generally disallow kernel usage of this memory. > + Example typical kernel usage would be page structs and page tables. > + > + > +config MEMHP_DEFAULT_TYPE_NORMAL > + bool "Normal" > + help > + Online driver managed hotplug memory into zone normal. > + Select this if you want the kernel to be able to utilize > + this memory for kernel data (e.g. page tables). > + > +config MEMHP_DEFAULT_TYPE_MOVABLE > + bool "Movable" > + help > + Online driver managed hotplug memory into zone movable. > + Select this if you do not want the kernel to be able to > + utilize this memory for kernel data (e.g. page tables). > + > +endchoice > + > +config MEMHP_DEFAULT_TYPE > + string > + default "online" if MEMHP_DEFAULT_TYPE_NORMAL > + default "online_movable" if MEMHP_DEFAULT_TYPE_MOVABLE > + default "offline" > + Could we get rid of CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE and simply have all three types as choices? normal/movable/offline? > config MEMORY_HOTREMOVE > bool "Allow for memory hot remove" > select HAVE_BOOTMEM_INFO_NODE if (X86_64 || PPC64) > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 3b6f93962481..1e4340fa9f07 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -219,11 +219,26 @@ void put_online_mems(void) > > bool movable_node_enabled = false; > > -#ifndef CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE > -int mhp_default_online_type = MMOP_OFFLINE; > -#else > -int mhp_default_online_type = MMOP_ONLINE; > -#endif > +static int mhp_default_online_type = -1; > +int memhp_default_type(void) > +{ > + int type; > + > + if (mhp_default_online_type >= 0) > + return mhp_default_online_type; > + > + type = mhp_online_type_from_str(CONFIG_MEMHP_DEFAULT_TYPE); > + if (type < 0) > + type = MMOP_OFFLINE; How could that ever happen? It's a bit weird that we are parsing strings when we can just decide that at compile-time using IS_ENABLED() etc? Apart from that LGTM. -- Cheers, David / dhildenb