From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC5ECC48BE6 for ; Wed, 16 Jun 2021 06:41:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 718FF613B9 for ; Wed, 16 Jun 2021 06:41:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 718FF613B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C12596B006C; Wed, 16 Jun 2021 02:41:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC1A66B006E; Wed, 16 Jun 2021 02:41:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A14276B0070; Wed, 16 Jun 2021 02:41:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id 6B8FD6B006C for ; Wed, 16 Jun 2021 02:41:27 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F2EC68249980 for ; Wed, 16 Jun 2021 06:41:26 +0000 (UTC) X-FDA: 78258640572.23.C0BDDD0 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2058.outbound.protection.outlook.com [40.107.92.58]) by imf12.hostedemail.com (Postfix) with ESMTP id BD7CC13A for ; Wed, 16 Jun 2021 06:41:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nR2JXm79Zw+166/EAt6GCj+e5AtF2YrYkcCGXv+TqqcqJh0oSOUoqs2ekgLRV6keIpSVepd+uluayg5eF7aLvU6tfOB3Ul8c0N6RuBH1rKiXrupDONmzY+OE5GY9gTgP5jod97RNLKz6ZMmflA8dAyJOeWUEpGd2ajnYBZYwzOicGMPYFwvCnB4em9oL0wh1eOEadVnk1px8k7T+hCNONf/QeILRjuMbUIDDv91OJD3UYvqk+/gfnrYRlBKNjDRyUzZv8Yb7uSjJDpf1gBFGndpWte35UcRFXgDjuX+KJZh1PJiI6s81+qZj8mHArn+hEhRNf1xE/j193aBW2wqhzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YbPAk0OOin0Z4A4OGw3KVg2sg1fttQN/yzQpoHdj3G0=; b=TYGxtVzCfAMx7UChM98imqU0pIG2gzAG06mQYXbVlMcX4WiAHoVINwrKzEarAUQ7MGrHdOdmwMF1Z6K/BAZIytXg0MJkxmLer4PeRaOFMh8stU60NMX1pf6MmCLSrnFuM+gTYcDU4kxUT5ZkUJn36YVWTGSsLOMDrF1UfnDi/iugQtzELs4h7QE2VfujhgezQdDkvcc0fxSU+e/hVzeXMzr8JWFBOFe/eT19r05HbH0oURhrBoReGS3oWgaj2xCgxJg/8Tahlt83L5SWnT+TwDpQkd+xpW+YjpbpqJxbzb8nijyciHvioMIsoLZrXuoMRX2Pz4YaUbnoEkoqDVDXHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=lst.de smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YbPAk0OOin0Z4A4OGw3KVg2sg1fttQN/yzQpoHdj3G0=; b=Xl+Ph59VFp+ll091TxOkyR1FRYDnYOoZ7BdDj8TnjFb2TJpbwJY76yxL9Ht6g5vIBoo0sVjF3Aqv3bhVThQQJEWdKZlMgCtoV2rL9ZKie2MIMjS9oW11ypslC1NsSADt5ga2oO8IWy0C+Hn1VQogouwlDogv/xyUr7/emdrz4P4Selnf6IGniWXPQxPAPUBptMeZ/+gnSQmqqq3Zqc5w9jAu/ZNG9UVKogR5EbPxL0KMjIwTkD0V5T0t6b+JwKPOgnKnKtwQ8bqZ3DY4bitLKEG+pZcplXGTA4/qfXV5UlcmtYuYRfc1l5HbKUrRWEV21vT7HedsksAEB9c5AsYAig== Received: from DS7PR03CA0048.namprd03.prod.outlook.com (2603:10b6:5:3b5::23) by MW3PR12MB4537.namprd12.prod.outlook.com (2603:10b6:303:5b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.15; Wed, 16 Jun 2021 06:41:24 +0000 Received: from DM6NAM11FT005.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b5:cafe::36) by DS7PR03CA0048.outlook.office365.com (2603:10b6:5:3b5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Wed, 16 Jun 2021 06:41:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT005.mail.protection.outlook.com (10.13.172.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4242.16 via Frontend Transport; Wed, 16 Jun 2021 06:41:23 +0000 Received: from nvdebian.localnet (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 16 Jun 2021 06:41:21 +0000 From: Alistair Popple To: kernel test robot CC: "kbuild-all@lists.01.org" , Linux Memory Management List , Christoph Hellwig , Andrew Morton Subject: Re: [linux-next:master 5116/5396] mm/memory.c:710:25: sparse: sparse: cast to non-scalar Date: Wed, 16 Jun 2021 16:41:19 +1000 Message-ID: <3772450.SNKsl09b0z@nvdebian> In-Reply-To: <202105262107.LkxpsZsV-lkp@intel.com> References: <202105262107.LkxpsZsV-lkp@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8628db19-823e-4ed8-1adb-08d93091c21b X-MS-TrafficTypeDiagnostic: MW3PR12MB4537: X-Microsoft-Antispam-PRVS: X-MS-Exchange-Transport-Forked: True X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8aabD4CRHHphcHTAQwvOSLczTPcbKhUtSK2uDSKACciTqJDsNbKcLEGRiiSj+zyK6hDw/R4HzJy86/lttGPkLhKMKUcfX2afjA+C95UN+v+ZV1VnTXce+b9fnPKOKvWPitdDtQ6KyFNuZdx1BONhKXOlXqJWnbxHqZY5mpbrGb6ArHQq50RyI/ZXX2fNVRp8PKKijINYGcGXiMuaHExxi9kNiyX0IxR9BRr+/dU7yF+yd3XVcoIiNAG7yjBeENNvK46Ul3eU9kP+9BEjL6GbQK7vgnzmKfxgZMiCdnsmGqvbC8Lqu7kbDHciem6KYZDO/X+1yoCUtUGSW2oS2jGHKkfHwmEoMpLopL6cJw33wiG4GesjEs1rDzTiNuUKVJs8TzcMtzNbZghtxuMAuwS5i0QYBbqzuDAHPmtY54ZNyfxHnhZ6nJejt2oyeBQIo2SdAOsIRcplV+XWlULLYDYsYtwznndMu9P7w+N77zNZSUGnoESY5yES277UcAHmJMFqVBy9Q30IeOpvYNR1BprmwcHfFEC2bmQ1g34g3yFyr7l0KbWlxy2Nh4kwR4gj9bFWRLpIuwvIjTunAwrvvkhHfVgVraFbAjP8nPU2z0rHBvcOWj0r0acoqv0ayGZAIZNVH4OurM/ygQRu9UldL70qAdjdYKYLwADP6/g5BZifj1uOfSbae3KC59z4FqraduEMVnNm82qvFFzpIE3KAJNubfK3zQJ4Xp+FrS6PliOCxQvZUOBFJBftmvCisfIj3wGiNfS/V7p2bXEkqAUNxfYiSRkeS46pSTqe4MZ4nrgXdsU= X-Forefront-Antispam-Report: CIP:216.228.112.34;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid03.nvidia.com;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(136003)(396003)(36840700001)(46966006)(70586007)(9576002)(36906005)(70206006)(82310400003)(83380400001)(4326008)(86362001)(36860700001)(8936002)(6916009)(966005)(5660300002)(9686003)(33716001)(82740400003)(26005)(47076005)(316002)(8676002)(336012)(426003)(186003)(356005)(54906003)(7636003)(478600001)(2906002)(16526019)(39026012);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2021 06:41:23.2544 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8628db19-823e-4ed8-1adb-08d93091c21b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT005.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4537 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BD7CC13A X-Stat-Signature: ma1wnwgsqodspa4j4y9qejajmj15sgoq Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Xl+Ph59V; dmarc=pass (policy=none) header.from=nvidia.com; spf=none (imf12.hostedemail.com: domain of apopple@nvidia.com has no SPF policy when checking 40.107.92.58) smtp.mailfrom=apopple@nvidia.com X-HE-Tag: 1623825672-714957 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wednesday, 26 May 2021 11:56:13 PM AEST kernel test robot wrote: > sparse warnings: (new ones prefixed by >>) > >> mm/memory.c:710:25: sparse: sparse: cast to non-scalar > >> mm/memory.c:710:25: sparse: sparse: cast from non-scalar These warnings seem strange to me - sparse is warning about the following: struct test test1 = { .x = 0 }, test2; test2 = (struct test) test1; But I don't see what the issue is. Obviously you wouldn't normally write code like this but this is the result of macro expansion. The reason this warning occurs only for Alpha is READ_ONCE has a different implementation there. At this stage I don't think there is a problem with this patch though - it is either an issue with sparse or with the Alpha READ_ONCE implementation. I did have a go at fixing the Alpha implementation but couldn't come up with a way to make sparse happy. It's also worth noting a x86 build encounters the same pair of warnings in other analogous situations. - Alistair > mm/memory.c:1024:17: sparse: sparse: context imbalance in 'copy_pte_range' - different lock contexts for basic block > mm/memory.c:1721:16: sparse: sparse: context imbalance in '__get_locked_pte' - different lock contexts for basic block > mm/memory.c:1770:9: sparse: sparse: context imbalance in 'insert_page' - different lock contexts for basic block > mm/memory.c:2272:17: sparse: sparse: context imbalance in 'remap_pte_range' - different lock contexts for basic block > mm/memory.c:2528:17: sparse: sparse: context imbalance in 'apply_to_pte_range' - unexpected unlock > mm/memory.c:2816:17: sparse: sparse: context imbalance in 'wp_page_copy' - unexpected unlock > mm/memory.c:3162:17: sparse: sparse: context imbalance in 'wp_pfn_shared' - unexpected unlock > mm/memory.c:3225:19: sparse: sparse: context imbalance in 'do_wp_page' - different lock contexts for basic block > mm/memory.c: note: in included file (through include/linux/mm.h, arch/alpha/include/asm/io.h, include/linux/io.h, include/linux/irq.h, ...): > include/linux/pgtable.h:257:16: sparse: sparse: cast to non-scalar > include/linux/pgtable.h:257:16: sparse: sparse: cast from non-scalar > mm/memory.c:4823:5: sparse: sparse: context imbalance in 'follow_invalidate_pte' - different lock contexts for basic block > mm/memory.c:4944:9: sparse: sparse: context imbalance in 'follow_pfn' - unexpected unlock > > vim +710 mm/memory.c > > 702 > 703 static void restore_exclusive_pte(struct vm_area_struct *vma, > 704 struct page *page, unsigned long address, > 705 pte_t *ptep) > 706 { > 707 pte_t pte; > 708 swp_entry_t entry; > 709 > > 710 pte = pte_mkold(mk_pte(page, READ_ONCE(vma->vm_page_prot))); > 711 if (pte_swp_soft_dirty(*ptep)) > 712 pte = pte_mksoft_dirty(pte); > 713 > 714 entry = pte_to_swp_entry(*ptep); > 715 if (pte_swp_uffd_wp(*ptep)) > 716 pte = pte_mkuffd_wp(pte); > 717 else if (is_writable_device_exclusive_entry(entry)) > 718 pte = maybe_mkwrite(pte_mkdirty(pte), vma); > 719 > 720 set_pte_at(vma->vm_mm, address, ptep, pte); > 721 > 722 /* > 723 * No need to take a page reference as one was already > 724 * created when the swap entry was made. > 725 */ > 726 if (PageAnon(page)) > 727 page_add_anon_rmap(page, vma, address, false); > 728 else > 729 /* > 730 * Currently device exclusive access only supports anonymous > 731 * memory so the entry shouldn't point to a filebacked page. > 732 */ > 733 WARN_ON_ONCE(!PageAnon(page)); > 734 > 735 if (vma->vm_flags & VM_LOCKED) > 736 mlock_vma_page(page); > 737 > 738 /* > 739 * No need to invalidate - it was non-present before. However > 740 * secondary CPUs may have mappings that need invalidating. > 741 */ > 742 update_mmu_cache(vma, address, ptep); > 743 } > 744 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >