From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B5AC7618D for ; Tue, 14 Mar 2023 21:16:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 889366B0072; Tue, 14 Mar 2023 17:16:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 838E78E0002; Tue, 14 Mar 2023 17:16:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DA2D8E0001; Tue, 14 Mar 2023 17:16:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 602C36B0072 for ; Tue, 14 Mar 2023 17:16:06 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2D43F40AFD for ; Tue, 14 Mar 2023 21:16:06 +0000 (UTC) X-FDA: 80568761532.13.EECB264 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 2E8911A0008 for ; Tue, 14 Mar 2023 21:16:02 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aJzrJqwN; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678828563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l1S6ZGAmfPeeMbczfA0ranezCsJrkelQbLrqGcFpuM0=; b=QltoG/Dk0MHU18axCu5sgODfxO0oYf1ZzyA18aR3I3GjAtC0/ccDREb6u/n1gT2OP47jhO VxTN91qOQozFLO3olyyW2jH9YeqbW7u9LwvVqQp8yhSv4wG3re0x5iwjmOSbdq80I07UxR +JZE6JE0oxRA+WvpEdm7hW67WeKesCs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aJzrJqwN; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678828563; a=rsa-sha256; cv=none; b=2npfZ5ZbvK7NWnSaVqULpiNr1ANXUBLwwww2FqL1Rx7TPViWa9F1+NJPrvHgo6EN57mos2 KyFvLDk2ggQQ2qmPFYpkdEtX4dVSucllomcMXWhP/v/feu8GOXjNCHc/GnrAf44AaXW+ir M/nRvOO0QBvVIoa7P1S+A2+d3WgpuQ0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678828562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l1S6ZGAmfPeeMbczfA0ranezCsJrkelQbLrqGcFpuM0=; b=aJzrJqwNtRhoWO7W9kbCEbr36GOJdG2Q7TUFq1Pr6Yckkx0ypR5LBRQltLVZZjFyksXLfy AaEWdIWPJtA9seXnBRhUnf55Sf+TvaUOm/6VCUwfFzroPOtY8T29VrGINbVJG4mFzl8onW 4iM5uP2B6g4Bx15jmt+yR4vmEu4TOMM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-410-5WPA3pIjPxuOlksm0f2Vlw-1; Tue, 14 Mar 2023 17:15:59 -0400 X-MC-Unique: 5WPA3pIjPxuOlksm0f2Vlw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 297B71869B6F; Tue, 14 Mar 2023 21:15:58 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 54495400F55; Tue, 14 Mar 2023 21:15:55 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230308165251.2078898-1-dhowells@redhat.com> <20230308165251.2078898-3-dhowells@redhat.com> To: Christoph Hellwig Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Miklos Szeredi , Christoph Hellwig , John Hubbard , linux-unionfs@vger.kernel.org Subject: Re: [PATCH v17 02/14] splice: Make do_splice_to() generic and export it MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3771086.1678828554.1@warthog.procyon.org.uk> Date: Tue, 14 Mar 2023 21:15:54 +0000 Message-ID: <3771087.1678828554@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Stat-Signature: o9axt9nummiz8grbt1pp56anq4frfkcn X-Rspam-User: X-Rspamd-Queue-Id: 2E8911A0008 X-Rspamd-Server: rspam06 X-HE-Tag: 1678828562-436317 X-HE-Meta: U2FsdGVkX1+Rg/Cv7WKHCEDhPGQTjAvrAPfKEwQPfw03AUn16BdNmcbYWU/6ajcavpA8y7PrGB+IBNzJSblQ9O1MM/4gsiLwI3pW28Nbk6TC0pl2qiWcpEMS9Duvt8aCjG0I0sSQ2WgFjkqiQ0u6wtXMc9kQs9nXgitM131VmlioueLECki1fUxLDbTWdtN6hPghptIzzlmNThEXm54oJFFZSrGmN6NZJJhS7/c9k/ruaA9XeT2xC88d+bmWOLBQmPmyD0KMZz0+FkR5qey71ONGKDwoaBOPoB3vuRqU7FvhCgAPEy8GhjhxyHef53ztW05wJRPQQ2kTyosDJ7JDRlfOZzAnrc5ckuq/vCGs0LSrfezwvb2wGstVTOiTTyaqgVKKhuxrRTeunSaUGN8nknsC08lluQIFPUnuYsUuRwQws5RYHjLqNdPZX67U2+wEBIz3g0heH5BFXsG+X+1y5XgugpD77JKVfOolqkxTFFtxMVVzrgFbcWuH57TZS+CfsGYdN1EcU9U0oyPvP/gr2u2ev12O3X6naELw4VSyelbtOEW6FMexLHnYM6tzkin25SYTvKJvGhcuzOBw7PRkA9NbVJZR1WdG/bOggkvwq8aKN0N/jBp2RlAuajjiO/77GBluoAGGXBriNC58WoRzoetJ4Hszl1AruSWsK2PtXg8aMH92IFz8rB7AW8QOzj5ErlKGTKMNLNWFF3kNTnBKUeUcWDCfdvS2qWBa+AGdMR+R2fxXfOQgMYCcuicxlJTFpykuqPYOJHTt0jr7iL2De7koXb9qz60sEkIVjtTGiXw/b6/NvUtqhp7FE32eZXYKl7m4bWKBqicwTeBXcGixyHNo3C4GKlFl6i6TdYDOaafWAiZeSZ+UqHSTus6lVlBrN/IkpP8fXMtTgSdv1iQE399ogPAcLYonGlr3wzaglg8czNCIX0tv9TB1zkGwzO1iS1AeWPUw1jTIO16eyBv Dd+4GWUm ouriIe2hv00FaxcrRVpRC2rj2IFaU6ebXwCugRtF+To+5mfNzU+2H8nyOq3apTuAMgA85m4wGsh/XsC4njOQbNzGypz3V1RurVHCaN0SG+ErqmpPvv7pncZMBjNBmpwL2GwBxmfORp8xIXtsSCconjMMRhQQnqAOGTaWHM8RNW+SIqKs/tU3/mp4wXRxzkxtEO4/fakEidQPxdDweVabJ2d9Zfu+9lrWGWH7sJ83lT+u36Gd3wp5MwS9mORt1dm27/Bx+gRTqnNH+4DkX09BrEms49g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > > -static long do_splice_to(struct file *in, loff_t *ppos, > > - struct pipe_inode_info *pipe, size_t len, > > - unsigned int flags) > > +long vfs_splice_read(struct file *in, loff_t *ppos, > > The (pre-existing) long here is odd given that ->splice_read > returns a ssize_t. This might be a good time to fix that up. There's a while lot of places in splice.c that use long rather than ssize_t. I can produce a separate patch that changes them all, but that should perhaps be separate to this. David