From: "Martin J. Bligh" <mbligh@aracnet.com>
To: William Lee Irwin III <wli@holomorphy.com>, linux-mm@kvack.org
Subject: Re: free_more_memory() calls try_to_free_pages() with a NULL classzone
Date: Wed, 18 Sep 2002 20:11:53 -0700 [thread overview]
Message-ID: <376979708.1032379912@[10.10.2.3]> (raw)
In-Reply-To: <20020919025439.GI28202@holomorphy.com>
> I'm not convinced contig_page_data is supposed to even be defined.
It's not. Thus this:
zone = contig_page_data.node_zonelists[GFP_NOFS&GFP_ZONEMASK].zones[0];
should have been caught at compile time.
The fact that we define it in numa.c is even more amusing.
If you fix what you pointed out, and add the appended, does it
compile?
--- 2.5.36-mm1/mm/numa.c.old 2002-09-18 19:47:11.000000000 -0700
+++ 2.5.36-mm1/mm/numa.c 2002-09-18 19:47:32.000000000 -0700
@@ -11,11 +11,11 @@
int numnodes = 1; /* Initialized for UMA platforms */
+#ifndef CONFIG_DISCONTIGMEM
+
static bootmem_data_t contig_bootmem_data;
pg_data_t contig_page_data = { .bdata = &contig_bootmem_data };
-#ifndef CONFIG_DISCONTIGMEM
-
/*
* This is meant to be invoked by platforms whose physical memory starts
* at a considerably higher value than 0. Examples are Super-H, ARM, m68k.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-09-19 3:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-19 2:54 William Lee Irwin III
2002-09-19 3:11 ` Martin J. Bligh [this message]
2002-09-19 5:07 ` Martin J. Bligh
2002-09-26 8:52 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='376979708.1032379912@[10.10.2.3]' \
--to=mbligh@aracnet.com \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox