From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A072C6FD20 for ; Fri, 24 Mar 2023 16:48:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA44A6B0072; Fri, 24 Mar 2023 12:48:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A547D6B0074; Fri, 24 Mar 2023 12:48:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 942BB6B0075; Fri, 24 Mar 2023 12:48:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 866826B0072 for ; Fri, 24 Mar 2023 12:48:01 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 582241C5EDF for ; Fri, 24 Mar 2023 16:48:01 +0000 (UTC) X-FDA: 80604373962.25.2491837 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id BF48940009 for ; Fri, 24 Mar 2023 16:47:57 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HGHcNS1D; spf=pass (imf07.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679676479; a=rsa-sha256; cv=none; b=OpyPQFz+vOKaMzmsHaQBAoeFxiOiz1+1JW7hgOl1daRApUH749ktUN8vu11ht1GcnBr1m8 vEH4kizLaxgzcCdwpe5fKrGZaNg9IuliFsIU3T/L9ZpkAcRSGK0jUW6PhKN4Sjfsz9BLxD dKJRSzh7QNhYlR2mXRehUV3dC+tRIRE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HGHcNS1D; spf=pass (imf07.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679676479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GYpegQTjs8QE2vMjmbkJrxADGrCfBG31fu1995bYC+o=; b=j8Ksb6oxgFczVwwAgiHk2u8bE+E66MHREZcUX3ypI6ckciX0UjEaf9jfvkR8mdMK6Rniwp gjp3Zq36/3eXP+HvW/m2jTkjPH8vgENT/mAbHKAQkZfqqqUnIoALZqj43Fx42UpP963WKO JFKkAd4pLQWBKHBKzCILeo/nWTD45oQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679676477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GYpegQTjs8QE2vMjmbkJrxADGrCfBG31fu1995bYC+o=; b=HGHcNS1Dio5xrXQIpLD+m2gNCGeElvfnIu896JertH+np74qfhwfrysNgGFkPRyI4bk3Ph +DuxWtrUFQuIIo7GdqIzn+6vJIfYRFd2B31ftFpWZrrHKI2PnZT93GZ4FUBmdLWLbBneRQ Eb05X0sXni7Fqjt2M6HweZL3NWOVRLM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-328-VJ8UMeoZOXiWZHJjI0z7SQ-1; Fri, 24 Mar 2023 12:47:53 -0400 X-MC-Unique: VJ8UMeoZOXiWZHJjI0z7SQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D2344801206; Fri, 24 Mar 2023 16:47:52 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB2EB492C3E; Fri, 24 Mar 2023 16:47:50 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: To: Herbert Xu Cc: dhowells@redhat.com, willy@infradead.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, viro@zeniv.linux.org.uk, hch@infradead.org, axboe@kernel.dk, jlayton@kernel.org, brauner@kernel.org, torvalds@linux-foundation.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-crypto@vger.kernel.org Subject: Re: [RFC PATCH 23/28] algif: Remove hash_sendpage*() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3763054.1679676470.1@warthog.procyon.org.uk> Date: Fri, 24 Mar 2023 16:47:50 +0000 Message-ID: <3763055.1679676470@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Rspam-User: X-Rspamd-Queue-Id: BF48940009 X-Rspamd-Server: rspam01 X-Stat-Signature: ag115djds7qeddiys3335tbbp1ccj71y X-HE-Tag: 1679676477-540210 X-HE-Meta: U2FsdGVkX1+QKK16zHhRKgkBP+9KL/uNqbMIhK/LioQ5s6jLBWvYK/Wlgr02MwPpGAK/cGBz7hh/Du0RaFdUdnwZzHzhvhtpwWzikKNMY6fANbLmKm04ZcAi4wCnsWXRnQnKSzmsM5bgH+trqbKacOFhhFgDwozS3nQOwtC6Vpxk/aiLGerMWebT9tIw/dd1IbXztJs8tpoLcynRrCUq4FQKeVtxSkDtN6xJS4VzN84QkvBBjDW4//Zdv8zF4JCEWRPGg+yixEpremZq7IIyxJSd+q+RKrTyNZTFCDOEI49kIy2FX7/kCQMx0VTQTe8O5Y1g4CcTJUDdOROZnadDVieH8l+dFknVTjSRJcdpv/j0tXB9YTPZe3G5CZ038I/us51ovS/bsQfcwrjLxRWD8gceOBFMibKWwE3NaZ30SCIEx94zR1td/3+G7wmoHYBPbLsNY0tzcdw14FQMGldzFyOPIOj7QknlbKcSD7XCjC0C9F6hwzvxi+VbCmqEiKiz1eXHLlOwcFXOK0w2AcWgXPd66dDc4pLdT1pldy/WERdPYBGfTypBg3rLPpix+Ud234SbE4Iktsvm/h3mlifvBBtvSyWrZNUgq8H9WDgMx2udFgGxgkhSe03FAtHsoTSWzaaGfFXktyGyVXXnY9bfMgIEDCwNv3i9LIx1WJnxLCDDbA0iRckAfNhJ3mDPVroSdqjUaN8bC3uIpQb6Hs+colAHkCSJgZV5RuqZUzAHxJ0ttoOG7xGklzxRxMxUi6xvj1Bdncd76JFnwhkJTJJ9TnV9CM0GM3c5mZVyV7qxUoPSOb36BXzoyBMGKVulCjdSBqWtQkmSaRpfl/Qx2AZTZ+TzptQ7DXCcXNjZ7dWxizOGXUDoVNrONtzM0MJdCejJEPChxt/WeO5wExmqaYPbBGF//8LaUTxbNmH7ZfR/RYjkLdLLo/5Oi6EqJYwlB1yTzlTMb4xOc943/tnF34p hcoyt3q0 CJdwYBuu4WZ+gbbh1zCeLwZKLrqhL5aSsQGrGT2wzHydhUijZc/D/ibMCLWYbi/N62BodbfUXouNogTdx7hu1bvlsqPOkwksNB9tCCSHtmHsvbgdX3OlxpQiyJbAxQBlYE+G27VQTIYSZoCEicgkU33gSYOHCFWNrsRH1qfDXffEVviIMHvezHHXtfsmM3fkBvgW8Y/X2YpNfn9oVW6Lm8GM6lPdizICO+UB1Z/N3nKweT6znu6ZudAU16/ulWJtNGk/sBFFerpOO79P5d2rniEihXKd2W/jpOTe/uI1o7Wzls0g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Herbert Xu wrote: > David Howells wrote: > > Remove hash_sendpage*() and use hash_sendmsg() as the latter seems to just > > use the source pages directly anyway. > > ... > > > - if (!(flags & MSG_MORE)) { > > - if (ctx->more) > > - err = crypto_ahash_finup(&ctx->req); > > - else > > - err = crypto_ahash_digest(&ctx->req); > > You've just removed the optimised path from user-space to > finup/digest. You need to add them back to sendmsg if you > want to eliminate sendpage. I must be missing something, I think. What's particularly optimal about the code in hash_sendpage() but not hash_sendmsg()? Is it that the former uses finup/digest, but the latter ony does update+final? Also, looking at: if (!ctx->more) { if ((msg->msg_flags & MSG_MORE)) hash_free_result(sk, ctx); how is ctx->more meant to be interpreted? I'm guessing it means that we're continuing to the previous op. But we do we need to free any old result if MSG_MORE is set, but not if it isn't? David