From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E8CC7EE32 for ; Thu, 29 Aug 2024 07:40:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40CCE6B00B7; Thu, 29 Aug 2024 03:40:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 395A26B00BE; Thu, 29 Aug 2024 03:40:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 237046B00C0; Thu, 29 Aug 2024 03:40:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 006D06B00B7 for ; Thu, 29 Aug 2024 03:40:07 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4885280321 for ; Thu, 29 Aug 2024 07:40:07 +0000 (UTC) X-FDA: 82504484454.01.F11CB53 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 24B4340007 for ; Thu, 29 Aug 2024 07:40:04 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724917161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jqIptO4LOoqh0rcNoz56H0SYRGwMzCLIFP6EHWb/rtY=; b=f255pi9jwkCQy9VPllYN+KDWU2jM1PqysZMaOyE6SbdYUcYngdwoI1NyiggLUlgSzSbEEm +0yRUYwARJAEussrBpg/2B6BFmPd73dBZ3W7NOJ8Den77PMHRw7125wr243RyeXGUyb0qz ftofzHIiyTfGbxFrG7Ittq+crHhZRcI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724917161; a=rsa-sha256; cv=none; b=69jL8gWjVeqqS4HIsYaxb3m4v0Zvd4AN8fVZFxXLL+GXlPXoAEMhUmwWwdBjysnDQziicv hoZ6ezXV7LDKXMDHb/G3bam5jgEKGwbavZQh7UHoLxzp964nXYtUMwMOOnRmKiAvP9V+o/ U/p6bGaBzMW3k2O4oCGugDEsv+lPHbI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 61C34DA7; Thu, 29 Aug 2024 00:40:30 -0700 (PDT) Received: from [10.162.41.23] (e116581.arm.com [10.162.41.23]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C7FF3F73B; Thu, 29 Aug 2024 00:40:01 -0700 (PDT) Message-ID: <37577635-89c9-4afe-a30d-add02c0eb896@arm.com> Date: Thu, 29 Aug 2024 13:09:58 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tools/mm: Use calloc and check the potential memory allocation failure To: Markus Elfring , Zhu Jun , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, Andrew Morton Cc: LKML References: <20240829055621.3890-1-zhujun2@cmss.chinamobile.com> <716f7466-562d-4bbe-a8ec-851a0b289db5@web.de> Content-Language: en-US From: Dev Jain In-Reply-To: <716f7466-562d-4bbe-a8ec-851a0b289db5@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 24B4340007 X-Stat-Signature: 5i9r43ssj77mts1cjf9n15cjqs5e3shu X-HE-Tag: 1724917204-891 X-HE-Meta: U2FsdGVkX1+jzmYzNqCzqdXz26hoRErXJ1bNXfU7ODnwDJyWPNWkMPsbERsjpAm0/72vHALwlaxsDpBPu6EsCJsXhL/hKN5voZS1yhcs2BbpcNQorSLvSOAzqXxfoZENicQBq2TLc6iB2EakBH3CslFsL8gBNHLZkItTeLXd309y4rIiZxqDr4M8bhxPuhw33Yo3x5VzVj49O6wi8bNIsoke7qQ6iYLoJVFUPNgC3JyO7amUn5tjKR43esHWZjNW7DT3bydY8fetU9QMCG/zGzT2Pi/4lkbpuom3XceU5Rb0O9yf0QtGRkbZ+svKZ62xb9omEbaXNGrvYq4Jnb7uhsOWussEtj6kjzt8R+qhvbjv0KQj4e8KXadOTLwIDtAtKPqM12Z0dRFm0tDjMwyKbkOscxHpzLlNUrBAYKi9xG416TEbiCuzc6wWCzVS+J6hwETan8WvT5Tr9844roqd0dnm44xVFmo/6RW7PUwz15vbkUO45Jlbwedy660T0bEIp8v0RSgPvDwE4wSf7qLad4hERYqMFmctksizlf7tbbV5oGcqnUK4SJbWWLBv8LwD+WHmLoFbwaLajgfdLz4u9xko3zTvBcroLt/TQH66ceQ9+8IzjkBQ9h8HSetL/pAAd4Wc9G8GCPMlVA9q5qipQ4vbgdOxXk9tWhbEppTrrBsKSKwM3iQv/VqTQJs8+kvsPGOr9jKrzAef4/ATtKL6oDSwvcQzK930x7LRfGuacKOHvYkULqLy+vfnHe5B3Zyj+hi55+3UF4pABlb/Kg1o3C8j47+q4roLr6RYOReCk1SjbSLU8BhFmxZtj19pfzTWCI6JAv7xuWSBr4Vv/NQNvzhaPuhrT4D2qHp+2+9lH3ThVvv0BHqXs9L/ENSZGk8yYmL+nCNbhOYOSkT4ZdsYhxeMlGfaWlnv57B7dGQfHBPNKRHfP5sUrKxVOUpXMQcgoB4wLHwlBzYvhwKTaY5 ozNz5pEp /X6eZ2Y4GmLLNn8Pjb33F4Y5g65Foy2FqZgxChr6HQH6u1LdFwG5sgElkSkKgQk+Fn6BloQBDxtKP2GzO3aXyGdVb8Dx7Jb9hVONHfwqgYxGmUtUYY/8kreaM3hO8h/3QjjjW79Uq4EpyhUtcq57YyR6JeqHfmdX3L6oi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/29/24 11:55, Markus Elfring wrote: >> Replace malloc with calloc and add memory allocating check > memset(…, 0, …) call by calloc()? Calloc returns zeroed-out memory. > > >> of comm_str before used. > * Add also a null pointer check for the detection of a memory allocation failure. Which is exactly what Zhu has done? > > * Would you like to improve such a change description another bit > (with tags like “Fixes” and “Cc”)? > > * How do you think about to omit the statement “fprintf(stderr, "Out of memory\n");”? Why? > > * I suggest to omit the word “potential” from the summary phrase. > > > Regards, > Markus >