From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 247F5E6F06D for ; Fri, 1 Nov 2024 16:24:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A6D46B008C; Fri, 1 Nov 2024 12:24:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 757406B0093; Fri, 1 Nov 2024 12:24:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61EF26B0095; Fri, 1 Nov 2024 12:24:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 44CE36B008C for ; Fri, 1 Nov 2024 12:24:21 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D7B7216069A for ; Fri, 1 Nov 2024 16:24:20 +0000 (UTC) X-FDA: 82738047420.08.31BA1AC Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf22.hostedemail.com (Postfix) with ESMTP id 90A39C000F for ; Fri, 1 Nov 2024 16:23:43 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=phncJ5FX; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf22.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730478177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Xgaa20mje3eJrSCrnSFC9yazY/wXpJmFMU70h4HLjI=; b=0G0Ig8+zCn3hiu+hem3IIcgp3ca5YLMwGJaj/6TG5PIVU8Zha9cMH6QfFKliuH29xu9eHt K6ht21Lej406DL6e0n3fgepclgv6LYSZo/4XUxOJ2NxDfzagGNDDQgseY9ijmOmwybn7WH rgwKeU9mvpRSFC6fX4+jPrl4WqmZm1k= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=phncJ5FX; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf22.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730478177; a=rsa-sha256; cv=none; b=vUAndFZRjVdbLzafg9FgBztb7cSUDWzA8crVRd2OFWZt5qYyaZjVEpuT9bgtm6cmVMN+b8 xy/tuEPPSXT7E0Ve7SOQuXTewt3VXN4AX6QaJAvqkuS3BNMLCXz3Xdwveocat3jHYFmr+q G+lFjyesOuUzhQqh92PFun3IeMhFpH0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6Xgaa20mje3eJrSCrnSFC9yazY/wXpJmFMU70h4HLjI=; b=phncJ5FXPhT/q+hCcFE7MtumlU itjmiVSImydeG4klTYxAW740OhGCXkc+VUTKFYqq7n+IjTVb4p1Npb2DJT7u5k6PZ8bIMwYaySm80 dLpHXSzEmR3/ILm0emL4o0qRd0gBg1+HXypeRMphrRuserZpPK0hvnDBypYRqWpEqf7voB7MSVBX7 wUAJh5PVYf5Ut4LbOewf+oBlotLyCUaB0tgUWMdtNaCvll3CjdUo/W7wvt1iWw1pPAG6C44B1u3Fj 6mE+7b9KksqkW5fyI0Xl1yFA25ZkcZybqqVbUiX85ksexTYC+LmzWIqDOqY9eLjjuIBjqGWtt/YKH pTPxaMgg==; Received: from [189.78.222.89] (helo=[192.168.15.100]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1t6uRN-000UYc-HK; Fri, 01 Nov 2024 17:24:01 +0100 Message-ID: <3754d3af-13bd-499b-9bca-633de721724f@igalia.com> Date: Fri, 1 Nov 2024 13:23:55 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] tmpfs: Initialize sysfs during tmpfs init To: Nathan Chancellor Cc: Hugh Dickins , Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , krisman@kernel.org, Stephen Rothwell , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Theodore Ts'o References: <20241101013741.295792-1-andrealmeid@igalia.com> <20241101013741.295792-4-andrealmeid@igalia.com> <20241101071942.GB2962282@thelio-3990X> Content-Language: en-US From: =?UTF-8?Q?Andr=C3=A9_Almeida?= In-Reply-To: <20241101071942.GB2962282@thelio-3990X> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 90A39C000F X-Stat-Signature: odti1q4oh8si843zmfj57zfr5yajie9d X-HE-Tag: 1730478223-580849 X-HE-Meta: U2FsdGVkX1/C6S8sxFQ2Yllso/EMpGRX4Hhq1GFwtQQFde3vm3+jefUeoD97BfTFUv1Zq+TgPqb4kmHpQRvDXcQNszRSuGZo9XyHBTrsd03vzYkK+SjXEI+dsOPzM+ml4olRa7vMH4wJ3fPlt3jmnufT90x55t/UtxDs1dUYyi/oNhejB3074bagEZP0aJZfzTmoh5oXWyKpK6V3os4CbX26dhD8BOCeqUbrrQVV/owVVJoEvC2/nofSc670nqHKK8cYatinEMutkXuehxZGCJOP1iQY/RLpkWlysbAX6DhAGxAsHkwPjwL7PiFTYdlT1APC0nqBYyhljPD2ZhRSrVPiLGPZneICpL0ILaFUtt54tTMtTkYsfJOxJomPvnHgBgKDbmLwlU39b4/QhvGHewKFmOTbSKDxIlAVwkQDnTb3Jrv3+DBPejdJPsbYRDnIqyLSeutEw2Ok9/pt5kfeCwYVkfi5lItiXJzhVvhb2faXz0u03xl/k0Q4MRGmHo97+mjkW/Y+m9K7kXdGzazsarQgNnxBNEeNZ89SN6gtgU5ay6mSE815+yFcQG6T1R9G5sEYp7r9ISvZMFLnDcA1EZRrOV0ZSyfaLdXEMkd3aNed3IH5phmssR1H6T5tSb9LbK/3fl+Z51aoGPV9PVzAT1jZGQFsf30LVq2ZVlDi6tOP3XR/z97a0L+flbtaeEFA8a07NOXPXYjK8IP6APNe2KsSfp8VWrnk6nOMzofY0DE1qvTGg1W8FYkhRIRC+4al1t10tJP1IuEejO/PIzWKTW+87d2xKu+vvQBuoOu8CJ32NcvJMgRsSsJd4xkWmnbqerFrGJoo6r4+KJutyWFdZp35Wiqgi3YtSATM1DSNx1uLsVnPW2YJzztFCf9/56we1kgsLwph8YwqfdGwbrkOv6dwxmGiJx4U3mW+8wdgj3xql4Uv0vZPOZ2DaTAsIy9nvZjDyld2Cpf3GhpQekz dxhqRbiH /LzgVt3L+aLCphKef8Zxh5TK+sYOwOg3Hme4i1VSGsv+FHYb3RK+xBTNKmYxvCGvZ6BZR8AQz97fN9ALlC9q4G2bNbABLzJ+yLPTf92ou3lSaLA+cF4gnjfx/OWY0LCR9/J307uwMYw++z9BetFNyv4+gyRfMdiZVfWblTXBY1PQSz0NzVZ2kAFHAQYkuOvDaCpqFyb0h/qD40QHvUcr5aNWCCfAHCzOVcdMOeOG00J0QEEvv7oEV9dAIL6cy9/HYn5uFr+4NzgirmKNCht8RerFSg7M4QBrbxmj5Df3Ue8XBpH6ov/9yQ/2lE6VQaU6jNBMXjuB8BSLSaRKgXBEawhZfltk7I8w2FYGyp5kzRRANcc4JyxkWEN4pxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Em 01/11/2024 04:19, Nathan Chancellor escreveu: > Hi André, > > On Thu, Oct 31, 2024 at 10:37:41PM -0300, André Almeida wrote: >> Instead of using fs_initcall(), initialize sysfs with the rest of the >> filesystem. This is the right way to do it because otherwise any error >> during tmpfs_sysfs_init() would get silently ignored. It's also useful >> if tmpfs' sysfs ever need to display runtime information. >> >> Signed-off-by: André Almeida >> --- >> mm/shmem.c | 130 ++++++++++++++++++++++++++++------------------------- >> 1 file changed, 68 insertions(+), 62 deletions(-) >> >> diff --git a/mm/shmem.c b/mm/shmem.c >> index 6038e1d11987..8ff2f619f531 100644 >> --- a/mm/shmem.c >> +++ b/mm/shmem.c >> @@ -5126,6 +5126,66 @@ static struct file_system_type shmem_fs_type = { >> .fs_flags = FS_USERNS_MOUNT | FS_ALLOW_IDMAP | FS_MGTIME, >> }; >> >> +#if defined(CONFIG_SYSFS) && defined(CONFIG_TMPFS) > > This condition... > >> +static int __init tmpfs_sysfs_init(void) >> +{ >> + int ret; >> + >> + tmpfs_kobj = kobject_create_and_add("tmpfs", fs_kobj); >> + if (!tmpfs_kobj) >> + return -ENOMEM; >> + >> + ret = sysfs_create_group(tmpfs_kobj, &tmpfs_attribute_group); >> + if (ret) >> + kobject_put(tmpfs_kobj); >> + >> + return ret; >> +} >> +#endif /* CONFIG_SYSFS && CONFIG_TMPFS */ >> + >> void __init shmem_init(void) >> { >> int error; >> @@ -5149,6 +5209,14 @@ void __init shmem_init(void) >> goto out1; >> } >> >> +#ifdef CONFIG_SYSFS > > and this condition are not the same, so there will be a compile error if > CONFIG_SHMEM and CONFIG_SYSFS are enabled but CONFIG_TMPFS is not, such > as with ARCH=x86_64 allnoconfig for me: > > mm/shmem.c: In function 'shmem_init': > mm/shmem.c:5243:17: error: implicit declaration of function 'tmpfs_sysfs_init'; did you mean 'uids_sysfs_init'? [-Wimplicit-function-declaration] > 5243 | error = tmpfs_sysfs_init(); > | ^~~~~~~~~~~~~~~~ > | uids_sysfs_init > Thanks for the catch! Fixed for v2 >> + error = tmpfs_sysfs_init(); >> + if (error) { >> + pr_err("Could not init tmpfs sysfs\n"); >> + goto out1; >> + } >> +#endif > > Cheers, > Nathan