From: Chen Wandun <chenwandun@huawei.com>
To: David Hildenbrand <david@redhat.com>, <hughd@google.com>,
<akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] mm/shmem: return -EINVAL for addr not PAGE_SIZE aligned
Date: Sun, 5 Jun 2022 10:05:35 +0800 [thread overview]
Message-ID: <374dfbbd-415e-890e-15db-b36c34a70a8d@huawei.com> (raw)
In-Reply-To: <e25a6d7b-c93f-c680-5044-c9dac1aa0a2f@redhat.com>
On 2022/6/1 22:14, David Hildenbrand wrote:
> On 01.06.22 15:37, David Hildenbrand wrote:
>> On 01.06.22 14:44, Chen Wandun wrote:
>>> If addr is not PAGE_SIZE aligned, return -EINVAL directly.
>> Why is this one to be treated in a special way compared to all of the
>> other related checks?
> Ah, I see you modify other places in other patches. Maybe just combine
> all these return value changes into a single patch? That makes it look
> less "special".
OK, patch 2 and patch 3 are used to return error value directly, I will
combine these patch
to a single patch in next version.
Thanks.
>
>
>
next prev parent reply other threads:[~2022-06-05 2:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 12:44 [PATCH 0/4] a few cleanup and bugfixes about shmem Chen Wandun
2022-06-01 12:44 ` [PATCH 1/4] mm/shmem: check return value of shmem_init_inodecache Chen Wandun
2022-06-01 12:54 ` Matthew Wilcox
2022-06-01 13:34 ` Kefeng Wang
2022-06-01 12:44 ` [PATCH 2/4] mm/shmem: return -EINVAL for addr not PAGE_SIZE aligned Chen Wandun
2022-06-01 13:37 ` David Hildenbrand
2022-06-01 14:14 ` David Hildenbrand
2022-06-05 2:05 ` Chen Wandun [this message]
2022-06-01 12:44 ` [PATCH 3/4] mm/shmem: return error code directly Chen Wandun
2022-06-01 12:44 ` [PATCH 4/4] mm/shmem: rework calculation of inflated_addr in shmem_get_unmapped_area Chen Wandun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=374dfbbd-415e-890e-15db-b36c34a70a8d@huawei.com \
--to=chenwandun@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox