From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F03FEC4345F for ; Fri, 3 May 2024 16:42:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87FA96B0082; Fri, 3 May 2024 12:42:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82EAF6B0088; Fri, 3 May 2024 12:42:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F69A6B0089; Fri, 3 May 2024 12:42:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 55AC66B0082 for ; Fri, 3 May 2024 12:42:04 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 173A41A10F6 for ; Fri, 3 May 2024 16:42:04 +0000 (UTC) X-FDA: 82077651768.27.1A71BB9 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by imf21.hostedemail.com (Postfix) with ESMTP id C08AB1C0009 for ; Fri, 3 May 2024 16:42:01 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=a2rw53HZ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714754522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Aa8qg3KK3q/jGAq4vm/majK0jCDOLd6BougEXc9Jw4=; b=2lYTOtEXVo+TZvA7atolQ2vPTU8iIky8jBiD0TOAnPW6EIYenvBiaxyG20VDS/2B/f5hU/ ye6z5oyIGQkaUuywU4hnALKYqmWhse4VWSmkvWWI53+Mo1O+C/+F/S4HpLtUTYy7BrHsSW czkmBmH09S+4+Rldbb4CPeFe21WLe/k= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=a2rw53HZ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714754522; a=rsa-sha256; cv=none; b=bLjhZ0UHmPijO7zwiVZIrLWXTsAMl/i7j6UntFGvZYVcL61NCWkpcx5f41mV155z7xsPT6 Hli+XldQiQOzWCj4QE9CS3bxPQl/V0OnE8wy1mlsJmPmmHlp9ahyW1STjYf59njfXff5j2 s5pNeQRux1jcnNy8G8lCPrE/JLlf4Sc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714754522; x=1746290522; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6yaN6Tg5Pi5uYX9aCa0y3OfnrA67rHUXaDA4i8gsLlY=; b=a2rw53HZpnh6mOljcrOrPbpmkmYeV80X1MxzhQgoJeUJIcsevgOqU2sx HOxBEOF66n7wFBXlsHwroAP1zAKfyIOcUB14S6A4YWovgvRrBSmoWqZ0M UCus4poBqxToCD7JhcVlCnVovubBmufD0aKs/QZ2Omoubs86pX75R22CQ 1v4gn7o5nPsZtXTSybDO81Gz2F2skIb7kGGk5WA9ImAzgs0F6bF+G70j2 kks8EO6Y9gIKRzSRUm924M28VtTe/iDps9nq8XIpeRdwQOsn2G1WGFfC5 F1m6MOmgpmz5Ir33AWpnzpFbUwHmv+YrzKQcbe3wKwAC6K+mCYmJdSXKc A==; X-CSE-ConnectionGUID: +HmFBf9fRWqwlgq/+oh1hA== X-CSE-MsgGUID: 5IXswIAlRvqG9WoR4bnBxw== X-IronPort-AV: E=McAfee;i="6600,9927,11063"; a="10415373" X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="10415373" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 09:42:00 -0700 X-CSE-ConnectionGUID: K6Vn7gjMR26u5PtnJMH4hA== X-CSE-MsgGUID: 6T7K0AKiRK+99ocJX5AK6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="32305945" Received: from zhangche-mobl.amr.corp.intel.com (HELO [10.209.82.31]) ([10.209.82.31]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 09:41:58 -0700 Message-ID: <37447227-b478-4751-953f-b7199a6a55d0@intel.com> Date: Fri, 3 May 2024 09:41:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/29] mm: use ARCH_PKEY_BITS to define VM_PKEY_BITN To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-4-joey.gouly@arm.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240503130147.1154804-4-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C08AB1C0009 X-Stat-Signature: ziixj4ezehdet4sehwfwr68p3aacgrzq X-HE-Tag: 1714754521-690793 X-HE-Meta: U2FsdGVkX1/PkUeQxvPHdpwOItUKA187WPvYfi+MNjCMUy73eYPTLUo3NBEIu/F81XkYSv/Tfrg4DIjSyZIKrLJ6sHkExL+ZHRQtnVpNaQ1nt1w7V3gJafL5k4wlAlWfv4jSxJRkZ9m2Wrw/T1nkKVJWDsV1t4V/KopahzO8rNUfimOW12g+q9V6/fpSmCeOTGZc3ZUtuhBvFOqSDg0Zkq6nTAknSWeBx8Yx98WqLIZYQGWRTNHH8Ragw9acMgNQzmM6NTiizYjhghmDGlvrG343KaP048F+T2C9RIgZxYwX3i//8isnWiT6xwEfNwm3rwGWPzScfcgaMHRKtu6mcHGc1B5hAU9O3JujzpKK4IXTCWPJHukJD9riVY4NeRXuX7Uy4BfXsqEUHWsIB5kzydsU7KUde2tQxey5pNGc0X9eSc7Z6QpDsfSa7BVHDz70Titt4b/TQb3/INQ0pekBvhzRZT7gdfWUARiGx2SSD5kHdLZoWAiooxJMRuZANEIKVZH4KaUY35bZB+m2sRljjqT8wYRbwpMxMzIhe2W2nsM+Tzg38Co4L+9opr3MaRWM1BzvmQdb9gg8CUGqp562+nMhcxelIzTtjYh+e2tdI3E39L30Afr/HC1C1dNJiWt829DRjUuh3kQnwKH8VLccXTYXgkp+AvD6/nSRCRbRYrOzJP23+LcEN916b7FFI19KdmSZAe0wFob3qZvAjimH2yHVJp7kDM+Q1DYgrpfroPeSkY7MKUHFT01hwQTUO6DUVgdiBEXMLozpdVqMMOnT7tclZclkqHt9cjdSnc9Z5nPdYlZRE2WR+CVNlUY4NK5D3+67U4RYICin5Cf3HbQFXklSOu/BOmSUFAj0u2khIG/+Mpo/cMTN623hV31FPOiz+Xh/pSINmjLr3/1C7OGwSGjkVkRf/XDxQGG+gbaTiPtN047iT2zA/GigcaRUI2fiTd0nu/ecIiS9hb8djp/ PwW/2oNw 3PYm8un/aTnEPLewsSWYCwJKiVBVv3psAVsanN//rpYclac8Jc3OIBlPH1tFk/Xf25LpOb1eLAyoVkUH95KGHtHeKl+m8IkEsK//kNfNp4addPHPoVV5mgag4x7TDLo3QY8ZX3SVIeGbxcddk5lI5AMD6M6IRds9XnxeuK7Ri31VrV24p8lPSaLvAQedw/UW9Rf1MlGfF0HbBBdqNRlNCy8FYypkkno3UYoXUTa9v5DBmdBrNBuSEO2mF8xEfEQozPHKr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/3/24 06:01, Joey Gouly wrote: > #ifdef CONFIG_ARCH_HAS_PKEYS > -# define VM_PKEY_SHIFT VM_HIGH_ARCH_BIT_0 > -# define VM_PKEY_BIT0 VM_HIGH_ARCH_0 /* A protection key is a 4-bit value */ > -# define VM_PKEY_BIT1 VM_HIGH_ARCH_1 /* on x86 and 5-bit value on ppc64 */ > -# define VM_PKEY_BIT2 VM_HIGH_ARCH_2 > -# define VM_PKEY_BIT3 VM_HIGH_ARCH_3 > -#ifdef CONFIG_PPC > +# define VM_PKEY_SHIFT VM_HIGH_ARCH_BIT_0 > +# define VM_PKEY_BIT0 VM_HIGH_ARCH_0 > +# define VM_PKEY_BIT1 VM_HIGH_ARCH_1 > +# define VM_PKEY_BIT2 VM_HIGH_ARCH_2 > +#if CONFIG_ARCH_PKEY_BITS > 3 > +# define VM_PKEY_BIT3 VM_HIGH_ARCH_3 > +#else > +# define VM_PKEY_BIT3 0 > +#endif > +#if CONFIG_ARCH_PKEY_BITS > 4 It's certainly not pretty, but it does get the arch #ifdef out of generic code. We might need to rethink this if we get another architecture or two, but this seems manageable for now. Acked-by: Dave Hansen