From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20F75C6FD1D for ; Fri, 17 Mar 2023 17:50:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 928C96B0075; Fri, 17 Mar 2023 13:50:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D9B66B0078; Fri, 17 Mar 2023 13:50:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 779B46B007B; Fri, 17 Mar 2023 13:50:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 68B2C6B0075 for ; Fri, 17 Mar 2023 13:50:25 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 35F15C1962 for ; Fri, 17 Mar 2023 17:50:25 +0000 (UTC) X-FDA: 80579129610.29.C4BC583 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 0B5F814001C for ; Fri, 17 Mar 2023 17:50:22 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BqBA6FqC; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679075423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n+5rVi0WyfwWKJrN+StQmENQv1kIwISDnMPK24LSLpw=; b=nic7BtyK/ugQhHeuS7nBk/2gGpWtbNz90IFsnt7S683Wd5V/UsxvIaW79NlPgVXCp5AmMm Knyh5xSxL/o0H+3S0u//PQz/l8L84OlZ5UhvFphRVvXgYPlWMdKmLKqLoT1aLOWejjSggw wabmW2rK5MWzG2LY1zklWnm587bOsLE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BqBA6FqC; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679075423; a=rsa-sha256; cv=none; b=GEpesbkbmp1T2OnsQW+YYMbFTh+LWLa3TiWCw6bGfdnmPy8Hv8gcnbMLTvZQLr91hD0Pjf AokO42GcWxCtCI1EEduCCDuIIkYpbhLPyKCVlxbDgbOLfGjgc7Xwo/zhNBfJK0qNzRUjSD 8xwLfECrhpkp8++G3x5qHRY3ztDcUf0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679075421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n+5rVi0WyfwWKJrN+StQmENQv1kIwISDnMPK24LSLpw=; b=BqBA6FqCPsM4NlpzJJBjsi72jY8U6qHSR9EcXWhG0U4pVtzN2/puM+ZJiuyRAWw1WQv3o9 sQVU7ACMCrWtJz29KNn7z2QcwvEh6oO0M0Bj12xRQk6ukwh2uhDWaD2cov2ap54gv17H5C 2+lZMQPtpIVINRZ3Xlwl4XlgNgMbq8g= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-n1UcXLRdOy6pwks2aLMH8g-1; Fri, 17 Mar 2023 13:50:20 -0400 X-MC-Unique: n1UcXLRdOy6pwks2aLMH8g-1 Received: by mail-wm1-f72.google.com with SMTP id l17-20020a05600c1d1100b003ed29ba093cso2184933wms.6 for ; Fri, 17 Mar 2023 10:50:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679075419; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n+5rVi0WyfwWKJrN+StQmENQv1kIwISDnMPK24LSLpw=; b=YJ5cph8el/+TPq0dX4fWcArG0d0HC2FCjRgLqMA8YYwnvkeTlodYrFCzHljsIQ8Wy2 mEZ3jMhfHL/lt2i5eH361rxnvpDndDyNE5/slearkC8XiVKgQhJ+yP6tLK9WfD+tpCNc iuHZus6rcU+yLsK5IeNspjqrA8M2pbUqftom+D5vbGvnwtwj5aQGlPgGgrdEQ9m+zqiK n5//qAhfxryBOsgFvW2AAlJkyPuj07fFJ+Bi0FZFKxzovAWPmTlR5wjhV0SIN3nnSRzu m6kGt8tcXLjEiTpx358nl9mNUhgChvwYnqkuhOjudtgCW5UD3Hl/5VdUR3pfu7h8d7W3 Gqzw== X-Gm-Message-State: AO0yUKUzdgyCIRnGQrhRz/VsmqpX2GtyS4DKWhrvz0BJE37BzucMV0o1 mQZ47f9pRMYPL4hIC99OALyPWTKIj+M8cXTPRIjmFjuV57Uh9Ka9q/vkMw/0mHLSCaUrhfVfd9j KnjxrKZ2GVFA= X-Received: by 2002:a05:600c:524a:b0:3ed:3e72:3580 with SMTP id fc10-20020a05600c524a00b003ed3e723580mr7677039wmb.26.1679075419109; Fri, 17 Mar 2023 10:50:19 -0700 (PDT) X-Google-Smtp-Source: AK7set/WzB0KfelzZQrjurkv0RtAmJa99mtgVV5SoH08YYwFZPhGUX8bbh4GYOhR/WlBJ8RJz4hW1g== X-Received: by 2002:a05:600c:524a:b0:3ed:3e72:3580 with SMTP id fc10-20020a05600c524a00b003ed3e723580mr7677020wmb.26.1679075418729; Fri, 17 Mar 2023 10:50:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:5700:cb5b:f73a:c650:1d9? (p200300cbc7025700cb5bf73ac65001d9.dip0.t-ipconnect.de. [2003:cb:c702:5700:cb5b:f73a:c650:1d9]) by smtp.gmail.com with ESMTPSA id u10-20020a7bcb0a000000b003eb5ce1b734sm2931664wmj.7.2023.03.17.10.50.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Mar 2023 10:50:18 -0700 (PDT) Message-ID: <373b22c7-9162-eff0-1f0c-0a8d79a8b372@redhat.com> Date: Fri, 17 Mar 2023 18:50:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm/page_alloc: Make deferred page init free pages in MAX_ORDER blocks To: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , Vlastimil Babka Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230317153501.19807-1-kirill.shutemov@linux.intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230317153501.19807-1-kirill.shutemov@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0B5F814001C X-Stat-Signature: 8eqykci4ua4456sth6zomm3efjqn68xt X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679075422-369302 X-HE-Meta: U2FsdGVkX1/qQX5mC4smTkYjhb4l2w5EcOKWFI24eRtcn1DLfUAFS2HyLdUBEERL+ST0lWxR6EKbWiCYLe55Qsv1kq29MYd3CZGvbY0PoBtSJqjcqg2ElXfoKAz5/By65DHWj03NMFttiw3YlBFgG+OfvzO3oYGMZMFCrL1PXrT3YxKL023YesaIJUn3XhvvJc/60oY+eh2RrADiTqHY6iXdwlLSHgowxQm7i0iz6Pw+G8xUo7Xv6k3aKzpa/taC5kVMhK/x+oaLTVk5AX/r8Y1o7k/R0mOV4CkQ/PZLxkV0GpEVzxRbOeZ2RA6Ztq0qw1jX4rodV+EJenNKq66hF3Zw5e5vQBIpefUmf3AyxJmV827gesgH54B3uvNTZqBYx5E7OlASLhom5myNNzJp9Yh4WoZf7OliqNHdv80WluPj3lIdKy6Hwe3XTaLmpGe994IIU88zH57QBjLiGxcKhCkKJg9+vn3eDpAwKCFG68rnJT/p9OqI9ftKu+Y1FU96ZVyGT7DEtmycQXp/3x4wUAj6S3vwXPcydy/RsrdXJ1Vpynq0at8o4V6TWPXFh+Wt7C+Pu9Ta9ioQUrOicDShWb8tsBF4u0Vhf2Q9u5iH/xUtL2ulRFvAUaYF2bLePTGqw9CW09PHdJ1nvKnKP2H6zGQkCVFy9yUIj18GZ4XAS4kZDr0o0/nSkgvTjkOQOie8GCe0W9Bg2yfZA/yYmTCJMgajdMPqS7UteAJ+Z6wzXpoyQm6TlU5HK3fkeyAtG0lGEmRs/CMDrFo4MbA8pC6uNFqzWWMr0jQdjEgleCsdl9Iwkn0F5wO3wGrvjlbXHX7ntPRlvXieikX0eckuEQiXhAek4mmeaH0lZD0mKf06U1U+hl6o6npv2fDhR0ZywJ56EOSBU9KuxDmTTDGAVqafEa4lm3grK4slxmY/miIkgFZKUkykwSagwGzk8qzYesdf70SY1Wbr9a5SeZmllDN AOemX4W5 z5MLHfIA5ZFEeOxly4rbGUv+MW+Ajfu62R/5gWtdcLzSMSmJvbegYofsVo/uZ5EmC2XnNb3mgIbR6bHXydZ9a2EH7suxskruaC0bZbKYlFtvvmnLvfjBM4FWQ6F38gSQR9e8RVjugGdi9z/XPDoV0NE8bPSHD6dEDBUSH2KDD2re7Lx/E3yDvK2UBLOojp/tgA3mNPVn1lqpO28cttYxgUBBlAp9KPuiRCgDe4ZWKP2lfvGjd5Q8PscwGhotSqQycfAgKjU93YJud5y1Nltum4SqPHvqoygrIs8/NsYX7pQ51NnLOZx9AuNLfNWQNhUQ1Mif98Grwo1NW6z2JeW9mXUK+I+9fnEYbuyTU+IJCpfSK3eRtNfXWoCUI0j+esIuKjQhFOFCdQ/3EM/qWiFjuZWab5cO77r9VdO+q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.03.23 16:35, Kirill A. Shutemov wrote: > Normal page init path frees pages during the boot in MAX_ORDER chunks, > but deferred page init path does it in pageblock blocks. > > Change deferred page init path to work in MAX_ORDER blocks. > > For cases when pageblock is larger than MAX_ORDER, set migrate type to > MIGRATE_MOVABLE for all pageblocks covered by the page. See commit b3d40a2b6d10c9d0424d2b398bf962fb6adad87e Author: David Hildenbrand Date: Tue Mar 22 14:43:20 2022 -0700 mm: enforce pageblock_order < MAX_ORDER Some places in the kernel don't really expect pageblock_order >= MAX_ORDER, and it looks like this is only possible in corner cases: 1) CONFIG_DEFERRED_STRUCT_PAGE_INIT we'll end up freeing pageblock_order pages via __free_pages_core(), which cannot possibly work. ... How should it still happen? -- Thanks, David / dhildenb