From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F775E7718B for ; Thu, 2 Jan 2025 00:07:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A69966B007B; Wed, 1 Jan 2025 19:07:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F32B6B0083; Wed, 1 Jan 2025 19:07:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86C3B6B0085; Wed, 1 Jan 2025 19:07:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 64AB76B007B for ; Wed, 1 Jan 2025 19:07:03 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BBDD081050 for ; Thu, 2 Jan 2025 00:07:02 +0000 (UTC) X-FDA: 82960569510.27.339C9C6 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf20.hostedemail.com (Postfix) with ESMTP id 5B24B1C0005 for ; Thu, 2 Jan 2025 00:06:09 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fmc7bSaD; spf=pass (imf20.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735776397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y713/f0f785zEA94Opwqb6fiMwYNpnqQhjKjw8eunkg=; b=rrvPDyG7RP3y4WdKoiwAwJ/kRyIsfLRC5aDY0hiEYT6dsv5xjgJPq0yIUq7wRDq/AJ6200 l9KzFigdIlKDfMnaNhxI/4FAFYEJkDIV3AjLymbabPX7mIdObUP3Ygh0GKn998bmPqtM/U NVfjd11x5qwdvH3czmiPxNEyf/qf0lE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735776397; a=rsa-sha256; cv=none; b=rm/P6g16G2j5MAUqFaKg82rxA+L1F74m/vKbnuW0BzDuORULT4Q65nUoWGuqMs8hmFNPQQ jLUg+M08JXzTKNXoQHJ92npha1cyk0i4vNZHSl/mfYpZZ432uwVleeG+Hk2+bIvDjywU+s oeslGwoMJiYtHc4AL5HtZvWSiXusif8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fmc7bSaD; spf=pass (imf20.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-aaeef97ff02so1128775366b.1 for ; Wed, 01 Jan 2025 16:07:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735776419; x=1736381219; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=y713/f0f785zEA94Opwqb6fiMwYNpnqQhjKjw8eunkg=; b=fmc7bSaD9Dpa31wZPiNBQSgL9akMLrBHagotUKpOObgVhDBmnboiXfRirhQBeUrhl1 DZ/tdFF54u32B7r+YTB+BwlRLc+QJ2bhT6w0Itbf3gf8HC3f9vt4gis1pYO7mTkBExKs bXVCewRROA1vlIxAUnih0KiV65FsY9UpOoVmyefaPO/F2llqtFuZQLNHMP55gXE5AbaS RzwMJQQjKwr9HVGf9JpLyKkvCyZdff3SurZcUpHv5OKI6gjSNzEMt0PBQ6yDEEG/+G7v yc2KjxalMNwUJfM7XUhXHHE0w5H1xapA7uDH3sDLwpO66RjPPpsN9he0q/uGikNxH4bb iNUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735776419; x=1736381219; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y713/f0f785zEA94Opwqb6fiMwYNpnqQhjKjw8eunkg=; b=b1AqydqSaOY/ySBOICo0EBvEBHNC6IuDanNS/1XbxEAtZq2aTRCIRDo5/HOBxqCPUw vLQrhb8tmEauMhmy5+KlLz0f+XYROP+s7xT6pNSQrCx6VWZKV/lBEBVaX6YJA0ikw4E0 O4tC3LqxAXw9+SWEVjX93SXHE+JrwSCXGPtXWBShUnYxq8CVy3M3yO//R/ITUM7i9jaU 9N601XEfPksVo0QvM8/p2uxY3qY4BsWF2uhFQEMY2UZbcNGcG9VQb/jqS+S5HUSno3IP 9TSuWcFy+3QWqdnvW5luqwT5Rt2BPbFIDCVz1wbx85/EHYwaU0eA1YsryHCdRbSh1Ux2 qdyQ== X-Forwarded-Encrypted: i=1; AJvYcCV0G3YYb4SjeGJ+/mZVIUXDtv7VNTD1QF9QNmtTKEq0Q5M/98BReqXzdWOhX3GSrFg54edB5Ua75A==@kvack.org X-Gm-Message-State: AOJu0YzuiXpL5oaMCsQqDuYc5rjUuka+VWjTSQArxHNTYMMRXvPe+QaQ 5NSb0zyrPbTbX5bEWGAEvYrl7lN0S8q6n6gvp4s6D/ETMWPWEfZ5 X-Gm-Gg: ASbGnctDe0EU4t44Xg8IvrRHrlYs4CTqOOxT1NYEE507N+B7uZ/VAhUDHYpjEcofJNI SfsgRi28dOOZlBjOwIeY7ZIoWocnUtndrj0Yat1abG3xWn+VXtCOyxVbxpkYdigqhorDCe74wV4 3BSegJwyKPQ+M+kW3isryY+jDyt4B8b5Amxr0aHtDa/vAAiXbH0YRHL+rqEWZNNuXw+JZouEvKN XYNsq+JwlFz0wOnsIwTfSBsMdtolxWM8oNCFLoV0HfAdhMwQz/lbUTOBpqIdxKmgFVjjcb6 X-Google-Smtp-Source: AGHT+IFrVlvPbI0GMuQjWuu5OKI1dbZ6JGftY4K+Vml6sfN5jZqaYrvpfSH+kghh3UCCEYi+h8/ynQ== X-Received: by 2002:a17:907:6d0c:b0:aac:212d:a883 with SMTP id a640c23a62f3a-aac34451c4fmr3364567566b.45.1735776418706; Wed, 01 Jan 2025 16:06:58 -0800 (PST) Received: from [132.69.243.32] ([132.69.243.32]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80665253dsm17619697a12.0.2025.01.01.16.06.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jan 2025 16:06:57 -0800 (PST) Message-ID: <3736e1f1-231c-4060-9fdc-579c11600720@gmail.com> Date: Thu, 2 Jan 2025 02:06:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes To: Rik van Riel , Karim Manaouil Cc: the arch/x86 maintainers , Linux Kernel Mailing List , kernel-team@meta.com, Dave Hansen , luto@kernel.org, peterz@infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton , zhengqi.arch@bytedance.com, "open list:MEMORY MANAGEMENT" References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-10-riel@surriel.com> <95b614577f5475a919c878d6906d721004c83584.camel@surriel.com> <24c9b4b6-e07b-4cee-aa7f-6f317a1b7ef6@gmail.com> <20250101161556.lniuomixy75vmj5g@ed.ac.uk> <7be55c4eb33aac4f9b99c70bfd4578934fbdd0ea.camel@surriel.com> Content-Language: en-US From: Nadav Amit Autocrypt: addr=nadav.amit@gmail.com; keydata= xsFNBF3nSCQBEACinGNWCLb3Iptvg066zPUQCFfR0nIX+j/pjxlLd094zOKLJ7Z1wKNNTQgb +Y1GQYwKurK1hFHISPc1T7xk2twzov5niFqQp1/E0I6t/92rxo7C26tKMrCHgqXpFXXBaOvq t0QN8B83o3sfS3OZyc0F5hWoJijhKQ+h7dJHMPpBBeTWiZzYVlMNz/wRzYrh1nvesbGJtV1w Wk96qoQAOagczRaSRWouJ1O2JbHqQarLJG657hqtPZctQ1mkXQcJedT1c8ejWBdIiU0rIpV/ R2uTgM5NSjVrY5OxiS2G4C/bDcI4Q6ApWxqu1zRGffKWRFJdQvttSv+JbW2q6OCvJReJs1i6 nTovpfJb3g9d7U76LtAw7HE5iIl5CmyFoTMMH+sDc5PG7JRboiofku9DWeDGK4rB2s97GuA9 BXJDHBbH1AI+Y0H6oz/Dri1sQSayUU8Xj/jCkwxpwDle1qYYE0UM4PqDTUoeejURR/h/AREt bCecfxNUYNz2jY8PUL0YXj6yex2p1otMy5sy7djrTqhC02AXLQ3Oab2UJuMZnf4cTbN2sGXu CRXcCSsoyhxIFtwpgdVIDqkPMCOEPvUwy9hWs0N9Xy+jOebpH6FYxq83pP3IhyBdaoexoyGL IkSzrO4+0bVk5voh5SIYVkLEooMSEQT9rfSdrJmRRuM7S/PowwARAQABzSFOYWRhdiBBbWl0 IDxuYWRhdi5hbWl0QGdtYWlsLmNvbT7CwZcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQRIkveiyXlibH/D0jUdoCpJptoPWgUCZWMLXAUJCz4qOAAKCRAdoCpJptoP WoWjD/0d8I+qQIHp2Eq7Whi+idkGDJaaBksRw2r0+XTzRj0CsCFJS7oMWudQaYaI2bTW9uha zfcmpnkm5aOVoxGOGJUJSy0H4of6lShE+7caoz1pdX+y15STij3+RvUjcGn0N+Mpxrnj6anm ArH5KOwzQJDiMF48ntQ2EQAFJ5X6YZ6Ed9N4I88XPeOtWaU21Q5tZI/ASHrQTH7BMukkVe2U PkSjn205vbrCfcC4Ohu9HXC8ey6l5txomFaTIRvaz1La3W8gQHhT2D2QeNnJFRudN5hQJNIE OHFi6QmPVIbI/uYD82h5uesiufycV2kvuIACmvs2T3tpaxSY9HOJF/yAhqg28hKE4wKQIwh2 wzZ+ywDeZ5TboqTjTU9oPHuRTxYItWmevJgQDwOYcssYI4wOdXvu/bh5VvhBgJxgkOOH7j8N efzqooL/2/pD/1JAO9GjPEWbuRx0dZh5tcMq/RYFFhdZQNFYmqdDyY0+y6ntxEo25ScvVLfR GqhpyJkN9+cqJZfg3IolbWoZxkSLtiCBge/EDRRoLJpjpsLpBmMmQcH/50WgQcoL5ObVlc1I ft1sKfzZvIyqXZfu3YcWgvOXfVXaMw1dXQ8ffwgyCSIsKvA5+Y45knd72SHny5z3gi1YsMc1 lm24v+OfxfmZMmJQ7TXBDl0JkOMnQ3A+KDb0oGAI6c7BTQRd50gkARAAt/NqfDSMph828JIn VOck27zsyT12AHRLIhsCCatw+zYbdMSLTW6hd/sChStdndAQlqOOW3mpm6bA+jl59c4OhkBW 8fDKgaWjVq8kBm4Z61zhzk3oXMmxgQ3cqMEfN36PCpcfs5MtLiMoa2JxaqFMQbKkmcZqz8fw qGIID/SMI5qdk+yWZSmR+6RdzXfppEIeqs78qTFxaEl+0MlAcgo2AjrMPLIjNK3k4jNAVCix KjMfkkPk6xVmP5Q7cr1st0xTTa1APt0y966oa6CZIdHY76D/jLpjJlfalctmEAxmyBqK0ZkK WDkEF+qCqqZ7oSkC1Q0ogBuBffIZb5srleqMz++IutiE4r/LELs7RanXXCRK5JYzZc/uAnxN fCJzqKR5/JxoSnCh0yQNU4FHa78DeD/SLnCu8JwTGkcX9ZUW/ZQ+5Nsimy+SlZb0UyaWA+vr Q7+F7OAL6PFsE8v+Q2u2EHwa8e2KmsL0sC+enBXbaogLFFfKi4I13vOk+76nCZTNetRhAubM etLe1PZZ0IDzgGhjFg+cc/jptq3qYjK+3jzhdKaqmoibAoea3E/5HsTVVbxUiYEdk2crTqf9 Mr5S5AzQfH19xU7uUduBvjN3L0dRKP0wJEqgCIB5gZBjD8AYmKSgdEujDAPQNXTJgwB99C+r F0XoHEmO6m9vI6djzDsAEQEAAcLBfAQYAQgAJgIbDBYhBEiS96LJeWJsf8PSNR2gKkmm2g9a BQJlYwtcBQkLPio4AAoJEB2gKkmm2g9ah7wP/jP18+dznONUt3Nga6XKYxxlVmVnMlqHx6SB jDWTwFzcQ6UeVVUmODWBSLI+iqg5djkgsTcHwI668qhIyyWaXC9ld+ONhUaE4NH1PKcJ8cdG vzhdTG8lM9mwmnJriTfih59OLI2yKpml/et44gvsfQpmFOyrdH9u6xPai5h3KyOoXD+Q3EzQ KEiHqs2x0PX72Jz4iVKEanP+qxEwzarUUcum94ecGilYY4jfxhfkgwBWjmC7ExbVTSEKIx3Q zdDbDiAxhAWymSisP3lbYqRo8mkg8r2emNan5L5Xh1b/62zmMO+p6gzucV7vO0VJxlKuUkFW 77Ug+X+hkDedvp2oRBz+wKtBxwSxlTM4toD49Jn111OMS6R5opquZP+/SJH1njSKY9MY3D3D 57QDpRUvqbqMDdqZqmYlMxntxTJ+0yksR61/t62F/bSp4XLxbgwCXMm73TxGrU73ngaS/Nxz Pv28VEcCGXZqFS2sbsbBSEjGgPhXf73YlI1fYiAFiaKHKvlofX+xNLeRHr9/+fL4JWPFurGi WYMyVA5Fv1sfefXhdEv9qNlhyNHxxB3vEpxkEOdo0JUhNfIcxe/w5iOfCUAtwUfvijvHUFHh U5QeQckJZTApjJ4S/Wa1ef8eS/LBsvG9xMNG3Ns+M+xR6unu6gTuzUNp7Zsxgmp8hs0racLB In-Reply-To: <7be55c4eb33aac4f9b99c70bfd4578934fbdd0ea.camel@surriel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5B24B1C0005 X-Stat-Signature: 7gi64k3kkgfsomj3qmg3197gg8rtpdzi X-Rspam-User: X-HE-Tag: 1735776369-398606 X-HE-Meta: U2FsdGVkX19NTxU/7ihm8c2Up/RX7sLrJbYORjdoTXUlFTyhBU4DWbjwtNDdzipWLPwt8O3wfXWswLH/+gFiyHPiKNJ4+hdJvdmezk5Re5ZIBgmgQ6j14BRCgLOKrTw43KiyMcR/0mo/y8eO6tWNxKDJDBin44FZ1kDA5oax7jyB0/aWf/Cihs+vttTs8JDy5P2dWa0Vrpjm5+d0IZOKicJGfSWCzsdoqThBSPbvVrhbSnlU41GYeDH3NTc1qEdtlk8Bz6IWWkmVSS9s63i0t51D50QCa87glQ6HGSLhNIxU/b1jtiC0/ZThZabjXhOXavGF7VkseudP5y5Es1s9xgxYuxl0jidOlRZgEZ0MTNX7juLsKOiCkhjwovaA0W6ehQ4fef7wEqVYUCzsJgL/Ufrm99YE35zOmVCti7xV7mNHJh6rDVvlUgt7j/e+YxilnZOPDi33oQwNXaWiSfH/KrrTZ4rgtJfR2/kM+eaoZiLHXwonBMQPPpgrEIA/vibjnx4Bxksft04YeMeZvI17v1PVqk7nw4uj87Gh09BHCpW68nDpnOuy5qvUx0yMNGBzWUOYrgc70KQT8swjj/N3QjKV3kkfKHKxWSSPgHqOWAlMw9xqlCdsxntVl24DQpYlmL+79JTk+/w2jhyMJuD93xqhBWXM6J+50lHx3B0p1bKIhr/5C55i16s9wqo6XIH25SIHtDYOiTlup5iX0lINnuH/tzAq70t8dMD6ynF9NzwQrT1ijVHgzRLsn1hX6PuwWYHMnyxY0weA0Gy8ypz9e2z3yO0nrM+WwfOLDLr4xSUTqgPgx9AY+ScdgNw5EKgFXFPXmgaHKhIJojAVnG4YLUaCp5Te50jzgt1JucjzQYQ+4gcds95YiOc7yHxSqpXVAkDOssQHR2BiIBBaDM4WcZLL1oqD1pJx5/bCjNAF1q+uMjMEZdXxih1nHHgdlqXoomQgfn3RrTUeU3UTUXg gMjWi/i0 mMYamQXxZAb3OtjDD7KOl2LHXW+KSoFRwZytWWkOS8ukpjm+sxtlx6z/2ddjyil9MJ/pRi58hrS3M2Y2E91tzjWfNuhRtl6DlVwrtPMFlrgw9pVW1tuCBDpApHhkhtpC48iZkw/wWl1ey3669IRR2Rv6e1DYddvf+t6JXlDkxDky57d1MB/E02iJqL5pm9S9fLQHcHpgPzR9F1SV88x4i+IwC1Jhgsl57Nm+lKST2odR1tIBafRUtC+Q5RRfJNhPEbzsxljghywjX3K/rmlV0pPTaO1f9MubZZnA8mx16HAEgo1l2Pbz7MKJXoabYAJw6wrmtisWzFhTmHdSgIQZ/jAQ5jVLnAP9I5l4ct5XVR4A4pJG3Rl/nPXTzNW60oOYVmjrI3+Dm4kZTSnnSU9QZLeec4kKyU9DmDuUUTdGl8s6ZI3GBhwoOoXl2fvFQXgJJxiwRJjSEmgxiX5KiJtrWua8juI/Y6AClJkgdCYupVHt+kUbYSzCNFs1VOXArP+EGZhO5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01/01/2025 18:23, Rik van Riel wrote: > On Wed, 2025-01-01 at 16:15 +0000, Karim Manaouil wrote: >> On Wed, Jan 01, 2025 at 05:20:01PM +0200, Nadav Amit wrote: >>> >>> >>> On 01/01/2025 6:42, Rik van Riel wrote: >>>> Fixed for the next version. >>> >>> Thanks Rik, >>> >>> Admittedly, I don't feel great about my overall last review - it >>> mostly >>> focused on style and common BKMs. >>> >>> I still don't quite get the entire logic. To name one thing that I >>> don't >>> understand: why do we need broadcast_asid_list and the complicated >>> games of >>> syncing it with broadcast_asid_used. Why wouldn't >>> broadcast_asid_used >>> suffice? >> >> If I uderstand correctly from Rik's patch, I think the list is needed >> to >> save the flush for only when we run out of the ASID space (wrap >> around). >> Without the list, whenever the ASID bit is cleared, you also have to >> flush >> the TLBs. > > That's exactly it. > > The list will only contain processes that are active on > multiple CPUs, and hit a TLB flush "at the right moment" > to be assigned a broadcast ASID, which will be true for > essentially every process that does a lot of TLB flushes > and is long lived. > > However, something like a kernel build has lots of > short lived, single threaded processes, for which we > should not be using broadcast TLB flushing, and which > will not need to remove themselves from the list at > exit time. Thank you Karim and Rik for the patient explanations. But IIUC, it does seem a bit overly complicated (and when I say complicated, I mostly refer to traversing the broadcast_asid_list and its overhead). It seems to me that basically you want to have two pieces of data that can easily be kept in bitmaps. 1. (existing) broadcast_asid_used - those that are currently "busy" and cannot be allocated. 2. (new) broadcast_asid_pending_flush - those that are logically free but were still not flushed. This would allow removing broadcast_asid_list. Then in reset_broadcast_asid_space(), you just do something like: bitmap_andnot(broadcast_asid_used, broadcast_asid_used, broadcast_asid_pending_flush, MAX_ASID_AVAILABLE); bitmap_clear(broadcast_asid_pending_flush, MAX_ASID_AVAILABLE); Seems to me as simpler to understand, faster, and may even allow in the future to avoid locking in fast-paths (would require different ordering and some thought). Of course, I might be missing something...