From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 920A1C54E90 for ; Thu, 22 May 2025 13:49:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C3C86B0083; Thu, 22 May 2025 09:49:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 074AF6B0088; Thu, 22 May 2025 09:49:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7E3E6B0089; Thu, 22 May 2025 09:49:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C5B3A6B0083 for ; Thu, 22 May 2025 09:49:55 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 807E6C1640 for ; Thu, 22 May 2025 13:49:55 +0000 (UTC) X-FDA: 83470677150.09.DFC3089 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id E836FA000E for ; Thu, 22 May 2025 13:49:52 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=akWnWdb5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747921793; a=rsa-sha256; cv=none; b=Y/fg4WcYxtLcDFeNFf6Ll5HFydYe2lySEr7PGQRIV3Cx7jtlcs568+YLAZ9mow7+T1mJEw ZJI+cvzi3Y+WwAMSIFeVqawwvIt4+qh8d/V097a8n6m164DzL8IssdXK2A4/l9UrEKgMmS hDOhBEfviJ81dJQMW2zNEfz17VoMd7g= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=akWnWdb5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747921793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L7ICUgElTJOvmuW/fRUrN0uPtBQoWoTMXBi3f1fVLcg=; b=yhotXarILOm0SAcRyu1PGVOvUk65iow5jkz2DqATsb0kLQCvoIX8mTABKd0kE7D7fu/44W mzYCJPV7uQa5CuriDGNcaMVswZFqXoFh4Y6PtKzU0fXj8tlaOYMoZYbumDlTtaj1stjDeE MUYGAptfM64Cq/2PXogbyP+AmXCcarM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747921792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L7ICUgElTJOvmuW/fRUrN0uPtBQoWoTMXBi3f1fVLcg=; b=akWnWdb5RMaQIjzhuRYHGja1TyFKfpOyJfUbqvQi9HE5YJtCHhap/ifB/DdZQhijSCmAET 02EqjaHHqGluXdD+6hzOXfgjoPqGH27msmp9x/kwyabFzunIlIbW0DcYALd41n5rmN4PVZ 9TSaR/6HKymqTizb6ge/6mg7zOPcHfQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-YAMHHKUkMXi2lmCwli7qyg-1; Thu, 22 May 2025 09:49:51 -0400 X-MC-Unique: YAMHHKUkMXi2lmCwli7qyg-1 X-Mimecast-MFC-AGG-ID: YAMHHKUkMXi2lmCwli7qyg_1747921790 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a3684a5655so2819520f8f.0 for ; Thu, 22 May 2025 06:49:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747921790; x=1748526590; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L7ICUgElTJOvmuW/fRUrN0uPtBQoWoTMXBi3f1fVLcg=; b=drWSMepuvb2wkwyQ0LTfd2X1EymGJzyFAIsrfTuz0AyK4KFpffacbfBM9sg0rz1uHZ qBwLXukhAsTdmOmwD9Q/iYVPKt/81iPbxjfwxp+wZSFc/yi9lL7JBcJXFHYQyi5qj/4Q ehkzE3Egg5nst7gRBuO4iLp9Q6RTl3d+8bPNCl0blqToatEfSbfqaEehJI/LRP1eeWUx w1LVcS53BqI9hWpSpioGI3Z/D1SgnDSQXhGyG313gWKcoEcIxMeCbWhKbjEuA6+9s+tt rS6b56YCB2QP4HoRHQ0EOTTcFZ84AqfEguxd96VuTBihHM3Rp8DUFi0xf3ZFaVNhnqV6 87aQ== X-Forwarded-Encrypted: i=1; AJvYcCXqzc3tOu2lMjYoVEm3q5YSLHVZ/Z0uPBZ2YfbVa38iaH6EfptjLr0YIR+OgSe56OZXXF1KhsyMeA==@kvack.org X-Gm-Message-State: AOJu0YxZQnEfH9B5CtPAn1srlzgNwbQl86yECfJQoAdWkjIMJBdduwmX vTaL2za6/41fqpDZfekoFfvy4yzgPhdoM9gn94K6HGBwhCjl7Zrls7hKwUPH+A08McUZyELkU0X 1klZcxfo3YcBS6KjPzpYBGrKcWFSI+0MD5TsItyqqcNmnMox5X0rn X-Gm-Gg: ASbGncs8awwErnSJlT8JLbmctlfB6F0SeKGg+GxOvFk9PsAGKtWus7utIIkt9EHqc56 8KWDGvw8jooXOMj5+XNg8y5ayUbFPdy47BOHVQcif7L1nETEYPs2gKz4dSdmUGhJkySHokmWAjK Iq9DDm1KGsslyL1Au3i7cmzav1ha/x4btBFDb1VsHLpB/bvR7PDchYnO2RTiJHJb1Mds9OYZbem PuZUNxFuWSuDAz6CYC86PcmQ6aGR5QYRkicZSqAyepf/mRos8KgfdHliUrLzaU1vx349Donb8nu xGD3Dc4TEUFzPs2DgEgw7T4nx43YdQ/0SrC7URbE0+tKQolydK8vtPRhTwEIemCY2fgXquuayJY mNNCbeM5N2MlzPbtwC4+0wA1n0DTramIztpQAIRo= X-Received: by 2002:a5d:5f91:0:b0:3a4:bafb:adca with SMTP id ffacd0b85a97d-3a4bafbb475mr2578840f8f.0.1747921790058; Thu, 22 May 2025 06:49:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvJZUocjHElLOP1bw5y0rdD1xEFO66HMenoF7MDlcuX++b3x46AoXstbEElsVoZWIJv7r2/A== X-Received: by 2002:a5d:5f91:0:b0:3a4:bafb:adca with SMTP id ffacd0b85a97d-3a4bafbb475mr2578805f8f.0.1747921789601; Thu, 22 May 2025 06:49:49 -0700 (PDT) Received: from ?IPV6:2003:d8:2f22:2e00:6e71:238a:de9f:e396? (p200300d82f222e006e71238ade9fe396.dip0.t-ipconnect.de. [2003:d8:2f22:2e00:6e71:238a:de9f:e396]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca888fcsm24405847f8f.78.2025.05.22.06.49.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 06:49:49 -0700 (PDT) Message-ID: <37346f0f-8f99-4979-9a0b-7276be6f34b1@redhat.com> Date: Thu, 22 May 2025 15:49:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 10/17] KVM: x86: Compute max_mapping_level with input from guest_memfd To: Sean Christopherson , Ackerley Tng Cc: tabba@google.com, kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <5ace54d1-800b-4122-8c05-041aa0ee12a1@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KdmXCKWVzqnAvrrePFFbNRrhZ2S8xvjK4ShXUpv4DfM_1747921790 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E836FA000E X-Stat-Signature: gyg6ht9waxboypucttwb3k4ab9p1z7ka X-Rspam-User: X-HE-Tag: 1747921792-246500 X-HE-Meta: U2FsdGVkX19t/VXrSSqT0cwvvCEZaUqCfbEtOgieo6EnEmPUL5pQ79l5ig/+VyVl4mhuJce6Kq6wdln8NWDfOmRm5OM8kkwtqwqNEGhn9pEWkJXkmtbo3q2bgIFmECWG1IccjoXLoExSlehKfHaVK7VVCd8sCT52Nlk7mRTlkucTK+FaW82SrlXla/3tiUa0WTCRLyDxez/Af+YOB0Px+cBqKhNAFI4jJd4nHGHtwgdJdzwBz0C3lla10bjdbnPo6jV3AfcBriYysuOtBv6NJzenAjaTVOLisLWrS2jsOjJ7NUDWpuUhX3mgbjQTRvVlunuCkuc/je2LkAsSRMUDtUGIke4XwxvVJV3C42HsRGHXtbzrQu2Y4txJkwMBqqUmm6VSy1phufMIFqpzBptTJGoWV74/tn2aUZqzhIlfQpBErWhYu7ItDagGgeWqCH1U9rVBC0dQF+nLn5UQccIIlbx2hlDWJJddpLdplVI50oYTwgWsIIcaBvJGGownvxPwr+lOZbCgqyOkqzBJ9n54VTAvAC1RG0Hkc6VTz3WRMBTEAhrf0ak1NoQ+zofnMvVlyfvExwMMSQ+BKBUYQVNhk6hf9+hRJCOQYIio/dULPUuX036VYeiEdDKUArJPmihMILaKtxEgzyyr2smxoB68GNrF1xdPjF8P2DSkZYjwoAophe0q8zHGPsbBm1thvrkregBeIpL0NHpX4Wy1ecByK9Y8BYYpFpdxwktYV3hhDfY9r8BG97jp5kYdUe3M12sAKYFuEZ9A+S1fdXrbVOEy+X8sDm9AulTvQ2RmTcrTIECMZlpsZhhH7HLfOhn6SHsjXxxHBOt6ZSmMA+YaWiRNimaaVXOTwDMrseJ913XsmZbO1BNHob6hoxnZFkd6g9FvLUN/B5Uo0ggc1IuHnyEz/j7Al3U5TsaF7TrvSkvoxI2Y2UWj2B6TGn3SrRwP3GpDKTcc2UWpyHwHuViD1LW NrkKImFa 805beOJd9pYIxWQUaZQfNf5mETZcl0GUvEDNBNt3se7LD/Be9PRblWA5+dgPG2t9Men7XLDQ36GXoan+ut1gOBQfeVkq1gDIaPJHq8qgrR2AFKlgiu4I1LL0ts5NwmNCAiYHgIVfFptJTy9/xiYlSsCkRP4GGVhmTbRbILhov+GLLm2u8wX5nV1REfXxcYFh2P8KBJ9V7ITmYbxpiV5yxgWSsy/zpREmdo9kZdGPrIy2hwLFvYynsjzF7u/zYRtkGbyqDe6sq7HNj5m4jVq9JTcUK4buKfNehAes9ASlPTXryfcAjMrgmTnQ4t/Hf29tJ8gbFjbemK+rJGdzHarY1XmDmZ2859LN7zRbeEmuphIOlDeaoo5M3AmV6Stb9Zuh83VwULmCcRPhxvXdRyn14ZBdz6g3o0UAeLppJ1trvBMN8JvKC7B99Lfqts/I6XAi1IT9VutFiGE2w4bNdmodvIFx+HFtaIYoroKa95ceVPfp0U+GzshCguatf+Dyvzzc0h1/23sP8aUsDejY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.05.25 15:22, Sean Christopherson wrote: > On Wed, May 21, 2025, Ackerley Tng wrote: >>>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h >>>> index de7b46ee1762..f9bb025327c3 100644 >>>> --- a/include/linux/kvm_host.h >>>> +++ b/include/linux/kvm_host.h >>>> @@ -2560,6 +2560,7 @@ static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) >>>> int kvm_gmem_get_pfn(struct kvm *kvm, struct kvm_memory_slot *slot, >>>> gfn_t gfn, kvm_pfn_t *pfn, struct page **page, >>>> int *max_order); >>>> +int kvm_gmem_mapping_order(const struct kvm_memory_slot *slot, gfn_t gfn); >>>> #else >>>> static inline int kvm_gmem_get_pfn(struct kvm *kvm, >>>> struct kvm_memory_slot *slot, gfn_t gfn, >>>> @@ -2569,6 +2570,12 @@ static inline int kvm_gmem_get_pfn(struct kvm *kvm, >>>> KVM_BUG_ON(1, kvm); >>>> return -EIO; >>>> } >>>> +static inline int kvm_gmem_mapping_order(const struct kvm_memory_slot *slot, >>>> + gfn_t gfn) >>> >>> Probably should indent with two tabs here. >> >> Yup! > > Nope! :-) > > In KVM, please align the indentation as you did. > > : Yeah, that way of indenting is rather bad practice. Especially for new > : code we're adding or when we touch existing code, we should just use two > : tabs. > > : That way, we can fit more stuff into a single line, and when doing > : simple changes, such as renaming the function or changing the return > : type, we won't have to touch all the parameters. > > At the cost of readability, IMO. The number of eyeballs that read the code is > orders of magnitude greater than the number of times a function's parameters end > up being shuffled around. Sacrificing readability and consistenty to avoid a > small amount of rare churn isn't a good tradeoff. I new KVM wanted to be weird! :P -- Cheers, David / dhildenb