From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E630AC3064D for ; Thu, 27 Jun 2024 13:00:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BFBA6B008A; Thu, 27 Jun 2024 09:00:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56F036B0095; Thu, 27 Jun 2024 09:00:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40FAB6B0099; Thu, 27 Jun 2024 09:00:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 257856B008A for ; Thu, 27 Jun 2024 09:00:31 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6FB39A0358 for ; Thu, 27 Jun 2024 13:00:30 +0000 (UTC) X-FDA: 82276677420.06.0E46B28 Received: from fhigh3-smtp.messagingengine.com (fhigh3-smtp.messagingengine.com [103.168.172.154]) by imf21.hostedemail.com (Postfix) with ESMTP id 6EAFC1C0028 for ; Thu, 27 Jun 2024 13:00:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=KUmBRGdI; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=Id5amWiO; spf=pass (imf21.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.154 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719493217; a=rsa-sha256; cv=none; b=mMQVJahaiSGgdtnCUIdTqmzP7Yrw1WzvL4lkWAi9gIpxyH9ABhNJPHCrljlfjGuTAYToHv 5gggrpNRLdc7aSs0jeYP9SzBhynrk3ZVz0gQx4lnx0cH74uvIkpzoc5jVPXuIIMNbsCSkv nwFRhnr1k0zxxxiYj+rYQ5f/ZqPUKgE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=KUmBRGdI; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=Id5amWiO; spf=pass (imf21.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.154 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719493217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SaPRVN9+AjgKYt7eKG84QyPDe0b8SyRoJDobeWJkzD8=; b=6uZ0KiGPdQ/U3LSgxmrY5YSKrJF9UXRNGwcN3tkXL0XtDGxbKhwVgCcbTAlit02iPABrir WY3bfB8v5dPuA33IQV34Yv7kLSNY0yYYEqSn0r/PIOisFvX0kzdrZ+zm6v7Hxe9QGBrjc7 F9BgsPw1D5BlXZxfbFm4L9tx237tigE= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 690011140297; Thu, 27 Jun 2024 09:00:25 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Thu, 27 Jun 2024 09:00:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1719493225; x=1719579625; bh=SaPRVN9+Aj gKYt7eKG84QyPDe0b8SyRoJDobeWJkzD8=; b=KUmBRGdIUf5FWf7rQXCmh7UHb8 iWaNMubHRVwhjcJ6jdNkq5OXjuKH9rHOsL1aS8A5sttLGDMIsmha3zr58XJY6XTU Oyel/FgZYQcddBNZ0/eJk4xbrhL0xiEROWbKANigGKyAzWAVhqpHA4SoETJxXrhM n2ea3NKDk2ChSj87houXAh9dQMwk6M0WLY6VwTr0q38ZD9NKd9Y4cxE01SeL+p6w fO5MicY21BFRxhMAvUhFWN8N3b0Ji5Tc8VCBau8hQ0Y78vMqZLLEL195NQ5f3j15 mKpObT/xfDU+NVHR7j9lkQJjSojtbnDftSPXNSfVEyvhiWvvBg5iGtvUxByg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719493225; x=1719579625; bh=SaPRVN9+AjgKYt7eKG84QyPDe0b8 SyRoJDobeWJkzD8=; b=Id5amWiO2NMu6jmK6d2q/dqQpdqYpWoqufPq03NVdbOU BDPRxQbgjmmP5zgJkfcjVRUMtkduBZvJHwzp4mgo7FO0s9OLetP2MrvbwOYhvu4T 5P/t8G0r/v2513+x7WbHqpsAhVsAOT5B2V5Mp7+fiPy/XXr3SbYHTRlAR1LVH7Wm Kj0uLqROh+eNxBLg2NCeTGqtLTMc1Q0lnGFFtmOimxQP+iO5PbGOhR2w0wFlbdv8 zHdPOdPCUdYwmAavm740u99rAr+xP5ucHMrm0D0XI3346j9JDnDk3pRtJa4LuUvi f1fcuI5J+63rAsBXBB1ZFGwv97dZnGceCv6k0LHr5w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdeggdehlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 176F5B6008D; Thu, 27 Jun 2024 09:00:24 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-538-g1508afaa2-fm-20240616.001-g1508afaa MIME-Version: 1.0 Message-Id: <3732da73-ecad-4415-bfa7-0f9ad6b2a58e@app.fastmail.com> In-Reply-To: References: Date: Thu, 27 Jun 2024 15:00:03 +0200 From: "Arnd Bergmann" To: "Naresh Kamboju" , "open list" , linuxppc-dev , linux-mm , lkft-triage@lists.linaro.org, "Linux Regressions" Cc: "Jocelyn Falempe" , "Anders Roxell" , "Christophe Leroy" , "Aneesh Kumar K.V" , "Nicholas Piggin" , "Naveen N. Rao" , "Andrew Morton" , "Dan Carpenter" Subject: Re: powerpc: nvram_64.c:75:13: error: 'oops_to_nvram' used but never defined [-Werror] Content-Type: text/plain X-Stat-Signature: gzj99dfmxz4nxiiac7mhs3nqt14hahj6 X-Rspamd-Queue-Id: 6EAFC1C0028 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719493226-456075 X-HE-Meta: U2FsdGVkX18ldB8j5xk6Wls4fkmUlS0L8+2ylih0VOCcrzrM8Y42e0PR80gjDyLmbyaIi2w+ez92kYDRI6l7f/YB3Yo2ljd8tC96tjmkxFrxOpilX0XtXSKyhGaWnuenCnl9G+9oOmHPpg/UL5NRuV3m5LNzh/VN4P/HTu4W3QYb1AcyVAvxrdVwHHTKRPdQaCjD0NNjuot17Q0GU5z25lVGqSyX5qb01oHsUhSvZ1zhLc67iB03E1cdOKebiXOytvn9ohol4hWFGfXNWes2KU3vcIHvFmxDpTLcubNiCaBVlayg7wzLfBx27LKU4u3HQd9PlqIEn6Foo7ayJwZRVPdybx5sGXLaXLBRtG+FLXQNPfGWs7Gz1M7cgeyy5Mks+pzcK5zImd0zyF/7MYVreIGVSJH4gCWN49DLCsid7xoqtH8oh3N4O1qoagtmBiB23vteFiMWemOBgUZoKLJ7xErhUySU0/XxB6sRE+Zrdev2t3d5HofqzPpOr6P3rxIfeknSauO3Ib1R5fnu2ao3qU2VoDIgBlWcMu/k0KB/f43JIYrhwkt9bieH3PMquRkzu2Uf4/j6rGVv7VK85ZPuBlfhwEH5mUmkW3BRbBDI25ypMBqKwpOOhl2LoXgto8Kfta6iBW5TWC4TAncM0zShIAyJq7LNVaPQttoWhj4PDMtH/e/LABIozbvlQQsFp07sPgbt2Jy0wJU7Q+HnRPFjUVXD231Eje47S5rjgXLi9/OHhw3hS+GJ0RGXn5u8N0hrqmjS9MLsOT01K7dggLI1SORA0qLTkSI74QyKLLuYpuutBI+YfTIMKyx/HSMXJfQrEidXgNJdAtQu+amPyDOr6UfiCmmBIg53IWz949Iq52eRH/QONrdOHQF+u0NStDIbd1kYcgrv14eimDOlWBNBtBVeNumVKh+zTTakyXT5xeeWKcSV4A+y4/vrGAj97tnFfvgQpIfHM5GavPjZixF 6Y3lbFKD wIwO5VY72pRITrcp8QOc5XdXPOXRpqQ2fPrr2CgL/voFDuWS4JYmMt3sg647MoUHilEtQDEVN416KTm+RDnYr+HRwtr0vD4xScNo5XwdDIYIc41bkzwLUUh16rhKJjy1lGQxTU0XAFp27PvrDFwd/TOnJNL1lRRTCQuxR+sKLq6vS8yXyjFuBKjmQgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 27, 2024, at 14:49, Naresh Kamboju wrote: > The powerpc builds failed on Linux next-20240626 tag due to following > ---- > arch/powerpc/kernel/nvram_64.c:79:17: error: initialization of 'void > (*)(struct kmsg_dumper *, enum kmsg_dump_reason, const char *)' from > incompatible pointer type 'void (*)(struct kmsg_dumper *, enum > kmsg_dump_reason)' [-Werror=incompatible-pointer-types] > 79 | .dump = oops_to_nvram > | ^~~~~~~~~~~~~ > arch/powerpc/kernel/nvram_64.c:79:17: note: (near initialization for > 'nvram_kmsg_dumper.dump') > arch/powerpc/kernel/nvram_64.c:645:13: error: conflicting types for > 'oops_to_nvram'; have 'void(struct kmsg_dumper *, enum > kmsg_dump_reason, const char *)' > 645 | static void oops_to_nvram(struct kmsg_dumper *dumper, > | ^~~~~~~~~~~~~ > arch/powerpc/kernel/nvram_64.c:75:13: note: previous declaration of > 'oops_to_nvram' with type 'void(struct kmsg_dumper *, enum > kmsg_dump_reason)' > 75 | static void oops_to_nvram(struct kmsg_dumper *dumper, > | ^~~~~~~~~~~~~ > arch/powerpc/kernel/nvram_64.c:75:13: error: 'oops_to_nvram' used but > never defined [-Werror] > arch/powerpc/kernel/nvram_64.c:645:13: error: 'oops_to_nvram' defined > but not used [-Werror=unused-function] > 645 | static void oops_to_nvram(struct kmsg_dumper *dumper, > | ^~~~~~~~~~~~~ > cc1: all warnings being treated as error The problem is the forward declaration that was not changed as part of commit 7e72bb7504d1 ("printk: add a short description string to kmsg_dump()"). This should fix it: diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c index e385d3164648..a9da83c4243a 100644 --- a/arch/powerpc/kernel/nvram_64.c +++ b/arch/powerpc/kernel/nvram_64.c @@ -73,7 +73,8 @@ static const char *nvram_os_partitions[] = { }; static void oops_to_nvram(struct kmsg_dumper *dumper, - enum kmsg_dump_reason reason); + enum kmsg_dump_reason reason, + const char *desc); static struct kmsg_dumper nvram_kmsg_dumper = { .dump = oops_to_nvram Arnd