From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74EC0C77B7C for ; Tue, 24 Jun 2025 10:17:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C593D6B00A7; Tue, 24 Jun 2025 06:16:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C304A6B00AA; Tue, 24 Jun 2025 06:16:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1EEF6B00AC; Tue, 24 Jun 2025 06:16:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9E4406B00A7 for ; Tue, 24 Jun 2025 06:16:59 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 434A71603BF for ; Tue, 24 Jun 2025 10:16:59 +0000 (UTC) X-FDA: 83589890958.23.6CD9BCA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id B9BA9C000E for ; Tue, 24 Jun 2025 10:16:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XDAOvGzJ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750760216; a=rsa-sha256; cv=none; b=E7TU0GRyd7VNTxVZSMW1JkSJh/QTdysqKZ4DeyzwxAm21U+5IkNA5HPlEP6ch1BbSEDgpr hidtQNyByXxrxHjFy/LjaQdETDz9JtqRwXJ9PWMtpM+k/xITta56XidudjfeFNR4VHnAt2 6H6YBqg6oYLP02qQa/v0ov8tEWSsJs4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XDAOvGzJ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750760216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e8dNKC0X6bQu3TedhJQtwWZN5XrLmAV6V9h08RG7LQU=; b=bZGxRgqfd3Z1svp/lNbBA6eoGUbuzGV4/VWPXOafTn0VpckRxZAq2wpxEHHa4yAfm0Zo/y oRKrxtkGoKbSCe0poX/Xd0Jf1l1Yf726MD9ZQuwo8JRuYTB2uMvOCKXoGUbImWY686fQwA Tes+IvZFEIgK+VaDTfuNBgRYWOXYWTo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750760216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e8dNKC0X6bQu3TedhJQtwWZN5XrLmAV6V9h08RG7LQU=; b=XDAOvGzJ6EXKnvGXHCozoTu9bQZKwIIFocJS+/RjhHxbFu14sUPyFeBEPWsdV6cUNlAede QSVKtg1X29hPTp7wjYE2SQVny/dBb9BSpclNCW0e48uVvazchpCPyx613jVcf4oAiEfSx9 2ekhv+Z6r/q0fUEwqDg50SPt7MeL0q4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-2vNjQ-ujMgCdKI09i0wBuw-1; Tue, 24 Jun 2025 06:16:53 -0400 X-MC-Unique: 2vNjQ-ujMgCdKI09i0wBuw-1 X-Mimecast-MFC-AGG-ID: 2vNjQ-ujMgCdKI09i0wBuw_1750760212 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45311704d1fso32914945e9.1 for ; Tue, 24 Jun 2025 03:16:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750760212; x=1751365012; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=e8dNKC0X6bQu3TedhJQtwWZN5XrLmAV6V9h08RG7LQU=; b=eG0X3KlNuWCKETTFQYAGvAiEd9wkak8Iv6KWyBfjTdAfH9ZXE/m2+XMt/0eNmmtqk8 ptyB/f1ZTG08UEBMxKsYuKe/kP/ccWehLke7qwxEj3m1Ewa2X5Kmj3m9Yub4GCAet9xS +3YAh40vBEdUREo59ftaBZyaPDg7OsY2aosdemUX+w3fRsZLHaMsdFZS7AGqQWkqx1pl ub0U6EpCUOWdQEh21cWXw0GOkSYbHKxFak2+tV7myWaZ4PI7K1IRFY6mBo5Ciszr+o0j BujbH1L7jqPsvDEWWnau4Wooy7vE3X329jyCrhk/vKkl67rfXDCpFz5UAc67JlKIOxak tU1w== X-Forwarded-Encrypted: i=1; AJvYcCWNIpJB+OvIQtk+6wGHnm6ykns0vz9dHoc+1rQ6QSo/7fCA43RYUmjiLdTfJWr8lVpJhlnKIkJyAQ==@kvack.org X-Gm-Message-State: AOJu0Yw7VlKfYF94iBhIdlQpHfC17b+m3iew9Cuq9T6g/w/idirtrPck ZtEPW4CZFbLrXvlJn8z8xhTmVDnCSN9h5wzDC0B1X3hFITWsbmQ855kjtZhd4/O9OT9MuvrjDlU 2lq5JrA/l2Y0jYKMOY/VKwfkgFKGlauiwFsajRWNI2y/bvxartJjJ X-Gm-Gg: ASbGncsmRh9afQwtXVpS7spyTkhb7jnQr2cGILZrMZoOrdrqGIJdTghyW8ktASzc5V1 GaMEGZEdSnhxdvK1jInJb/U8H1iYSL6DPuZpHinolaIoBxaeqtusGpllntmalos3t+IzCnqbUq0 PhrZt1B4psHxg8knP33MG8uXuRw1hxCHPQYKyU8yGDQV4rG/lHQCiIns6H1ng7Q2neN/3OBgnju /T79bUkFeqrKBYDvp1jOZ4YbIBka7lSs8BGuiza5E8o/7rpMDnVvyz+dUF1C4tR1b4p/LSpmIEj 5quW5wfCnJJbMxrYqryIZyruHLkHKnjSQcRJedONpR4tq7am5pREU44= X-Received: by 2002:a05:600c:3b83:b0:43c:f513:9591 with SMTP id 5b1f17b1804b1-453659ca16cmr163569545e9.14.1750760211630; Tue, 24 Jun 2025 03:16:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEX0VcTFdiCx5jjkFEDifcYlhqbdTljgPaOYfiwFQrIaleDtnv03N4HZ/siPyrW8guste0lAg== X-Received: by 2002:a05:600c:3b83:b0:43c:f513:9591 with SMTP id 5b1f17b1804b1-453659ca16cmr163569115e9.14.1750760211185; Tue, 24 Jun 2025 03:16:51 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453647f29bdsm137196525e9.18.2025.06.24.03.16.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jun 2025 03:16:50 -0700 (PDT) Message-ID: <372bbfa5-1869-4bf2-9c16-0b828cdb86f5@redhat.com> Date: Tue, 24 Jun 2025 12:16:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 00/18] KVM: Mapping guest_memfd backed memory at the host for software protected VMs To: Fuad Tabba , Sean Christopherson Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250611133330.1514028-1-tabba@google.com> <80e062dd-2445-45a6-ba4a-8f5fe3286909@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gFQw23RkxV4o69CRhS2gPWmtxiyPi3WVBr_TD2JztYQ_1750760212 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: B9BA9C000E X-Rspamd-Server: rspam10 X-Stat-Signature: wko63xwx7mrirx8ey6k8uron7h77xjne X-HE-Tag: 1750760216-152849 X-HE-Meta: U2FsdGVkX182TXDByINDOzRae61yPKYTnDd1Z2MT6uN94yTpSwWMU4xGkKieXrnxIOoRw+xnQCOZQtqrB9zbun70b947ORr79kgqiWZc0Gvq5zWE2z1Kzrp67CtccQ16ZcxidnnkLzf2K3Z5GIUrgeHYsDe945O+QXSHI4GNgZT5mDVJsr1BAwhupAihltHl1pDzpR2zSJ22low506QLMylpCCqPiySoCaTKJ2uELrWJ6+JLO5CFQWHHbnEzy5ZtOkqvNaPHUYzcTOSKWm0F4dw3zXdb7Aml09KZxq2WZ0pdHPpUGq7fEnD6fAHqMGAnGfuUIwXhT86duFdyrRTbM9iahE1lrc7XmmQbQjKvhLKr90CGdc31GrkYg9vEZm3htqO3v3v5gUStd1eBJQxcw/T8s6wOMD02Uj4+Zp44u0/ZCaU2fb35tKpzm7bVCiaBQhw8dTP+V9IxjztZ8rITm7X4mTMiYPgtVI4pju+JlItfed2Ksfy3jtSBrWgSyoYnVq3mhAMh2KX3Dg02P+/ihGQDXNQ2huaIs0HoiHufZveyziRRUFuUtfMUdMOvf9lf2/4TilzfhCd8g/lTYQy1CbrMwYtYk1Su74gHGoms4a6iv6HNQnPV0D6daWXQvLZW6MSJB5zoUcmxWhme9laB29zUj0/CWP+vvHTtpJP3gucNstKB7wawR25m/F7Xz1vMMYY+QNm3Tb9ypVa19lXfjWH6gC1M37YD1Tp/IhPwIs4BsgCpESbz6DX+3rtyypXOMU0pNzQSRIjtmHhM4iHDZa6snBuNzLi4tORQduiJrREkv8eccEA6AucQZorXJ4aOU8Nxzgie4KXtpJnbCNPVdtlMCK0tQhFVxdcu5pOMgEM+c7KpphTOZqfodbjx0OzC7XLrNxfd4y5zR3Sdv3BSKXkfrS35yIUciqGdMP6baOBzJGXt9FuLmE2RdW0jnnAwkWCaItAKTcsEH/3Eh+G 4J+DrxVU 08VGdG6/lBqYU+e41IanmvAwgUFx7eGJ+oMSycnbi0g2arSoNj2nHvPef3xh7eAj3Vi3XPoG2vPyK0YgS0uosFdRovmf48g0VNi6UnjrBY44oY/Pm12x2vcXvUr3uIre//P1gfJcII+wt1OwrNYCfbvirm+oEt4VT1iVGV0uigRgScfIVRgWY3I4xmLNSmoY43hwky0WqdEEyj7gDzAM21zcEFoD5XLubVYPO/rZex4aaR2kf6OeUlyHyyhv7a/5dw5q1HkuwYUgXQ+iGDDBMy/OxVYMG15MoNm4lWUigkoEIrnoYLJTG8SJIo2WBivuUv6kYpgHGStXVGXosWFFHOIXg67DZtxH5criNL4TmJzETGSa+70ugijNg5E0pTQOdgA94cE93a5Aq7JJe1cxcVQBgP33vvPHgN13Z8QI5fwjsv7DH+eCJTwNmricBbU6bL2QlE7CdC/ZJgu4yXAW/foOTf7rsRw5Yz0y9lqXrInwxi4WdPtt6atUW+NZW/KNAWdMHXQ5/WSrsG27SJyJPDIccXhb4DxBmAv9j4YFhYDA1AdGfdz3bPcJ8dLb4CMJBIJtqBBFTuscScYc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.06.25 12:02, Fuad Tabba wrote: > Hi, > > Before I respin this, I thought I'd outline the planned changes for > V13, especially since it involves a lot of repainting. I hope that > by presenting this first, we could reduce the number of times I'll > need to respin it. > > In struct kvm_arch: add bool supports_gmem instead of renaming > has_private_mem > > The guest_memfd flag GUEST_MEMFD_FLAG_SUPPORT_SHARED should be > called GUEST_MEMFD_FLAG_MMAP > > The memslot internal flag KVM_MEMSLOT_SUPPORTS_GMEM_SHARED should be > called KVM_MEMSLOT_SUPPORTS_GMEM_MMAP > > kvm_arch_supports_gmem_shared_mem() should be called > kvm_arch_supports_gmem_mmap() > > kvm_gmem_memslot_supports_shared() should be called > kvm_gmem_memslot_supports_mmap() > > kvm_gmem_fault_shared(struct vm_fault *vmf) should be called > kvm_gmem_fault_user_mapping(struct vm_fault *vmf) > > The capability KVM_CAP_GMEM_SHARED_MEM should be called > KVM_CAP_GMEM_MMAP > > The Kconfig CONFIG_KVM_GMEM_SHARED_MEM should be called > CONFIG_KVM_GMEM_SUPPORTS_MMAP Works for me. > > Also, what (unless you disagree) will stay the same as V12: > > Rename CONFIG_KVM_PRIVATE_MEM to CONFIG_KVM_GMEM: Since private > implies gmem, and we will have additional flags for MMAP support Agreed. > > Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to > CONFIG_KVM_GENERIC_GMEM_POPULATE Agreed. > > Rename kvm_slot_can_be_private() to kvm_slot_has_gmem(): since > private does imply that it has gmem Right. It's a little more tricky in reality at least with this series: without in-place conversion, not all gmem can have private memory. But the places that check kvm_slot_can_be_private() likely only care about if this memslot is backed by gmem. Sean also raised a "kvm_is_memslot_gmem_only()", how did you end up calling that? -- Cheers, David / dhildenb