From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA2ED6DDF1 for ; Fri, 15 Nov 2024 11:02:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD4606B0082; Fri, 15 Nov 2024 06:02:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5CBE6B0085; Fri, 15 Nov 2024 06:02:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 889266B0089; Fri, 15 Nov 2024 06:02:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 66E726B0082 for ; Fri, 15 Nov 2024 06:02:32 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EEA261C61DE for ; Fri, 15 Nov 2024 11:02:31 +0000 (UTC) X-FDA: 82788039558.23.1DC6A27 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id 50C4640006 for ; Fri, 15 Nov 2024 11:01:33 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="lt3/8/f0"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dcZhBi6s; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="lt3/8/f0"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dcZhBi6s; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731668493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CaKjRLnpC239oXGpUgc4pPUvL79CAjd8/+DsZGm6FWA=; b=M0Q0hcqgBDQLnso9L/YTQvQwOldKiLEziVs2Y1L8drfRKz9/CPISot7I49a841CPhxs7Xw xS4mraQGRYAcTTQaqubBvYYMX1AhA+2SgoxxjxD3m7X/BZuutEZ+HCgb07u9S6PKRR361p of7+hSsgGEpLyAaXmjtfEHaqF2ubKZY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731668493; a=rsa-sha256; cv=none; b=t4ve8o4kgMgyq0wp2KjOC8SirwjpYVeO9I9oeZlHH1YtWOtgW697fTpznVBmp6V9VFWdCJ +ZrJlmZ9owuRmMg0qeRmO+mMpngkuGge/k26OkRQ0D08kfz94VVv3awYzz9QZ9mYV43tqJ sdn3YDhpSfidfGVGrfxOFyvpYMwipqo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="lt3/8/f0"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dcZhBi6s; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="lt3/8/f0"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dcZhBi6s; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8E2B11F806; Fri, 15 Nov 2024 11:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731668547; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CaKjRLnpC239oXGpUgc4pPUvL79CAjd8/+DsZGm6FWA=; b=lt3/8/f0c3WlY/vrR0AOc2qvRjF3TDonPcpJ8xJeRJxCS32JcwnIE+/BX+8WSyfnxT6ZgG UahfbtsjH1fXMiXmLKtzKhD6D/HpMBQh6DJom8wA/F+3iBOVX21PYxAK63rkiyQ9WzLCdj JXoRGqEqSU4BzD2vfbec8gbIVEG+yu4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731668547; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CaKjRLnpC239oXGpUgc4pPUvL79CAjd8/+DsZGm6FWA=; b=dcZhBi6sctJO037ibHyDh47nMXmWPOWpV5y9061fcmTjrn+Iqh2nN0tczx+oV4yiw1uN0d VILiEKc9pQgV7GAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731668547; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CaKjRLnpC239oXGpUgc4pPUvL79CAjd8/+DsZGm6FWA=; b=lt3/8/f0c3WlY/vrR0AOc2qvRjF3TDonPcpJ8xJeRJxCS32JcwnIE+/BX+8WSyfnxT6ZgG UahfbtsjH1fXMiXmLKtzKhD6D/HpMBQh6DJom8wA/F+3iBOVX21PYxAK63rkiyQ9WzLCdj JXoRGqEqSU4BzD2vfbec8gbIVEG+yu4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731668547; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CaKjRLnpC239oXGpUgc4pPUvL79CAjd8/+DsZGm6FWA=; b=dcZhBi6sctJO037ibHyDh47nMXmWPOWpV5y9061fcmTjrn+Iqh2nN0tczx+oV4yiw1uN0d VILiEKc9pQgV7GAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5FA1213485; Fri, 15 Nov 2024 11:02:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cSv9FkMqN2cdYwAAD6G6ig (envelope-from ); Fri, 15 Nov 2024 11:02:27 +0000 Message-ID: <3727258a-7caf-4f05-b8a9-20ab82ee4ea0@suse.cz> Date: Fri, 15 Nov 2024 12:02:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] sched/numa: Fix memory leak due to the overwritten vma->numab_state To: Raghavendra K T , Adrian Huang , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Andrew Morton , linux-kernel@vger.kernel.org, Adrian Huang , Jiwei Sun , "linux-mm@kvack.org" References: <20241113102146.2384-1-ahuang12@lenovo.com> <1c8e478d-866a-440e-a11f-80fd210cc5ca@amd.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <1c8e478d-866a-440e-a11f-80fd210cc5ca@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 99pmug8573nibi781a31fpzkah6cyzu6 X-Rspam-User: X-Rspamd-Queue-Id: 50C4640006 X-Rspamd-Server: rspam02 X-HE-Tag: 1731668493-252660 X-HE-Meta: U2FsdGVkX18pKRB3OsP1HgngGM5Di2kgTCFnFBkVIqCzWICi9YoqkT0BXvsiVtVfOnbAG3YS3iAEtWQz3gZ1DuMmIxpIGN1ohB2CK1bP7VEAN7Ja637Gj2Kla42QGJGa9yp9Ou3qFoJkeoEZP0iXhAdM2hQ5dgwIhYSJmrg2pvp/6LIGakA3zhkZfggSlCXhSbSDMlfOdbCie71dVeEPpHOGuOlMNJDf5lA04RqqeJ5ZiDN3JahhbQf2AVoUyUUJ2upRqcGclHpij6yvfRlRENTkrbdG8YR1CpQpL/lCS5C/gY1LNOsT2lBeVUG4wfprGQZPa2Ftzor3SfuA3XdEqF2zg/BvpCsVKDU6o7LGTHs2sbVbWVOXXpx9GjndE6pcagBxrG/GrM+taSjj2Yy1rnt3W8d+eff9itJdsCEIv8eRHLgugLo3k2Sf0l/49GV/ExzmYrCNo6Bs14XoiVaWhWyXYvI0t1GXGU3sh6rovn9oy4qPkee0caOFddSAwxRtPnMy9vIkvPLO+5+8hax14ta5LhgidDksJIkVehPl1AAuYj9965HquAfLhw9pqExwpmZjvLcMaZFNhz/HuQRB7/334giWKzztMJCjo5MFUyHC6KAFnIjBilWQafW93Rd7ER8aDuPO2HXfzLf42jPn4r/J3UtX5OgiBcqR0FxAripqX3wcWBQRaQd3r4mXdYwxdhsXjdAfpFmf8f3FCTwfZWhXIPJpRjM80e1r5W9zQk/UFUqXuscJ8fYBauRFGiqP27LIin9ObyKIWLGt+uxQ9PJxnXu0uaskUcBVRLbxtswCSTU7N5RuCsXN90l22TVEp+QgXeDIr/gH8IVybj/aEXPrxi55Hegf05lh1Jj4n4q7jV5wWLohpclvmOo73sKzXWyIfRnzIe5B+QyhULIBxVyLHTnNw7c337+0a9BXd55UpBlh1WQlovB+BG4qNYZ5by9S5emRYIpQRFRpkOp jIIvcOD+ I87fy0FuFvC0QI2dnnASDGTeV0aJeNiV5XfIStumKh95ugaHnV9wSZxQYzTYsLpub+5MoY6FRCy/yxztpwkAZIWR+Fp2ZF0ZCz5KoMxLiWzSg2gXKKB3tpIQvMjoaZ1mBnFjAElUmi2j0Y6LdNgHr47utcpLqrZB6qInlSD0NylVwdRQWF+kMMOIPMQNLvEZw+aZqz1E84j/BTfOUtFdaXerkhp+7TV17BnJN0P4FSg/ljFki+IPfQ8/kAJQ065MBMapp/cFsFOUWvo6ooVYPUt/jaAmAB33YYmT7gDVvqTBhoaYKR67QLewb+KSDx/Oy+l5IneFna+zK2J4Js3J3e+DrxPMXGT8yCgbOwmRNT/fu/vUqlUOnpFRrkklC/OgHX2N8ud7weuoZ+47zYU5VRpg+09Q4cyE7bNzZE1G4P/5eYG3tJxUd92tON77ZIZhK8kHm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/15/24 11:45, Raghavendra K T wrote: > + Vlastimil > > Looks like he was unintentionally missed in CC. He has added Reviewed-by > to V1 Thanks, seems I did it for v1 when v2 was already sent, and without also cc linux-mm I didn't notice it was. > On 11/13/2024 3:51 PM, Adrian Huang wrote: >> From: Adrian Huang >> >> [Problem Description] >> When running the hackbench program of LTP, the following memory leak is >> reported by kmemleak. >> >> # /opt/ltp/testcases/bin/hackbench 20 thread 1000 >> Running with 20*40 (== 800) tasks. >> >> # dmesg | grep kmemleak >> ... >> kmemleak: 480 new suspected memory leaks (see /sys/kernel/debug/kmemleak) >> kmemleak: 665 new suspected memory leaks (see /sys/kernel/debug/kmemleak) >> >> # cat /sys/kernel/debug/kmemleak >> unreferenced object 0xffff888cd8ca2c40 (size 64): >> comm "hackbench", pid 17142, jiffies 4299780315 >> hex dump (first 32 bytes): >> ac 74 49 00 01 00 00 00 4c 84 49 00 01 00 00 00 .tI.....L.I..... >> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ >> backtrace (crc bff18fd4): >> [] __kmalloc_cache_noprof+0x2f9/0x3f0 >> [] task_numa_work+0x725/0xa00 >> [] task_work_run+0x58/0x90 >> [] syscall_exit_to_user_mode+0x1c8/0x1e0 >> [] do_syscall_64+0x85/0x150 >> [] entry_SYSCALL_64_after_hwframe+0x76/0x7e >> ... >> >> This issue can be consistently reproduced on three different servers: >> * a 448-core server >> * a 256-core server >> * a 192-core server >> >> [Root Cause] >> Since multiple threads are created by the hackbench program (along with >> the command argument 'thread'), a shared vma might be accessed by two or >> more cores simultaneously. When two or more cores observe that >> vma->numab_state is NULL at the same time, vma->numab_state will be >> overwritten. >> >> Although current code ensures that only one thread scans the VMAs in a >> single 'numa_scan_period', there might be a chance for another thread >> to enter in the next 'numa_scan_period' while we have not gotten till >> numab_state allocation [1]. >> >> Note that the command `/opt/ltp/testcases/bin/hackbench 50 process 1000` >> cannot the reproduce the issue. It is verified with 200+ test runs. >> >> [Solution] >> Use the cmpxchg atomic operation to ensure that only one thread executes >> the vma->numab_state assignment. >> >> [1] https://lore.kernel.org/lkml/1794be3c-358c-4cdc-a43d-a1f841d91ef7@amd.com/ >> >> Fixes: ef6a22b70f6d ("sched/numa: apply the scan delay to every new vma") >> Reported-by: Jiwei Sun >> Signed-off-by: Adrian Huang >> Reviewed-by: Raghavendra K T Reviewed-by: Vlastimil Babka >> --- >> kernel/sched/fair.c | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 3356315d7e64..7f99df294583 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -3399,10 +3399,16 @@ static void task_numa_work(struct callback_head *work) >> >> /* Initialise new per-VMA NUMAB state. */ >> if (!vma->numab_state) { >> - vma->numab_state = kzalloc(sizeof(struct vma_numab_state), >> - GFP_KERNEL); >> - if (!vma->numab_state) >> + struct vma_numab_state *ptr; >> + >> + ptr = kzalloc(sizeof(*ptr), GFP_KERNEL); >> + if (!ptr) >> + continue; >> + >> + if (cmpxchg(&vma->numab_state, NULL, ptr)) { >> + kfree(ptr); >> continue; >> + } >> >> vma->numab_state->start_scan_seq = mm->numa_scan_seq; >>