From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4255ACAC598 for ; Wed, 17 Sep 2025 05:21:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E1618E0010; Wed, 17 Sep 2025 01:21:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B8288E0001; Wed, 17 Sep 2025 01:21:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 858A38E0010; Wed, 17 Sep 2025 01:21:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 720F58E0001 for ; Wed, 17 Sep 2025 01:21:02 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 23F8CC03D0 for ; Wed, 17 Sep 2025 05:21:02 +0000 (UTC) X-FDA: 83897593164.02.ABC3F29 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf02.hostedemail.com (Postfix) with ESMTP id 3FA0D80006 for ; Wed, 17 Sep 2025 05:20:58 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=lVILmbS0; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="KpCiw/vV"; spf=pass (imf02.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1758086458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YeHQ++qmunjNnUHiKB6bTh5iKeWrW83y7P19MD2knR8=; b=f2hGiVQ2EW48A4/dUftJYaWQeN47qnbe5GrZz7+UtyaLeoF99nFVFkf0YxUdSOA2fZNo/e ZUlSyYmddhRleUT5El4fla2Da/IJU5rhogE4+gefQHrk9OdUG4hvRL8bfsuyPqiH+fFiVu wfCEfCVZ+11iAXojn0lrA94qfkDSYg0= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1758086458; a=rsa-sha256; cv=pass; b=PFU+iLnPwKXjQLRdVH3n/CLgyGBLH8DhdoaQPI/pdlQ2/NjT59CzNd5HlT6P9T0YP/gKBG eKtDBO2Lut2e/HHY31ncYRIKnAjoUOqID/Lc6Fv8qgRIICzw69lJK3+A4usHoep52wlT2H hJXvbhKtyb8n5ulppusF3WRxA2YBkF4= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=lVILmbS0; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="KpCiw/vV"; spf=pass (imf02.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58GLdVmv024707; Wed, 17 Sep 2025 05:20:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=YeHQ++qmunjNnUHiKB6bTh5iKeWrW83y7P19MD2knR8=; b= lVILmbS0oOocDfgN+QTx7nNg8X9rEaStyBOmieWrvulDd4l7/e1pDfWoT6ZT/nvS OorR6M4r9NFRDe1uFsFVFBOLxp92DtsZUiVUWVmMmRgPgfIqrGFl5UM3GSuNJ9FY INp1BBekKh3VQ3D1jbMCiQUBK+BxeMuM56jyxcY89K+OHurAN3TX+dQHr9n+bv3f f03jHh93aI+Rp2rAbEYHpIFNLYxkB7bOT7Bh14P83BG4aFrxinlzBULjVYCZGr/6 4uOBjxG4IFip+xHE2wXHDroc+W2ZLU3tzGxK+Hi9Ejry+Y7s7os2rqDbRH61OIp5 5cxQZEkQarWd3qEV1UnZ1A== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 497g0k8dru-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Sep 2025 05:20:33 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 58H3Vu3l036766; Wed, 17 Sep 2025 05:20:32 GMT Received: from cy7pr03cu001.outbound.protection.outlook.com (mail-westcentralusazon11010061.outbound.protection.outlook.com [40.93.198.61]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 494y2daays-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Sep 2025 05:20:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GTOEv7CtaH/p+I+q9CSoKJXol+uNbfLPDFEwpi34B3FO6datDTACAOvs2oZDe9FrHV8y9EM5KsEzSJgbbmyiF5E4jNxfXEHlNW2gAiMJIjMEcca1u6XerqFub7CUaOl74U1AMFOsrx06LsKFg0WKCOC5Hdd/pEw52MNx85N9XIu3RrdsCugBMEnioiOqXfPlcIQl/i/+YNcF6fXW8Qo4VRRYmtLGYuYsQ0JAOWlOM9QpNGVtJ7hCBn44rf2+YZZkuFet301/ygknUtis7UEwxwaRDm5D7oH9cLDFBK+u16M6obOIulg4ts0gyAK3Ezz335uRfeKIp8SJVkEJ5FZWmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YeHQ++qmunjNnUHiKB6bTh5iKeWrW83y7P19MD2knR8=; b=jjWmHQSI4GyIUik6rcN908C3oNgRRDb0H7PEHCMsSqZ3sAhQawWIrtIgYoM2OVTk3nP5iecTlX+nSAHUl0KfilX+0c6pgWC66xYg0qACXyqkSkWrWnxEUEpSxveIPXEAVhuo3TqMLd+7SSo9RtcpWzMvTzgNjLi+xILqAprs4DT8GLtTg3uVfn79tFIintasA8uwjUPX9MwpgSHZFkruRUDmDtWuGne/R2S/6fvs5z7mqnNOz6BC4JQZfYqCXz1BFastWA7WqFhFDkImdrPYAcjzOxT05qheMlLVr5CfE6CbEw3qpVu041MPWLFiy0MMc/XArPaesDkZlHV7dCL7Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YeHQ++qmunjNnUHiKB6bTh5iKeWrW83y7P19MD2knR8=; b=KpCiw/vVwBetU7f3ysbWORa2GX1JqhRRxw1FYxB+N6tPHxLS+pjaeajIGGszdoTT7xuOnChkWdX987HdVKIIjFrKTU8bnbaLrprZuCdFjo7JpuOMlGAWjjMbXNrkRbcpT84AMR9udk+VQTVDrboygH83uHvZGPZxnQTiXLd0JO8= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by CH0PR10MB4908.namprd10.prod.outlook.com (2603:10b6:610:cb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.22; Wed, 17 Sep 2025 05:20:28 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.9115.022; Wed, 17 Sep 2025 05:20:27 +0000 Date: Wed, 17 Sep 2025 06:20:25 +0100 From: Lorenzo Stoakes To: Mateusz Guzik Cc: Chris Mason , Andrew Morton , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S . Miller" , Andreas Larsson , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , David Rientjes , Shakeel Butt , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Masami Hiramatsu , Oleg Nesterov , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Jason Gunthorpe , John Hubbard , Peter Xu , Jann Horn , Pedro Falcato , Matthew Wilcox , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 02/10] mm: convert core mm to mm_flags_*() accessors Message-ID: <36fc538c-4e25-409d-b718-437fe97201ac@lucifer.local> References: <1eb2266f4408798a55bda00cb04545a3203aa572.1755012943.git.lorenzo.stoakes@oracle.com> <20250916194915.1395712-1-clm@meta.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0256.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::28) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|CH0PR10MB4908:EE_ X-MS-Office365-Filtering-Correlation-Id: 7181ae72-1ff7-4f1f-0084-08ddf5a9e9e0 X-LD-Processed: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?KzBuNlVJRjBUU1dFY0h6bzhtSytsQlhCYVo3ZnRrNDNEVjBDS1VUL2plaTF1?= =?utf-8?B?akF4cjMxbk5QclAzVWpoTFNjTTdLZEhaOUU4RGU0N2t0RExnM3E1Qm9xV3BE?= =?utf-8?B?MUE1YzNCVU5SNjAzaEtHT1NUVVRlYXZyQTFiM1RIZnBhdGN3S1E5Q3E5R09F?= =?utf-8?B?RGdJMjJGTmZwSGQ2YWFOTGpQdDc5RlUrVUdpVW5yZGxCWC9JT0xmb2hmc3JO?= =?utf-8?B?N3krSm5lenI0cEsyWG5uNFRPYlpSWEJzdjEzWEMyWUtFZSt6cWJMNUJ6c3la?= =?utf-8?B?b0VKaHRVMVY1NDhMZkZOTHJYQXcwOXB1QTZ6S3dWWE1ZVEozdW5EcHo1RTZO?= =?utf-8?B?LzdMNlEzWWdIVU1iYVljdW5JR0taUG5CRlZWS1N2b0xZbUtkZFNQRjJZMGRy?= =?utf-8?B?TmNjYWxnenZTbFoyMlVTYWZtSHRxUG9SeGFyNFRYcHNmUHVNRkdqTk9DNWNC?= =?utf-8?B?bDVOWmNDNHNuU1F5M1lnK2tBbVRIbVk1VVc1YjB2bFZoVFhMY0poV09xdXZu?= =?utf-8?B?NUsrelVVd1NzUUJzUzltUXdFL3ptVnltT0plZzYyOTc5ODJwNkpTeUV0QXV4?= =?utf-8?B?VHgyNllibld4SmswOWVtVjVYS1ZiTGswRi9JV0pUVlQxNTFTTDd0UmVLdlIz?= =?utf-8?B?VVk3ek9FVGtyV0pEZkFXN29BU0UvOXUrQmZJdUpYakVHZ2hZdGR4RmFIOXYx?= =?utf-8?B?R2xoWGtsL3I4bEdtcVF3RHBXeW5ISmtyQnVNTFFFRUpaYXlOL2RCZEtBQjYr?= =?utf-8?B?Mm54blNldWZGSFRpNmZqQWVpcXBYeHhjeTNYVmFuVkdMdXpSOVNudHdIaEV1?= =?utf-8?B?VjRGWkp2WG9kcGU2VDVQZlV5OWtoMHMwQmh3QlN0NVVqR1p2OGVvdVM5OHp0?= =?utf-8?B?QXVwQ0JOd3dOTVBmL1c5UkorZ1FUUE5la1ZITHBLUTlCZ3dmdHdScjdCVHd1?= =?utf-8?B?KzA5YjE5enJ6RlZFQ0RUYTFnK29RV3RCRlMxWHpOYXBaem1nWFQ5Z1lpQkdz?= =?utf-8?B?VUlzMy9DQTdZakRpcTE3YUdBa0JVcFN3d3VZN1NuYm5WeTcrcE9zbXEwckRS?= =?utf-8?B?MWYyTjEyN2V4NndxRVhEbUlsSzB4dkR6YjA2eTc3cWNLT1dWT2t6U3RIKzJV?= =?utf-8?B?L1NKOXN0YnFXVER4QitOR3hHZE9MR3JSS0NsRUVBT05DK1dxdXl4MWV0cTdp?= =?utf-8?B?VkZQQ2QxZjNGYm1rRDhjSjFsc0ZrUU9tZmxaSFpzcnJLS2hlSERqQkNIWEND?= =?utf-8?B?VU9SaU0vcnNkbm5mVDkyVGdaS0c1V09lVXNaTUVtVDlHbFFVb1RNQmEwQmNE?= =?utf-8?B?YlM1dFZ1TTVZMFc0aC9RdUtyaTRSNTFBY243SmY0N1IxcXJOZlNzZ1RvRE1n?= =?utf-8?B?VitWVk9oYUhncTZ6ZklIcTMvTDBDK3JrbkVYRHFMeGo0YUtPeDlEclNocUlI?= =?utf-8?B?MXdycExHNW0xOTJVcHJjdWY5SFd2QU5EL093c0MvRHBLY29yT0pDbUZjQWNi?= =?utf-8?B?UDNMeVhOcnB5MGw5NW9vbWtGRDljWDk4TmFDN1BHeWxIS21NT1M4Ri9TU2hS?= =?utf-8?B?dFBqaHBGNXlCYXJiOGQ1WXhqUFBBMSs2WjliZGlzSE1vMUMvU0dobnVlTTB2?= =?utf-8?B?aDNJaDIzMFMycWVvekFrdzlkSHZWVkYxV2xFcmVubW9HclRYdW9nTDRLMm02?= =?utf-8?B?OTQyZHh6aXl1SlpXSXhwTUVhSWQ3RW1RK0NOOVFmczh1WmVhcTF4Y2Y0RE5H?= =?utf-8?B?blRlVjE4TUFSQnVIT096MnUwOXZiZkViYnhWOEtwSGIwcjBuZC9wUkpiV3o5?= =?utf-8?B?Y1NWVVM5cEh4bWNUUVQ0QW5HT05Mdit5N3psMk56S0srU1poM3hRa1dKMVU5?= =?utf-8?B?Nm5CZjhYWVo1UFdBZzAraHk1U3dVQ0NwNEJVVjJRVFBDcTFjbFlQaEJrMTlT?= =?utf-8?Q?TUw5ml241o4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1ZMK2NnTUdoOEM3bGRhNXU1OHpPS1Z2SVFZbFY5R21hVXRFZG1pWEFZQ1I0?= =?utf-8?B?OWsrZU9BVk5OZDVKbzZNSmhZMTJFUlcvcmR3Sk85VkY2ZHkyV0hEL3BNYXVL?= =?utf-8?B?enlhY0JsN1YzQ3kwOEhIMzNwUjZ6YmhxL1VoVnBLYldMSGdWWWE5Z1c3SGJK?= =?utf-8?B?d2pIZDZGd2x5ZWlmaWUwTGtqQ2F2dnJZSld6Vk9uVkVuZ0dMSVJERVliMUx0?= =?utf-8?B?QnU3QzE1MzVxQVk3WXRVVTY4M1FpQk4rWFdlejNaSW92d1RZOGlJUlVqRENM?= =?utf-8?B?azdrWkljbllwaERuMHR4TUFpK1c0L0JWVmZNeVczbUV0NmFHNm1LdzkrL2p0?= =?utf-8?B?OGR4dlR0UERyVmFrMkVyVDVaT0xwVVJ0aTRaS3hDdlJuWHVBRHpKWHZiYmQ3?= =?utf-8?B?QmhRdDRXL1IxS1VQUEpDc01oa2xiQ3BSMmtmd2dtN1JqaFVmVUdMWUMrTEtt?= =?utf-8?B?ZExTQ3lZQUhwSkNHUzg5aDg3V2tEdjJDNFFvbHA2LzBWQTJsMVZRWlFyTktv?= =?utf-8?B?NzNZbkwzQ1pSRGhPOHRaZmVCbEJWTU43Mld6akhyeDMyNkJOOUNFamp5VmNP?= =?utf-8?B?ODVlNWl5WmF4WkxHZGFjQzV0MHd6UFhnWjlsVllVbEVOVVdmRVFXbXQ5WTRE?= =?utf-8?B?dU56QVBhZm05VHRvNGdZWDJocFhDdElPNFk4dkNhTU5rRExkd2tBczRhNFYz?= =?utf-8?B?aDMrbjB1Y0ZLRG5kNUxUNXcvNzBjb1E1MGEzd1ZDbW5UY2RLUjdPQUptNHZT?= =?utf-8?B?TDA0RHdoV3FtUWUySEpaL25GTmpQMmE3SFg4TThJNFBSMlVieU4vRUx1cjEy?= =?utf-8?B?MGdBbVkvTVVjYzBnMWZweUtHdG1LbEUzV0JlbWZQTmxwdEtiRWVRVFlqamJC?= =?utf-8?B?UVZkMHRjYzNRdWNiS0k2K2t0cTgxMWljb0F4Z0hFZWFhQm4vZ0tFV0JVT09W?= =?utf-8?B?UjE4czVLS3E1cmNzWjlwVUJPRG5hcGlEN1Fvb3crYjdEZTE3Y29OZGdlSjZu?= =?utf-8?B?czhOeE1SZDlpaDRjTGhEc3lPanBWeGJOcVNiQ2RsSy9LU3pacVI2UC9zOXJM?= =?utf-8?B?c2N4djdsMStwTTdVL1BVdVR1b05vVEpjSHlxMURlZTIzREtTSWZKRS92d2VO?= =?utf-8?B?ZGFIb3RFZk1tMS9sT3ZYSkU0U2JjOUdoeEJmWTJZNWlrTGNMVXduRW5zNXRm?= =?utf-8?B?Z3ZKK0ZodTRQdlU4RFVTQnVVWDB0Sm9pNkdVR2JtWE5oR2FicnBBUzFnS3Ny?= =?utf-8?B?VjkzaDRmdUpkc2ppQm93a00rcW1OWHJ1UW5IYStWTlNXYmZ3SFkrc0g5aFVv?= =?utf-8?B?K0k5bkxGQnFMcnF0dlRRd2dHQ0dtWU5oU3BZKzE2MnZ4bUFrT1NWRk03ak92?= =?utf-8?B?SGUvdndkdWRDb1c4eWNFdXI3R2pvSSt5MmF4WTB4VzRNTXhsVVNFTnFWVUh1?= =?utf-8?B?YmNOZnRJZUhtVWZmenErZzdUQ0p1OEgveWlyOHNZQ0Q4dzFWTCtTb09EYVc2?= =?utf-8?B?NVg2bHp1dWlHQ0xlTGUxMDVXRjFXTzE1dHZLRkk4cmFSWHRuaythSWYzSm9I?= =?utf-8?B?YTNRR0NSM3VmU1VaaWNtZUtsZllQSVllL1daSW82QUFlN0FQb2NXaGI4STg0?= =?utf-8?B?NjhwV0pEclBoTU9OckpPRDBqWVZRTmpnZzRKK3Zyc3ZmeFNuZkRCanlpUTJ4?= =?utf-8?B?dGsvbDl4cnc0b1R0VlgzUGJsbWZpbm0vcXZNK1U1bG1SeE9wWjhhQ3U4enpn?= =?utf-8?B?K0llbkoxZW9nVTdLaGphR1g4eWgwOWNtZEhsc0REaFFMN2crb3dqTDhNdzhi?= =?utf-8?B?QjNSUm1oZWI4ajEycGVGZ213dGFxeThxMk1seTU3RW5GR08zVVFuSmJEdHBY?= =?utf-8?B?N3Jpa09OTGE1TjNybWNhaEdYL2FzYVk4d1J4UVM5c1h6MkpDNitOTGVhd1dP?= =?utf-8?B?Qys5a0pPcXJWQ2QraHk2WVhINnVhMzd3RlJ6cDViaStIdldpblJrcTVIRFRZ?= =?utf-8?B?ZjMwZEVUWVh2Yjl1Y1NEUTNEREVlRkM3WEIwQ2Z2Mmx2aEVsUTEvYmpFSVlL?= =?utf-8?B?VUh4TU1OZVFXbzZpMUNid1ROc1pBU0duWWZYMHpvbUJ2RHlMMzFySHk3K1BJ?= =?utf-8?B?YUQyVDh2VC8ra0s0U0s0a210UmRLaW9PZ3RiNUJyWTBTdzU5ZTRGZ1BjRENo?= =?utf-8?B?WWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: M4L219LxMPCt4X7FYiuP0kz0FcRPdJx63TQBuu618Bb10IoKTXgQsqwo9JEsuySNCnu/T1RSQbajldWi3oECsLNEjuQ8wfFZO0Rta+GlxfHOyYBITGD0jMzBA7QulukYPsGOD7/OaMzRvPmNTBvucv6mTPlCpM0CZYPVu62xTb/vk5drJ1idq7CZk1iI2GrVastx4QdROt6psa8u4sTX23o7SNTm8WdhVpw9/3MHqLTavWGtDJ47hrYUnQ4IAoD0/+YOmDtvaC7P21HZIC1r1H3mdYL7Qc+A4d5AIPubLVSGa2iQnSG81bOdYTEN+tOwRA+KSMGt/Ahopt4Xv/2agck87+dvXBlFB5dcjxCn7Rmln0rYuCbRrQzUppi2RdQwa0kwZFPlcqfSuvC4toncgVJQc9X9v5qPOPOxoEW+IwFzkmTrXIsH7hg1Te8P+nMKYNO+bzlvl5fj+0AmmhtcnP0j7TFnvosTiQHbuekcGsBpUnKdpxe2L0b5+lT8bY++fvR1SB57QjeldhoalbjjG31og8IOosQq+rRibkYvHakaKiaV92KT1nfFNB7E/QLTlImB7uvpCfExjjuHgo9lDYS4TBHsPF2meaXteELSm4k= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7181ae72-1ff7-4f1f-0084-08ddf5a9e9e0 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2025 05:20:27.9232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H+M9MgLyoaTqMi+cb7iTgVdM532OEQPCTdkUcwoVfMbXaZS3LIR+YhIrpvCyU7NH/psYngeQKc/vZnFJ6gOSZS1TuaBYaz3R2HZDbfSvmts= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4908 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-16_02,2025-09-16_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2508110000 definitions=main-2509170050 X-Authority-Analysis: v=2.4 cv=b9Oy4sGx c=1 sm=1 tr=0 ts=68ca4521 b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=GoEa3M9JfhUA:10 a=VabnemYjAAAA:8 a=yPCof4ZbAAAA:8 a=QXECTrqsWQhBFdpvQ2MA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=gKebqoRLp9LExxC7YDUY:22 cc=ntf awl=host:12084 X-Proofpoint-GUID: M23Ee3jdukBe_K4k_ip0sUhcjYf73lRI X-Proofpoint-ORIG-GUID: M23Ee3jdukBe_K4k_ip0sUhcjYf73lRI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTE2MDIwMyBTYWx0ZWRfX5DkN5L+EJjiK z6zsBik2d9qoIO+PA5hXfEyRxp4U0AjBYPbLgcKpQWrSCkn2clmwgPc6ukkxH0t4TFQMcAFuHfO cHD1KmfSsihov5lnLHyGtvbmI/Lmuo7VfC9HGh6nPSRQAjQd6Cl7mhWTwnjJA7EB/5hyLGEr6IL 8h7TW4Y5UGJ8YOtGXwVprUjtf06LaTUBLEXGGGvzCw2QsSDIK0Gx4ODFKog71+5JmjKE2JyVjrP BWs220Af9iBEpRHQbJUsvI0YvDl94N6aSP5kfyu0kNpJym0+cYlI2lQg3IULW7XD6PVYuu84hyv JoK8e+pQ24lVOjt3NZxmb4/h3gZ1qq5ylssf1qADNkhX4YsfIz7cXrGB2wsGCxWeRxFO1w57UDn 8AWpdXZoJPnkZ72A9fv5nOooYu4C+g== X-Rspamd-Queue-Id: 3FA0D80006 X-Stat-Signature: b81xij8up8fcaiwksbdq6rrbpjezropz X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1758086458-95730 X-HE-Meta: U2FsdGVkX18O0OulcpsCfKdp9Lnq2wExOxhu2ZBucodbF9xon5A3kNrb5ajv18NjLnmVRnSv0tW3DJA5hSRHe/ouhG/n3sZqRVijdUV5A4eJydgtbyVYfsRrDtmlBLmns9v1Og6CNl4gB7eVysDeHrc8EhHWxZdNrIlPPBXEfD85Kk55sf3GzIZh7ndbXufEzpDth5ansr1Ul4biUc+0UBiY8TECMjr4a4Dr3ls/UQfYa6StvYxcTsU6jclZn+uSeEkqnwX7s252q0vF5Bzb/fBGnSpYm4mzu3oblN2x9pL9oZJv04SUaamYTIel3D1Dfb81JGSyTBu+TPq/J0ITXcakljf8Z8yaQu0XHxIB/3vytZcOxkOo42FfSaZ8kKUnv2j9aMpIZ3HA2yA25l+mGdGKlgy5mBoG20Umtmt05TuEywolXi2O2AnvfgKqoPyN0sjbyXREFWi5Ui+rdLl/ht/dljfpCNFXCZTtTCXbkxOwC/vMg9VzXi7nGbyEpj26feGnZPt6n50sCLq3hBNZ4CPRBmQARZUsffCXcepr0WsEZ0Hf7dRLQBpU3FWNEEqqNzUwfqqus6eH4cNaU095uZTpPu0hohq7Lxby+V0UmU9eaU/vH37GtMEB8pDUXweOywt3LVOQxkFmgOHvSoS4JlNmMhBdLv7RdjbNK5twztDw4fmh6yaWfAZKZtEo2TyfLjBWChWzk9nBVVl/FQpXOjqiLkVh6JF/D2+URdTmQn5LtxpOImxEubiiGR7vAJ0669qpH7+zwvKxFl/QKjBbBICHo99Vm3CqZc+hJVI+xsPXzPGBm5bzebFuAG71YKqHX0Z5hnwiWAE4cL4op49Qy56bMML/jCcJI/XuhX81255YoSTlVekOd5IN4kvx+IsoGqFtgIggHjP/zPKETT/oTDlfsMoqj58JXZTHHS8NEtEWXVPtyuxQvPJMsH9kTUAx2dcakvrcQ+ORCdLw4vB RGauTnyh CgJVKfqgNZ5Dd0nQ7Gg8rN+uPGduIZUrnnLgmmKI+FPJoMWN6BpTA5AIC2qFLDAhD0ZLTO8aKLlzAbO+dml7CkyLdSTUtwZiNiwGCbsjody3P0EH9U20ro0OSsNVzzp9y1/9b5EH8L7h5/tSf+SMpGxUzVzgFb732cbteFLBqE3hrXprX5tmqC8Xp5imaZwUfHzcZy3EYqPcn9NFkfZ8az8MrVk2abDy9dnqRktSRTS9BUwW5quELxJEgijKP5o4ZBVElN2Q7PIhckGZuVS8jaE+e1XUBRzpVF7JUYj+r32JKxr1imSU7zF5m/LqVGnz0q77ZTEMKMCG2wkOaRJQTVav4RGe5C6QiuL7T+kIdgt2gPqqYMCLss7PdHz21yYps/6qL1KMis/UTcGBTg1aYiSh6yegSoqA4Fnr24dIDm6OKCZURJpN8kpAq75DUNbmN+KVd9dSjqG3ijYCUb7o8zGGwNu5rmmJoYoLsozGooCDDIpVdvWA+xZiC/sLcLNX/pmJNrXVPyJ6oCncJVUpH4vX2yO/cxl+hxeQgSMgMa0Q3Mer8YcVRxiY2EDlht7t1f7G4cQMypiUGTkt6ewJUJOahvxuoLms72s7EaYwvRihIjjLXFj/eN6hlesO30dzFYAc270/OzzJ6YMYb8icw20CmE+qwSV6zuAFkrIZH4CRvmQFB2JsRuwcWxOW3+AEBR9NXz5bO18Z06D+KNz6rSKJ4nYwnccLarP03EgZ7MieLUNmA6uS80JxBknqHrdYakyQOoO3WWtPvaqVotlhc2zugdoM2M/KgVqbjA4R4v8yY3aDGuAuu/G5/umFAbF5zc+WNKMdEcN+8X2ZbMJiGAiHEwMb/sajqKsr6iGUIG5o6lQm5FecmfELkWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 17, 2025 at 02:16:54AM +0200, Mateusz Guzik wrote: > On Wed, Sep 17, 2025 at 1:57 AM Chris Mason wrote: > > > > On Tue, 12 Aug 2025 16:44:11 +0100 Lorenzo Stoakes wrote: > > > > > As part of the effort to move to mm->flags becoming a bitmap field, convert > > > existing users to making use of the mm_flags_*() accessors which will, when > > > the conversion is complete, be the only means of accessing mm_struct flags. > > > > > > This will result in the debug output being that of a bitmap output, which > > > will result in a minor change here, but since this is for debug only, this > > > should have no bearing. > > > > > > Otherwise, no functional changes intended. > > > > > > Signed-off-by: Lorenzo Stoakes > > > > [ ... ] > > > > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > > > index 25923cfec9c6..17650f0b516e 100644 > > > --- a/mm/oom_kill.c > > > +++ b/mm/oom_kill.c > > > > [ ... ] > > > > > @@ -1251,7 +1251,7 @@ SYSCALL_DEFINE2(process_mrelease, int, pidfd, unsigned int, flags) > > > * Check MMF_OOM_SKIP again under mmap_read_lock protection to ensure > > > * possible change in exit_mmap is seen > > > */ > > > - if (!test_bit(MMF_OOM_SKIP, &mm->flags) && !__oom_reap_task_mm(mm)) > > > + if (mm_flags_test(MMF_OOM_SKIP, mm) && !__oom_reap_task_mm(mm)) > > > ret = -EAGAIN; > > > mmap_read_unlock(mm); > > > > > > > Hi Lorzeno, I think we lost a ! here. > > > > claude found enough inverted logic in moved code that I did a new run with > > a more explicit prompt for it, but this was the only new hit. > > > > I presume conversion was done mostly manually? Actually largely via sed/emacs find-replace. I'm not sure why this case happened. But maybe it's one of the not 'largely' changes... Human-in-the-middle is obviously subject to errors :) > > The way(tm) is to use coccinelle. > > I whipped out the following real quick and results look good: > > @@ > expression mm, bit; > @@ > > - test_bit(bit, &mm->flags) > + mm_flags_test(bit, mm) Thanks. Not sure it'd hit every case. But that's useful to know, could presumably expand to hit others. I will be changing VMA flags when my review load finally allows me to so knowing this is useful... Cheers, Lorenzo > > $ spatch --sp-file mmbit.cocci mm/oom_kill.c > [snip] > @@ -892,7 +892,7 @@ static bool task_will_free_mem(struct ta > * This task has already been drained by the oom reaper so there are > * only small chances it will free some more > */ > - if (test_bit(MMF_OOM_SKIP, &mm->flags)) > + if (mm_flags_test(MMF_OOM_SKIP, mm)) > return false; > > if (atomic_read(&mm->mm_users) <= 1) > @@ -1235,7 +1235,7 @@ SYSCALL_DEFINE2(process_mrelease, int, p > reap = true; > else { > /* Error only if the work has not been done already */ > - if (!test_bit(MMF_OOM_SKIP, &mm->flags)) > + if (!mm_flags_test(MMF_OOM_SKIP, mm)) > ret = -EINVAL; > } > task_unlock(p); > @@ -1251,7 +1251,7 @@ SYSCALL_DEFINE2(process_mrelease, int, p > * Check MMF_OOM_SKIP again under mmap_read_lock protection to ensure > * possible change in exit_mmap is seen > */ > - if (!test_bit(MMF_OOM_SKIP, &mm->flags) && !__oom_reap_task_mm(mm)) > + if (!mm_flags_test(MMF_OOM_SKIP, mm) && !__oom_reap_task_mm(mm)) > ret = -EAGAIN; > mmap_read_unlock(mm);