From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B099EB64DA for ; Fri, 30 Jun 2023 15:39:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86E2A8E002C; Fri, 30 Jun 2023 11:39:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81DBF8E000F; Fri, 30 Jun 2023 11:39:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E5EC8E002C; Fri, 30 Jun 2023 11:39:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5F3DA8E000F for ; Fri, 30 Jun 2023 11:39:35 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 36CFEA0117 for ; Fri, 30 Jun 2023 15:39:35 +0000 (UTC) X-FDA: 80959823910.26.AFFC222 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf12.hostedemail.com (Postfix) with ESMTP id 0774C40014 for ; Fri, 30 Jun 2023 15:39:32 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=zaYlwpyq; spf=pass (imf12.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.41 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688139573; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GW4hZL9mt4ivrUPperLWHI1+1eLqsC5B64iKsS7Hy+Q=; b=Wz7jizam+Y8IdYHMdkY3rb0ArFlP+N4qm/xLAFl+nDGeenhXEoSRQnRodiTjRIjyhXsyx7 x9qIjvAYE21ENs6Ykqeqi3BRMYvjCNgWCdScurQRqhL1rdk/kVNYIMlZAjlGkqQ53Fl5Bo yN6O2R4dnLwUWb3KiHnqxAxd0dCALxo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688139573; a=rsa-sha256; cv=none; b=gg+sS7v3Him0+1PvOmUMySo6SM/07lCsDylF+xQHxp5bv184B79czc9fdz4i4nfudoT4iB 4wnyVantMTUyUYEHR23GfCYZCVKiLs19tPvmSXftb8pHtRgCWOXFRLsLTbADxvXB27fSAX T0nz0KngYwvlRQMjYKkjzKBO8RfJg7s= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=zaYlwpyq; spf=pass (imf12.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.41 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-7748ca56133so24281439f.0 for ; Fri, 30 Jun 2023 08:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1688139572; x=1690731572; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GW4hZL9mt4ivrUPperLWHI1+1eLqsC5B64iKsS7Hy+Q=; b=zaYlwpyqR1r+ylRi1/dLp+c0bQERixaHgbimhfhmJNvExYP2eGOgu8XnPw9vM8Hpjs R/UcmdlbZLrh1XM0pnbfSojW6rollvwv0+PNPtVD8UEK5ob7zqGHxllt9cyX7ATSVFVF RXMBYj155B6MqGnnx1zSj/T5+9HhABeQco03tqlI0QEPXLVNyoLvMc/sOEDIIRLSFN7k I6WIAwX+qTU9JsijQBmlKOHfcbxMihndDF9oXu//eGUGLNhp+dwHH+8GlXY+Q+HHaI3z lc7mPJnjoLPyyjLVPHXIsq+ixQj9M3Ee0ouIuB15+t+PBxK0nJlW30ioMK8NB12pwllH RT8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688139572; x=1690731572; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GW4hZL9mt4ivrUPperLWHI1+1eLqsC5B64iKsS7Hy+Q=; b=UhKzXb+we2HL6mVJ4m7htgtvTs4RmCISiMoqdjpgdpN5qAtisKV9UoU9lr1Pu9S1kl A7oIrINBk10vih6p0yULuskLg7c5nTorWya3NQBtVjZ2qxYCl5tkD7wQTrTFXqIPzxCB YJPwH1gI/Hjh1znQVaK77ekY98yYZbUk861HLzULCnU9zVEQav7nna0QNQQDTLn3HRSe /PnA97ADPnqcm+3PMopUBa5/cm8Qm7iBTKHajgjQHNJoe+iajcYFRuxugiGGocksS2rJ 3gckG1Zi1JtD8zy6SX75+6xfH4WPJaqPhkqkVfHtQHd25SapIGf0uF9nXUBjTemVYbfb E69Q== X-Gm-Message-State: ABy/qLYoBgNUKHznz8xc8p26be8iy2iIWmGYRxSMECm64Ye+Kkq9V4wI Qgk67n3eayMo1U10rx78EyosnQ== X-Google-Smtp-Source: APBJJlGx0U82VVFMbma5VnBcP6dGqi3j+tVO+N0aGevcZzzCTGDk10Waj4U7AeCx8trU4YD9mdXzsQ== X-Received: by 2002:a05:6e02:2195:b0:345:ad39:ff3 with SMTP id j21-20020a056e02219500b00345ad390ff3mr3977556ila.3.1688139571782; Fri, 30 Jun 2023 08:39:31 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id c18-20020a92c8d2000000b00345e4c4f53asm633703ilq.40.2023.06.30.08.39.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jun 2023 08:39:31 -0700 (PDT) Message-ID: <36eda01e-502e-b93d-9098-77ed5a16f33c@kernel.dk> Date: Fri, 30 Jun 2023 09:39:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH 03/11] vfs: Use init_kiocb() to initialise new IOCBs Content-Language: en-US To: David Howells , Al Viro , Christoph Hellwig Cc: Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Christian Brauner References: <20230630152524.661208-1-dhowells@redhat.com> <20230630152524.661208-4-dhowells@redhat.com> From: Jens Axboe In-Reply-To: <20230630152524.661208-4-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0774C40014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: whwn1gon5uw685ca5h9g6ciqibr9njad X-HE-Tag: 1688139572-914901 X-HE-Meta: U2FsdGVkX18HXDQ+whDKG/gPPq01TCybi9MBiNVQNm7iOkkEXyrkJoklSC5/+rMfcGjt+fbAZMy0lQ2TGbDCfYsGrR7qXX+SMVG25aCuneVIPYtUYMwmHOILhQ6h9OCnMHWuR0kCVRg9BjoSiZZtIka8cAFbQKv88i/iA81OAySVMi3T7LyiGtyTQ/npJE9YzfrDFZru00YpiB0shmQM5qCx5bWzx1rw1E5b/27lUODh0XmawHAJtrSxlwGNdqK/2XZNZk1X/ceSiQpr87UkYO7af+N1j9HBIH58B022RBbIrWvWlqDHNupHOpZ5HHA8FVP3PJuQA3giixt/ehbvt+LvNDEQbJfAHlXIbS2lbg1ZDMRctEjlUjd4YBIOBt4s0S/Gy2KQtGZ2zlj9z8hq/SMGVtmn+UR1mYzMehQHdSXSl11jGjRaMribInVAc8LOJM9ttdodmGbBfN2iWh74TkGmY3I4XbHJgWMifu3LTzwKKLAV6ZFyTOtbBpC9Naq6hyNsPOa8s/exYBETW5PgMwtZ5ZPAXAc0Z7ABgb37kc/Z0ckXyJaY5XTYGO+JQCBIKjrow6SFtEnrAwpcCrIAPEh4IS8Vpp6nYCixMkTQCzLek2gITDwZa463hTDvA2rTr7OH6x/RpdUKjK69hALYqwwkLqKZ1QU4L1VyD84d/FctpeauavRIanv5H/2vX9D9y5DAnFjBVIldb+0zOywIPbYxoSSm5CUA0ht6oZq8EU7VVclq3OWc8SSLEm7nAhMA1f0/4t7JAeBg9fNgyCnxsyjnmc6OVgx2YxDURgP65zElvIZf+aMnOp4qyOuxXaKBl6k7eQCJQesU+kIQp7mrlgfn0nm6akjEbDWYv13wB5ZE8LsIwYoomg8BpN8n6nclm6TFtqRqmDsWFa2dW+uv/trbZCgOAqSkJ87KP83FAn5p6HvwS/xJZJqiwekveyB1mE8HG0wtnboxnmCPzxy J6nZt8N5 DCKwReCsyWLbQyMMXYHeColgaa+zIGEvr4/vnm1m1/SCvmd8af5u4p7flddS1s5pWnj5VkMtecHXjAaNhSgMEYnCKFTg3QpO5XJvLVp/E7ishRh2W7gu+RfRWCnt9+JbmiyNVW4etEK4E/+2S/PDM5q2+UQ+WB1Kj3uwypORas+JkASeolCYxX2ocp81+if5r2n06cUURm6mxm6HUThLsMM5etuqBRd+OC2BPBoiO8QWqguA8h0GPaxBLw+fRo3LvIcrWztuz3MO95iBnoCaQCM74NzP7AK1yUdKEl4147dicaeHOlosFf7lo2oBENCic1Vd5PIIOQs+Bv8N0LTX5P1MIHh3R5H6mYFTpLp40NsmK2xiv34d3XP5DBYiys086p0+rLHypd2NhnrG8HHWOC0OznoCadVhKALKm1e8EyacjYUS8ifjJMI0Vsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/30/23 9:25?AM, David Howells wrote: > diff --git a/io_uring/rw.c b/io_uring/rw.c > index 1bce2208b65c..1cade1567162 100644 > --- a/io_uring/rw.c > +++ b/io_uring/rw.c > @@ -655,12 +655,13 @@ static bool need_complete_io(struct io_kiocb *req) > S_ISBLK(file_inode(req->file)->i_mode); > } > > -static int io_rw_init_file(struct io_kiocb *req, fmode_t mode) > +static int io_rw_init_file(struct io_kiocb *req, unsigned int io_direction) > { > struct io_rw *rw = io_kiocb_to_cmd(req, struct io_rw); > struct kiocb *kiocb = &rw->kiocb; > struct io_ring_ctx *ctx = req->ctx; > struct file *file = req->file; > + fmode_t mode = (io_direction == WRITE) ? FMODE_WRITE : FMODE_READ; > int ret; > > if (unlikely(!file || !(file->f_mode & mode))) Not ideal to add a branch here, probably better to just pass in both? > @@ -870,7 +871,7 @@ int io_write(struct io_kiocb *req, unsigned int issue_flags) > iov_iter_restore(&s->iter, &s->iter_state); > iovec = NULL; > } > - ret = io_rw_init_file(req, FMODE_WRITE); > + ret = io_rw_init_file(req, WRITE); > if (unlikely(ret)) { > kfree(iovec); > return ret; > @@ -914,7 +915,6 @@ int io_write(struct io_kiocb *req, unsigned int issue_flags) > __sb_writers_release(file_inode(req->file)->i_sb, > SB_FREEZE_WRITE); > } > - kiocb->ki_flags |= IOCB_WRITE; > > if (likely(req->file->f_op->write_iter)) > ret2 = call_write_iter(req->file, kiocb, &s->iter); > One concern here is that we're using IOCB_WRITE here to tell if sb_start_write() has been done or not, and hence whether kiocb_end_write() needs to be called. You know set it earlier, which means if we get a failure if we need to setup async data, then we know have IOCB_WRITE set at that point even though we did not call sb_start_write(). -- Jens Axboe