From: Zhongkun He <hezhongkun.hzk@bytedance.com>
To: Michal Hocko <mhocko@suse.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
wuyun.abel@bytedance.com
Subject: Re: [External] Re: [PATCH 0/3] mm: replace atomic_t with percpu_ref in mempolicy.
Date: Sun, 15 Jan 2023 00:10:17 +0800 [thread overview]
Message-ID: <36e3df6c-0f70-96e5-51e2-55870b134713@bytedance.com> (raw)
In-Reply-To: <Y8GFUiSih8f0mUoU@dhcp22.suse.cz>
> On Fri 13-01-23 17:20:39, Michal Hocko wrote:
>>
>> This is really hard to follow. Without having the context from previous
>> discussions I would be completely lost. Please structure your cover
>> letter but also other patch in general in the form:
>> - what is the problem you would like to deal with
>> - want to introduce pidfd_set_mempolicy because XYZ
>> - what stands in the way
>> - mempolicy objects access constrains (reliance on operating in
>> the current context)
>> - reference counting needs to be unconditional
>> - why regular reference counting is not sufficient (performance)
>> - what is this patchset proposing
>> - per cpu reference counting
>> - how is it implemented
>> - how is the patch series structured
>> - make the reference counting unconditional
>> - special case static (never released) policies
>> - replace standard ref counting by per-cpu reference counting
> - introduce pidfd_set_mempolicy
>> - how has this been tested?
Hi Michal, thanks for your review and suggestions.
I will follow the advice above to structure the letter and
split the patches smaller on next version.
Thanks.
next prev parent reply other threads:[~2023-01-14 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 16:14 Zhongkun He
2022-12-04 16:14 ` [PATCH 1/3] mm: replace mpol_put() with mpol_kill() initiated the destruction of mpol Zhongkun He
2022-12-04 16:14 ` [PATCH 2/3] mm: fix the reference of mempolicy in some functions Zhongkun He
2022-12-04 16:14 ` [PATCH 3/3] mm: add __rcu symbol for task->mempolicy Zhongkun He
2022-12-04 18:25 ` [PATCH 0/3] mm: replace atomic_t with percpu_ref in mempolicy kernel test robot
2023-01-13 16:20 ` Michal Hocko
2023-01-13 16:22 ` Michal Hocko
2023-01-14 16:10 ` Zhongkun He [this message]
2023-01-13 17:04 ` Michal Hocko
2023-01-14 16:52 ` [External] " Zhongkun He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36e3df6c-0f70-96e5-51e2-55870b134713@bytedance.com \
--to=hezhongkun.hzk@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=wuyun.abel@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox