From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55939C001E0 for ; Wed, 2 Aug 2023 15:34:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE1DA2801BB; Wed, 2 Aug 2023 11:34:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D92A32801AA; Wed, 2 Aug 2023 11:34:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5A792801BB; Wed, 2 Aug 2023 11:34:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B810F2801AA for ; Wed, 2 Aug 2023 11:34:47 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 37B7B40809 for ; Wed, 2 Aug 2023 15:34:47 +0000 (UTC) X-FDA: 81079562214.08.EF0C031 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id D3FEBC000D for ; Wed, 2 Aug 2023 15:34:43 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EG7zQHYb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690990484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n78bnGVsAoOJqkX1uLwNexotfEvlRn3c46tZUzNtPkg=; b=0hHqZo2F0mYuhulaStZ13267VdNmEqe/1zUIDp2WdtPqjJYIGw8lYH5DFtW7nP6XtXfNwn fU0IEHZHWJVwjGWXDH934Xj8XGMCkg+KEEUO+ckvA43d9l5tgF/2Dl4qOQeLMA35vhcgL6 0rbV3S2DngKGD79zOXlItkGB6iDwOjk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EG7zQHYb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690990484; a=rsa-sha256; cv=none; b=Vz/kkrlMacDX0fDugL0kl6p1mBaTbgYgzA86Z+pnfLIVWtL4NrxBvT2Jp0Fg4sCmI9S+le OllQr+B18mxXsi3SgoaH1X+x/ArAQPnCM2B6ogIU0NbZyhbnsvjtJppQQAChwvMhIDSEtW vj88jeDyOEeTiFiSz/lcPmjk2iuSZb4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690990482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n78bnGVsAoOJqkX1uLwNexotfEvlRn3c46tZUzNtPkg=; b=EG7zQHYbQDPgFjth4eshH9tT6P8g3TEo+umH3Z88XJi0g7yowmKiMaJaqIj7UsU0VXOSK/ PwsLgzLfg4L2LdGfcLCm9f0Q8J76MQMNKn8ghGc+Bs20s4pq30ZtEFLnD6vGPWLc7Ckk8a GDs2VxVEB/7NhBiZ6FTY/LsxA1HlHNo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-Ki7LrUFmP7uEorJRPaS6Iw-1; Wed, 02 Aug 2023 11:34:39 -0400 X-MC-Unique: Ki7LrUFmP7uEorJRPaS6Iw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fd0fa4d08cso41649385e9.1 for ; Wed, 02 Aug 2023 08:34:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690990477; x=1691595277; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n78bnGVsAoOJqkX1uLwNexotfEvlRn3c46tZUzNtPkg=; b=BXABlneallKOad8PRLVzz8MXsj4XMMcCIsG2UAsiFotYvRiiuoR/50NFDBL6R3x0N3 kr0PFKaFDk+M8hrSWIWbiL8Ao2RCWITMjeqxcESKMMum/Wgh6m6P0tHR/bMtR6SntPtu ogqZsQnrVPRM6HHuKwS074YmQ4kFf9qJpjQOEgbp+PPj/qJsWSWQdz0cCHL7uTdhc1op DGtsOPveFrcKQRyRCyuEBOzIYo5g3+9BOrQXi4ZJ7pFY+6V2CGsYw6+5bH+orFDd75Mo QPB5t3AWnqCacXNdy/mBUSwrXmrcyFpv/czr24laipPQUZX70HQ3kbJ37zt5ilW2zYjm a9Ag== X-Gm-Message-State: ABy/qLY9806ROIQ7jAXI98jfACpwOOVx/vycSnBh8A0/v3f60flqJClO lkiBty6LI62CcQt5a+juNNsttgZu6Te1VTi4AeCcSWdsYd22SEH49Mt7QpROA6TssZZEFk8huf9 7qlN3KLotIU4= X-Received: by 2002:a05:600c:22d8:b0:3fd:2e6b:10c8 with SMTP id 24-20020a05600c22d800b003fd2e6b10c8mr4768537wmg.23.1690990476924; Wed, 02 Aug 2023 08:34:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlE7TrYd8KCPetPnWu6tIAydNWrryFMnACSUqOeeUTUc0h+AEVnhFN8Sv7HlT/gIPrHNuELzhg== X-Received: by 2002:a05:600c:22d8:b0:3fd:2e6b:10c8 with SMTP id 24-20020a05600c22d800b003fd2e6b10c8mr4768509wmg.23.1690990476508; Wed, 02 Aug 2023 08:34:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:e00:b8a4:8613:1529:1caf? (p200300cbc70b0e00b8a4861315291caf.dip0.t-ipconnect.de. [2003:cb:c70b:e00:b8a4:8613:1529:1caf]) by smtp.gmail.com with ESMTPSA id z1-20020adfd0c1000000b0031424f4ef1dsm19468614wrh.19.2023.08.02.08.34.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Aug 2023 08:34:36 -0700 (PDT) Message-ID: <36dc6356-78b6-5cc5-0a1a-ef01bbce15f9@redhat.com> Date: Wed, 2 Aug 2023 17:34:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 2/8] smaps: use vm_normal_page_pmd() instead of follow_trans_huge_pmd() To: Mel Gorman Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Linus Torvalds , liubo , Peter Xu , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini References: <20230801124844.278698-1-david@redhat.com> <20230801124844.278698-3-david@redhat.com> <20230802151613.3nyg3xof3gyovlxu@techsingularity.net> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230802151613.3nyg3xof3gyovlxu@techsingularity.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D3FEBC000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: opf71sq9rmoge85ym4ypacmz7de9cq6y X-HE-Tag: 1690990483-582039 X-HE-Meta: U2FsdGVkX1+q8TefVL3Qc+tXosjeXxadKev3XsJY0qT9fKhLlftc7aYTDllIVPfLEqZmcoVNcYJpwp7hkymJXgMETA5m4i3aWrEyyJtXByKu1zEAO0+N9DYQ7jLlFeBmsVdUfTLOhslRCSMy/+/88+CmqNIwhNFgDR7UMeGzajWiJKZEDeECdb+5PyHOCXRRKKLAP+I16aJu8jhHAogDgykukyma62uP8uINrku8QPJ2Teqo8kgQ5FxKMFJSpSJDnr2j8wup+jLauJRhGbrGUP2U9K+rmTc0xtZDw8F1/cBgCcG27/rkVSPY00LVv63S6e5HVOBd8emJkwLDYOHMvnyxXBxEsoeWl5gXZ2SB37oasijcctgfAwc61k005N2DST+1ejf/ipSt6A5RKV4mQrKq9gqgarA80weOgVAPIIFj3pi1l7JmcG/U2vk4o1m1276c8XHU0dtQBOXtRTrvqIiKyslY5ubYAQLlAM/fJoUej/4k2PuWLJYfoEr8Kjh+Nu9FZ5k1Gg04fxJnlCF1URUQ6+KVBzJFy+lhr8fas+tErC1x3QHWEubqU9EQyGXd0Y0fsen2bg9Obw6Go+K3k88Bh4klf1xlLFsIYZQUcza9rw1x4QMny+f0dnHR6CghPC9LzszytOK8FfWDUp2encrfYMBlXuF2/QJEMiREiiIDnPSHJm9vQ0c9jeG8wqbadYYmn981x7+DESNx/88LSmLztMGPvkid3my57ikOQfaNnXxEEFnjo/MuL+7nsWsXVZtNr/Zwbnsq3qZyqFx7svUvPOwWd3ikyDmrHMUnylO1S10onpYBm8GG4JHSBvfDnsDQTDQoLEQRMb16/KF4GP3m++7zNGgzCtYrxv4c3a1mlK2wDKHjX/EKuW9Pp1dxzJ8r1+hTm6nqfwJIvfEwdmFeui5YU3QsjZr/X5hAY14YrWwZDO+UeNsb2bnV9j8s11Cc/ZYwTGbV9p+ZYlO Iii4KTHr 9W1hCl5EspNAZPF67sr7riyTsDo6dcKwwdQNHnEJHhnAFiwGkuD/fjMZ8G8XqEbbwUE96lf2S7H0U+kWl0PSy2sRtacPkArASGhqaNuRwsuY6DJcCsbY5kHUCtT5FW4PNGxX1qJtm3aL1RsP56V7h22qYFQdujxEE0WJYsv0A6vTQoZgzwpu290+gz16mvBuTSvHvhDTLszPDgTOJXBhFsFpFOXNuNQCEoOHXiw8v7Lg3IvAyAhv2sgOeDfYmCsnTZoV9qBC8Su4iuH5EGL5vrFSHsEq16m1I+X6IdSNDYBVJP0lZAeJOMYD1v2D4WDKZCYkA6kOoC3YiNw3nd1lL+KKQr0BoZMLq7FF6QQgsVPFGhkHHP5q23VnjwOQSkp4EiY+8egnBiU/3/8qWbsvgSof2SaswxUvZuEKzdNiDsAigXqMMNIFVaIvE9RgBhpFQXlcwwz7CmH9vYeZFNODG+c86dPA4KJquqX3U+qFc9WLSvyfrDdZcwLZ7dKtZlwYvKcK7QSutfQxCoMU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.08.23 17:16, Mel Gorman wrote: > On Tue, Aug 01, 2023 at 02:48:38PM +0200, David Hildenbrand wrote: >> We shouldn't be using a GUP-internal helper if it can be avoided. >> >> Similar to smaps_pte_entry() that uses vm_normal_page(), let's use >> vm_normal_page_pmd() that similarly refuses to return the huge zeropage. >> >> In contrast to follow_trans_huge_pmd(), vm_normal_page_pmd(): >> >> (1) Will always return the head page, not a tail page of a THP. >> >> If we'd ever call smaps_account with a tail page while setting "compound >> = true", we could be in trouble, because smaps_account() would look at >> the memmap of unrelated pages. >> >> If we're unlucky, that memmap does not exist at all. Before we removed >> PG_doublemap, we could have triggered something similar as in >> commit 24d7275ce279 ("fs/proc: task_mmu.c: don't read mapcount for >> migration entry"). >> >> This can theoretically happen ever since commit ff9f47f6f00c ("mm: proc: >> smaps_rollup: do not stall write attempts on mmap_lock"): >> >> (a) We're in show_smaps_rollup() and processed a VMA >> (b) We release the mmap lock in show_smaps_rollup() because it is >> contended >> (c) We merged that VMA with another VMA >> (d) We collapsed a THP in that merged VMA at that position >> >> If the end address of the original VMA falls into the middle of a THP >> area, we would call smap_gather_stats() with a start address that falls >> into a PMD-mapped THP. It's probably very rare to trigger when not >> really forced. >> >> (2) Will succeed on a is_pci_p2pdma_page(), like vm_normal_page() >> >> Treat such PMDs here just like smaps_pte_entry() would treat such PTEs. >> If such pages would be anonymous, we most certainly would want to >> account them. >> >> (3) Will skip over pmd_devmap(), like vm_normal_page() for pte_devmap() >> >> As noted in vm_normal_page(), that is only for handling legacy ZONE_DEVICE >> pages. So just like smaps_pte_entry(), we'll now also ignore such PMD >> entries. >> >> Especially, follow_pmd_mask() never ends up calling >> follow_trans_huge_pmd() on pmd_devmap(). Instead it calls >> follow_devmap_pmd() -- which will fail if neither FOLL_GET nor FOLL_PIN >> is set. >> >> So skipping pmd_devmap() pages seems to be the right thing to do. >> >> (4) Will properly handle VM_MIXEDMAP/VM_PFNMAP, like vm_normal_page() >> >> We won't be returning a memmap that should be ignored by core-mm, or >> worse, a memmap that does not even exist. Note that while >> walk_page_range() will skip VM_PFNMAP mappings, walk_page_vma() won't. >> >> Most probably this case doesn't currently really happen on the PMD level, >> otherwise we'd already be able to trigger kernel crashes when reading >> smaps / smaps_rollup. >> >> So most probably only (1) is relevant in practice as of now, but could only >> cause trouble in extreme corner cases. >> >> Fixes: ff9f47f6f00c ("mm: proc: smaps_rollup: do not stall write attempts on mmap_lock") >> Signed-off-by: David Hildenbrand > > Maybe move the follow_trans_huge_pmd() declaration from linux/huge_mm.h > to mm/internal.h to discourage future mistakes? Otherwise > Makes sense. > Acked-by: Mel Gorman Thanks! -- Cheers, David / dhildenb